)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"716842c619fa3affd3c17230ea40fed86f4e93eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da0c15f0_e13028a1","line":17,"updated":"2016-03-25 02:53:11.000000000","message":"Nit: add a related-bug or partial-bug reference to the defect this is fixing","commit_id":"306173d25e8fba7655bb9b104200272deebd158b"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"ca99cf6ed85636e96f8917b674ddf6dd198afc7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da0c15f0_aa2b7b93","line":17,"in_reply_to":"da0c15f0_e13028a1","updated":"2016-03-26 04:50:44.000000000","message":"I completely missed adding the reference earlier. Done now.","commit_id":"306173d25e8fba7655bb9b104200272deebd158b"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1e050af2c8cde8f42378b1cc67aad6a9f00b29af","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch modifies the tenant_id while creating gw port to"},{"line_number":10,"context_line":"a special uuid assigned to constant \u0027ROUTER_GW_TENANT_ID\u0027."},{"line_number":11,"context_line":"This is to avoid using the string value \u0027\u0027 as tenant_id"},{"line_number":12,"context_line":"which creates ambiguities when using tenant_id to"},{"line_number":13,"context_line":"differentiate operations like creating router gw ports"},{"line_number":14,"context_line":"manually, and by updating \u0027external_gateway_info\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da0c15f0_c42692b9","line":11,"updated":"2016-03-27 23:58:19.000000000","message":"I don\u0027t understand what this change improves, router-update used \u0027\u0027 as tenant_id, now we would use ROUTER_GW_TENANT_ID?","commit_id":"6e1d909c45ad1e197d56697b4e8492d08091d429"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"5f48d58d05a318ca61e26d3d414fb70a6dff2a9f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch modifies the tenant_id while creating gw port to"},{"line_number":10,"context_line":"a special uuid assigned to constant \u0027ROUTER_GW_TENANT_ID\u0027."},{"line_number":11,"context_line":"This is to avoid using the string value \u0027\u0027 as tenant_id"},{"line_number":12,"context_line":"which creates ambiguities when using tenant_id to"},{"line_number":13,"context_line":"differentiate operations like creating router gw ports"},{"line_number":14,"context_line":"manually, and by updating \u0027external_gateway_info\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da0c15f0_291754ee","line":11,"in_reply_to":"da0c15f0_c42692b9","updated":"2016-03-28 12:15:28.000000000","message":"Can you please see the reply I posted for your comment in patch https://review.openstack.org/#/c/274021/?","commit_id":"6e1d909c45ad1e197d56697b4e8492d08091d429"}],"neutron/common/constants.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"77214091ff90446b0c00608bc59bd62e80da92bb","unresolved":false,"context_lines":[{"line_number":221,"context_line":"VALID_DIRECTIONS \u003d (INGRESS_DIRECTION, EGRESS_DIRECTION)"},{"line_number":222,"context_line":"VALID_ETHERTYPES \u003d (lib_constants.IPv4, lib_constants.IPv6)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"ROUTER_GW_TENANT_ID \u003d \u0027ca64efce-6ebd-4e21-9058-90f9c2489347\u0027"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"# Neutron-lib migration shim. This will wrap any constants that are moved"},{"line_number":227,"context_line":"# to that library in a deprecation warning, until they can be updated to"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_a8ba6708","line":224,"updated":"2016-04-05 10:22:04.000000000","message":"We don\u0027t need magic value in my opinion.\n\nI have seen the dependent patch where you leverage this.\nI think you are making an assumption that the tenant_id of a create operation is always inferred from the keystone context, which is not true in general.\n\nFor instance, admin and adv_svc users can specify the tenant_id, and therefore there is a way to circumvent the check you have added.\n\nAlso, this creates a question regarding code mainteinance as one will have to keep in mind that there also \u0027special tenant_ids\u0027 when it comes to validating requests.\n\nOn the plus side an admin user might now be able to list all gateway ports using this tenant id...","commit_id":"306173d25e8fba7655bb9b104200272deebd158b"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"0b92eb96eacc0c7b9f6ed86ac57d29daab009259","unresolved":false,"context_lines":[{"line_number":221,"context_line":"VALID_DIRECTIONS \u003d (INGRESS_DIRECTION, EGRESS_DIRECTION)"},{"line_number":222,"context_line":"VALID_ETHERTYPES \u003d (lib_constants.IPv4, lib_constants.IPv6)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"ROUTER_GW_TENANT_ID \u003d \u0027ca64efce-6ebd-4e21-9058-90f9c2489347\u0027"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"# Neutron-lib migration shim. This will wrap any constants that are moved"},{"line_number":227,"context_line":"# to that library in a deprecation warning, until they can be updated to"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_e1a44ca7","line":224,"in_reply_to":"9a061dce_a8ba6708","updated":"2016-04-06 03:56:15.000000000","message":"Got your point. Yeah, this adds on to an already quirky issue and makes it worse.\nDo you have any suggestions to fix it in code with an upfront validation, rather than policy update or a deferred validation?","commit_id":"306173d25e8fba7655bb9b104200272deebd158b"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e3bcae3fc880fcef73da6034b9261c5ffa1e9982","unresolved":false,"context_lines":[{"line_number":221,"context_line":"VALID_DIRECTIONS \u003d (INGRESS_DIRECTION, EGRESS_DIRECTION)"},{"line_number":222,"context_line":"VALID_ETHERTYPES \u003d (lib_constants.IPv4, lib_constants.IPv6)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"ROUTER_GW_TENANT_ID \u003d \u0027ca64efce-6ebd-4e21-9058-90f9c2489347\u0027"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"# Neutron-lib migration shim. This will wrap any constants that are moved"},{"line_number":227,"context_line":"# to that library in a deprecation warning, until they can be updated to"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_566ebb96","line":224,"range":{"start_line":224,"start_character":23,"end_line":224,"end_character":59},"updated":"2016-04-18 15:25:34.000000000","message":"The feedback that I had in mind here is that we need a constant instead of hard-coding \u0027\u0027 everywhere.  Howewer, the constant\u0027s value could still be \u0027\u0027 for compatibility.  Then, we don\u0027t have to think about release notes or anything like that.  creating a constant gives us a place to document what this is used for and it allows us to easily find the pieces of code that deal with it.  That\u0027s all.","commit_id":"6e1d909c45ad1e197d56697b4e8492d08091d429"}]}
