)]}'
{"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":11255,"name":"Dustin Lundquist","username":"dustin.lundquist","inactive":true},"change_message_id":"901d899aa590b62c995245691336d1f4c610b032","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        mac \u003d constants.FLOODING_ENTRY[0]"},{"line_number":652,"context_line":"        mac_found \u003d False"},{"line_number":653,"context_line":"        for entry in curr_entries.splitlines():"},{"line_number":654,"context_line":"            if mac in entry and agent_ip in entry:"},{"line_number":655,"context_line":"                return"},{"line_number":656,"context_line":"            if not mac_found:"},{"line_number":657,"context_line":"                mac_found \u003d (mac in entry)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_48f947c8","line":654,"updated":"2016-03-24 18:42:13.000000000","message":"Do we want to log a warning suggesting a Linux kernel upgrade if this occurs?","commit_id":"a16f0db211c7acc2d27cd63a6a39b29265f680e8"},{"author":{"_account_id":11255,"name":"Dustin Lundquist","username":"dustin.lundquist","inactive":true},"change_message_id":"680dc669befae2db76316ad731ab7013cf56cd4f","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        mac \u003d constants.FLOODING_ENTRY[0]"},{"line_number":652,"context_line":"        mac_found \u003d False"},{"line_number":653,"context_line":"        for entry in curr_entries.splitlines():"},{"line_number":654,"context_line":"            if mac in entry and agent_ip in entry:"},{"line_number":655,"context_line":"                return"},{"line_number":656,"context_line":"            if not mac_found:"},{"line_number":657,"context_line":"                mac_found \u003d (mac in entry)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_785218df","line":654,"in_reply_to":"da0c15f0_2e485b2d","updated":"2016-03-24 20:17:08.000000000","message":"Agreed, could be pretty noisy.","commit_id":"a16f0db211c7acc2d27cd63a6a39b29265f680e8"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"1dc7aef350e8eb8c9eb6d63c20c00ff869cf9a2a","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        mac \u003d constants.FLOODING_ENTRY[0]"},{"line_number":652,"context_line":"        mac_found \u003d False"},{"line_number":653,"context_line":"        for entry in curr_entries.splitlines():"},{"line_number":654,"context_line":"            if mac in entry and agent_ip in entry:"},{"line_number":655,"context_line":"                return"},{"line_number":656,"context_line":"            if not mac_found:"},{"line_number":657,"context_line":"                mac_found \u003d (mac in entry)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_2e485b2d","line":654,"in_reply_to":"da0c15f0_48f947c8","updated":"2016-03-24 19:39:21.000000000","message":"L2 pop rpcs are received when a new port is created on the network, or this agent is restarted. But a lot of the info will have been received previously and already added to the fdb table. So this is a normal situation.","commit_id":"a16f0db211c7acc2d27cd63a6a39b29265f680e8"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"ee805c9d3f413e0f9ac8581bac793c6a636bf52f","unresolved":false,"context_lines":[{"line_number":662,"context_line":"            self.add_fdb_bridge_entry(mac, agent_ip, interface, \"add\")"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    def add_fdb_entries(self, agent_ip, ports, interface):"},{"line_number":665,"context_line":"        curr_entries \u003d utils.execute([\u0027bridge\u0027, \u0027fdb\u0027, \u0027show\u0027, \u0027dev\u0027,"},{"line_number":666,"context_line":"                                      interface], run_as_root\u003dTrue)"},{"line_number":667,"context_line":"        for mac, ip in ports:"},{"line_number":668,"context_line":"            if mac !\u003d constants.FLOODING_ENTRY[0]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_40ad9f30","line":665,"updated":"2016-04-11 06:54:19.000000000","message":"curr_entries is used only in add_fdb_flooding_entry. So\nplease move this to add_fdb_flooding_entry\ncurr_entries \u003d utils.execute([\u0027bridge\u0027, \u0027fdb\u0027, \u0027show\u0027, \u0027dev\u0027,interface], run_as_root\u003dTrue)\n\nOtherwise we are necessarily calling utils.execute(..) for valid mac(ie. when mac !\u003d \u002700:00:00:00:00:00\u0027)","commit_id":"a16f0db211c7acc2d27cd63a6a39b29265f680e8"},{"author":{"_account_id":11255,"name":"Dustin Lundquist","username":"dustin.lundquist","inactive":true},"change_message_id":"901d899aa590b62c995245691336d1f4c610b032","unresolved":false,"context_lines":[{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    def add_fdb_entries(self, agent_ip, ports, interface):"},{"line_number":665,"context_line":"        curr_entries \u003d utils.execute([\u0027bridge\u0027, \u0027fdb\u0027, \u0027show\u0027, \u0027dev\u0027,"},{"line_number":666,"context_line":"                                      interface], run_as_root\u003dTrue)"},{"line_number":667,"context_line":"        for mac, ip in ports:"},{"line_number":668,"context_line":"            if mac !\u003d constants.FLOODING_ENTRY[0]:"},{"line_number":669,"context_line":"                self.add_fdb_ip_entry(mac, ip, interface)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_e8e13b00","line":666,"updated":"2016-03-24 18:42:13.000000000","message":"Since curr_entries is only used in the VXLAN_UCAST and if a FLOODING_ENTRY MAC is included in ports, we should guard this so it isn\u0027t invoked unnecessarily.","commit_id":"a16f0db211c7acc2d27cd63a6a39b29265f680e8"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"1dc7aef350e8eb8c9eb6d63c20c00ff869cf9a2a","unresolved":false,"context_lines":[{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    def add_fdb_entries(self, agent_ip, ports, interface):"},{"line_number":665,"context_line":"        curr_entries \u003d utils.execute([\u0027bridge\u0027, \u0027fdb\u0027, \u0027show\u0027, \u0027dev\u0027,"},{"line_number":666,"context_line":"                                      interface], run_as_root\u003dTrue)"},{"line_number":667,"context_line":"        for mac, ip in ports:"},{"line_number":668,"context_line":"            if mac !\u003d constants.FLOODING_ENTRY[0]:"},{"line_number":669,"context_line":"                self.add_fdb_ip_entry(mac, ip, interface)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_4ef82f7d","line":666,"in_reply_to":"da0c15f0_e8e13b00","updated":"2016-03-24 19:39:21.000000000","message":"Yes, I\u0027ll add that in the next patchset. I\u0027m pretty sure there will always be flooding entries in ports, so I\u0027ll just check for VXLAN_UCAST","commit_id":"a16f0db211c7acc2d27cd63a6a39b29265f680e8"},{"author":{"_account_id":19680,"name":"Daniel Levy","email":"dlevy@us.ibm.com","username":"dlevy"},"change_message_id":"4665646f85b2c7c27c609e05c4928dd40f71d298","unresolved":false,"context_lines":[{"line_number":670,"context_line":"                self.add_fdb_bridge_entry(mac, agent_ip, interface,"},{"line_number":671,"context_line":"                                          operation\u003d\"replace\")"},{"line_number":672,"context_line":"            elif self.vxlan_mode \u003d\u003d lconst.VXLAN_UCAST:"},{"line_number":673,"context_line":"                self.add_fdb_flooding_entry(interface, agent_ip, curr_entries)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    def remove_fdb_entries(self, agent_ip, ports, interface):"},{"line_number":676,"context_line":"        for mac, ip in ports:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_f72317bb","line":673,"range":{"start_line":673,"start_character":65,"end_line":673,"end_character":77},"updated":"2016-03-31 19:32:04.000000000","message":"Might as well retrieve curr_entries in add_fdb_flooding_entry since it\u0027s not used anywhere else to reduce code complexity.","commit_id":"a16f0db211c7acc2d27cd63a6a39b29265f680e8"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"92d5712a79bbe3b9b0120d935ae75fa94c19ddf9","unresolved":false,"context_lines":[{"line_number":670,"context_line":"                self.add_fdb_bridge_entry(mac, agent_ip, interface,"},{"line_number":671,"context_line":"                                          operation\u003d\"replace\")"},{"line_number":672,"context_line":"            elif self.vxlan_mode \u003d\u003d lconst.VXLAN_UCAST:"},{"line_number":673,"context_line":"                self.add_fdb_flooding_entry(interface, agent_ip, curr_entries)"},{"line_number":674,"context_line":""},{"line_number":675,"context_line":"    def remove_fdb_entries(self, agent_ip, ports, interface):"},{"line_number":676,"context_line":"        for mac, ip in ports:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_416f84fb","line":673,"range":{"start_line":673,"start_character":65,"end_line":673,"end_character":77},"in_reply_to":"ba0121b8_f72317bb","updated":"2016-04-01 10:58:03.000000000","message":"That would cause the same \"bridge fdb show ...\" to be run for every port in the list. This way it just runs once. And the unit tests are easier.","commit_id":"a16f0db211c7acc2d27cd63a6a39b29265f680e8"}]}
