)]}'
{"neutron/tests/fullstack/resources/environment.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"a08fcc17caec2baca697806f90a7a13aae7def2c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.network_range \u003d None"},{"line_number":44,"context_line":"        self.mech_drivers \u003d mech_drivers"},{"line_number":45,"context_line":"        # In this list there will be stored IP addresses already choosen for"},{"line_number":46,"context_line":"        # agents, servers and such things in each test:"},{"line_number":47,"context_line":"        self.used_ip_addresses \u003d []"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_e7620116","line":46,"updated":"2016-03-24 22:45:26.000000000","message":"The problem here is that testr runs multiple tests in parallel via multiprocessing. This variable will be local to each test runner process. I had something else in mind: A class that represents a pool of resources (In our case ports and IP addresses). You can allocate or free a resource from the pool atomically (Via a file lock, available from oslo), and the used resources are persisted to disk, so this pool would be shared between test runner processes.","commit_id":"314bca5fd6b96fe3b013dd99a03bc436062aca24"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"bb9cd8f5124be01dbe4c33acb0545da053fd248a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.network_range \u003d None"},{"line_number":44,"context_line":"        self.mech_drivers \u003d mech_drivers"},{"line_number":45,"context_line":"        # In this list there will be stored IP addresses already choosen for"},{"line_number":46,"context_line":"        # agents, servers and such things in each test:"},{"line_number":47,"context_line":"        self.used_ip_addresses \u003d []"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_46d645c6","line":46,"in_reply_to":"da0c15f0_e7620116","updated":"2016-03-25 07:17:30.000000000","message":"I can do such class but I\u0027m not sure if it is really necessary. Please note that for each test there is openvswitch bridge created and connection between agents is only inside such bridge. So tests are separated each other and even if there will be used same L2 network and same IPs in different tests then it is IMHO not a problem.\nProblem is only if two agents from same test got same IP address and this patch should solve this.","commit_id":"314bca5fd6b96fe3b013dd99a03bc436062aca24"}]}
