)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"a41ed45e0609f397b554ef58c54943d638b5d1d9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t disconnect br-int from phys br if connected"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When starting up, we don\u0027t want to delete the patch port between br-int"},{"line_number":10,"context_line":"and and the physical bridges.  In liberty the br-int bridge was changed to not"},{"line_number":11,"context_line":"tear down flows on startup, and  change"},{"line_number":12,"context_line":"I9801b76829021c9a0e6358982e1136637634a521 will change the physical bridges to"},{"line_number":13,"context_line":"not tear down flows also."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da0c15f0_627eb5e5","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":31},"updated":"2016-03-25 20:02:30.000000000","message":"extra whitespace","commit_id":"244f36e7581fa1a55d7ad7713bc3bfcf92b12f03"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"a41ed45e0609f397b554ef58c54943d638b5d1d9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t disconnect br-int from phys br if connected"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When starting up, we don\u0027t want to delete the patch port between br-int"},{"line_number":10,"context_line":"and and the physical bridges.  In liberty the br-int bridge was changed to not"},{"line_number":11,"context_line":"tear down flows on startup, and  change"},{"line_number":12,"context_line":"I9801b76829021c9a0e6358982e1136637634a521 will change the physical bridges to"},{"line_number":13,"context_line":"not tear down flows also."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da0c15f0_221e7dba","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":7},"updated":"2016-03-25 20:02:30.000000000","message":"nit: extra \u0027and\u0027","commit_id":"244f36e7581fa1a55d7ad7713bc3bfcf92b12f03"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"5a881ebefd1a3a4f5df18b8d2a799d0fc3f74c02","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t disconnect br-int from phys br if connected"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When starting up, we don\u0027t want to delete the patch port between br-int"},{"line_number":10,"context_line":"and and the physical bridges.  In liberty the br-int bridge was changed to not"},{"line_number":11,"context_line":"tear down flows on startup, and  change"},{"line_number":12,"context_line":"I9801b76829021c9a0e6358982e1136637634a521 will change the physical bridges to"},{"line_number":13,"context_line":"not tear down flows also."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da0c15f0_39898227","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":7},"in_reply_to":"da0c15f0_221e7dba","updated":"2016-03-27 04:38:31.000000000","message":"Done","commit_id":"244f36e7581fa1a55d7ad7713bc3bfcf92b12f03"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"5a881ebefd1a3a4f5df18b8d2a799d0fc3f74c02","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Don\u0027t disconnect br-int from phys br if connected"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When starting up, we don\u0027t want to delete the patch port between br-int"},{"line_number":10,"context_line":"and and the physical bridges.  In liberty the br-int bridge was changed to not"},{"line_number":11,"context_line":"tear down flows on startup, and  change"},{"line_number":12,"context_line":"I9801b76829021c9a0e6358982e1136637634a521 will change the physical bridges to"},{"line_number":13,"context_line":"not tear down flows also."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da0c15f0_198c7e34","line":10,"range":{"start_line":10,"start_character":30,"end_line":10,"end_character":31},"in_reply_to":"da0c15f0_627eb5e5","updated":"2016-03-27 04:38:31.000000000","message":"Done","commit_id":"244f36e7581fa1a55d7ad7713bc3bfcf92b12f03"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8f67234ba736efadbe66e876b19298d6439dfc82","unresolved":false,"context_lines":[{"line_number":12,"context_line":"I9801b76829021c9a0e6358982e1136637634a521 will change the physical"},{"line_number":13,"context_line":"bridges to not tear down flows also."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Without this patch the patch port is torn down and not reinstalled until"},{"line_number":16,"context_line":"after the initial flows are set back up."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-Bug: #1514056"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da0c15f0_669500dd","line":15,"updated":"2016-03-28 09:55:53.000000000","message":"I think \u0027torn\u0027 is correct. Past tense of \u0027tear\u0027.","commit_id":"683d1b525dab0a5052cf9e401493314234f6f38a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d379de9bcc22671c226eb3982fe6abb8e344cf8b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"I9801b76829021c9a0e6358982e1136637634a521 will change the physical"},{"line_number":13,"context_line":"bridges to not tear down flows also."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Without this patch the patch port is torn down and not reinstalled until"},{"line_number":16,"context_line":"after the initial flows are set back up."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-Bug: #1514056"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da0c15f0_24ab0ed8","line":15,"range":{"start_line":15,"start_character":37,"end_line":15,"end_character":41},"updated":"2016-03-28 00:36:05.000000000","message":"turn","commit_id":"683d1b525dab0a5052cf9e401493314234f6f38a"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"a41ed45e0609f397b554ef58c54943d638b5d1d9","unresolved":false,"context_lines":[{"line_number":1124,"context_line":"                    self.int_br.delete_port(int_if_name)"},{"line_number":1125,"context_line":"                    br.delete_port(phys_if_name)"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"                # Setup int_br to physical bridge patches.  If they already"},{"line_number":1128,"context_line":"                # exist we just update them, otherwise we create them but don\u0027t"},{"line_number":1129,"context_line":"                # connect them until after the drop rules are in place."},{"line_number":1130,"context_line":"                if (self.int_br.port_exists(int_if_name)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_a2172d50","line":1127,"updated":"2016-03-25 20:02:30.000000000","message":"Instead of doing the same function inside if/else, I would like to see something like:\n\n INT_IF_NAME \u003d constants.NONEXISTENT_PEER\n if self.int_br.port_exists(int_if_name):\n     INT_IF_NAME \u003d phys_if_name\n int_ofport \u003d self.int_br.add_patch_port(int_if_name, INT_IF_NAME)\n\n PHYS_IF_NAME \u003d constants.NONEXISTENT_PEER\n if br.port_exists(phys_if_name):\n     PHYS_IF_NAME \u003d phys_if_name\n phys_ofport \u003d br.add_patch_port(phys_if_name, PHYS_IF_NAME)\n\n\nIn this case we won\u0027t need to remember about two places to update the same function.","commit_id":"244f36e7581fa1a55d7ad7713bc3bfcf92b12f03"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"5a881ebefd1a3a4f5df18b8d2a799d0fc3f74c02","unresolved":false,"context_lines":[{"line_number":1124,"context_line":"                    self.int_br.delete_port(int_if_name)"},{"line_number":1125,"context_line":"                    br.delete_port(phys_if_name)"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"                # Setup int_br to physical bridge patches.  If they already"},{"line_number":1128,"context_line":"                # exist we just update them, otherwise we create them but don\u0027t"},{"line_number":1129,"context_line":"                # connect them until after the drop rules are in place."},{"line_number":1130,"context_line":"                if (self.int_br.port_exists(int_if_name)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_7983fa04","line":1127,"in_reply_to":"da0c15f0_a2172d50","updated":"2016-03-27 04:38:31.000000000","message":"Done","commit_id":"244f36e7581fa1a55d7ad7713bc3bfcf92b12f03"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"a41ed45e0609f397b554ef58c54943d638b5d1d9","unresolved":false,"context_lines":[{"line_number":1127,"context_line":"                # Setup int_br to physical bridge patches.  If they already"},{"line_number":1128,"context_line":"                # exist we just update them, otherwise we create them but don\u0027t"},{"line_number":1129,"context_line":"                # connect them until after the drop rules are in place."},{"line_number":1130,"context_line":"                if (self.int_br.port_exists(int_if_name)):"},{"line_number":1131,"context_line":"                    int_ofport \u003d self.int_br.add_patch_port("},{"line_number":1132,"context_line":"                        int_if_name, phys_if_name)"},{"line_number":1133,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_62ccf535","line":1130,"range":{"start_line":1130,"start_character":19,"end_line":1130,"end_character":20},"updated":"2016-03-25 20:02:30.000000000","message":"nit: you don\u0027t need to use parentheses here.","commit_id":"244f36e7581fa1a55d7ad7713bc3bfcf92b12f03"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"5a881ebefd1a3a4f5df18b8d2a799d0fc3f74c02","unresolved":false,"context_lines":[{"line_number":1127,"context_line":"                # Setup int_br to physical bridge patches.  If they already"},{"line_number":1128,"context_line":"                # exist we just update them, otherwise we create them but don\u0027t"},{"line_number":1129,"context_line":"                # connect them until after the drop rules are in place."},{"line_number":1130,"context_line":"                if (self.int_br.port_exists(int_if_name)):"},{"line_number":1131,"context_line":"                    int_ofport \u003d self.int_br.add_patch_port("},{"line_number":1132,"context_line":"                        int_if_name, phys_if_name)"},{"line_number":1133,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_5986f613","line":1130,"range":{"start_line":1130,"start_character":19,"end_line":1130,"end_character":20},"in_reply_to":"da0c15f0_62ccf535","updated":"2016-03-27 04:38:31.000000000","message":"Not sure why I had those here, good catch.","commit_id":"244f36e7581fa1a55d7ad7713bc3bfcf92b12f03"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"a41ed45e0609f397b554ef58c54943d638b5d1d9","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"                else:"},{"line_number":1134,"context_line":"                    int_ofport \u003d self.int_br.add_patch_port("},{"line_number":1135,"context_line":"                        int_if_name, constants.NONEXISTENT_PEER)"},{"line_number":1136,"context_line":"                if (br.port_exists(phys_if_name)):"},{"line_number":1137,"context_line":"                    phys_ofport \u003d br.add_patch_port("},{"line_number":1138,"context_line":"                        phys_if_name, int_if_name)"},{"line_number":1139,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_e2d805f2","line":1136,"range":{"start_line":1136,"start_character":19,"end_line":1136,"end_character":20},"updated":"2016-03-25 20:02:30.000000000","message":"the same about parentheses","commit_id":"244f36e7581fa1a55d7ad7713bc3bfcf92b12f03"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8f67234ba736efadbe66e876b19298d6439dfc82","unresolved":false,"context_lines":[{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"                # Setup int_br to physical bridge patches.  If they already"},{"line_number":1128,"context_line":"                # exist we just update them, otherwise we create them but don\u0027t"},{"line_number":1129,"context_line":"                # connect them until after the drop rules are in place."},{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"                int_if_target \u003d constants.NONEXISTENT_PEER"},{"line_number":1132,"context_line":"                if self.int_br.port_exists(int_if_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_4690bcec","line":1129,"updated":"2016-03-28 09:55:53.000000000","message":"+1. it will be a little more work to grab and inspect the flows, but it will protect us against the case where an agent was killed after ports being partially wired or where the flows were cleared from OVS by an admin.","commit_id":"683d1b525dab0a5052cf9e401493314234f6f38a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d379de9bcc22671c226eb3982fe6abb8e344cf8b","unresolved":false,"context_lines":[{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"                # Setup int_br to physical bridge patches.  If they already"},{"line_number":1128,"context_line":"                # exist we just update them, otherwise we create them but don\u0027t"},{"line_number":1129,"context_line":"                # connect them until after the drop rules are in place."},{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"                int_if_target \u003d constants.NONEXISTENT_PEER"},{"line_number":1132,"context_line":"                if self.int_br.port_exists(int_if_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_049a4a63","line":1129,"range":{"start_line":1129,"start_character":31,"end_line":1129,"end_character":36},"updated":"2016-03-28 00:36:05.000000000","message":"patch existence doesn\u0027t ensure drop rules existence so you should check patch existence + drop rules existence to update them only.\n\nI would prefer we do nothing if both patch ports exist and are correctly configured (drop rules included) and otherwise rebuild everything","commit_id":"683d1b525dab0a5052cf9e401493314234f6f38a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ff084db71f50e5e4fa6449fc34d04b125006ac0f","unresolved":false,"context_lines":[{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"                # Setup int_br to physical bridge patches.  If they already"},{"line_number":1128,"context_line":"                # exist we just update them, otherwise we create them but don\u0027t"},{"line_number":1129,"context_line":"                # connect them until after the drop rules are in place."},{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"                int_if_target \u003d constants.NONEXISTENT_PEER"},{"line_number":1132,"context_line":"                if self.int_br.port_exists(int_if_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_c81d3b11","line":1129,"in_reply_to":"ba0121b8_113129a3","updated":"2016-03-29 09:10:00.000000000","message":"The workflow is:\n\n 1) create patch ports or wire them if they exist\n 2) create drop rules\n 3) wire patch ports\n\nIf the agent is killed during 2) then patch ports are created but not wired. With your proposal, the next agent startup will wire patch ports during 1)!","commit_id":"683d1b525dab0a5052cf9e401493314234f6f38a"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"d8b845a2f1a6ed02fe657448f23638d5f12ccacb","unresolved":false,"context_lines":[{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"                # Setup int_br to physical bridge patches.  If they already"},{"line_number":1128,"context_line":"                # exist we just update them, otherwise we create them but don\u0027t"},{"line_number":1129,"context_line":"                # connect them until after the drop rules are in place."},{"line_number":1130,"context_line":""},{"line_number":1131,"context_line":"                int_if_target \u003d constants.NONEXISTENT_PEER"},{"line_number":1132,"context_line":"                if self.int_br.port_exists(int_if_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_113129a3","line":1129,"in_reply_to":"da0c15f0_4690bcec","updated":"2016-03-29 02:54:50.000000000","message":"If the drop flows aren\u0027t already in place, but the ports are wired, then isn\u0027t everything broken before the agent already starts?   Is it worth the extra overhead of checking if the drop flows are in place at that point?","commit_id":"683d1b525dab0a5052cf9e401493314234f6f38a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8f67234ba736efadbe66e876b19298d6439dfc82","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"            self.phys_ofports[physical_network] \u003d phys_ofport"},{"line_number":1145,"context_line":""},{"line_number":1146,"context_line":"            # block all untranslated traffic between bridges"},{"line_number":1147,"context_line":"            self.int_br.drop_port(in_port\u003dint_ofport)"},{"line_number":1148,"context_line":"            br.drop_port(in_port\u003dphys_ofport)"},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"            if self.use_veth_interconnection:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_a6bd586a","line":1147,"updated":"2016-03-28 09:55:53.000000000","message":"In OVS if we add a rule that matches another exactly, it just replaces it.","commit_id":"683d1b525dab0a5052cf9e401493314234f6f38a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d379de9bcc22671c226eb3982fe6abb8e344cf8b","unresolved":false,"context_lines":[{"line_number":1144,"context_line":"            self.phys_ofports[physical_network] \u003d phys_ofport"},{"line_number":1145,"context_line":""},{"line_number":1146,"context_line":"            # block all untranslated traffic between bridges"},{"line_number":1147,"context_line":"            self.int_br.drop_port(in_port\u003dint_ofport)"},{"line_number":1148,"context_line":"            br.drop_port(in_port\u003dphys_ofport)"},{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"            if self.use_veth_interconnection:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da0c15f0_44cba253","line":1147,"updated":"2016-03-28 00:36:05.000000000","message":"We won\u0027t end up with n drop rules where n is the number of ovs agent restarts?","commit_id":"683d1b525dab0a5052cf9e401493314234f6f38a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4c44a9f22ca79f2f72772022c2ca442476976a32","unresolved":false,"context_lines":[{"line_number":1128,"context_line":"                # Setup int_br to physical bridge patches.  If they already"},{"line_number":1129,"context_line":"                # exist we leave them alone, otherwise we create them but don\u0027t"},{"line_number":1130,"context_line":"                # connect them until after the drop rules are in place."},{"line_number":1131,"context_line":"                int_ofport \u003d self.int_br.get_port_ofport(int_if_name)"},{"line_number":1132,"context_line":"                if int_ofport \u003d\u003d ovs_lib.INVALID_OFPORT:"},{"line_number":1133,"context_line":"                    int_ofport \u003d self.int_br.add_patch_port("},{"line_number":1134,"context_line":"                        int_if_name, constants.NONEXISTENT_PEER)"},{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":"                phys_ofport \u003d br.get_port_ofport(phys_if_name)"},{"line_number":1137,"context_line":"                if phys_ofport \u003d\u003d ovs_lib.INVALID_OFPORT:"},{"line_number":1138,"context_line":"                    phys_ofport \u003d br.add_patch_port("},{"line_number":1139,"context_line":"                        phys_if_name, constants.NONEXISTENT_PEER)"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"            self.int_ofports[physical_network] \u003d int_ofport"},{"line_number":1142,"context_line":"            self.phys_ofports[physical_network] \u003d phys_ofport"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_994dc940","line":1139,"range":{"start_line":1131,"start_character":16,"end_line":1139,"end_character":65},"updated":"2016-03-31 12:48:56.000000000","message":"Could as well be:\n\n    for port in (int_if_name, phys_if_name):\n        ...","commit_id":"6be740451488175a7cb3162290a714821498ab99"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"b0c3ceda0b724f6610b2a9d0bded3cd4e9c9915a","unresolved":false,"context_lines":[{"line_number":1128,"context_line":"                # Setup int_br to physical bridge patches.  If they already"},{"line_number":1129,"context_line":"                # exist we leave them alone, otherwise we create them but don\u0027t"},{"line_number":1130,"context_line":"                # connect them until after the drop rules are in place."},{"line_number":1131,"context_line":"                int_ofport \u003d self.int_br.get_port_ofport(int_if_name)"},{"line_number":1132,"context_line":"                if int_ofport \u003d\u003d ovs_lib.INVALID_OFPORT:"},{"line_number":1133,"context_line":"                    int_ofport \u003d self.int_br.add_patch_port("},{"line_number":1134,"context_line":"                        int_if_name, constants.NONEXISTENT_PEER)"},{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":"                phys_ofport \u003d br.get_port_ofport(phys_if_name)"},{"line_number":1137,"context_line":"                if phys_ofport \u003d\u003d ovs_lib.INVALID_OFPORT:"},{"line_number":1138,"context_line":"                    phys_ofport \u003d br.add_patch_port("},{"line_number":1139,"context_line":"                        phys_if_name, constants.NONEXISTENT_PEER)"},{"line_number":1140,"context_line":""},{"line_number":1141,"context_line":"            self.int_ofports[physical_network] \u003d int_ofport"},{"line_number":1142,"context_line":"            self.phys_ofports[physical_network] \u003d phys_ofport"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_3f38dd3c","line":1139,"range":{"start_line":1131,"start_character":16,"end_line":1139,"end_character":65},"in_reply_to":"ba0121b8_994dc940","updated":"2016-03-31 13:09:42.000000000","message":"We need to put the resulting ofport that is retrieved or created into separate arrays below, so we need different variables.","commit_id":"6be740451488175a7cb3162290a714821498ab99"}],"neutron/tests/functional/agent/test_l2_ovs_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4c8d9d66d64d540ef1c76549a469e99a6ede94b8","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        self.assertEqual(patch_int_ofport_before, self.agent.patch_int_ofport)"},{"line_number":239,"context_line":"        self.assertEqual(patch_tun_ofport_before, self.agent.patch_tun_ofport)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_assert_br__patch_port_ofports_dont_change(self):"},{"line_number":242,"context_line":"        # When the integration bridge is setup, it should reuse the existing"},{"line_number":243,"context_line":"        # patch ports between br-int and br-tun."},{"line_number":244,"context_line":"        self.setup_agent_and_ports(port_dicts\u003d[])"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_679b4a73","line":241,"range":{"start_line":241,"start_character":8,"end_line":241,"end_character":54},"updated":"2016-03-30 03:33:29.000000000","message":"br_phys_patch_port_ofports_dont_change","commit_id":"5ecbbfc1b73019e15b79e0b1e2f207dfef798ee7"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"f5bb88754f235dda6af55c24776c8c6c38e51edb","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        # patch ports between br-int and br-phys."},{"line_number":244,"context_line":"        self.setup_agent_and_ports(port_dicts\u003d[])"},{"line_number":245,"context_line":"        patch_int_ofport_before \u003d self.agent.int_ofports[\u0027physnet\u0027]"},{"line_number":246,"context_line":"        patch_tun_ofport_before \u003d self.agent.phys_ofports[\u0027physnet\u0027]"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        self.setup_agent_and_ports(port_dicts\u003d[], create_tunnels\u003dTrue)"},{"line_number":249,"context_line":"        self.assertEqual(patch_int_ofport_before,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_c1d3d1d3","line":246,"updated":"2016-03-31 13:12:00.000000000","message":"you should probably rename patch_tun_ofport_before -\u003e patch_phys_ofport_before right?","commit_id":"6be740451488175a7cb3162290a714821498ab99"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4c44a9f22ca79f2f72772022c2ca442476976a32","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        patch_int_ofport_before \u003d self.agent.int_ofports[\u0027physnet\u0027]"},{"line_number":246,"context_line":"        patch_tun_ofport_before \u003d self.agent.phys_ofports[\u0027physnet\u0027]"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        self.setup_agent_and_ports(port_dicts\u003d[], create_tunnels\u003dTrue)"},{"line_number":249,"context_line":"        self.assertEqual(patch_int_ofport_before,"},{"line_number":250,"context_line":"                         self.agent.int_ofports[\u0027physnet\u0027])"},{"line_number":251,"context_line":"        self.assertEqual(patch_tun_ofport_before,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_1c4fe76b","line":248,"range":{"start_line":248,"start_character":50,"end_line":248,"end_character":69},"updated":"2016-03-31 12:48:56.000000000","message":"Is it really needed?","commit_id":"6be740451488175a7cb3162290a714821498ab99"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"74fdf862c2e4ddfaec300dc3ded7d47cf9e10ecc","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        patch_int_ofport_before \u003d self.agent.int_ofports[\u0027physnet\u0027]"},{"line_number":246,"context_line":"        patch_tun_ofport_before \u003d self.agent.phys_ofports[\u0027physnet\u0027]"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        self.setup_agent_and_ports(port_dicts\u003d[], create_tunnels\u003dTrue)"},{"line_number":249,"context_line":"        self.assertEqual(patch_int_ofport_before,"},{"line_number":250,"context_line":"                         self.agent.int_ofports[\u0027physnet\u0027])"},{"line_number":251,"context_line":"        self.assertEqual(patch_tun_ofport_before,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_8ad3a903","line":248,"range":{"start_line":248,"start_character":50,"end_line":248,"end_character":69},"in_reply_to":"ba0121b8_1c4fe76b","updated":"2016-03-31 13:23:06.000000000","message":"I don\u0027t think so.  I\u0027ve removed it.","commit_id":"6be740451488175a7cb3162290a714821498ab99"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"f5bb88754f235dda6af55c24776c8c6c38e51edb","unresolved":false,"context_lines":[{"line_number":245,"context_line":"        patch_int_ofport_before \u003d self.agent.int_ofports[\u0027physnet\u0027]"},{"line_number":246,"context_line":"        patch_tun_ofport_before \u003d self.agent.phys_ofports[\u0027physnet\u0027]"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        self.setup_agent_and_ports(port_dicts\u003d[], create_tunnels\u003dTrue)"},{"line_number":249,"context_line":"        self.assertEqual(patch_int_ofport_before,"},{"line_number":250,"context_line":"                         self.agent.int_ofports[\u0027physnet\u0027])"},{"line_number":251,"context_line":"        self.assertEqual(patch_tun_ofport_before,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_df7f21a9","line":248,"range":{"start_line":248,"start_character":50,"end_line":248,"end_character":69},"in_reply_to":"ba0121b8_1c4fe76b","updated":"2016-03-31 13:12:00.000000000","message":"I think it can be removed, it\u0027s also inconsistent with line 244 :)","commit_id":"6be740451488175a7cb3162290a714821498ab99"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97f156a1ff3644ba07cc145dae672afb0eb2888e","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        # patch ports between br-int and br-phys."},{"line_number":290,"context_line":"        self.setup_agent_and_ports(port_dicts\u003d[])"},{"line_number":291,"context_line":"        patch_int_ofport_before \u003d self.agent.int_ofports[\u0027physnet\u0027]"},{"line_number":292,"context_line":"        patch_tun_ofport_before \u003d self.agent.phys_ofports[\u0027physnet\u0027]"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        self.setup_agent_and_ports(port_dicts\u003d[], create_tunnels\u003dTrue)"},{"line_number":295,"context_line":"        self.assertEqual(patch_int_ofport_before,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba0121b8_4b1b3eca","line":292,"updated":"2016-03-31 20:06:24.000000000","message":"Rossella suggested before the name here is incorrect.","commit_id":"84a822f6f2a07005d704c915939e99985a002edd"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"e0e0f3c439a1feb7b008dcf5374494cf4d6c105a","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        # patch ports between br-int and br-phys."},{"line_number":290,"context_line":"        self.setup_agent_and_ports(port_dicts\u003d[])"},{"line_number":291,"context_line":"        patch_int_ofport_before \u003d self.agent.int_ofports[\u0027physnet\u0027]"},{"line_number":292,"context_line":"        patch_tun_ofport_before \u003d self.agent.phys_ofports[\u0027physnet\u0027]"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        self.setup_agent_and_ports(port_dicts\u003d[], create_tunnels\u003dTrue)"},{"line_number":295,"context_line":"        self.assertEqual(patch_int_ofport_before,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba0121b8_7ca7e6bc","line":292,"in_reply_to":"ba0121b8_4b1b3eca","updated":"2016-03-31 20:53:16.000000000","message":"Sorry for the confusion, I missed her comment before.  Fixed in next PS","commit_id":"84a822f6f2a07005d704c915939e99985a002edd"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97f156a1ff3644ba07cc145dae672afb0eb2888e","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        patch_int_ofport_before \u003d self.agent.int_ofports[\u0027physnet\u0027]"},{"line_number":292,"context_line":"        patch_tun_ofport_before \u003d self.agent.phys_ofports[\u0027physnet\u0027]"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        self.setup_agent_and_ports(port_dicts\u003d[], create_tunnels\u003dTrue)"},{"line_number":295,"context_line":"        self.assertEqual(patch_int_ofport_before,"},{"line_number":296,"context_line":"                         self.agent.int_ofports[\u0027physnet\u0027])"},{"line_number":297,"context_line":"        self.assertEqual(patch_tun_ofport_before,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba0121b8_6b772202","line":294,"range":{"start_line":294,"start_character":50,"end_line":294,"end_character":69},"updated":"2016-03-31 20:06:24.000000000","message":"So why do we need it?","commit_id":"84a822f6f2a07005d704c915939e99985a002edd"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"e0e0f3c439a1feb7b008dcf5374494cf4d6c105a","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        patch_int_ofport_before \u003d self.agent.int_ofports[\u0027physnet\u0027]"},{"line_number":292,"context_line":"        patch_tun_ofport_before \u003d self.agent.phys_ofports[\u0027physnet\u0027]"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        self.setup_agent_and_ports(port_dicts\u003d[], create_tunnels\u003dTrue)"},{"line_number":295,"context_line":"        self.assertEqual(patch_int_ofport_before,"},{"line_number":296,"context_line":"                         self.agent.int_ofports[\u0027physnet\u0027])"},{"line_number":297,"context_line":"        self.assertEqual(patch_tun_ofport_before,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba0121b8_3cc3ae58","line":294,"range":{"start_line":294,"start_character":50,"end_line":294,"end_character":69},"in_reply_to":"ba0121b8_6b772202","updated":"2016-03-31 20:53:16.000000000","message":"I don\u0027t think we do.  I accidentally removed it in the wrong place.  Fixed in next PS","commit_id":"84a822f6f2a07005d704c915939e99985a002edd"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"89f2a7b8faf89ced134c8586cf710e51b1f8ae38","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"            int_br.get_port_ofport.return_value \u003d ovs_lib.INVALID_OFPORT"},{"line_number":1078,"context_line":"            self.agent.setup_physical_bridges({\"physnet1\": \"br-eth\"})"},{"line_number":1079,"context_line":"            expected_calls \u003d ["},{"line_number":1080,"context_line":"                mock.call.phys_br_cls(\u0027br-eth\u0027),"},{"line_number":1081,"context_line":"                mock.call.phys_br.create(),"},{"line_number":1082,"context_line":"                mock.call.phys_br.setup_controllers(mock.ANY),"},{"line_number":1083,"context_line":"                mock.call.phys_br.setup_default_table(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_609a1f65","line":1080,"range":{"start_line":1080,"start_character":41,"end_line":1080,"end_character":42},"updated":"2016-03-29 20:36:06.000000000","message":"You should add a test to validate the change and avoid regression, typically call twice setup_physical_bridges and verify that add_patch_port is called 2*n time during the 1st setup_physical_bridges call, none during the 2nd call.","commit_id":"855c8b3737407878b5dd211b3f63fdb5566110d8"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_tunnel.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"689e76c07abc5ca63f2c038f313db774284762bc","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self.mock_int_bridge.add_port.return_value \u003d self.MAP_TUN_INT_OFPORT"},{"line_number":133,"context_line":"        self.mock_int_bridge.add_patch_port.side_effect \u003d ("},{"line_number":134,"context_line":"            lambda tap, peer: self.ovs_int_ofports[tap])"},{"line_number":135,"context_line":"        self.mock_int_bridge.get_port_ofport.return_value \u003d \\"},{"line_number":136,"context_line":"            ovs_lib.INVALID_OFPORT"},{"line_number":137,"context_line":"        self.mock_int_bridge.get_vif_ports.return_value \u003d []"},{"line_number":138,"context_line":"        self.mock_int_bridge.get_ports_attributes.return_value \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_e5e8e8b6","line":135,"updated":"2016-03-30 09:25:23.000000000","message":"use parenthesis for line continuation\n\n[1] http://docs.openstack.org/developer/hacking/","commit_id":"1d7a988f335cf6e2c21c45126f0ea0864e01cc9a"},{"author":{"_account_id":10540,"name":"Clayton O\u0027Neill","email":"clayton.oneill@charter.com","username":"coneill"},"change_message_id":"e66c935a1e6e1d8080178ae6ee9ee87e86262ef5","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        self.mock_int_bridge.add_port.return_value \u003d self.MAP_TUN_INT_OFPORT"},{"line_number":133,"context_line":"        self.mock_int_bridge.add_patch_port.side_effect \u003d ("},{"line_number":134,"context_line":"            lambda tap, peer: self.ovs_int_ofports[tap])"},{"line_number":135,"context_line":"        self.mock_int_bridge.get_port_ofport.return_value \u003d \\"},{"line_number":136,"context_line":"            ovs_lib.INVALID_OFPORT"},{"line_number":137,"context_line":"        self.mock_int_bridge.get_vif_ports.return_value \u003d []"},{"line_number":138,"context_line":"        self.mock_int_bridge.get_ports_attributes.return_value \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_8310f2a9","line":135,"in_reply_to":"ba0121b8_e5e8e8b6","updated":"2016-03-30 13:22:46.000000000","message":"Done","commit_id":"1d7a988f335cf6e2c21c45126f0ea0864e01cc9a"}]}
