)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2afb9a2429e0dfbe7beef612899bd1224c32a2bf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"limit it raises an assertion."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch will change the default link-local-address pair"},{"line_number":16,"context_line":"subnet and perfixlen and will also make it configurable for"},{"line_number":17,"context_line":"future expansion if required."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1562110"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da0c15f0_45dc5b12","line":16,"updated":"2016-03-25 20:23:56.000000000","message":"nit: prefixlen","commit_id":"6bad7f6ec6953d9819ef30d7d517d1c2a3210dbf"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"dabae515396acb68f6865bf81631932405735401","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brian Haley \u003cbrian.haley@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-30 13:22:42 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DVR: Increase the link-local address pair range"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current dvr_fip_ns.py file has a FIP_LL_SUBNET configured"},{"line_number":10,"context_line":"with a subnet prefixlen of /23 which only allows 255 pairs of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba0121b8_7d4f216b","line":7,"updated":"2016-03-30 20:32:50.000000000","message":"I didn\u0027t see an answer to Brian\u0027s question about the upgrade process. Will the IPs be renumbered or persistent? This is worth mentioning in the commit message.","commit_id":"8025bcff331101daa7276d57fcdb59ce3d75c23d"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"82b5a7989b6dfe4b319b450b93c0fb2cb8d885e5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brian Haley \u003cbrian.haley@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-30 13:22:42 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DVR: Increase the link-local address pair range"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current dvr_fip_ns.py file has a FIP_LL_SUBNET configured"},{"line_number":10,"context_line":"with a subnet prefixlen of /23 which only allows 255 pairs of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba0121b8_8eb75df4","line":7,"in_reply_to":"ba0121b8_7d4f216b","updated":"2016-03-30 22:02:35.000000000","message":"So I ran some tests to see, here\u0027s what I saw:\n\nInitial value in the fip- namespace:\n\n5: fpr-52582976-0:\n    inet 169.254.31.239/31 scope global fpr-52582976-0\n\n1) Updating the code and re-starting the l3-agent made no change:\n\n5: fpr-52582976-0:\n    inet 169.254.31.239/31 scope global fpr-52582976-0\n\n2) Dis- and re-associating a floating IP changed the IP:\n\n5: fpr-52582976-0:\n    inet 169.254.178.169/31 scope global fpr-52582976-0\n\nThis is because the dis-association actually removed the fpr- device\n\n3) With the original code back in place, I associated a floating IP with an existing VM.  Then I restarted the l3-agent with the new changes added a floating IP for a second tenant\u0027s VM.  The veth to that tenant\u0027s router got an IP from the \"new\" subnet cidr:\n\n5: fpr-52582976-0:\n    inet 169.254.31.29/31 scope global fpr-52582976-0\n\n6: fpr-a8a4391e-a@if2:\n    inet 169.254.178.169/31 scope global fpr-a8a4391e-a\n\n4) I then dis- and re-associated the floating IP for that first tenant.  Since the fpr-device was re-created it got a \"new\" IP:\n\n6: fpr-a8a4391e-a@if2:\n    inet 169.254.178.169/31 scope global fpr-a8a4391e-a\n\n7: fpr-52582976-0@if6:\n    inet 169.254.155.21/31 scope global fpr-52582976-0\n\n\nSo I think it works fine on an upgrade unless I missed something, and since the \"old\" and \"new\" cidrs didn\u0027t overlap, there should be no overlap conflict.\n\nLet me know if there\u0027s something else I should test.","commit_id":"8025bcff331101daa7276d57fcdb59ce3d75c23d"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d2e1ffbf6aa22627d2f3e3f667c52fbbd212bd4c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brian Haley \u003cbrian.haley@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-30 13:22:42 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DVR: Increase the link-local address pair range"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current dvr_fip_ns.py file has a FIP_LL_SUBNET configured"},{"line_number":10,"context_line":"with a subnet prefixlen of /23 which only allows 255 pairs of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba0121b8_6962c33f","line":7,"in_reply_to":"ba0121b8_8eb75df4","updated":"2016-03-30 22:29:57.000000000","message":"Thanks Brian I think that covers it. For testing, we can look into the partial grenade job. It currently only tests an upgrade scenario with the OVS agent on the \u0027old\u0027 node, not the L3 agent, but we can move the L3 agent from the main node to the extra node to test compatibility of the L3 agent as well. Ihar knows more about this and where this effort stands.","commit_id":"8025bcff331101daa7276d57fcdb59ce3d75c23d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"4f69c9a80ba2ff90ab4cae7f7cbe4f9c002a67f8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Brian Haley \u003cbrian.haley@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-30 13:22:42 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DVR: Increase the link-local address pair range"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The current dvr_fip_ns.py file has a FIP_LL_SUBNET configured"},{"line_number":10,"context_line":"with a subnet prefixlen of /23 which only allows 255 pairs of"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba0121b8_c9678fe7","line":7,"in_reply_to":"ba0121b8_8eb75df4","updated":"2016-03-30 22:17:27.000000000","message":"Yes the ips assigned will be persistent as far as the Node is powered up and running.\n\nAs Brian had mentioned in the message above, restarting the agent will not affect the IP ranges.\n\nSo we should be good here.","commit_id":"8025bcff331101daa7276d57fcdb59ce3d75c23d"}],"neutron/agent/l3_agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5426dc01c6d9ab44b7ea6ec5b01d85b5ba21f3a0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    conf.register_opts(external_process.OPTS)"},{"line_number":45,"context_line":"    conf.register_opts(pd.OPTS)"},{"line_number":46,"context_line":"    conf.register_opts(ra.OPTS)"},{"line_number":47,"context_line":"    conf.register_opts(dvr_fip_ns.FIP_OPTS)"},{"line_number":48,"context_line":"    config.register_availability_zone_opts_helper(conf)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_82d85b1f","line":47,"updated":"2016-03-28 18:19:31.000000000","message":"You\u0027ll need similar changes in the test files","commit_id":"214cf49cebea98dbfe666b6c683adf4a28284e52"}],"neutron/agent/linux/keepalived.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"920f42d5838e80a37cc12f9edece82637eb0c925","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        metadata_cidr \u003d \u0027169.254.169.254/32\u0027"},{"line_number":179,"context_line":"        self.primary_vip_range \u003d get_free_range("},{"line_number":180,"context_line":"            parent_range\u003d\u0027169.254.0.0/16\u0027,"},{"line_number":181,"context_line":"            excluded_ranges\u003d[metadata_cidr,"},{"line_number":182,"context_line":"                             cfg.CONF.fip_rtr_link_local_cidr] + ha_cidrs,"},{"line_number":183,"context_line":"            size\u003dPRIMARY_VIP_RANGE_SIZE)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_8ec5245d","line":181,"updated":"2016-03-28 19:57:51.000000000","message":"We need to figure out a way to pass the config option from the l3 agent to the keepalived.","commit_id":"2ba9ca4b1f126a38f15537240e219c4d789c6f19"}],"neutron/common/constants.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"802753454554ea2db7d2f9ffb13a13c7ef0ad935","unresolved":false,"context_lines":[{"line_number":232,"context_line":"# them all here so we don\u0027t have overlap.  We define the metadata"},{"line_number":233,"context_line":"# cidr since it falls in the range."},{"line_number":234,"context_line":"PRIVATE_CIDR_RANGE \u003d \u0027169.254.0.0/16\u0027"},{"line_number":235,"context_line":"DVR_FIP_LL_CIDR \u003d \u0027169.254.128.0/18\u0027"},{"line_number":236,"context_line":"L3_HA_NET_CIDR \u003d \u0027169.254.192.0/18\u0027"},{"line_number":237,"context_line":"METADATA_CIDR \u003d \u0027169.254.169.254/32\u0027"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba0121b8_5239f4d7","line":235,"updated":"2016-04-01 20:59:51.000000000","message":"this range actually included the metadata IP, should change to 169.254.64.0/18","commit_id":"8025bcff331101daa7276d57fcdb59ce3d75c23d"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8cdd41bd7c253ddc1f8c7dfc0fa820823a6f1cb1","unresolved":false,"context_lines":[{"line_number":236,"context_line":"IPV6_MAX_PREFIXLEN \u003d 128"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"# Some components communicate using private address ranges, define"},{"line_number":239,"context_line":"# them all here so we don\u0027t have overlap.  We define the metadata"},{"line_number":240,"context_line":"# cidr since it falls in the range."},{"line_number":241,"context_line":"PRIVATE_CIDR_RANGE \u003d \u0027169.254.0.0/16\u0027"},{"line_number":242,"context_line":"DVR_FIP_LL_CIDR \u003d \u0027169.254.64.0/18\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_d5a78b4d","line":239,"range":{"start_line":239,"start_character":16,"end_line":239,"end_character":40},"updated":"2016-04-04 21:33:10.000000000","message":"Strictly speaking, some overlap would be okay.  But, for now, it is probably better to use disjoint address ranges just for sanity.\n\nBut, to point out one case where overlap is ok, DVR_FIP_LL_CIDR and L3_HA_NET_CIDR could overlap without causing any issues because they are used in disjoint namespaces for disjoint reasons.  :)","commit_id":"865591b60174f5a34bd5bbe7b231b00dc20e9422"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"9d376affee25cf60691127e7730d01150feed210","unresolved":false,"context_lines":[{"line_number":236,"context_line":"IPV6_MAX_PREFIXLEN \u003d 128"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"# Some components communicate using private address ranges, define"},{"line_number":239,"context_line":"# them all here so we don\u0027t have overlap.  We define the metadata"},{"line_number":240,"context_line":"# cidr since it falls in the range."},{"line_number":241,"context_line":"PRIVATE_CIDR_RANGE \u003d \u0027169.254.0.0/16\u0027"},{"line_number":242,"context_line":"DVR_FIP_LL_CIDR \u003d \u0027169.254.64.0/18\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_f8533669","line":239,"range":{"start_line":239,"start_character":16,"end_line":239,"end_character":40},"in_reply_to":"9a061dce_95d79822","updated":"2016-04-06 15:44:59.000000000","message":"I might have driven you to make this even less clear.  I was just making a note and didn\u0027t mean to suggest action.\n\nSome of these ranges do need to be disjoint.  For example, the metadata probably should overlap with anything since those addresses exist in a number of different namespaces.","commit_id":"865591b60174f5a34bd5bbe7b231b00dc20e9422"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"615eb8ecc0e29b9356042987fe12dcf790cf643c","unresolved":false,"context_lines":[{"line_number":236,"context_line":"IPV6_MAX_PREFIXLEN \u003d 128"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"# Some components communicate using private address ranges, define"},{"line_number":239,"context_line":"# them all here so we don\u0027t have overlap.  We define the metadata"},{"line_number":240,"context_line":"# cidr since it falls in the range."},{"line_number":241,"context_line":"PRIVATE_CIDR_RANGE \u003d \u0027169.254.0.0/16\u0027"},{"line_number":242,"context_line":"DVR_FIP_LL_CIDR \u003d \u0027169.254.64.0/18\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_95d79822","line":239,"range":{"start_line":239,"start_character":16,"end_line":239,"end_character":40},"in_reply_to":"9a061dce_d5a78b4d","updated":"2016-04-05 19:25:03.000000000","message":"Done","commit_id":"865591b60174f5a34bd5bbe7b231b00dc20e9422"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f695d2cec11e156e705ead237f8ff4a89bd182f9","unresolved":false,"context_lines":[{"line_number":236,"context_line":"IPV6_MAX_PREFIXLEN \u003d 128"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"# Some components communicate using private address ranges, define"},{"line_number":239,"context_line":"# them all here so we don\u0027t have overlap.  We define the metadata"},{"line_number":240,"context_line":"# cidr since it falls in the range."},{"line_number":241,"context_line":"PRIVATE_CIDR_RANGE \u003d \u0027169.254.0.0/16\u0027"},{"line_number":242,"context_line":"DVR_FIP_LL_CIDR \u003d \u0027169.254.64.0/18\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"9a061dce_711901d7","line":239,"range":{"start_line":239,"start_character":16,"end_line":239,"end_character":40},"in_reply_to":"9a061dce_f8533669","updated":"2016-04-06 16:27:01.000000000","message":"s/should/shouldn\u0027t/","commit_id":"865591b60174f5a34bd5bbe7b231b00dc20e9422"}],"neutron/opts.py":[{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"920f42d5838e80a37cc12f9edece82637eb0c925","unresolved":false,"context_lines":[{"line_number":119,"context_line":"             neutron.db.dvr_mac_db.dvr_mac_address_opts,"},{"line_number":120,"context_line":"             neutron.db.l3_dvr_db.router_distributed_opts,"},{"line_number":121,"context_line":"             neutron.db.l3_agentschedulers_db.L3_AGENTS_SCHEDULER_OPTS,"},{"line_number":122,"context_line":"             neutron.db.l3_hamode_db.L3_HA_OPTS,"},{"line_number":123,"context_line":"             neutron.agent.l3.dvr_fip_ns.FIP_OPTS)"},{"line_number":124,"context_line":"         ),"},{"line_number":125,"context_line":"        (\u0027database\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba0121b8_4e794c2f","line":122,"updated":"2016-03-28 19:57:51.000000000","message":"Just added in here to see if we can pass it on to the keepalived from neutron.conf.","commit_id":"2ba9ca4b1f126a38f15537240e219c4d789c6f19"}]}