)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"43981f4fc0b24cd6af7ef6c06a7d91edc0690a32","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This patch adds notify for tag operations."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4373b2220f87751a4d89462bef37d04bf9a71fe7"},{"line_number":14,"context_line":"Closes-Bug: #1560226"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da0c15f0_2b1d84bd","line":14,"updated":"2016-03-28 14:30:04.000000000","message":"I am not sure if this patch gets the submitter of the bug the full solution. It looks like something outside of neutron wants a message sent?","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"a8bff98cbaa8c4b2aaae4d9efefc3eebfd4dd77e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This patch adds notify for tag operations."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4373b2220f87751a4d89462bef37d04bf9a71fe7"},{"line_number":14,"context_line":"Closes-Bug: #1560226"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_09d9f521","line":14,"in_reply_to":"da0c15f0_2b1d84bd","updated":"2016-03-29 10:03:08.000000000","message":"Yeah, so I hoped that he reviews this patch.","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"051b231002fa2b2cabda329fb194b622b18579f9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hirofumi Ichihara \u003cichihara.hirofumi@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-29 14:37:05 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add notify for tag operations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a tag\u0027s added to (or removed from) a resource, no notification is"},{"line_number":10,"context_line":"generated indicating that the network (or port or whatever) has changed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da4df55a_9f76f53c","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":10},"updated":"2016-12-22 04:42:40.000000000","message":"Precisely speaking, I think \u0027notification\u0027 is better :)","commit_id":"0daed9ebcab7d46d066fd9d8af576d9aca0a7205"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"48ce51b2032749c9853ee0a5fffcfdef45d67093","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hirofumi Ichihara \u003cichihara.hirofumi@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-11-29 14:37:05 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add notify for tag operations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a tag\u0027s added to (or removed from) a resource, no notification is"},{"line_number":10,"context_line":"generated indicating that the network (or port or whatever) has changed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da4df55a_941a5416","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":10},"in_reply_to":"da4df55a_9f76f53c","updated":"2016-12-22 08:43:30.000000000","message":"Sorry, I forgot ;)","commit_id":"0daed9ebcab7d46d066fd9d8af576d9aca0a7205"}],"neutron/extensions/tag.py":[{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"ffad2716d9ab989d6875ea2ff83736e596df4c06","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def notify_tag_action(context, action, parent, parent_id, tags):"},{"line_number":79,"context_line":"    notifier \u003d n_rpc.get_notifier(\u0027network\u0027)"},{"line_number":80,"context_line":"    tag_event \u003d \u0027tag.%s\u0027 % action"},{"line_number":81,"context_line":"    payload \u003d {\u0027parent_resource\u0027: parent,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_8b864f11","line":78,"range":{"start_line":78,"start_character":58,"end_line":78,"end_character":62},"updated":"2016-03-28 14:40:03.000000000","message":"tags will need to be optional (for the \u0027remove all\u0027 case)","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"a8bff98cbaa8c4b2aaae4d9efefc3eebfd4dd77e","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        raise exceptions.InvalidInput(error_message\u003dmsg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def notify_tag_action(context, action, parent, parent_id, tags):"},{"line_number":79,"context_line":"    notifier \u003d n_rpc.get_notifier(\u0027network\u0027)"},{"line_number":80,"context_line":"    tag_event \u003d \u0027tag.%s\u0027 % action"},{"line_number":81,"context_line":"    payload \u003d {\u0027parent_resource\u0027: parent,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_0079d193","line":78,"range":{"start_line":78,"start_character":58,"end_line":78,"end_character":62},"in_reply_to":"da0c15f0_8b864f11","updated":"2016-03-29 10:03:08.000000000","message":"Right. I missed the case.","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"ffad2716d9ab989d6875ea2ff83736e596df4c06","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def notify_tag_action(context, action, parent, parent_id, tags):"},{"line_number":79,"context_line":"    notifier \u003d n_rpc.get_notifier(\u0027network\u0027)"},{"line_number":80,"context_line":"    tag_event \u003d \u0027tag.%s\u0027 % action"},{"line_number":81,"context_line":"    payload \u003d {\u0027parent_resource\u0027: parent,"},{"line_number":82,"context_line":"               \u0027parent_resource_id\u0027: parent_id,"},{"line_number":83,"context_line":"               \u0027tags\u0027: tags}"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_1f8d627b","line":80,"range":{"start_line":80,"start_character":17,"end_line":80,"end_character":20},"updated":"2016-03-28 14:40:03.000000000","message":"Typically it\u0027s possible to identify an event by its name; \u0027network.update.end\u0027, \u0027volume.delete.end\u0027 etc. \u0027tag\u0027 is a little generic. Something like \u0027neutron-tag\u0027 would make it more identifiable but that also would not be consistent with other services; perhaps ask the oslo or neutron teams?","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"a8bff98cbaa8c4b2aaae4d9efefc3eebfd4dd77e","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def notify_tag_action(context, action, parent, parent_id, tags):"},{"line_number":79,"context_line":"    notifier \u003d n_rpc.get_notifier(\u0027network\u0027)"},{"line_number":80,"context_line":"    tag_event \u003d \u0027tag.%s\u0027 % action"},{"line_number":81,"context_line":"    payload \u003d {\u0027parent_resource\u0027: parent,"},{"line_number":82,"context_line":"               \u0027parent_resource_id\u0027: parent_id,"},{"line_number":83,"context_line":"               \u0027tags\u0027: tags}"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_80ade133","line":80,"range":{"start_line":80,"start_character":17,"end_line":80,"end_character":20},"in_reply_to":"da0c15f0_1f8d627b","updated":"2016-03-29 10:03:08.000000000","message":"Thank you for good suggestion. Indeed \u0027tag\u0027 can be used by other projects as well. This patch can set event_type like \u0027network.update.\u0027 and \u0027router.update.\u0027 if we prefer consistency about event_type but we will lose consitency about payload at once. And also it looks like oslo team doesn\u0027t manage the name. Therefore, I like \u0027neutron_tag.\u0027 here.","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"ffad2716d9ab989d6875ea2ff83736e596df4c06","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    tag_event \u003d \u0027tag.%s\u0027 % action"},{"line_number":81,"context_line":"    payload \u003d {\u0027parent_resource\u0027: parent,"},{"line_number":82,"context_line":"               \u0027parent_resource_id\u0027: parent_id,"},{"line_number":83,"context_line":"               \u0027tags\u0027: tags}"},{"line_number":84,"context_line":"    notifier.info(context, tag_event, payload)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_abb193e3","line":83,"range":{"start_line":83,"start_character":23,"end_line":83,"end_character":27},"updated":"2016-03-28 14:40:03.000000000","message":"For \u0027remove all\u0027 the tags element should not be present","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"a8bff98cbaa8c4b2aaae4d9efefc3eebfd4dd77e","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    tag_event \u003d \u0027tag.%s\u0027 % action"},{"line_number":81,"context_line":"    payload \u003d {\u0027parent_resource\u0027: parent,"},{"line_number":82,"context_line":"               \u0027parent_resource_id\u0027: parent_id,"},{"line_number":83,"context_line":"               \u0027tags\u0027: tags}"},{"line_number":84,"context_line":"    notifier.info(context, tag_event, payload)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_606ecdca","line":83,"range":{"start_line":83,"start_character":23,"end_line":83,"end_character":27},"in_reply_to":"da0c15f0_abb193e3","updated":"2016-03-29 10:03:08.000000000","message":"Done","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"ffad2716d9ab989d6875ea2ff83736e596df4c06","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        validate_tag(id)"},{"line_number":113,"context_line":"        parent, parent_id \u003d get_parent_resource_and_id(kwargs)"},{"line_number":114,"context_line":"        result \u003d self.plugin.update_tag(request.context, parent, parent_id, id)"},{"line_number":115,"context_line":"        notify_tag_action(request.context, \u0027add\u0027, parent, parent_id, [id])"},{"line_number":116,"context_line":"        return result"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def update_all(self, request, body, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_2b92a39e","line":115,"range":{"start_line":115,"start_character":44,"end_line":115,"end_character":47},"updated":"2016-03-28 14:40:03.000000000","message":"Suggest using \u0027create\u0027","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"a8bff98cbaa8c4b2aaae4d9efefc3eebfd4dd77e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        validate_tag(id)"},{"line_number":113,"context_line":"        parent, parent_id \u003d get_parent_resource_and_id(kwargs)"},{"line_number":114,"context_line":"        result \u003d self.plugin.update_tag(request.context, parent, parent_id, id)"},{"line_number":115,"context_line":"        notify_tag_action(request.context, \u0027add\u0027, parent, parent_id, [id])"},{"line_number":116,"context_line":"        return result"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def update_all(self, request, body, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_bb5f760d","line":115,"range":{"start_line":115,"start_character":44,"end_line":115,"end_character":47},"in_reply_to":"da0c15f0_2b92a39e","updated":"2016-03-29 10:03:08.000000000","message":"Done","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"ffad2716d9ab989d6875ea2ff83736e596df4c06","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        parent, parent_id \u003d get_parent_resource_and_id(kwargs)"},{"line_number":123,"context_line":"        result \u003d self.plugin.update_tags(request.context, parent,"},{"line_number":124,"context_line":"                                         parent_id, body)"},{"line_number":125,"context_line":"        notify_tag_action(request.context, \u0027replace\u0027, parent,"},{"line_number":126,"context_line":"                          parent_id, body[\u0027tags\u0027])"},{"line_number":127,"context_line":"        return result"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_eb970b8e","line":125,"range":{"start_line":125,"start_character":44,"end_line":125,"end_character":51},"updated":"2016-03-28 14:40:03.000000000","message":"I would maybe suggest \u0027update\u0027 for this one","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"a8bff98cbaa8c4b2aaae4d9efefc3eebfd4dd77e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        parent, parent_id \u003d get_parent_resource_and_id(kwargs)"},{"line_number":123,"context_line":"        result \u003d self.plugin.update_tags(request.context, parent,"},{"line_number":124,"context_line":"                                         parent_id, body)"},{"line_number":125,"context_line":"        notify_tag_action(request.context, \u0027replace\u0027, parent,"},{"line_number":126,"context_line":"                          parent_id, body[\u0027tags\u0027])"},{"line_number":127,"context_line":"        return result"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_3bf886e5","line":125,"range":{"start_line":125,"start_character":44,"end_line":125,"end_character":51},"in_reply_to":"da0c15f0_eb970b8e","updated":"2016-03-29 10:03:08.000000000","message":"Done","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"ffad2716d9ab989d6875ea2ff83736e596df4c06","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        validate_tag(id)"},{"line_number":133,"context_line":"        parent, parent_id \u003d get_parent_resource_and_id(kwargs)"},{"line_number":134,"context_line":"        result \u003d self.plugin.delete_tag(request.context, parent, parent_id, id)"},{"line_number":135,"context_line":"        notify_tag_action(request.context, \u0027remove\u0027, parent, parent_id, [id])"},{"line_number":136,"context_line":"        return result"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def delete_all(self, request, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_df476a1b","line":135,"range":{"start_line":135,"start_character":44,"end_line":135,"end_character":50},"updated":"2016-03-28 14:40:03.000000000","message":"\u0027delete\u0027 is more standard","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"a8bff98cbaa8c4b2aaae4d9efefc3eebfd4dd77e","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        validate_tag(id)"},{"line_number":133,"context_line":"        parent, parent_id \u003d get_parent_resource_and_id(kwargs)"},{"line_number":134,"context_line":"        result \u003d self.plugin.delete_tag(request.context, parent, parent_id, id)"},{"line_number":135,"context_line":"        notify_tag_action(request.context, \u0027remove\u0027, parent, parent_id, [id])"},{"line_number":136,"context_line":"        return result"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def delete_all(self, request, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_7bdafe79","line":135,"range":{"start_line":135,"start_character":44,"end_line":135,"end_character":50},"in_reply_to":"da0c15f0_df476a1b","updated":"2016-03-29 10:03:08.000000000","message":"Done","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"ffad2716d9ab989d6875ea2ff83736e596df4c06","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # DELETE /v2.0/networks/{network_id}/tags"},{"line_number":140,"context_line":"        parent, parent_id \u003d get_parent_resource_and_id(kwargs)"},{"line_number":141,"context_line":"        result \u003d self.plugin.delete_tags(request.context, parent, parent_id)"},{"line_number":142,"context_line":"        notify_tag_action(request.context, \u0027remove_all\u0027, parent, parent_id)"},{"line_number":143,"context_line":"        return result"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da0c15f0_cbc0477f","line":142,"range":{"start_line":142,"start_character":44,"end_line":142,"end_character":54},"updated":"2016-03-28 14:40:03.000000000","message":"Suggest \u0027clear\u0027 or maybe \u0027delete_all\u0027","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"a8bff98cbaa8c4b2aaae4d9efefc3eebfd4dd77e","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        # DELETE /v2.0/networks/{network_id}/tags"},{"line_number":140,"context_line":"        parent, parent_id \u003d get_parent_resource_and_id(kwargs)"},{"line_number":141,"context_line":"        result \u003d self.plugin.delete_tags(request.context, parent, parent_id)"},{"line_number":142,"context_line":"        notify_tag_action(request.context, \u0027remove_all\u0027, parent, parent_id)"},{"line_number":143,"context_line":"        return result"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_bbe4963b","line":142,"range":{"start_line":142,"start_character":44,"end_line":142,"end_character":54},"in_reply_to":"da0c15f0_cbc0477f","updated":"2016-03-29 10:03:08.000000000","message":"Done","commit_id":"5d577b0a4e5f862db0cd4f9eaadb9b07b332c06e"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"51a2cc03be142f03bc704f4ca0a7ae60ce5bd03d","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def notify_tag_action(context, action, parent, parent_id, tags\u003dNone):"},{"line_number":79,"context_line":"    notifier \u003d n_rpc.get_notifier(\u0027network\u0027)"},{"line_number":80,"context_line":"    tag_event \u003d \u0027neutron_tag.%s\u0027 % action"},{"line_number":81,"context_line":"    payload \u003d {\u0027parent_resource\u0027: parent,"},{"line_number":82,"context_line":"               \u0027parent_resource_id\u0027: parent_id}"},{"line_number":83,"context_line":"    if tags is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_273b123a","line":80,"updated":"2016-03-30 03:39:18.000000000","message":"I think putting neutron here is unnecessary. We are already publishing to a specific topic of \u0027network\u0027. The only publisher to that topic should be Neutron so having \u0027neutron\u0027 on this one particular resource seems wrong.","commit_id":"ed161648aea79791d3a9673dadc37268d011d87e"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b7727ebcf53d9c8b197384d3281f20e3d318d0c5","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":"def notify_tag_action(context, action, parent, parent_id, tags\u003dNone):"},{"line_number":79,"context_line":"    notifier \u003d n_rpc.get_notifier(\u0027network\u0027)"},{"line_number":80,"context_line":"    tag_event \u003d \u0027neutron_tag.%s\u0027 % action"},{"line_number":81,"context_line":"    payload \u003d {\u0027parent_resource\u0027: parent,"},{"line_number":82,"context_line":"               \u0027parent_resource_id\u0027: parent_id}"},{"line_number":83,"context_line":"    if tags is not None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_a8f24ed0","line":80,"in_reply_to":"ba0121b8_273b123a","updated":"2016-03-30 07:43:06.000000000","message":"You\u0027re right. I noticed the notification message includes publisher_id. I will update.","commit_id":"ed161648aea79791d3a9673dadc37268d011d87e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3bd58c5ccf1ffd2be353b9b866a4b1deeac7fc12","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        parent, parent_id \u003d get_parent_resource_and_id(kwargs)"},{"line_number":115,"context_line":"        notify_tag_action(request.context, \u0027create.start\u0027,"},{"line_number":116,"context_line":"                          parent, parent_id, [id])"},{"line_number":117,"context_line":"        result \u003d self.plugin.update_tag(request.context, parent, parent_id, id)"},{"line_number":118,"context_line":"        notify_tag_action(request.context, \u0027create.end\u0027,"},{"line_number":119,"context_line":"                          parent, parent_id, [id])"},{"line_number":120,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_8fa35b9e","line":117,"updated":"2016-04-04 13:36:33.000000000","message":"If the tag plugin returns information of a targeted resource, we can notify richer information. It seems searchlight needs more information.","commit_id":"df081844007e3d3d2bdb48e3ed674888a9b17cb6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"aa5bea592924513d7f73890c3c147069971f8b7c","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        parent, parent_id \u003d get_parent_resource_and_id(kwargs)"},{"line_number":115,"context_line":"        notify_tag_action(request.context, \u0027create.start\u0027,"},{"line_number":116,"context_line":"                          parent, parent_id, [id])"},{"line_number":117,"context_line":"        result \u003d self.plugin.update_tag(request.context, parent, parent_id, id)"},{"line_number":118,"context_line":"        notify_tag_action(request.context, \u0027create.end\u0027,"},{"line_number":119,"context_line":"                          parent, parent_id, [id])"},{"line_number":120,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_ad889323","line":117,"updated":"2016-08-16 09:28:32.000000000","message":"Is searchlight not capable of keeping track of the parent received from a separate notification?","commit_id":"df081844007e3d3d2bdb48e3ed674888a9b17cb6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f1f190f1458fae44b2eb4742465566b25800e74f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        parent, parent_id \u003d get_parent_resource_and_id(kwargs)"},{"line_number":115,"context_line":"        notify_tag_action(request.context, \u0027create.start\u0027,"},{"line_number":116,"context_line":"                          parent, parent_id, [id])"},{"line_number":117,"context_line":"        result \u003d self.plugin.update_tag(request.context, parent, parent_id, id)"},{"line_number":118,"context_line":"        notify_tag_action(request.context, \u0027create.end\u0027,"},{"line_number":119,"context_line":"                          parent, parent_id, [id])"},{"line_number":120,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_9d3476fc","line":117,"in_reply_to":"9a061dce_6f3e2329","updated":"2016-04-07 12:54:40.000000000","message":"Yes, the tag plugin does not return the information.\n\nI wonder we can change the interface of the tag plugin.\nIf it helps us much, it is worth considered.","commit_id":"df081844007e3d3d2bdb48e3ed674888a9b17cb6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9ec4cdf9788216cfd9e0409343c70abb3b927124","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        parent, parent_id \u003d get_parent_resource_and_id(kwargs)"},{"line_number":115,"context_line":"        notify_tag_action(request.context, \u0027create.start\u0027,"},{"line_number":116,"context_line":"                          parent, parent_id, [id])"},{"line_number":117,"context_line":"        result \u003d self.plugin.update_tag(request.context, parent, parent_id, id)"},{"line_number":118,"context_line":"        notify_tag_action(request.context, \u0027create.end\u0027,"},{"line_number":119,"context_line":"                          parent, parent_id, [id])"},{"line_number":120,"context_line":"        return result"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_6f3e2329","line":117,"in_reply_to":"9a061dce_8fa35b9e","updated":"2016-04-07 05:40:50.000000000","message":"Tag plugin doesn\u0027t return the information. If we needs it, we must get the information from DB in order just to notify.","commit_id":"df081844007e3d3d2bdb48e3ed674888a9b17cb6"}]}
