)]}'
{"neutron/objects/base.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"90ae8ffe8e82f563cf0e12aa4d7c07272d744617","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class NeutronSyntheticFieldMultipleForeignKeys(exceptions.NeutronException):"},{"line_number":58,"context_line":"    message \u003d _(\"Synthetic fields %(field)s shouldn\u0027t have more than one \""},{"line_number":59,"context_line":"                \"foreign key\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_0a657244","line":58,"range":{"start_line":58,"start_character":27,"end_line":58,"end_character":33},"updated":"2016-03-29 05:28:05.000000000","message":"Similarly, \"Synthetic field\" is better if this log message show just a field.","commit_id":"b594301bd7bb539e2f53435011d2788c547b1aa6"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"db7201dbe45aed62d2457c9b55e8de31f536f209","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class NeutronSyntheticFieldMultipleForeignKeys(exceptions.NeutronException):"},{"line_number":58,"context_line":"    message \u003d _(\"Synthetic fields %(field)s shouldn\u0027t have more than one \""},{"line_number":59,"context_line":"                \"foreign key\")"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_f079ef30","line":58,"range":{"start_line":58,"start_character":27,"end_line":58,"end_character":33},"in_reply_to":"ba0121b8_0a657244","updated":"2016-03-29 15:03:16.000000000","message":"+1.. From the code it\u0027s evident that it can\u0027t be multiple.. \nhttps://github.com/openstack/neutron/blob/d27b27c183828b17aabfd736d5251e3f408a199d/neutron/objects/base.py#L301","commit_id":"b594301bd7bb539e2f53435011d2788c547b1aa6"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f9aa3e57b2d4c42257cd4bd64a69460551ba6f62","unresolved":false,"context_lines":[{"line_number":409,"context_line":"                  field\u003d\u0027field\u0027)):"},{"line_number":410,"context_line":"            obj \u003d self._test_class(self.context, **self.obj_fields[0])"},{"line_number":411,"context_line":"            self.assertRaises(base.NeutronSyntheticFieldMultipleForeignKeys,"},{"line_number":412,"context_line":"                              obj.create)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    @mock.patch.object(obj_db_api, \u0027update_object\u0027)"},{"line_number":415,"context_line":"    def test_update_no_changes(self, update_mock):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba0121b8_3a322bf2","line":412,"updated":"2016-03-29 13:44:45.000000000","message":"What does this test validate? The create_object function never raises the exception, so it does not really cover any real life scenario.\n\nInstead, you probably want to right a test case that would attempt to load object based synthetic fields for a type with multiple foreign keys.","commit_id":"381d27f81d9368a373314215fb31e28230bef7b0"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"903980b7e05a6e7422d749fd8561e225cb25d956","unresolved":false,"context_lines":[{"line_number":587,"context_line":""},{"line_number":588,"context_line":"    _test_class \u003d FakeNeutronObjectSyntheticField"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"    def test_load_synthetic_db_fields_wiht_multiple_foreign_keys(self):"},{"line_number":591,"context_line":"        obj \u003d self._test_class(self.context, **self.obj_fields[0])"},{"line_number":592,"context_line":"        self.assertRaises(base.NeutronSyntheticFieldMultipleForeignKeys,"},{"line_number":593,"context_line":"                          obj.load_synthetic_db_fields)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_722f71f6","line":590,"range":{"start_line":590,"start_character":38,"end_line":590,"end_character":42},"updated":"2016-03-30 12:03:22.000000000","message":"with","commit_id":"810c67e01e5e6756a407aa7175781073fd430088"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7f4eccc31bf2bfca35397ce6042c2ff64dc9e1e9","unresolved":false,"context_lines":[{"line_number":587,"context_line":""},{"line_number":588,"context_line":"    _test_class \u003d FakeNeutronObjectSyntheticField"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"    def test_load_synthetic_db_fields_wiht_multiple_foreign_keys(self):"},{"line_number":591,"context_line":"        obj \u003d self._test_class(self.context, **self.obj_fields[0])"},{"line_number":592,"context_line":"        self.assertRaises(base.NeutronSyntheticFieldMultipleForeignKeys,"},{"line_number":593,"context_line":"                          obj.load_synthetic_db_fields)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_e3a44ea7","line":590,"range":{"start_line":590,"start_character":38,"end_line":590,"end_character":42},"in_reply_to":"ba0121b8_722f71f6","updated":"2016-03-30 13:20:28.000000000","message":"Done","commit_id":"810c67e01e5e6756a407aa7175781073fd430088"}]}