)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9e76f3643fc81cbda4154f39b38221059cb0480e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix invalid mock name in test_ovs_neutron_agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The test_ovs_neutron_agent mocks on reset_tunnel_br while the patch [1] renamed this method to  setup_tunnel_br."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"[1] https://review.openstack.org/#/c/182920/"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_ac9badc8","line":9,"updated":"2016-03-29 13:16:04.000000000","message":"You should wrap this line.","commit_id":"2795789b7eb1b461b3ddda2d5517cee31761e03d"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8844dfc1049be0fa2ffe18a1ddaf1995852c41a1","unresolved":false,"context_lines":[{"line_number":2984,"context_line":"            self.agent.state_rpc \u003d mock.Mock()"},{"line_number":2985,"context_line":"            self.agent.rpc_loop(polling_manager\u003dmock.Mock())"},{"line_number":2986,"context_line":""},{"line_number":2987,"context_line":"            self.assertTrue(self.agent.setup_physical_bridges.called)"},{"line_number":2988,"context_line":"            self.assertTrue(self.agent.setup_integration_br.called)"},{"line_number":2989,"context_line":""},{"line_number":2990,"context_line":"    def test_scan_ports_failure(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_73e9651a","line":2987,"updated":"2016-04-05 09:03:56.000000000","message":"we should be checking the parameters passed to the method","commit_id":"8366c5ebc2e50180c1a3ff8246c84a1613071e46"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"3e50561608fa831917a1606329821444d34bba40","unresolved":false,"context_lines":[{"line_number":2984,"context_line":"            self.agent.state_rpc \u003d mock.Mock()"},{"line_number":2985,"context_line":"            self.agent.rpc_loop(polling_manager\u003dmock.Mock())"},{"line_number":2986,"context_line":""},{"line_number":2987,"context_line":"            self.assertTrue(self.agent.setup_physical_bridges.called)"},{"line_number":2988,"context_line":"            self.assertTrue(self.agent.setup_integration_br.called)"},{"line_number":2989,"context_line":""},{"line_number":2990,"context_line":"    def test_scan_ports_failure(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_5fc6e349","line":2987,"in_reply_to":"9a061dce_73e9651a","updated":"2016-04-05 09:32:28.000000000","message":"This check here is to make sure that the mock setup_physical_bridges mocks the right thing so that this test fails upon potential renaming setup_physical_bridges - to prevent the same situation as happened to reset_tunnel_br (see commit message, based on Carl Baldwin comment). Hence the parameters of this method do not actually matter. The test verifies what happens when scan_ports() fails, regardless of what agent does in other parts.\n\nActually, I\u0027ve found that the \"with\" context form does the same check while having nicer syntax, hence will replace the mock initializations with that one, removing the need for these assertions completely.","commit_id":"8366c5ebc2e50180c1a3ff8246c84a1613071e46"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8844dfc1049be0fa2ffe18a1ddaf1995852c41a1","unresolved":false,"context_lines":[{"line_number":2985,"context_line":"            self.agent.rpc_loop(polling_manager\u003dmock.Mock())"},{"line_number":2986,"context_line":""},{"line_number":2987,"context_line":"            self.assertTrue(self.agent.setup_physical_bridges.called)"},{"line_number":2988,"context_line":"            self.assertTrue(self.agent.setup_integration_br.called)"},{"line_number":2989,"context_line":""},{"line_number":2990,"context_line":"    def test_scan_ports_failure(self):"},{"line_number":2991,"context_line":"        self._test_scan_ports_failure(\u0027scan_ports\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_b3f3fd09","line":2988,"updated":"2016-04-05 09:03:56.000000000","message":"ditto","commit_id":"8366c5ebc2e50180c1a3ff8246c84a1613071e46"}]}