)]}'
{"neutron/agent/l3/agent.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"db62aed5fe50b1bee381dab4e07e8bf83e01c16a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import eventlet"},{"line_number":17,"context_line":"import netaddr"},{"line_number":18,"context_line":"from neutron_lib import constants as lib_const"},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_log import log as logging"},{"line_number":21,"context_line":"import oslo_messaging"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_3bab2020","line":18,"updated":"2016-04-24 04:02:27.000000000","message":"I would suggest to follow uniform naming convention. Some places I can find we have just imported this as \"constants\" instead of \"lib_const\"","commit_id":"4148a347b365ec2ff9b8f5255b100208e23efbc8"}],"neutron/agent/l3/dvr_edge_router.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"db62aed5fe50b1bee381dab4e07e8bf83e01c16a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from neutron_lib import constants as l3_constants"},{"line_number":16,"context_line":"from oslo_log import log as logging"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _LE"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_7ba59845","line":15,"updated":"2016-04-24 04:02:27.000000000","message":"ditto. I understand the changes would be more if we rename l3_constants to either constants or lib_const but it will help in better code maintenance.","commit_id":"4148a347b365ec2ff9b8f5255b100208e23efbc8"}],"neutron/agent/l3/dvr_local_router.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"db62aed5fe50b1bee381dab4e07e8bf83e01c16a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import collections"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import netaddr"},{"line_number":19,"context_line":"from neutron_lib import constants as l3_constants"},{"line_number":20,"context_line":"from oslo_log import log as logging"},{"line_number":21,"context_line":"from oslo_utils import excutils"},{"line_number":22,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_db62ec15","line":19,"updated":"2016-04-24 04:02:27.000000000","message":"ditto","commit_id":"4148a347b365ec2ff9b8f5255b100208e23efbc8"}],"neutron/agent/l3/ha_router.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"db62aed5fe50b1bee381dab4e07e8bf83e01c16a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import shutil"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import netaddr"},{"line_number":19,"context_line":"from neutron_lib import constants as n_consts"},{"line_number":20,"context_line":"from oslo_log import log as logging"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron._i18n import _LE"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_1b6d8404","line":19,"updated":"2016-04-24 04:02:27.000000000","message":"This is really confusing.. some places we are using \"n_consts\" for neutron constants and other places for neutron_lib constants :(","commit_id":"4148a347b365ec2ff9b8f5255b100208e23efbc8"}],"neutron/agent/linux/openvswitch_firewall/rules.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"db62aed5fe50b1bee381dab4e07e8bf83e01c16a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import netaddr"},{"line_number":17,"context_line":"from neutron_lib import constants as n_consts"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.agent import firewall"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_fb6fe8f9","line":17,"updated":"2016-04-24 04:02:27.000000000","message":"ditto","commit_id":"4148a347b365ec2ff9b8f5255b100208e23efbc8"}],"neutron/api/v2/attributes.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"db62aed5fe50b1bee381dab4e07e8bf83e01c16a","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import netaddr"},{"line_number":21,"context_line":"from neutron_lib import constants"},{"line_number":22,"context_line":"from neutron_lib import exceptions as n_exc"},{"line_number":23,"context_line":"from oslo_log import log as logging"},{"line_number":24,"context_line":"from oslo_utils import uuidutils"},{"line_number":25,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_7b53d839","line":22,"updated":"2016-04-24 04:02:27.000000000","message":"Better not to import neutron_lib exceptions as n_exe... as we are using this alias for neutron\u0027s exception instead of neutron\u0027s lib exception at some places.","commit_id":"4148a347b365ec2ff9b8f5255b100208e23efbc8"}],"neutron/common/constants.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"db62aed5fe50b1bee381dab4e07e8bf83e01c16a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"SORT_DIRECTION_ASC \u003d \u0027asc\u0027"},{"line_number":54,"context_line":"SORT_DIRECTION_DESC \u003d \u0027desc\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"ETHERTYPE_NAME_ARP \u003d \u0027arp\u0027"},{"line_number":57,"context_line":"ETHERTYPE_ARP \u003d 0x0806"},{"line_number":58,"context_line":"ETHERTYPE_IP \u003d 0x0800"},{"line_number":59,"context_line":"ETHERTYPE_IPV6 \u003d 0x86DD"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_5b253cc0","line":56,"updated":"2016-04-24 04:02:27.000000000","message":"How about moving L56-L59 to the neutron-lib as well?","commit_id":"4148a347b365ec2ff9b8f5255b100208e23efbc8"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f6cbd0b0ba81e10fe4d3fee0b2a53b7234692895","unresolved":false,"context_lines":[{"line_number":53,"context_line":"SORT_DIRECTION_ASC \u003d \u0027asc\u0027"},{"line_number":54,"context_line":"SORT_DIRECTION_DESC \u003d \u0027desc\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"ETHERTYPE_NAME_ARP \u003d \u0027arp\u0027"},{"line_number":57,"context_line":"ETHERTYPE_ARP \u003d 0x0806"},{"line_number":58,"context_line":"ETHERTYPE_IP \u003d 0x0800"},{"line_number":59,"context_line":"ETHERTYPE_IPV6 \u003d 0x86DD"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_48544f20","line":56,"in_reply_to":"1a122d0e_5b253cc0","updated":"2016-04-24 15:25:13.000000000","message":"Maybe, but not part of this change.","commit_id":"4148a347b365ec2ff9b8f5255b100208e23efbc8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"db62aed5fe50b1bee381dab4e07e8bf83e01c16a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# For backward-compatibility of security group rule API,"},{"line_number":63,"context_line":"# we keep the old value for IPv6 ICMP."},{"line_number":64,"context_line":"# It should be clean up in the future."},{"line_number":65,"context_line":"PROTO_NAME_IPV6_ICMP_LEGACY \u003d \u0027icmpv6\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"IP_PROTOCOL_NAME_ALIASES \u003d {"},{"line_number":68,"context_line":"    PROTO_NAME_IPV6_ICMP_LEGACY: lib_constants.PROTO_NAME_IPV6_ICMP}"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_1b3bc4ec","line":65,"updated":"2016-04-24 04:02:27.000000000","message":"we are not moving this out?","commit_id":"4148a347b365ec2ff9b8f5255b100208e23efbc8"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f6cbd0b0ba81e10fe4d3fee0b2a53b7234692895","unresolved":false,"context_lines":[{"line_number":62,"context_line":"# For backward-compatibility of security group rule API,"},{"line_number":63,"context_line":"# we keep the old value for IPv6 ICMP."},{"line_number":64,"context_line":"# It should be clean up in the future."},{"line_number":65,"context_line":"PROTO_NAME_IPV6_ICMP_LEGACY \u003d \u0027icmpv6\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"IP_PROTOCOL_NAME_ALIASES \u003d {"},{"line_number":68,"context_line":"    PROTO_NAME_IPV6_ICMP_LEGACY: lib_constants.PROTO_NAME_IPV6_ICMP}"}],"source_content_type":"text/x-python","patch_set":16,"id":"1a122d0e_a831a30d","line":65,"in_reply_to":"1a122d0e_1b3bc4ec","updated":"2016-04-24 15:25:13.000000000","message":"ditto","commit_id":"4148a347b365ec2ff9b8f5255b100208e23efbc8"}],"neutron/tests/etc/neutron.conf":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"2e8004d3de9f0cd13dccb64d1fc575b4162e7668","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ba0121b8_120d7290","updated":"2016-03-29 23:10:08.000000000","message":"I did not intend to include the changes to this file.","commit_id":"581d7908f31cecd99dd9e1b9389eaccd800fef49"}]}