)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/br_int.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"6368b2affa823e95efe5df2ea936c22b33c6d8bc","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        mac_addresses \u003d {netaddr.EUI(mac) for mac in mac_addresses}"},{"line_number":192,"context_line":"        flows \u003d self.dump_flows(constants.MAC_SPOOF_TABLE)"},{"line_number":193,"context_line":"        for flow in flows:"},{"line_number":194,"context_line":"            if flow.table_id !\u003d constants.MAC_SPOOF_TABLE:"},{"line_number":195,"context_line":"                continue"},{"line_number":196,"context_line":"            matches \u003d dict(flow.match.items())"},{"line_number":197,"context_line":"            if matches.get(\u0027in_port\u0027) !\u003d port:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_42b72c86","line":194,"updated":"2016-04-05 11:10:21.000000000","message":"is this check really needed? at line 192 we dump only the flows of the MAC_SPOOF_TABLE","commit_id":"69c974dc9cefa56f249524b436035b7033d1b849"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"c5e9aba9c8be12dae342328bfae8ac7c19b40c99","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        mac_addresses \u003d {netaddr.EUI(mac) for mac in mac_addresses}"},{"line_number":192,"context_line":"        flows \u003d self.dump_flows(constants.MAC_SPOOF_TABLE)"},{"line_number":193,"context_line":"        for flow in flows:"},{"line_number":194,"context_line":"            if flow.table_id !\u003d constants.MAC_SPOOF_TABLE:"},{"line_number":195,"context_line":"                continue"},{"line_number":196,"context_line":"            matches \u003d dict(flow.match.items())"},{"line_number":197,"context_line":"            if matches.get(\u0027in_port\u0027) !\u003d port:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_6fbb1528","line":194,"in_reply_to":"9a061dce_42b72c86","updated":"2016-04-05 18:33:06.000000000","message":"nope. Now I don\u0027t remember why I had added that... :)","commit_id":"69c974dc9cefa56f249524b436035b7033d1b849"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"2d34a9a732581a15f3c1f9d1b3d165f4867c148b","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        return set(failed_devices)"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"    @staticmethod"},{"line_number":883,"context_line":"    def setup_arp_spoofing_protection(bridge, vif, port_details):"},{"line_number":884,"context_line":"        if not port_details.get(\u0027port_security_enabled\u0027, True):"},{"line_number":885,"context_line":"            LOG.info(_LI(\"Skipping ARP spoofing rules for port \u0027%s\u0027 because \""},{"line_number":886,"context_line":"                         \"it has port security disabled\"), vif.port_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_b4163eef","line":883,"updated":"2016-04-05 11:32:05.000000000","message":"nit: This is now setup_arp_and_mac_spoofing_protection,\n\nbut nothing to hold the patch.","commit_id":"69c974dc9cefa56f249524b436035b7033d1b849"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5dd05d1adcc8f7e1588662a381b7fa3021c265ce","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        return set(failed_devices)"},{"line_number":881,"context_line":""},{"line_number":882,"context_line":"    @staticmethod"},{"line_number":883,"context_line":"    def setup_arp_spoofing_protection(bridge, vif, port_details):"},{"line_number":884,"context_line":"        if not port_details.get(\u0027port_security_enabled\u0027, True):"},{"line_number":885,"context_line":"            LOG.info(_LI(\"Skipping ARP spoofing rules for port \u0027%s\u0027 because \""},{"line_number":886,"context_line":"                         \"it has port security disabled\"), vif.port_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_9bd18f5a","line":883,"in_reply_to":"9a061dce_b4163eef","updated":"2016-04-05 17:29:42.000000000","message":"Yeah, we can rename after this. Just tried to keep it pretty small since it needs to be back-ported all of the way to kilo","commit_id":"69c974dc9cefa56f249524b436035b7033d1b849"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"2d34a9a732581a15f3c1f9d1b3d165f4867c148b","unresolved":false,"context_lines":[{"line_number":892,"context_line":"            LOG.debug(\"Skipping ARP spoofing rules for network owned port \""},{"line_number":893,"context_line":"                      \"\u0027%s\u0027.\", vif.port_name)"},{"line_number":894,"context_line":"            bridge.delete_arp_spoofing_protection(port\u003dvif.ofport)"},{"line_number":895,"context_line":"            bridge.set_allowed_macs_for_port(port\u003dvif.ofport, allow_all\u003dTrue)"},{"line_number":896,"context_line":"            return"},{"line_number":897,"context_line":"        # clear any previous flows related to this port in our ARP table"},{"line_number":898,"context_line":"        bridge.delete_arp_spoofing_allow_rules(port\u003dvif.ofport)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_54b522ec","line":895,"updated":"2016-04-05 11:32:05.000000000","message":"question: Is this completely necessary for the fix?\n\nI\u0027m trying to remember how keepalived handles the mac addresses on the ha- router ports. I guess it\u0027s only broadcast/multicast destination and normal source, right?.","commit_id":"69c974dc9cefa56f249524b436035b7033d1b849"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"fe00cc85f98f765417b8cdad38fe52516a87d25e","unresolved":false,"context_lines":[{"line_number":892,"context_line":"            LOG.debug(\"Skipping ARP spoofing rules for network owned port \""},{"line_number":893,"context_line":"                      \"\u0027%s\u0027.\", vif.port_name)"},{"line_number":894,"context_line":"            bridge.delete_arp_spoofing_protection(port\u003dvif.ofport)"},{"line_number":895,"context_line":"            bridge.set_allowed_macs_for_port(port\u003dvif.ofport, allow_all\u003dTrue)"},{"line_number":896,"context_line":"            return"},{"line_number":897,"context_line":"        # clear any previous flows related to this port in our ARP table"},{"line_number":898,"context_line":"        bridge.delete_arp_spoofing_allow_rules(port\u003dvif.ofport)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_4089a925","line":895,"in_reply_to":"9a061dce_1b98dfbf","updated":"2016-04-06 08:46:44.000000000","message":"ahh, allow_all!. yikess!!","commit_id":"69c974dc9cefa56f249524b436035b7033d1b849"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5dd05d1adcc8f7e1588662a381b7fa3021c265ce","unresolved":false,"context_lines":[{"line_number":892,"context_line":"            LOG.debug(\"Skipping ARP spoofing rules for network owned port \""},{"line_number":893,"context_line":"                      \"\u0027%s\u0027.\", vif.port_name)"},{"line_number":894,"context_line":"            bridge.delete_arp_spoofing_protection(port\u003dvif.ofport)"},{"line_number":895,"context_line":"            bridge.set_allowed_macs_for_port(port\u003dvif.ofport, allow_all\u003dTrue)"},{"line_number":896,"context_line":"            return"},{"line_number":897,"context_line":"        # clear any previous flows related to this port in our ARP table"},{"line_number":898,"context_line":"        bridge.delete_arp_spoofing_allow_rules(port\u003dvif.ofport)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_1b98dfbf","line":895,"in_reply_to":"9a061dce_54b522ec","updated":"2016-04-05 17:29:42.000000000","message":"This call clears any mac spoofing rules that may have been previously setup.","commit_id":"69c974dc9cefa56f249524b436035b7033d1b849"}]}
