)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a9839c50c878a9a43656de9b5cc3acd768479169","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support provider:flooding_vtep in neutron-server"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the support for configuring flooding vtep"},{"line_number":10,"context_line":"in neutron server. This configuration is only avaiable"},{"line_number":11,"context_line":"for VXLAN network"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_cc575324","line":10,"range":{"start_line":10,"start_character":46,"end_line":10,"end_character":54},"updated":"2016-04-01 08:23:17.000000000","message":"typo: \"available\"","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d13b8b4b8e5412cee2558b95ed42b3f0609fbe17","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in neutron server. This configuration is only available"},{"line_number":11,"context_line":"for VXLAN network"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7bc541f307f6a6e8d7e7157633fdf9c43f02919a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a061dce_143f3c26","line":13,"updated":"2016-04-09 05:57:29.000000000","message":"DocImpact flag needs a change description. Plz add one.","commit_id":"d7aa525419ad034e18b7e3543681f4ec56b61c6f"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"d299741abe36619dfbb386f8ea803a3f629699ae","unresolved":false,"context_lines":[{"line_number":10,"context_line":"in neutron server. This configuration is only available"},{"line_number":11,"context_line":"for VXLAN network"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7bc541f307f6a6e8d7e7157633fdf9c43f02919a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a061dce_5ff1cdcc","line":13,"in_reply_to":"9a061dce_143f3c26","updated":"2016-04-10 02:21:51.000000000","message":"Will add in next patch, thanks.","commit_id":"d7aa525419ad034e18b7e3543681f4ec56b61c6f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"13d9d9431d0f48ebe2214cd0cd8b803d8cd0671d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Na \u003cnazhu@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-09 23:23:29 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support provider:flooding_vtep in neutron-server"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the support for configuring flooding vtep"},{"line_number":10,"context_line":"in neutron server. This configuration is only available"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a061dce_1300e9a9","line":7,"updated":"2016-04-10 07:37:05.000000000","message":"Pleas repfix this with ML2","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"ab2050137c48426bfdad220614cebfecae765b65","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Na \u003cnazhu@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-09 23:23:29 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Support provider:flooding_vtep in neutron-server"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the support for configuring flooding vtep"},{"line_number":10,"context_line":"in neutron server. This configuration is only available"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a1b2928_e4cb181d","line":7,"in_reply_to":"9a061dce_1300e9a9","updated":"2016-04-11 10:56:06.000000000","message":"ok, thanks.","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"}],"neutron/api/v2/attributes.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"07ef6a761b5114813b233d449bdf787c24ea739e","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    return msg"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"def _validate_ip_unicast_address(data, valid_values\u003dNone):"},{"line_number":248,"context_line":"    msg \u003d _validate_ip_address(data)"},{"line_number":249,"context_line":"    if msg:"},{"line_number":250,"context_line":"        return msg"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_55ec9bf2","line":247,"range":{"start_line":247,"start_character":4,"end_line":247,"end_character":32},"updated":"2016-04-20 06:59:46.000000000","message":"I think this function is defined at [1], is there something wrong? or I missed something?\n\n[1] https://review.openstack.org/#/c/299191/5/neutron/extensions/flooding_vteps.py","commit_id":"c7ba130d00beae47bc54de51c0f4d378892bc996"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"b61ac9c0a0d4e9aca8652e195219be2dafcc26d3","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    return msg"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"def _validate_ip_unicast_address(data, valid_values\u003dNone):"},{"line_number":248,"context_line":"    msg \u003d _validate_ip_address(data)"},{"line_number":249,"context_line":"    if msg:"},{"line_number":250,"context_line":"        return msg"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_62247a5f","line":247,"range":{"start_line":247,"start_character":4,"end_line":247,"end_character":32},"in_reply_to":"1a122d0e_55ec9bf2","updated":"2016-04-20 13:08:07.000000000","message":"you are right, this should be removed.","commit_id":"c7ba130d00beae47bc54de51c0f4d378892bc996"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"b61ac9c0a0d4e9aca8652e195219be2dafcc26d3","unresolved":false,"context_lines":[{"line_number":636,"context_line":"              \u0027type:ip_address\u0027: _validate_ip_address,"},{"line_number":637,"context_line":"              \u0027type:ip_address_or_none\u0027: _validate_ip_address_or_none,"},{"line_number":638,"context_line":"              \u0027type:ip_unicast_address_list\u0027:"},{"line_number":639,"context_line":"              _validate_ip_unicast_address_list,"},{"line_number":640,"context_line":"              \u0027type:ip_pools\u0027: _validate_ip_pools,"},{"line_number":641,"context_line":"              \u0027type:mac_address\u0027: _validate_mac_address,"},{"line_number":642,"context_line":"              \u0027type:mac_address_or_none\u0027: _validate_mac_address_or_none,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_02dae64b","line":639,"range":{"start_line":639,"start_character":14,"end_line":639,"end_character":47},"updated":"2016-04-20 13:08:07.000000000","message":"This need to be removed.","commit_id":"c7ba130d00beae47bc54de51c0f4d378892bc996"}],"neutron/db/flooding_vteps_db.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"07ef6a761b5114813b233d449bdf787c24ea739e","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def create_provider_flooding_vteps(session, segment):"},{"line_number":40,"context_line":"    flooding_vteps \u003d segment.get(FLOODING_VTEP)"},{"line_number":41,"context_line":"    if flooding_vteps is None:"},{"line_number":42,"context_line":"        return True"},{"line_number":43,"context_line":"    segment_id \u003d segment[\u0027id\u0027]"},{"line_number":44,"context_line":"    with session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_19bc1ddb","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":29},"updated":"2016-04-20 06:59:46.000000000","message":"nit: Could be \"if not flooding_vteps\"","commit_id":"c7ba130d00beae47bc54de51c0f4d378892bc996"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"b61ac9c0a0d4e9aca8652e195219be2dafcc26d3","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"def create_provider_flooding_vteps(session, segment):"},{"line_number":40,"context_line":"    flooding_vteps \u003d segment.get(FLOODING_VTEP)"},{"line_number":41,"context_line":"    if flooding_vteps is None:"},{"line_number":42,"context_line":"        return True"},{"line_number":43,"context_line":"    segment_id \u003d segment[\u0027id\u0027]"},{"line_number":44,"context_line":"    with session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_02a8268c","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":29},"in_reply_to":"1a122d0e_19bc1ddb","updated":"2016-04-20 13:08:07.000000000","message":"Thanks, will update in next patch.","commit_id":"c7ba130d00beae47bc54de51c0f4d378892bc996"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"07ef6a761b5114813b233d449bdf787c24ea739e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":45,"context_line":"        for vtep in flooding_vteps:"},{"line_number":46,"context_line":"            # use default port number if no dstport in flooding vtep"},{"line_number":47,"context_line":"            if \u0027dstport\u0027 not in vtep:"},{"line_number":48,"context_line":"                vtep[\u0027dstport\u0027] \u003d VXLAN_PORT_DEFAULT"},{"line_number":49,"context_line":"            flooding_vtep \u003d NetworkSegmentFloodingVTEP("},{"line_number":50,"context_line":"                        segment_id\u003dsegment_id,"},{"line_number":51,"context_line":"                        remote_vtep_ip\u003dvtep[\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_b589af28","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":52},"updated":"2016-04-20 06:59:46.000000000","message":"nit: this could be vtep[\u0027dstport\u0027] \u003d vtep.get(\u0027dstport\u0027, VXLAN_PORT_DEFAULT)","commit_id":"c7ba130d00beae47bc54de51c0f4d378892bc996"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"b61ac9c0a0d4e9aca8652e195219be2dafcc26d3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":45,"context_line":"        for vtep in flooding_vteps:"},{"line_number":46,"context_line":"            # use default port number if no dstport in flooding vtep"},{"line_number":47,"context_line":"            if \u0027dstport\u0027 not in vtep:"},{"line_number":48,"context_line":"                vtep[\u0027dstport\u0027] \u003d VXLAN_PORT_DEFAULT"},{"line_number":49,"context_line":"            flooding_vtep \u003d NetworkSegmentFloodingVTEP("},{"line_number":50,"context_line":"                        segment_id\u003dsegment_id,"},{"line_number":51,"context_line":"                        remote_vtep_ip\u003dvtep[\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_c29aae6d","line":48,"range":{"start_line":47,"start_character":0,"end_line":48,"end_character":52},"in_reply_to":"1a122d0e_b589af28","updated":"2016-04-20 13:08:07.000000000","message":"Thanks, will update in next patch.","commit_id":"c7ba130d00beae47bc54de51c0f4d378892bc996"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"07ef6a761b5114813b233d449bdf787c24ea739e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                        dst_port\u003dvtep[\u0027dstport\u0027])"},{"line_number":53,"context_line":"            session.add(flooding_vtep)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    return True"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def extend_provider_flooding_vteps(seg_res, segment_db):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_79943142","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":15},"updated":"2016-04-20 06:59:46.000000000","message":"What is the point of this return?","commit_id":"c7ba130d00beae47bc54de51c0f4d378892bc996"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"b61ac9c0a0d4e9aca8652e195219be2dafcc26d3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                        dst_port\u003dvtep[\u0027dstport\u0027])"},{"line_number":53,"context_line":"            session.add(flooding_vtep)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    return True"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"def extend_provider_flooding_vteps(seg_res, segment_db):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_0296663e","line":55,"range":{"start_line":55,"start_character":0,"end_line":55,"end_character":15},"in_reply_to":"1a122d0e_79943142","updated":"2016-04-20 13:08:07.000000000","message":"No point.","commit_id":"c7ba130d00beae47bc54de51c0f4d378892bc996"}],"neutron/db/migration/alembic_migrations/versions/newton/expand/41066cb886ea_add_vtep_ip_to_segment.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d13b8b4b8e5412cee2558b95ed42b3f0609fbe17","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.create_table(\u0027segment_flooding_vtep\u0027,"},{"line_number":34,"context_line":"                   sa.Column(\u0027remote_vtep_ip\u0027,"},{"line_number":35,"context_line":"                       sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":36,"context_line":"                   sa.Column(\u0027segment_id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_f4fe0837","line":33,"updated":"2016-04-09 05:57:29.000000000","message":"I am little confused with the DB model.. AFAIU, we have to save remote_vtep_ip and then link it to a networksegment data model (as we can have multiple vteps for one networksegment). If this is the case, then where we are exactly saving the remote_vtep information? \n\nCan\u0027t we do like below:\n\nop.create_table(\n        \u0027segment_vteps\u0027,\n        sa.Column(\u0027id\u0027, sa.String(length\u003d36),\n                  nullable\u003dFalse),\n        sa.Column(\u0027remote_vtep_ip\u0027,\n                   sa.String(length\u003d64), nullable\u003dFalse),\n        sa.PrimaryKeyConstraint(\u0027id\u0027)\n    )\n\nop.create_table(\n        \u0027segment_x_vtep_bindings\u0027,\n        sa.Column(\u0027segment_vtep_id\u0027,\n                  sa.String(length\u003d36),\n                  nullable\u003dFalse),\n        sa.Column(\u0027segment_id\u0027,\n                  sa.String(length\u003d36),\n                  nullable\u003dTrue),\n        sa.ForeignKeyConstraint([\u0027segment_vtep_id\u0027],\n                                [\u0027segment_vteps.id\u0027],\n                                ondelete\u003d\u0027CASCADE\u0027),\n        sa.ForeignKeyConstraint([\u0027segment_id\u0027],\n                                [\u0027networksegments.id\u0027],\n                                ondelete\u003d\u0027CASCADE\u0027),\n        sa.PrimaryKeyConstraint(\u0027segment_vtep_id\u0027, \u0027segment_id\u0027)\n    )","commit_id":"d7aa525419ad034e18b7e3543681f4ec56b61c6f"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"d299741abe36619dfbb386f8ea803a3f629699ae","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.create_table(\u0027segment_flooding_vtep\u0027,"},{"line_number":34,"context_line":"                   sa.Column(\u0027remote_vtep_ip\u0027,"},{"line_number":35,"context_line":"                       sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":36,"context_line":"                   sa.Column(\u0027segment_id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_bd82acc6","line":33,"in_reply_to":"9a061dce_f4fe0837","updated":"2016-04-10 02:21:51.000000000","message":"The remote vtep is saved in this table, one network can have multiple remote vtep.","commit_id":"d7aa525419ad034e18b7e3543681f4ec56b61c6f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d13b8b4b8e5412cee2558b95ed42b3f0609fbe17","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                   sa.Column(\u0027segment_id\u0027,"},{"line_number":37,"context_line":"                       sa.String(length\u003d36),"},{"line_number":38,"context_line":"                       nullable\u003dFalse),"},{"line_number":39,"context_line":"                   sa.ForeignKeyConstraint([\u0027segment_id\u0027],"},{"line_number":40,"context_line":"                       [\u0027networksegments.id\u0027],"},{"line_number":41,"context_line":"                       ondelete\u003d\u0027CASCADE\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_d4d024cc","line":39,"updated":"2016-04-09 05:57:29.000000000","message":"Add sa.PrimaryKeyConstraint(\u0027segment_id\u0027)","commit_id":"d7aa525419ad034e18b7e3543681f4ec56b61c6f"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"d299741abe36619dfbb386f8ea803a3f629699ae","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                   sa.Column(\u0027segment_id\u0027,"},{"line_number":37,"context_line":"                       sa.String(length\u003d36),"},{"line_number":38,"context_line":"                       nullable\u003dFalse),"},{"line_number":39,"context_line":"                   sa.ForeignKeyConstraint([\u0027segment_id\u0027],"},{"line_number":40,"context_line":"                       [\u0027networksegments.id\u0027],"},{"line_number":41,"context_line":"                       ondelete\u003d\u0027CASCADE\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_5d7d50e6","line":39,"in_reply_to":"9a061dce_d4d024cc","updated":"2016-04-10 02:21:51.000000000","message":"OK, i think should add \nsa.PrimaryKeyConstraint(\u0027segment_id\u0027,\u0027remote_vtep_ip\u0027)","commit_id":"d7aa525419ad034e18b7e3543681f4ec56b61c6f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"13d9d9431d0f48ebe2214cd0cd8b803d8cd0671d","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.create_table(\u0027segment_flooding_vtep\u0027,"},{"line_number":34,"context_line":"                   sa.Column(\u0027remote_vtep_ip\u0027,"},{"line_number":35,"context_line":"                       sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":36,"context_line":"                   sa.Column(\u0027segment_id\u0027,"},{"line_number":37,"context_line":"                       sa.String(length\u003d36),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_732b2534","line":34,"updated":"2016-04-10 07:37:05.000000000","message":"indentation is dodgy","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"ab2050137c48426bfdad220614cebfecae765b65","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.create_table(\u0027segment_flooding_vtep\u0027,"},{"line_number":34,"context_line":"                   sa.Column(\u0027remote_vtep_ip\u0027,"},{"line_number":35,"context_line":"                       sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":36,"context_line":"                   sa.Column(\u0027segment_id\u0027,"},{"line_number":37,"context_line":"                       sa.String(length\u003d36),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a1b2928_24ed108c","line":34,"in_reply_to":"9a061dce_732b2534","updated":"2016-04-11 10:56:06.000000000","message":"ok, thanks.","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"}],"neutron/db/segments_db.py":[{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"e04b6d2aee271888bfa02f3d09152c6d19405153","unresolved":false,"context_lines":[{"line_number":32,"context_line":"class SegmentFloodingVTEP(model_base.BASEV2):"},{"line_number":33,"context_line":"    \"\"\"Represent VXLAN network remote VTEP ip addresses"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    segment_id \u003d sa.Column(sa.String(36),"},{"line_number":38,"context_line":"                        sa.ForeignKey(\u0027networksegments.id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_b81e9c09","line":35,"range":{"start_line":35,"start_character":4,"end_line":35,"end_character":7},"updated":"2016-04-01 05:54:40.000000000","message":"should add line \"__tablename__ \u003d \u0027segment_flooding_vtep\u0027\" here.","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"e04b6d2aee271888bfa02f3d09152c6d19405153","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    physical_network \u003d sa.Column(sa.String(64))"},{"line_number":59,"context_line":"    segmentation_id \u003d sa.Column(sa.Integer)"},{"line_number":60,"context_line":"    flooding_vteps \u003d orm.relationship(SegmentFloodingVTEP,"},{"line_number":61,"context_line":"                                      backref\u003d\u0027segment_flooding_vteps\u0027,"},{"line_number":62,"context_line":"                                      cascade\u003d\u0027all, delete, delete-orphan\u0027,"},{"line_number":63,"context_line":"                                      lazy\u003d\u0027joined\u0027)"},{"line_number":64,"context_line":"    is_dynamic \u003d sa.Column(sa.Boolean, default\u003dFalse, nullable\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_58d66028","line":61,"range":{"start_line":61,"start_character":47,"end_line":61,"end_character":69},"updated":"2016-04-01 05:54:40.000000000","message":"should remove \u0027s\u0027.","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d13b8b4b8e5412cee2558b95ed42b3f0609fbe17","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class SegmentFloodingVTEP(model_base.BASEV2):"},{"line_number":33,"context_line":"    \"\"\"Represent VXLAN network remote VTEP ip addresses"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_f469e826","line":32,"updated":"2016-04-09 05:57:29.000000000","message":"I believe we are not flooding the VTEP, Can we rename to NetworkRemoteVtep or something?","commit_id":"d7aa525419ad034e18b7e3543681f4ec56b61c6f"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"d299741abe36619dfbb386f8ea803a3f629699ae","unresolved":false,"context_lines":[{"line_number":29,"context_line":"\"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class SegmentFloodingVTEP(model_base.BASEV2):"},{"line_number":33,"context_line":"    \"\"\"Represent VXLAN network remote VTEP ip addresses"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_fd25440a","line":32,"in_reply_to":"9a061dce_f469e826","updated":"2016-04-10 02:21:51.000000000","message":"Thanks your comment, let keep this name first, it is the same with Arista commands.","commit_id":"d7aa525419ad034e18b7e3543681f4ec56b61c6f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d13b8b4b8e5412cee2558b95ed42b3f0609fbe17","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\"Represent VXLAN network remote VTEP ip addresses"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":"    __tablename__ \u003d \u0027segment_flooding_vtep\u0027"},{"line_number":37,"context_line":"    segment_id \u003d sa.Column(sa.String(36),"},{"line_number":38,"context_line":"                        sa.ForeignKey(\u0027networksegments.id\u0027,"},{"line_number":39,"context_line":"                            ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_d482e4c7","line":36,"updated":"2016-04-09 05:57:29.000000000","message":"__tablename__ un-necessary. plz remove..","commit_id":"d7aa525419ad034e18b7e3543681f4ec56b61c6f"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"d299741abe36619dfbb386f8ea803a3f629699ae","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    \"\"\"Represent VXLAN network remote VTEP ip addresses"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":"    __tablename__ \u003d \u0027segment_flooding_vtep\u0027"},{"line_number":37,"context_line":"    segment_id \u003d sa.Column(sa.String(36),"},{"line_number":38,"context_line":"                        sa.ForeignKey(\u0027networksegments.id\u0027,"},{"line_number":39,"context_line":"                            ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_9d39a844","line":36,"in_reply_to":"9a061dce_d482e4c7","updated":"2016-04-10 02:21:51.000000000","message":"I think it is necessary, if not set __tablename__, the default tablename \"segmentfloodingvteps\" is used, but i want the table name to be \"segment_flooding_vtep\".","commit_id":"d7aa525419ad034e18b7e3543681f4ec56b61c6f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"13d9d9431d0f48ebe2214cd0cd8b803d8cd0671d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":"    __tablename__ \u003d \u0027segment_flooding_vtep\u0027"},{"line_number":37,"context_line":"    segment_id \u003d sa.Column(sa.String(36),"},{"line_number":38,"context_line":"                        sa.ForeignKey(\u0027networksegments.id\u0027,"},{"line_number":39,"context_line":"                            ondelete\u003d\"CASCADE\"),"},{"line_number":40,"context_line":"                        nullable\u003dFalse,"},{"line_number":41,"context_line":"                        primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_5330a19e","line":38,"updated":"2016-04-10 07:37:05.000000000","message":"please fix indentation","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"ab2050137c48426bfdad220614cebfecae765b65","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":"    __tablename__ \u003d \u0027segment_flooding_vtep\u0027"},{"line_number":37,"context_line":"    segment_id \u003d sa.Column(sa.String(36),"},{"line_number":38,"context_line":"                        sa.ForeignKey(\u0027networksegments.id\u0027,"},{"line_number":39,"context_line":"                            ondelete\u003d\"CASCADE\"),"},{"line_number":40,"context_line":"                        nullable\u003dFalse,"},{"line_number":41,"context_line":"                        primary_key\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a1b2928_ac62acd6","line":38,"in_reply_to":"9a061dce_5330a19e","updated":"2016-04-11 10:56:06.000000000","message":"ok,thanks.","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"07ef6a761b5114813b233d449bdf787c24ea739e","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    is_dynamic \u003d sa.Column(sa.Boolean, default\u003dFalse, nullable\u003dFalse,"},{"line_number":66,"context_line":"                           server_default\u003dsa.sql.false())"},{"line_number":67,"context_line":"    segment_index \u003d sa.Column(sa.Integer, nullable\u003dFalse, server_default\u003d\u00270\u0027)"},{"line_number":68,"context_line":"    flooding_vteps \u003d orm.relationship(vteps_db.NetworkSegmentFloodingVTEP,"},{"line_number":69,"context_line":"                                      backref\u003d\"provider_flooding_vtep\","},{"line_number":70,"context_line":"                                      lazy\u003d\"joined\", cascade\u003d\"delete\")"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"NETWORK_TYPE \u003d NetworkSegment.network_type.name"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_9922ed50","line":70,"range":{"start_line":68,"start_character":0,"end_line":70,"end_character":70},"updated":"2016-04-20 06:59:46.000000000","message":"I think this line duplicated with line 61~64","commit_id":"c7ba130d00beae47bc54de51c0f4d378892bc996"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"b61ac9c0a0d4e9aca8652e195219be2dafcc26d3","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    is_dynamic \u003d sa.Column(sa.Boolean, default\u003dFalse, nullable\u003dFalse,"},{"line_number":66,"context_line":"                           server_default\u003dsa.sql.false())"},{"line_number":67,"context_line":"    segment_index \u003d sa.Column(sa.Integer, nullable\u003dFalse, server_default\u003d\u00270\u0027)"},{"line_number":68,"context_line":"    flooding_vteps \u003d orm.relationship(vteps_db.NetworkSegmentFloodingVTEP,"},{"line_number":69,"context_line":"                                      backref\u003d\"provider_flooding_vtep\","},{"line_number":70,"context_line":"                                      lazy\u003d\"joined\", cascade\u003d\"delete\")"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"NETWORK_TYPE \u003d NetworkSegment.network_type.name"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_02e4a6de","line":70,"range":{"start_line":68,"start_character":0,"end_line":70,"end_character":70},"in_reply_to":"1a122d0e_9922ed50","updated":"2016-04-20 13:08:07.000000000","message":"yes, sorry for my careless.","commit_id":"c7ba130d00beae47bc54de51c0f4d378892bc996"}],"neutron/extensions/multiprovidernet.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a9839c50c878a9a43656de9b5cc3acd768479169","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        flooding_vtep \u003d segment.get(pnet.FLOODING_VTEP)"},{"line_number":46,"context_line":"        if flooding_vtep:"},{"line_number":47,"context_line":"            msg \u003d attr._validate_ip_unicast_address_list("},{"line_number":48,"context_line":"                            flooding_vtep)"},{"line_number":49,"context_line":"            if msg:"},{"line_number":50,"context_line":"                raise webob.exc.HTTPBadRequest(msg)"},{"line_number":51,"context_line":"        segment.setdefault(pnet.FLOODING_VTEP,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_2fa7e10b","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":42},"updated":"2016-04-01 08:23:17.000000000","message":"nit: this could fit in one line","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"96fc8cdaf99928420ba5f2a023cc54caef9e9a88","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        flooding_vtep \u003d segment.get(pnet.FLOODING_VTEP)"},{"line_number":46,"context_line":"        if flooding_vtep:"},{"line_number":47,"context_line":"            msg \u003d attr._validate_ip_unicast_address_list("},{"line_number":48,"context_line":"                            flooding_vtep)"},{"line_number":49,"context_line":"            if msg:"},{"line_number":50,"context_line":"                raise webob.exc.HTTPBadRequest(msg)"},{"line_number":51,"context_line":"        segment.setdefault(pnet.FLOODING_VTEP,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_ac577424","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":42},"in_reply_to":"ba0121b8_2fa7e10b","updated":"2016-04-01 12:57:54.000000000","message":"ok, thanks.","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a9839c50c878a9a43656de9b5cc3acd768479169","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                            flooding_vtep)"},{"line_number":49,"context_line":"            if msg:"},{"line_number":50,"context_line":"                raise webob.exc.HTTPBadRequest(msg)"},{"line_number":51,"context_line":"        segment.setdefault(pnet.FLOODING_VTEP,"},{"line_number":52,"context_line":"                attr.ATTR_NOT_SPECIFIED)"},{"line_number":53,"context_line":"        if len(segment.keys()) !\u003d 4:"},{"line_number":54,"context_line":"            msg \u003d (_(\"Unrecognized attribute(s) \u0027%s\u0027\") %"},{"line_number":55,"context_line":"                   \u0027, \u0027.join(set(segment.keys()) -"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_ecc177e5","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":40},"updated":"2016-04-01 08:23:17.000000000","message":"nit: this could fit in one line","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"96fc8cdaf99928420ba5f2a023cc54caef9e9a88","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                            flooding_vtep)"},{"line_number":49,"context_line":"            if msg:"},{"line_number":50,"context_line":"                raise webob.exc.HTTPBadRequest(msg)"},{"line_number":51,"context_line":"        segment.setdefault(pnet.FLOODING_VTEP,"},{"line_number":52,"context_line":"                attr.ATTR_NOT_SPECIFIED)"},{"line_number":53,"context_line":"        if len(segment.keys()) !\u003d 4:"},{"line_number":54,"context_line":"            msg \u003d (_(\"Unrecognized attribute(s) \u0027%s\u0027\") %"},{"line_number":55,"context_line":"                   \u0027, \u0027.join(set(segment.keys()) -"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_0c3dc0dc","line":52,"range":{"start_line":51,"start_character":0,"end_line":52,"end_character":40},"in_reply_to":"ba0121b8_ecc177e5","updated":"2016-04-01 12:57:54.000000000","message":"ok, thanks.","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a9839c50c878a9a43656de9b5cc3acd768479169","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                raise webob.exc.HTTPBadRequest(msg)"},{"line_number":51,"context_line":"        segment.setdefault(pnet.FLOODING_VTEP,"},{"line_number":52,"context_line":"                attr.ATTR_NOT_SPECIFIED)"},{"line_number":53,"context_line":"        if len(segment.keys()) !\u003d 4:"},{"line_number":54,"context_line":"            msg \u003d (_(\"Unrecognized attribute(s) \u0027%s\u0027\") %"},{"line_number":55,"context_line":"                   \u0027, \u0027.join(set(segment.keys()) -"},{"line_number":56,"context_line":"                             set([pnet.NETWORK_TYPE, pnet.PHYSICAL_NETWORK,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_ef796994","line":53,"range":{"start_line":53,"start_character":34,"end_line":53,"end_character":35},"updated":"2016-04-01 08:23:17.000000000","message":"Can we change this number to len(pnet.ATTRIBUTES) ?","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"96fc8cdaf99928420ba5f2a023cc54caef9e9a88","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                raise webob.exc.HTTPBadRequest(msg)"},{"line_number":51,"context_line":"        segment.setdefault(pnet.FLOODING_VTEP,"},{"line_number":52,"context_line":"                attr.ATTR_NOT_SPECIFIED)"},{"line_number":53,"context_line":"        if len(segment.keys()) !\u003d 4:"},{"line_number":54,"context_line":"            msg \u003d (_(\"Unrecognized attribute(s) \u0027%s\u0027\") %"},{"line_number":55,"context_line":"                   \u0027, \u0027.join(set(segment.keys()) -"},{"line_number":56,"context_line":"                             set([pnet.NETWORK_TYPE, pnet.PHYSICAL_NETWORK,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_e7522512","line":53,"range":{"start_line":53,"start_character":34,"end_line":53,"end_character":35},"in_reply_to":"ba0121b8_ef796994","updated":"2016-04-01 12:57:54.000000000","message":"ok, thanks.","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a9839c50c878a9a43656de9b5cc3acd768479169","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        if len(segment.keys()) !\u003d 4:"},{"line_number":54,"context_line":"            msg \u003d (_(\"Unrecognized attribute(s) \u0027%s\u0027\") %"},{"line_number":55,"context_line":"                   \u0027, \u0027.join(set(segment.keys()) -"},{"line_number":56,"context_line":"                             set([pnet.NETWORK_TYPE, pnet.PHYSICAL_NETWORK,"},{"line_number":57,"context_line":"                                pnet.SEGMENTATION_ID,"},{"line_number":58,"context_line":"                                pnet.FLOODING_VTEP])))"},{"line_number":59,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_8f442d4a","line":58,"range":{"start_line":56,"start_character":29,"end_line":58,"end_character":52},"updated":"2016-04-01 08:23:17.000000000","message":"this could be pnet.ATTRIBUTES","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"96fc8cdaf99928420ba5f2a023cc54caef9e9a88","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        if len(segment.keys()) !\u003d 4:"},{"line_number":54,"context_line":"            msg \u003d (_(\"Unrecognized attribute(s) \u0027%s\u0027\") %"},{"line_number":55,"context_line":"                   \u0027, \u0027.join(set(segment.keys()) -"},{"line_number":56,"context_line":"                             set([pnet.NETWORK_TYPE, pnet.PHYSICAL_NETWORK,"},{"line_number":57,"context_line":"                                pnet.SEGMENTATION_ID,"},{"line_number":58,"context_line":"                                pnet.FLOODING_VTEP])))"},{"line_number":59,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_2759bd35","line":58,"range":{"start_line":56,"start_character":29,"end_line":58,"end_character":52},"in_reply_to":"ba0121b8_8f442d4a","updated":"2016-04-01 12:57:54.000000000","message":"ok, thanks.","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"}],"neutron/extensions/providernet.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4aa44e8bed3cb32d1ced385d8a8cf09a8d27224c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                          \u0027enforce_policy\u0027: True,"},{"line_number":49,"context_line":"                          \u0027default\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":50,"context_line":"                          \u0027is_visible\u0027: True},"},{"line_number":51,"context_line":"        FLOODING_VTEP: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":52,"context_line":"                        \u0027validate\u0027: {\u0027type:ip_unicast_address_list\u0027:"},{"line_number":53,"context_line":"                                    None},"},{"line_number":54,"context_line":"                        \u0027enforce_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_89bfbfcf","line":51,"updated":"2016-04-17 07:38:33.000000000","message":"this is an API change so please add a release note","commit_id":"25c7090f294fedf8a97de50b7faa3133c9ec23ea"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4aa44e8bed3cb32d1ced385d8a8cf09a8d27224c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                          \u0027default\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":50,"context_line":"                          \u0027is_visible\u0027: True},"},{"line_number":51,"context_line":"        FLOODING_VTEP: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":52,"context_line":"                        \u0027validate\u0027: {\u0027type:ip_unicast_address_list\u0027:"},{"line_number":53,"context_line":"                                    None},"},{"line_number":54,"context_line":"                        \u0027enforce_policy\u0027: True,"},{"line_number":55,"context_line":"                        \u0027default\u0027: attributes.ATTR_NOT_SPECIFIED,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_29cf8b80","line":52,"updated":"2016-04-17 07:38:33.000000000","message":"please make sure that this is part of neutron-lib. -if not then https://review.openstack.org/#/c/285441 will break you","commit_id":"25c7090f294fedf8a97de50b7faa3133c9ec23ea"}],"neutron/plugins/ml2/driver_api.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a9839c50c878a9a43656de9b5cc3acd768479169","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    allocation state associated with network segments of that type."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Network segments are represented by segment dictionaries using the"},{"line_number":50,"context_line":"    NETWORK_TYPE, PHYSICAL_NETWORK, SEGMENTATION_ID, FLOODING_VTEP"},{"line_number":51,"context_line":"    keys defined above, corresponding to the provider attributes.  Future"},{"line_number":52,"context_line":"    revisions of the TypeDriver API may add additional segment dictionary"},{"line_number":53,"context_line":"    keys. Attributes not applicable for a particular network_type may"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_6fdb997c","line":50,"range":{"start_line":50,"start_character":52,"end_line":50,"end_character":53},"updated":"2016-04-01 08:23:17.000000000","message":"nit: missing \"and\"","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"96fc8cdaf99928420ba5f2a023cc54caef9e9a88","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    allocation state associated with network segments of that type."},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    Network segments are represented by segment dictionaries using the"},{"line_number":50,"context_line":"    NETWORK_TYPE, PHYSICAL_NETWORK, SEGMENTATION_ID, FLOODING_VTEP"},{"line_number":51,"context_line":"    keys defined above, corresponding to the provider attributes.  Future"},{"line_number":52,"context_line":"    revisions of the TypeDriver API may add additional segment dictionary"},{"line_number":53,"context_line":"    keys. Attributes not applicable for a particular network_type may"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_0c46607a","line":50,"range":{"start_line":50,"start_character":52,"end_line":50,"end_character":53},"in_reply_to":"ba0121b8_6fdb997c","updated":"2016-04-01 12:57:54.000000000","message":"ok, thanks.","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"}],"neutron/plugins/ml2/drivers/type_tunnel.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a9839c50c878a9a43656de9b5cc3acd768479169","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        return {api.NETWORK_TYPE: self.get_type(),"},{"line_number":205,"context_line":"                api.PHYSICAL_NETWORK: None,"},{"line_number":206,"context_line":"                api.SEGMENTATION_ID: getattr(alloc, self.segmentation_key),"},{"line_number":207,"context_line":"                api.FLOODING_VTEP: segment.get("},{"line_number":208,"context_line":"                    api.FLOODING_VTEP),"},{"line_number":209,"context_line":"                api.MTU: self.get_mtu()}"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def allocate_tenant_segment(self, session):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_8fc70d95","line":208,"range":{"start_line":207,"start_character":0,"end_line":208,"end_character":39},"updated":"2016-04-01 08:23:17.000000000","message":"nit: this could fit in one line","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"96fc8cdaf99928420ba5f2a023cc54caef9e9a88","unresolved":false,"context_lines":[{"line_number":204,"context_line":"        return {api.NETWORK_TYPE: self.get_type(),"},{"line_number":205,"context_line":"                api.PHYSICAL_NETWORK: None,"},{"line_number":206,"context_line":"                api.SEGMENTATION_ID: getattr(alloc, self.segmentation_key),"},{"line_number":207,"context_line":"                api.FLOODING_VTEP: segment.get("},{"line_number":208,"context_line":"                    api.FLOODING_VTEP),"},{"line_number":209,"context_line":"                api.MTU: self.get_mtu()}"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def allocate_tenant_segment(self, session):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_6c61dc04","line":208,"range":{"start_line":207,"start_character":0,"end_line":208,"end_character":39},"in_reply_to":"ba0121b8_8fc70d95","updated":"2016-04-01 12:57:54.000000000","message":"ok, thanks.","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"}],"neutron/plugins/ml2/managers.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a9839c50c878a9a43656de9b5cc3acd768479169","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def _process_provider_segment(self, segment):"},{"line_number":91,"context_line":"        (network_type, physical_network,"},{"line_number":92,"context_line":"         segmentation_id, flooding_vtep) \u003d ("},{"line_number":93,"context_line":"                        self._get_attribute(segment, attr)"},{"line_number":94,"context_line":"                        for attr in provider.ATTRIBUTES)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        if attributes.is_attr_set(network_type):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_ef6329af","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":58},"updated":"2016-04-01 08:23:17.000000000","message":"no need to start a new line","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"96fc8cdaf99928420ba5f2a023cc54caef9e9a88","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def _process_provider_segment(self, segment):"},{"line_number":91,"context_line":"        (network_type, physical_network,"},{"line_number":92,"context_line":"         segmentation_id, flooding_vtep) \u003d ("},{"line_number":93,"context_line":"                        self._get_attribute(segment, attr)"},{"line_number":94,"context_line":"                        for attr in provider.ATTRIBUTES)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        if attributes.is_attr_set(network_type):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_4cd978f2","line":93,"range":{"start_line":93,"start_character":0,"end_line":93,"end_character":58},"in_reply_to":"ba0121b8_ef6329af","updated":"2016-04-01 12:57:54.000000000","message":"ok, thanks.","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a9839c50c878a9a43656de9b5cc3acd768479169","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                        self._get_attribute(segment, attr)"},{"line_number":94,"context_line":"                        for attr in provider.ATTRIBUTES)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        if attributes.is_attr_set(network_type):"},{"line_number":97,"context_line":"            if attributes.is_attr_set(flooding_vtep):"},{"line_number":98,"context_line":"                if (network_type !\u003d p_const.TYPE_VXLAN):"},{"line_number":99,"context_line":"                    msg \u003d _(\"%s is only for VXLAN network\""},{"line_number":100,"context_line":"                            ) % (api.FLOODING_VTEP)"},{"line_number":101,"context_line":"                    raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"            if network_type !\u003d p_const.TYPE_VXLAN:"},{"line_number":104,"context_line":"                segment \u003d {api.NETWORK_TYPE: network_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_cf758532","line":101,"range":{"start_line":96,"start_character":0,"end_line":101,"end_character":61},"updated":"2016-04-01 08:23:17.000000000","message":"Can we just pass what we get from line 93 to \"segment\", and then handle the validation at line 240?\n\nOr is this validation necessary?","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"96fc8cdaf99928420ba5f2a023cc54caef9e9a88","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                        self._get_attribute(segment, attr)"},{"line_number":94,"context_line":"                        for attr in provider.ATTRIBUTES)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        if attributes.is_attr_set(network_type):"},{"line_number":97,"context_line":"            if attributes.is_attr_set(flooding_vtep):"},{"line_number":98,"context_line":"                if (network_type !\u003d p_const.TYPE_VXLAN):"},{"line_number":99,"context_line":"                    msg \u003d _(\"%s is only for VXLAN network\""},{"line_number":100,"context_line":"                            ) % (api.FLOODING_VTEP)"},{"line_number":101,"context_line":"                    raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"            if network_type !\u003d p_const.TYPE_VXLAN:"},{"line_number":104,"context_line":"                segment \u003d {api.NETWORK_TYPE: network_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_8c8d50d5","line":101,"range":{"start_line":96,"start_character":0,"end_line":101,"end_character":61},"in_reply_to":"ba0121b8_cf758532","updated":"2016-04-01 12:57:54.000000000","message":"Thanks your comment.\nI think it is necessary, this feature is only for VXLAN, not all tunnel. Line 240 is for all tunnel, not only VXLAN.","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a9839c50c878a9a43656de9b5cc3acd768479169","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"            if network_type !\u003d p_const.TYPE_VXLAN:"},{"line_number":104,"context_line":"                segment \u003d {api.NETWORK_TYPE: network_type,"},{"line_number":105,"context_line":"                       api.PHYSICAL_NETWORK: physical_network,"},{"line_number":106,"context_line":"                       api.SEGMENTATION_ID: segmentation_id}"},{"line_number":107,"context_line":"            else:"},{"line_number":108,"context_line":"                segment \u003d {api.NETWORK_TYPE: network_type,"},{"line_number":109,"context_line":"                       api.PHYSICAL_NETWORK: physical_network,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_cf6bc583","line":106,"range":{"start_line":105,"start_character":0,"end_line":106,"end_character":60},"updated":"2016-04-01 08:23:17.000000000","message":"you should re-align the lines here.","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a9839c50c878a9a43656de9b5cc3acd768479169","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                       api.SEGMENTATION_ID: segmentation_id}"},{"line_number":107,"context_line":"            else:"},{"line_number":108,"context_line":"                segment \u003d {api.NETWORK_TYPE: network_type,"},{"line_number":109,"context_line":"                       api.PHYSICAL_NETWORK: physical_network,"},{"line_number":110,"context_line":"                       api.SEGMENTATION_ID: segmentation_id,"},{"line_number":111,"context_line":"                       api.FLOODING_VTEP: flooding_vtep}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"            self.validate_provider_segment(segment)"},{"line_number":114,"context_line":"            return segment"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_0f081dd9","line":111,"range":{"start_line":109,"start_character":0,"end_line":111,"end_character":56},"updated":"2016-04-01 08:23:17.000000000","message":"ditto","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"96fc8cdaf99928420ba5f2a023cc54caef9e9a88","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                       api.SEGMENTATION_ID: segmentation_id}"},{"line_number":107,"context_line":"            else:"},{"line_number":108,"context_line":"                segment \u003d {api.NETWORK_TYPE: network_type,"},{"line_number":109,"context_line":"                       api.PHYSICAL_NETWORK: physical_network,"},{"line_number":110,"context_line":"                       api.SEGMENTATION_ID: segmentation_id,"},{"line_number":111,"context_line":"                       api.FLOODING_VTEP: flooding_vtep}"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"            self.validate_provider_segment(segment)"},{"line_number":114,"context_line":"            return segment"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_6cb39c98","line":111,"range":{"start_line":109,"start_character":0,"end_line":111,"end_character":56},"in_reply_to":"ba0121b8_0f081dd9","updated":"2016-04-01 12:57:54.000000000","message":"ok, thanks.","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a9839c50c878a9a43656de9b5cc3acd768479169","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                {provider.NETWORK_TYPE: segment[api.NETWORK_TYPE],"},{"line_number":185,"context_line":"                 provider.PHYSICAL_NETWORK: segment[api.PHYSICAL_NETWORK],"},{"line_number":186,"context_line":"                 provider.SEGMENTATION_ID: segment[api.SEGMENTATION_ID],"},{"line_number":187,"context_line":"                 provider.FLOODING_VTEP:"},{"line_number":188,"context_line":"                segment[api.FLOODING_VTEP]}"},{"line_number":189,"context_line":"                for segment in segments]"},{"line_number":190,"context_line":"        else:"},{"line_number":191,"context_line":"            segment \u003d segments[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_ef3cc994","line":188,"range":{"start_line":187,"start_character":0,"end_line":188,"end_character":43},"updated":"2016-04-01 08:23:17.000000000","message":"nit: this could fit in one line","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"96fc8cdaf99928420ba5f2a023cc54caef9e9a88","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                {provider.NETWORK_TYPE: segment[api.NETWORK_TYPE],"},{"line_number":185,"context_line":"                 provider.PHYSICAL_NETWORK: segment[api.PHYSICAL_NETWORK],"},{"line_number":186,"context_line":"                 provider.SEGMENTATION_ID: segment[api.SEGMENTATION_ID],"},{"line_number":187,"context_line":"                 provider.FLOODING_VTEP:"},{"line_number":188,"context_line":"                segment[api.FLOODING_VTEP]}"},{"line_number":189,"context_line":"                for segment in segments]"},{"line_number":190,"context_line":"        else:"},{"line_number":191,"context_line":"            segment \u003d segments[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_ec65ec1d","line":188,"range":{"start_line":187,"start_character":0,"end_line":188,"end_character":43},"in_reply_to":"ba0121b8_ef3cc994","updated":"2016-04-01 12:57:54.000000000","message":"ok, thanks","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a9839c50c878a9a43656de9b5cc3acd768479169","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            network[provider.NETWORK_TYPE] \u003d segment[api.NETWORK_TYPE]"},{"line_number":193,"context_line":"            network[provider.PHYSICAL_NETWORK] \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":194,"context_line":"            network[provider.SEGMENTATION_ID] \u003d segment[api.SEGMENTATION_ID]"},{"line_number":195,"context_line":"            network[provider.FLOODING_VTEP] \u003d segment["},{"line_number":196,"context_line":"                    api.FLOODING_VTEP]"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def initialize(self):"},{"line_number":199,"context_line":"        for network_type, driver in six.iteritems(self.drivers):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_2f436114","line":196,"range":{"start_line":195,"start_character":0,"end_line":196,"end_character":38},"updated":"2016-04-01 08:23:17.000000000","message":"ditto","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"96fc8cdaf99928420ba5f2a023cc54caef9e9a88","unresolved":false,"context_lines":[{"line_number":192,"context_line":"            network[provider.NETWORK_TYPE] \u003d segment[api.NETWORK_TYPE]"},{"line_number":193,"context_line":"            network[provider.PHYSICAL_NETWORK] \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":194,"context_line":"            network[provider.SEGMENTATION_ID] \u003d segment[api.SEGMENTATION_ID]"},{"line_number":195,"context_line":"            network[provider.FLOODING_VTEP] \u003d segment["},{"line_number":196,"context_line":"                    api.FLOODING_VTEP]"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def initialize(self):"},{"line_number":199,"context_line":"        for network_type, driver in six.iteritems(self.drivers):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_2c6c0407","line":196,"range":{"start_line":195,"start_character":0,"end_line":196,"end_character":38},"in_reply_to":"ba0121b8_2f436114","updated":"2016-04-01 12:57:54.000000000","message":"ok, thanks.","commit_id":"f74bb1880982503923f1eb541aac83cb72765e4d"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d13b8b4b8e5412cee2558b95ed42b3f0609fbe17","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                           for attr in provider.ATTRIBUTES)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if attributes.is_attr_set(network_type):"},{"line_number":96,"context_line":"            if attributes.is_attr_set(flooding_vtep):"},{"line_number":97,"context_line":"                if (network_type !\u003d p_const.TYPE_VXLAN):"},{"line_number":98,"context_line":"                    msg \u003d _(\"%s is only for VXLAN network\""},{"line_number":99,"context_line":"                            ) % (api.FLOODING_VTEP)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_94622c15","line":96,"updated":"2016-04-09 05:57:29.000000000","message":"let\u0027s write a comment about this validation.","commit_id":"d7aa525419ad034e18b7e3543681f4ec56b61c6f"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"d299741abe36619dfbb386f8ea803a3f629699ae","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                           for attr in provider.ATTRIBUTES)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        if attributes.is_attr_set(network_type):"},{"line_number":96,"context_line":"            if attributes.is_attr_set(flooding_vtep):"},{"line_number":97,"context_line":"                if (network_type !\u003d p_const.TYPE_VXLAN):"},{"line_number":98,"context_line":"                    msg \u003d _(\"%s is only for VXLAN network\""},{"line_number":99,"context_line":"                            ) % (api.FLOODING_VTEP)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_dd220001","line":96,"in_reply_to":"9a061dce_94622c15","updated":"2016-04-10 02:21:51.000000000","message":"OK, thanks.","commit_id":"d7aa525419ad034e18b7e3543681f4ec56b61c6f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d13b8b4b8e5412cee2558b95ed42b3f0609fbe17","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        if attributes.is_attr_set(network_type):"},{"line_number":96,"context_line":"            if attributes.is_attr_set(flooding_vtep):"},{"line_number":97,"context_line":"                if (network_type !\u003d p_const.TYPE_VXLAN):"},{"line_number":98,"context_line":"                    msg \u003d _(\"%s is only for VXLAN network\""},{"line_number":99,"context_line":"                            ) % (api.FLOODING_VTEP)"},{"line_number":100,"context_line":"                    raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_74679825","line":98,"updated":"2016-04-09 05:57:29.000000000","message":"How about rewording the msg as _(\"REMOTE_VTEP functionality is only supported for VXLAN network segment\")","commit_id":"d7aa525419ad034e18b7e3543681f4ec56b61c6f"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"d299741abe36619dfbb386f8ea803a3f629699ae","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        if attributes.is_attr_set(network_type):"},{"line_number":96,"context_line":"            if attributes.is_attr_set(flooding_vtep):"},{"line_number":97,"context_line":"                if (network_type !\u003d p_const.TYPE_VXLAN):"},{"line_number":98,"context_line":"                    msg \u003d _(\"%s is only for VXLAN network\""},{"line_number":99,"context_line":"                            ) % (api.FLOODING_VTEP)"},{"line_number":100,"context_line":"                    raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_1d1d98bd","line":98,"in_reply_to":"9a061dce_74679825","updated":"2016-04-10 02:21:51.000000000","message":"OK, thanks.","commit_id":"d7aa525419ad034e18b7e3543681f4ec56b61c6f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"07ef6a761b5114813b233d449bdf787c24ea739e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        (network_type, physical_network,"},{"line_number":93,"context_line":"         segmentation_id) \u003d (self._get_attribute(segment, attr)"},{"line_number":94,"context_line":"                             for attr in provider.ATTRIBUTES)"},{"line_number":95,"context_line":"        flooding_vteps \u003d self._get_attribute(segment, vteps.FLOODING_VTEP)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        if attributes.is_attr_set(network_type):"},{"line_number":98,"context_line":"            if attributes.is_attr_set(flooding_vteps):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_d9e58538","line":95,"range":{"start_line":95,"start_character":0,"end_line":95,"end_character":74},"updated":"2016-04-20 06:59:46.000000000","message":"This can be part of loop in line 91~93, since you have changed the provider.ATTRIBUTES at [1]\n\n[1] https://review.openstack.org/#/c/299480/9/neutron/extensions/providernet.py","commit_id":"c7ba130d00beae47bc54de51c0f4d378892bc996"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"07ef6a761b5114813b233d449bdf787c24ea739e","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                {provider.NETWORK_TYPE: segment[api.NETWORK_TYPE],"},{"line_number":187,"context_line":"                 provider.PHYSICAL_NETWORK: segment[api.PHYSICAL_NETWORK],"},{"line_number":188,"context_line":"                 provider.SEGMENTATION_ID: segment[api.SEGMENTATION_ID],"},{"line_number":189,"context_line":"                 vteps.FLOODING_VTEP: segment[api.FLOODING_VTEP]}"},{"line_number":190,"context_line":"                for segment in segments]"},{"line_number":191,"context_line":"        else:"},{"line_number":192,"context_line":"            segment \u003d segments[0]"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_994dcd40","line":189,"range":{"start_line":189,"start_character":17,"end_line":189,"end_character":37},"updated":"2016-04-20 06:59:46.000000000","message":"maybe more appropriate with \"provider.FLOODING_VTEP\"","commit_id":"c7ba130d00beae47bc54de51c0f4d378892bc996"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"07ef6a761b5114813b233d449bdf787c24ea739e","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            network[provider.NETWORK_TYPE] \u003d segment[api.NETWORK_TYPE]"},{"line_number":194,"context_line":"            network[provider.PHYSICAL_NETWORK] \u003d segment[api.PHYSICAL_NETWORK]"},{"line_number":195,"context_line":"            network[provider.SEGMENTATION_ID] \u003d segment[api.SEGMENTATION_ID]"},{"line_number":196,"context_line":"            network[vteps.FLOODING_VTEP] \u003d segment[api.FLOODING_VTEP]"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def initialize(self):"},{"line_number":199,"context_line":"        for network_type, driver in six.iteritems(self.drivers):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_794a7127","line":196,"range":{"start_line":196,"start_character":12,"end_line":196,"end_character":69},"updated":"2016-04-20 06:59:46.000000000","message":"ditto","commit_id":"c7ba130d00beae47bc54de51c0f4d378892bc996"}],"neutron/tests/unit/plugins/ml2/drivers/base_type_tunnel.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4aa44e8bed3cb32d1ced385d8a8cf09a8d27224c","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":189,"context_line":"                            matchers.LessThan(TUN_MAX + 1))"},{"line_number":190,"context_line":"            self.assertEqual(segment[api.FLOODING_VTEP],"},{"line_number":191,"context_line":"                            flooding_vtep)"},{"line_number":192,"context_line":"            tunnel_ids.add(segment[api.SEGMENTATION_ID])"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        with testtools.ExpectedException(exc.NoNetworkAvailable):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_89a69fbf","line":191,"updated":"2016-04-17 07:38:33.000000000","message":"nit - alignment","commit_id":"25c7090f294fedf8a97de50b7faa3133c9ec23ea"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4aa44e8bed3cb32d1ced385d8a8cf09a8d27224c","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                        matchers.GreaterThan(TUN_MIN - 1))"},{"line_number":206,"context_line":"        self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":207,"context_line":"                        matchers.LessThan(TUN_MAX + 1))"},{"line_number":208,"context_line":"        self.assertEqual(segment[api.FLOODING_VTEP],"},{"line_number":209,"context_line":"                        flooding_vtep)"},{"line_number":210,"context_line":"        tunnel_ids.add(segment[api.SEGMENTATION_ID])"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_0993af5c","line":208,"updated":"2016-04-17 07:38:33.000000000","message":"ditto","commit_id":"25c7090f294fedf8a97de50b7faa3133c9ec23ea"}],"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"13d9d9431d0f48ebe2214cd0cd8b803d8cd0671d","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            if mpnet.SEGMENTS not in net:"},{"line_number":271,"context_line":"                for k, v in six.iteritems(net):"},{"line_number":272,"context_line":"                    if k \u003d\u003d pnet.FLOODING_VTEP:"},{"line_number":273,"context_line":"                        self.assertEqual(len(network[k]), 0)"},{"line_number":274,"context_line":"                    else:"},{"line_number":275,"context_line":"                        self.assertEqual(net[k], network[k])"},{"line_number":276,"context_line":"                    self.assertNotIn(mpnet.SEGMENTS, network)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_331a4d18","line":273,"updated":"2016-04-10 07:37:05.000000000","message":"please have the expected value as the first parameter","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"ab2050137c48426bfdad220614cebfecae765b65","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            if mpnet.SEGMENTS not in net:"},{"line_number":271,"context_line":"                for k, v in six.iteritems(net):"},{"line_number":272,"context_line":"                    if k \u003d\u003d pnet.FLOODING_VTEP:"},{"line_number":273,"context_line":"                        self.assertEqual(len(network[k]), 0)"},{"line_number":274,"context_line":"                    else:"},{"line_number":275,"context_line":"                        self.assertEqual(net[k], network[k])"},{"line_number":276,"context_line":"                    self.assertNotIn(mpnet.SEGMENTS, network)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a1b2928_b376843c","line":273,"in_reply_to":"9a061dce_331a4d18","updated":"2016-04-11 10:56:06.000000000","message":"I do not want to set FLOODING_VTEP in this test case.\nI will test FLOODING_VTEP in below class TestNetworkUnderlay.","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"13d9d9431d0f48ebe2214cd0cd8b803d8cd0671d","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                for expected, actual in zip(expected_segments, segments):"},{"line_number":282,"context_line":"                    for attr in pnet.ATTRIBUTES:"},{"line_number":283,"context_line":"                        if attr \u003d\u003d pnet.FLOODING_VTEP:"},{"line_number":284,"context_line":"                            self.assertEqual(len(actual[attr]), 0)"},{"line_number":285,"context_line":"                        else:"},{"line_number":286,"context_line":"                            self.assertEqual(expected[attr], actual[attr])"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_131749ee","line":284,"updated":"2016-04-10 07:37:05.000000000","message":"ditto","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"ab2050137c48426bfdad220614cebfecae765b65","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                for expected, actual in zip(expected_segments, segments):"},{"line_number":282,"context_line":"                    for attr in pnet.ATTRIBUTES:"},{"line_number":283,"context_line":"                        if attr \u003d\u003d pnet.FLOODING_VTEP:"},{"line_number":284,"context_line":"                            self.assertEqual(len(actual[attr]), 0)"},{"line_number":285,"context_line":"                        else:"},{"line_number":286,"context_line":"                            self.assertEqual(expected[attr], actual[attr])"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a1b2928_f38e3c26","line":284,"in_reply_to":"9a061dce_131749ee","updated":"2016-04-11 10:56:06.000000000","message":"ditto","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"13d9d9431d0f48ebe2214cd0cd8b803d8cd0671d","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        network \u003d networks[\u0027networks\u0027][0]"},{"line_number":309,"context_line":"        for attr in pnet.ATTRIBUTES:"},{"line_number":310,"context_line":"            if attr \u003d\u003d pnet.FLOODING_VTEP:"},{"line_number":311,"context_line":"                self.assertEqual(len(network[attr]), 0)"},{"line_number":312,"context_line":"            else:"},{"line_number":313,"context_line":"                self.assertEqual(expected_net[attr], network[attr])"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_73d20536","line":311,"updated":"2016-04-10 07:37:05.000000000","message":"ditto","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"ab2050137c48426bfdad220614cebfecae765b65","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        network \u003d networks[\u0027networks\u0027][0]"},{"line_number":309,"context_line":"        for attr in pnet.ATTRIBUTES:"},{"line_number":310,"context_line":"            if attr \u003d\u003d pnet.FLOODING_VTEP:"},{"line_number":311,"context_line":"                self.assertEqual(len(network[attr]), 0)"},{"line_number":312,"context_line":"            else:"},{"line_number":313,"context_line":"                self.assertEqual(expected_net[attr], network[attr])"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a1b2928_139e5856","line":311,"in_reply_to":"9a061dce_73d20536","updated":"2016-04-11 10:56:06.000000000","message":"ditto","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"13d9d9431d0f48ebe2214cd0cd8b803d8cd0671d","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        for expected, actual in zip(expected_segments, segments):"},{"line_number":330,"context_line":"            for attr in pnet.ATTRIBUTES:"},{"line_number":331,"context_line":"                if attr \u003d\u003d pnet.FLOODING_VTEP:"},{"line_number":332,"context_line":"                    self.assertEqual(len(actual[attr]), 0)"},{"line_number":333,"context_line":"                else:"},{"line_number":334,"context_line":"                    self.assertEqual(expected[attr], actual[attr])"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_b3dc9d47","line":332,"updated":"2016-04-10 07:37:05.000000000","message":"ditto","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"ab2050137c48426bfdad220614cebfecae765b65","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        for expected, actual in zip(expected_segments, segments):"},{"line_number":330,"context_line":"            for attr in pnet.ATTRIBUTES:"},{"line_number":331,"context_line":"                if attr \u003d\u003d pnet.FLOODING_VTEP:"},{"line_number":332,"context_line":"                    self.assertEqual(len(actual[attr]), 0)"},{"line_number":333,"context_line":"                else:"},{"line_number":334,"context_line":"                    self.assertEqual(expected[attr], actual[attr])"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a1b2928_93aa686f","line":332,"in_reply_to":"9a061dce_b3dc9d47","updated":"2016-04-11 10:56:06.000000000","message":"ditto","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"13d9d9431d0f48ebe2214cd0cd8b803d8cd0671d","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        self.assertNotIn(mpnet.SEGMENTS, network[\u0027network\u0027])"},{"line_number":429,"context_line":"        # External network underlay must be the same as the setting value"},{"line_number":430,"context_line":"        self.assertEqual(network[\u0027network\u0027]["},{"line_number":431,"context_line":"            pnet.FLOODING_VTEP], [\u0027158.0.0.1\u0027])"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def test_network_type_vlan_with_underlay_flooding_vtep(self):"},{"line_number":434,"context_line":"        data \u003d {\u0027network\u0027: {\u0027name\u0027: \u0027net1\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_93e19901","line":431,"updated":"2016-04-10 07:37:05.000000000","message":"please have expected parameter first","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"ab2050137c48426bfdad220614cebfecae765b65","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        self.assertNotIn(mpnet.SEGMENTS, network[\u0027network\u0027])"},{"line_number":429,"context_line":"        # External network underlay must be the same as the setting value"},{"line_number":430,"context_line":"        self.assertEqual(network[\u0027network\u0027]["},{"line_number":431,"context_line":"            pnet.FLOODING_VTEP], [\u0027158.0.0.1\u0027])"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    def test_network_type_vlan_with_underlay_flooding_vtep(self):"},{"line_number":434,"context_line":"        data \u003d {\u0027network\u0027: {\u0027name\u0027: \u0027net1\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a1b2928_13b5b8cc","line":431,"in_reply_to":"9a061dce_93e19901","updated":"2016-04-11 10:56:06.000000000","message":"ok, thanks.","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"13d9d9431d0f48ebe2214cd0cd8b803d8cd0671d","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        self.assertNotIn(mpnet.SEGMENTS, network[\u0027network\u0027])"},{"line_number":453,"context_line":"        # External network underlay must be the same as the setting value"},{"line_number":454,"context_line":"        self.assertEqual(network[\u0027network\u0027]["},{"line_number":455,"context_line":"            pnet.FLOODING_VTEP], [\u0027158.0.0.1\u0027])"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"class TestMl2NetworksWithVlanTransparencyAndMTU(TestMl2NetworksV2):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_d3e31104","line":455,"updated":"2016-04-10 07:37:05.000000000","message":"ditto","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"ab2050137c48426bfdad220614cebfecae765b65","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        self.assertNotIn(mpnet.SEGMENTS, network[\u0027network\u0027])"},{"line_number":453,"context_line":"        # External network underlay must be the same as the setting value"},{"line_number":454,"context_line":"        self.assertEqual(network[\u0027network\u0027]["},{"line_number":455,"context_line":"            pnet.FLOODING_VTEP], [\u0027158.0.0.1\u0027])"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"class TestMl2NetworksWithVlanTransparencyAndMTU(TestMl2NetworksV2):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a1b2928_b3c4c440","line":455,"in_reply_to":"9a061dce_d3e31104","updated":"2016-04-11 10:56:06.000000000","message":"ok, thanks.","commit_id":"ff2b3a5a6f9919da82b4f813d82ca177d61e2aa8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4aa44e8bed3cb32d1ced385d8a8cf09a8d27224c","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            if mpnet.SEGMENTS not in net:"},{"line_number":271,"context_line":"                for k, v in six.iteritems(net):"},{"line_number":272,"context_line":"                    if k \u003d\u003d pnet.FLOODING_VTEP:"},{"line_number":273,"context_line":"                        self.assertEqual(len(network[k]), 0)"},{"line_number":274,"context_line":"                    else:"},{"line_number":275,"context_line":"                        self.assertEqual(net[k], network[k])"},{"line_number":276,"context_line":"                    self.assertNotIn(mpnet.SEGMENTS, network)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_e982b3ff","line":273,"updated":"2016-04-17 07:38:33.000000000","message":"please have expected value first","commit_id":"25c7090f294fedf8a97de50b7faa3133c9ec23ea"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4454add96591e7cd6babf8200dac257ccf8c7f05","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            if mpnet.SEGMENTS not in net:"},{"line_number":271,"context_line":"                for k, v in six.iteritems(net):"},{"line_number":272,"context_line":"                    if k \u003d\u003d pnet.FLOODING_VTEP:"},{"line_number":273,"context_line":"                        self.assertEqual(len(network[k]), 0)"},{"line_number":274,"context_line":"                    else:"},{"line_number":275,"context_line":"                        self.assertEqual(net[k], network[k])"},{"line_number":276,"context_line":"                    self.assertNotIn(mpnet.SEGMENTS, network)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_7ba497a5","line":273,"in_reply_to":"1a122d0e_e982b3ff","updated":"2016-04-18 08:54:31.000000000","message":"I am confused... why it\u0027s not caught by https://github.com/openstack/neutron/blob/master/HACKING.rst\n([N332] Use assertEqual(expected_http_code, observed_http_code) instead of\nassertEqual(observed_http_code, expected_http_code).)","commit_id":"25c7090f294fedf8a97de50b7faa3133c9ec23ea"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4aa44e8bed3cb32d1ced385d8a8cf09a8d27224c","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                for expected, actual in zip(expected_segments, segments):"},{"line_number":282,"context_line":"                    for attr in pnet.ATTRIBUTES:"},{"line_number":283,"context_line":"                        if attr \u003d\u003d pnet.FLOODING_VTEP:"},{"line_number":284,"context_line":"                            self.assertEqual(len(actual[attr]), 0)"},{"line_number":285,"context_line":"                        else:"},{"line_number":286,"context_line":"                            self.assertEqual(expected[attr], actual[attr])"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_499da764","line":284,"updated":"2016-04-17 07:38:33.000000000","message":"please have expected value first","commit_id":"25c7090f294fedf8a97de50b7faa3133c9ec23ea"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4aa44e8bed3cb32d1ced385d8a8cf09a8d27224c","unresolved":false,"context_lines":[{"line_number":308,"context_line":"        network \u003d networks[\u0027networks\u0027][0]"},{"line_number":309,"context_line":"        for attr in pnet.ATTRIBUTES:"},{"line_number":310,"context_line":"            if attr \u003d\u003d pnet.FLOODING_VTEP:"},{"line_number":311,"context_line":"                self.assertEqual(len(network[attr]), 0)"},{"line_number":312,"context_line":"            else:"},{"line_number":313,"context_line":"                self.assertEqual(expected_net[attr], network[attr])"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_297dcb1c","line":311,"updated":"2016-04-17 07:38:33.000000000","message":"please have expected value first","commit_id":"25c7090f294fedf8a97de50b7faa3133c9ec23ea"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4aa44e8bed3cb32d1ced385d8a8cf09a8d27224c","unresolved":false,"context_lines":[{"line_number":329,"context_line":"        for expected, actual in zip(expected_segments, segments):"},{"line_number":330,"context_line":"            for attr in pnet.ATTRIBUTES:"},{"line_number":331,"context_line":"                if attr \u003d\u003d pnet.FLOODING_VTEP:"},{"line_number":332,"context_line":"                    self.assertEqual(len(actual[attr]), 0)"},{"line_number":333,"context_line":"                else:"},{"line_number":334,"context_line":"                    self.assertEqual(expected[attr], actual[attr])"},{"line_number":335,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_49748734","line":332,"updated":"2016-04-17 07:38:33.000000000","message":"please have expected value first","commit_id":"25c7090f294fedf8a97de50b7faa3133c9ec23ea"}]}
