)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"58683ab8bf05442edbdd2d2f92b702bb920b958b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"WIP: New engine facade from oslo_db"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Just the top of the iceberg"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I4f0693789f1c928ef47c5fdd982c147d1a9a89e1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_e27b50bc","line":10,"updated":"2016-03-31 21:30:16.000000000","message":"For tracking, please add Partial-Bug: #1520719","commit_id":"af8af976f47f3dad7da60ef474ebb3c6c2183260"}],"neutron/common/config.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"23b9cc52e628adacc7e737d1f98eaa8c1bf0544c","unresolved":false,"context_lines":[{"line_number":232,"context_line":"logging.register_options(cfg.CONF)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"def init(args, configure_db\u003dTrue, **kwargs):"},{"line_number":236,"context_line":"    cfg.CONF(args\u003dargs, project\u003d\u0027neutron\u0027,"},{"line_number":237,"context_line":"             version\u003d\u0027%%(prog)s %s\u0027 % version.version_info.release_string(),"},{"line_number":238,"context_line":"             **kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_64867d14","line":235,"updated":"2016-04-19 10:39:47.000000000","message":"isn\u0027t it safe to make the default False?\nthere are out-of-tree users.\neg.\nhttps://github.com/openstack/tap-as-a-service/blob/a7d933dec026c5035e711e4be2ece8002fa1a41b/neutron_taas/services/taas/agents/ovs/agent.py#L55","commit_id":"2785aa1b498c82f8e64cd2f4c9fa1b5ce427a164"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"199d3115f3841c5b8c899cd99be6618553700003","unresolved":false,"context_lines":[{"line_number":232,"context_line":"logging.register_options(cfg.CONF)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"def init(args, configure_db\u003dTrue, **kwargs):"},{"line_number":236,"context_line":"    cfg.CONF(args\u003dargs, project\u003d\u0027neutron\u0027,"},{"line_number":237,"context_line":"             version\u003d\u0027%%(prog)s %s\u0027 % version.version_info.release_string(),"},{"line_number":238,"context_line":"             **kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_92a15297","line":235,"in_reply_to":"1a122d0e_64867d14","updated":"2016-04-26 07:23:56.000000000","message":"fair point, thanks!","commit_id":"2785aa1b498c82f8e64cd2f4c9fa1b5ce427a164"}],"neutron/db/api.py":[{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"621ac9afd3652538315e4afbefb6b861b3dfbfda","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                raise db_exc.RetryRequest(e)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def configure(conf):"},{"line_number":52,"context_line":"    context_manager.configure(sqlite_fk\u003dTrue, **conf.database)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_2e6cf6ce","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":13},"updated":"2016-04-29 10:47:39.000000000","message":"@Ann, I believe you should preserve the lazy init behaviour and just replace _FACADE with context_manager. That way it would not be necessary to have \u0027configure_db\u0027 in \u0027config.init\u0027 and would not require changes in *_agent.py. \n\nOtherwise either True or False default would affect out-of-tree users.","commit_id":"e6712af5833c68e38d3e7c2bad1cea842d055ddb"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"8a570ca74d93e6992a748a19c30c5e8d4f0c5b1a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                raise db_exc.RetryRequest(e)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def configure(conf):"},{"line_number":52,"context_line":"    context_manager.configure(sqlite_fk\u003dTrue, **conf.database)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_e12ccc03","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":13},"in_reply_to":"1a122d0e_2e6cf6ce","updated":"2016-04-29 14:22:41.000000000","message":"I will split this change in two: one will leave lazy init and introduce new engine facade and the second to get rid of lazy init safely.","commit_id":"e6712af5833c68e38d3e7c2bad1cea842d055ddb"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"239d0488e5b4837aa5a7a906f97c78a255eb69bd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                raise db_exc.RetryRequest(e)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def configure(conf):"},{"line_number":52,"context_line":"    context_manager.configure(sqlite_fk\u003dTrue, **conf.database)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a122d0e_f599226e","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":13},"in_reply_to":"1a122d0e_e12ccc03","updated":"2016-04-29 15:35:20.000000000","message":"Thanks, I was about to suggest that.","commit_id":"e6712af5833c68e38d3e7c2bad1cea842d055ddb"}]}