)]}'
{"neutron/agent/linux/tc_lib.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"1d2181a6576ba7fdab3ce311770245e7bc967a27","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        cmd_result \u003d self._execute_tc_cmd(cmd)"},{"line_number":102,"context_line":"        if not cmd_result:"},{"line_number":103,"context_line":"            return None, None"},{"line_number":104,"context_line":"        pattern \u003d re.compile("},{"line_number":105,"context_line":"            r\"police \\w+ rate (\\w+) burst (\\w+)\")"},{"line_number":106,"context_line":"        for line in cmd_result.split(\"\\n\"):"},{"line_number":107,"context_line":"            m \u003d pattern.match(line.strip())"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_e163d5da","line":104,"updated":"2016-04-05 13:21:39.000000000","message":"can you compile the RE once as a constant in the top of the module?","commit_id":"4b89a24b8a185b90621b262ddc630b66445b87cc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1861b225f12e4da984a70fb1e6db47343fe833bd","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        cmd_result \u003d self._execute_tc_cmd(cmd)"},{"line_number":102,"context_line":"        if not cmd_result:"},{"line_number":103,"context_line":"            return None, None"},{"line_number":104,"context_line":"        pattern \u003d re.compile("},{"line_number":105,"context_line":"            r\"police \\w+ rate (\\w+) burst (\\w+)\")"},{"line_number":106,"context_line":"        for line in cmd_result.split(\"\\n\"):"},{"line_number":107,"context_line":"            m \u003d pattern.match(line.strip())"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_9af237d1","line":104,"in_reply_to":"9a061dce_e163d5da","updated":"2016-04-05 14:29:41.000000000","message":"Done","commit_id":"4b89a24b8a185b90621b262ddc630b66445b87cc"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d6bc955851d25d93ab831dfc3d12810c4202e4ca","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        return self._execute_tc_cmd(cmd, extra_ok_codes\u003d[2])"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def get_burst_value(self, bw_limit, burst_limit):"},{"line_number":193,"context_line":"        min_burst_value \u003d self._get_min_burst_value(bw_limit)"},{"line_number":194,"context_line":"        return max(min_burst_value, burst_limit)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def _get_min_burst_value(self, bw_limit):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_13cb0c74","line":193,"updated":"2016-04-15 09:18:42.000000000","message":"as discussed on IRC, \nI think we should not provide min (and let the admin handle that),\nand also, provide a default burst value.\n\nif burst_limit is None or 0, we may stick to 80% .. 150% that seems to be like a workable default for policing in the context of TCP when latency is low.","commit_id":"661cf90a336d2ebc9a907391835e2f4b73cdd151"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8bf3e95e237a51d6b0588255814e46c3df7c9593","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        return self._execute_tc_cmd(cmd, extra_ok_codes\u003d[2])"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def get_burst_value(self, bw_limit, burst_limit):"},{"line_number":193,"context_line":"        min_burst_value \u003d self._get_min_burst_value(bw_limit)"},{"line_number":194,"context_line":"        return max(min_burst_value, burst_limit)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def _get_min_burst_value(self, bw_limit):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_7d365904","line":193,"in_reply_to":"1a122d0e_13cb0c74","updated":"2016-04-17 21:27:08.000000000","message":"For ingress traffic policing I changed it and it will get 80% of bw_limit if burst will be 0 or None","commit_id":"661cf90a336d2ebc9a907391835e2f4b73cdd151"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0d8e17c7cb5ecc2a7f5c31048dab50c5a5315a3c","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        if not burst_limit:"},{"line_number":194,"context_line":"            # NOTE(slaweq): If burst value was not specified by user than it"},{"line_number":195,"context_line":"            # will be set as 80% of bw_limit to ensure that limit for TCP"},{"line_number":196,"context_line":"            # traffic will works well:"},{"line_number":197,"context_line":"            return float(bw_limit) * 0.8"},{"line_number":198,"context_line":"        return burst_limit"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_21f792f6","line":196,"range":{"start_line":196,"start_character":27,"end_line":196,"end_character":32},"updated":"2016-04-18 09:25:25.000000000","message":"works \u003d\u003e work\n\nconsider also adding this as a configuration value","commit_id":"a8c8f8bac0d70420188c91635fdeb1d186335792"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f4f4ad624bf59a5e77cd5f615c996b5e5a666081","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        if not burst_limit:"},{"line_number":194,"context_line":"            # NOTE(slaweq): If burst value was not specified by user than it"},{"line_number":195,"context_line":"            # will be set as 80% of bw_limit to ensure that limit for TCP"},{"line_number":196,"context_line":"            # traffic will works well:"},{"line_number":197,"context_line":"            return float(bw_limit) * 0.8"},{"line_number":198,"context_line":"        return burst_limit"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_6ee84ab5","line":196,"range":{"start_line":196,"start_character":27,"end_line":196,"end_character":32},"in_reply_to":"1a122d0e_21f792f6","updated":"2016-04-18 14:28:41.000000000","message":"That sounds like a good idea, do it as a follow up because otherwise this patch couldn\u0027t be backported.\n\nIt\u0027s better a parameter which can be shared for ovs/lb at a minimum.\n\nRandom thoughts:\nI wonder if there\u0027s any value on having a server side parameter to calculate that, and propagate to any underlying technology, or... in the other hand, may be it\u0027s something dependent on the type of policing done, and better left to the low level of the agent..","commit_id":"a8c8f8bac0d70420188c91635fdeb1d186335792"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b9b8e1eba7ec4bf29bf8f6931212e22ea318fca","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        if not burst_limit:"},{"line_number":194,"context_line":"            # NOTE(slaweq): If burst value was not specified by user than it"},{"line_number":195,"context_line":"            # will be set as 80% of bw_limit to ensure that limit for TCP"},{"line_number":196,"context_line":"            # traffic will works well:"},{"line_number":197,"context_line":"            return float(bw_limit) * 0.8"},{"line_number":198,"context_line":"        return burst_limit"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_93c50a3e","line":196,"range":{"start_line":196,"start_character":27,"end_line":196,"end_character":32},"in_reply_to":"1a122d0e_21f792f6","updated":"2016-04-18 14:49:53.000000000","message":"s/works/work \u003d\u003e done","commit_id":"a8c8f8bac0d70420188c91635fdeb1d186335792"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b9b8e1eba7ec4bf29bf8f6931212e22ea318fca","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        if not burst_limit:"},{"line_number":194,"context_line":"            # NOTE(slaweq): If burst value was not specified by user than it"},{"line_number":195,"context_line":"            # will be set as 80% of bw_limit to ensure that limit for TCP"},{"line_number":196,"context_line":"            # traffic will works well:"},{"line_number":197,"context_line":"            return float(bw_limit) * 0.8"},{"line_number":198,"context_line":"        return burst_limit"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_e77118aa","line":196,"range":{"start_line":196,"start_character":27,"end_line":196,"end_character":32},"in_reply_to":"1a122d0e_6ee84ab5","updated":"2016-04-18 14:49:53.000000000","message":"Why it couldn\u0027t be backported without such config option?\nIs it really good idea to add config option to configure level of default burst value? Cloud operator can set burst for his rules on whatever level he want.","commit_id":"a8c8f8bac0d70420188c91635fdeb1d186335792"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"8d911682003a7b89c1abbe4ae7f49376f32a5ed4","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        if not burst_limit:"},{"line_number":194,"context_line":"            # NOTE(slaweq): If burst value was not specified by user than it"},{"line_number":195,"context_line":"            # will be set as 80% of bw_limit to ensure that limit for TCP"},{"line_number":196,"context_line":"            # traffic will works well:"},{"line_number":197,"context_line":"            return float(bw_limit) * 0.8"},{"line_number":198,"context_line":"        return burst_limit"},{"line_number":199,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_79148843","line":196,"range":{"start_line":196,"start_character":27,"end_line":196,"end_character":32},"in_reply_to":"1a122d0e_e77118aa","updated":"2016-04-18 15:37:20.000000000","message":"Sorry, probably my explanation was misleading.\n\nIt\u0027s not backportable if we add the config option, but can be backported without the config option.\n\nAlso, we were talking on IRC, and may be we\u0027re adding two options for the same thing here. Administrator can tune the burst of the policy itself, and administrator is generally has a good knowledge of his own network.\n\nSo why adding this to two places?, may be just letting this be set via policy is enough.","commit_id":"a8c8f8bac0d70420188c91635fdeb1d186335792"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0d8e17c7cb5ecc2a7f5c31048dab50c5a5315a3c","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            return float(bw_limit) * 0.8"},{"line_number":198,"context_line":"        return burst_limit"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def get_tbf_burst_value(self, bw_limit, burst_limit):"},{"line_number":201,"context_line":"        min_burst_value \u003d float(bw_limit) / float(self.kernel_hz)"},{"line_number":202,"context_line":"        return max(min_burst_value, burst_limit)"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_21ce72b4","line":200,"updated":"2016-04-18 09:25:25.000000000","message":"please prefix the internal methods with a _","commit_id":"a8c8f8bac0d70420188c91635fdeb1d186335792"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f4f4ad624bf59a5e77cd5f615c996b5e5a666081","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            return float(bw_limit) * 0.8"},{"line_number":198,"context_line":"        return burst_limit"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def get_tbf_burst_value(self, bw_limit, burst_limit):"},{"line_number":201,"context_line":"        min_burst_value \u003d float(bw_limit) / float(self.kernel_hz)"},{"line_number":202,"context_line":"        return max(min_burst_value, burst_limit)"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_ee78daf4","line":200,"in_reply_to":"1a122d0e_21ce72b4","updated":"2016-04-18 14:28:41.000000000","message":"+1","commit_id":"a8c8f8bac0d70420188c91635fdeb1d186335792"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6b9b8e1eba7ec4bf29bf8f6931212e22ea318fca","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            return float(bw_limit) * 0.8"},{"line_number":198,"context_line":"        return burst_limit"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def get_tbf_burst_value(self, bw_limit, burst_limit):"},{"line_number":201,"context_line":"        min_burst_value \u003d float(bw_limit) / float(self.kernel_hz)"},{"line_number":202,"context_line":"        return max(min_burst_value, burst_limit)"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_56cb6053","line":200,"in_reply_to":"1a122d0e_21ce72b4","updated":"2016-04-18 14:49:53.000000000","message":"Done","commit_id":"a8c8f8bac0d70420188c91635fdeb1d186335792"}],"neutron/tests/unit/agent/linux/test_tc_lib.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"3e008dc86092ee140b8743c2acc2814a9f0d36e4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \u0027filter protocol all pref 49152 u32 \\nfilter protocol all pref \u0027"},{"line_number":33,"context_line":"    \u002749152 u32 fh 800: ht divisor 1 \\nfilter protocol all pref 49152 u32 fh \u0027"},{"line_number":34,"context_line":"    \u0027800::800 order 2048 key ht 800 \\n  match 00000000/00000000 at 0\\n  \u0027"},{"line_number":35,"context_line":"    \u0027police 0x1e rate %(bw)skbit burst %(burst)skbit mtu 2Kb action \\n\u0027"},{"line_number":36,"context_line":"    \u0027drop overhead 0b \\n  ref 1 bind 1\u0027"},{"line_number":37,"context_line":") % {\u0027bw\u0027: BW_LIMIT, \u0027burst\u0027: BURST}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_92cd0560","line":35,"updated":"2016-04-05 13:25:22.000000000","message":"shall we make sure we bump that policy mtu to the max?","commit_id":"4b89a24b8a185b90621b262ddc630b66445b87cc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4a526db953faf89b161fed3e819e4bef8c87db1d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    \u0027filter protocol all pref 49152 u32 \\nfilter protocol all pref \u0027"},{"line_number":33,"context_line":"    \u002749152 u32 fh 800: ht divisor 1 \\nfilter protocol all pref 49152 u32 fh \u0027"},{"line_number":34,"context_line":"    \u0027800::800 order 2048 key ht 800 \\n  match 00000000/00000000 at 0\\n  \u0027"},{"line_number":35,"context_line":"    \u0027police 0x1e rate %(bw)skbit burst %(burst)skbit mtu 2Kb action \\n\u0027"},{"line_number":36,"context_line":"    \u0027drop overhead 0b \\n  ref 1 bind 1\u0027"},{"line_number":37,"context_line":") % {\u0027bw\u0027: BW_LIMIT, \u0027burst\u0027: BURST}"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_17272265","line":35,"in_reply_to":"9a061dce_92cd0560","updated":"2016-04-05 14:11:15.000000000","message":"I didn\u0027t set it in my code for any specified value. According to http://man7.org/linux/man-pages/man8/police.8.html it should (or can be unlimited) so I will try to check how to set it for such value.\n\nWould it be ok for You?","commit_id":"4b89a24b8a185b90621b262ddc630b66445b87cc"}]}
