)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5dd24316fb74de8471386e32c62693dac716abfe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nate Johnston \u003cnate_johnston@cable.comcast.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-06 20:51:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"QoS DSCP follow up patch."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Changes RULE_TYPE_DSCP_MARK to RULE_TYPE_DSCP_MARKING to conform"},{"line_number":10,"context_line":"  with the rules name."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_e6dcfb47","line":7,"updated":"2016-07-07 06:50:41.000000000","message":"Please change this to something meaning ful. Follow up patch may be a bit confusing in a years time when we look at git log","commit_id":"ba8995f07925fb06d217d5a5f503d72eafa6c918"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"833762547610f70a3dd284e340eaa875e4646661","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nate Johnston \u003cnate_johnston@cable.comcast.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-06 20:51:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"QoS DSCP follow up patch."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Changes RULE_TYPE_DSCP_MARK to RULE_TYPE_DSCP_MARKING to conform"},{"line_number":10,"context_line":"  with the rules name."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_22912a9a","line":7,"in_reply_to":"1aa78d24_e6dcfb47","updated":"2016-07-11 13:45:56.000000000","message":"Done","commit_id":"ba8995f07925fb06d217d5a5f503d72eafa6c918"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"ac75c7e7a8266e14d19a93f7a6c286478a69f724","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Shaughnessy \u003cdavid.shaughnessy@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-11 14:27:44 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add object versioning to QoS DSCP + minor nits."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Changes RULE_TYPE_DSCP_MARK to RULE_TYPE_DSCP_MARKING to conform"},{"line_number":10,"context_line":"  with the rules name."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aa78d24_703d9c8e","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":47},"updated":"2016-07-12 01:46:38.000000000","message":"I don\u0027t think that this is worth information of first line. How about just \"Add object versioning to QoS DSCP\"?","commit_id":"1bc2bc8711cadcb0bd4c8e3605e505e8dc328b39"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"247f53be7558c06b94ceec2c7ed65eb88b138d2e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Shaughnessy \u003cdavid.shaughnessy@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-11 14:27:44 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add object versioning to QoS DSCP + minor nits."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"- Changes RULE_TYPE_DSCP_MARK to RULE_TYPE_DSCP_MARKING to conform"},{"line_number":10,"context_line":"  with the rules name."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1aa78d24_393e4b8b","line":7,"range":{"start_line":7,"start_character":33,"end_line":7,"end_character":47},"in_reply_to":"1aa78d24_703d9c8e","updated":"2016-07-12 09:55:33.000000000","message":"Done","commit_id":"1bc2bc8711cadcb0bd4c8e3605e505e8dc328b39"}],"neutron/common/exceptions.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5dd24316fb74de8471386e32c62693dac716abfe","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class QosRuleVersionUnavailable(e.NotFound):"},{"line_number":42,"context_line":"    message \u003d _(\"QoS Rule Unavailable in current object version.\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class QosPolicyNotFound(e.NotFound):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_46eceff2","line":42,"range":{"start_line":42,"start_character":26,"end_line":42,"end_character":37},"updated":"2016-07-07 06:50:41.000000000","message":"unavailable\nbelow the Rule is written as rule. please also change that","commit_id":"ba8995f07925fb06d217d5a5f503d72eafa6c918"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"833762547610f70a3dd284e340eaa875e4646661","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class QosRuleVersionUnavailable(e.NotFound):"},{"line_number":42,"context_line":"    message \u003d _(\"QoS Rule Unavailable in current object version.\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class QosPolicyNotFound(e.NotFound):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_028cee7d","line":42,"range":{"start_line":42,"start_character":26,"end_line":42,"end_character":37},"in_reply_to":"1aa78d24_46eceff2","updated":"2016-07-11 13:45:56.000000000","message":"Done","commit_id":"ba8995f07925fb06d217d5a5f503d72eafa6c918"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"818da40c434f6ca44f0719c5be7ca31fed44f8b6","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class QosRuleVersionUnavailable(e.NotFound):"},{"line_number":42,"context_line":"    message \u003d _(\"QoS Rule Unavailable in current object version.\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class QosPolicyNotFound(e.NotFound):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_ae5c854b","line":42,"range":{"start_line":42,"start_character":26,"end_line":42,"end_character":37},"in_reply_to":"1aa78d24_46eceff2","updated":"2016-07-07 08:41:39.000000000","message":"Just to clarify, you mean change \"Rule Unavailable\" to \"rule unavailable\" right?","commit_id":"ba8995f07925fb06d217d5a5f503d72eafa6c918"}],"neutron/objects/qos/rule.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5dd24316fb74de8471386e32c62693dac716abfe","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":115,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":116,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":117,"context_line":"            raise exceptions.QosRuleVersionUnavailable()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_46c34f57","line":117,"updated":"2016-07-07 06:50:41.000000000","message":"maybe pass the version here","commit_id":"ba8995f07925fb06d217d5a5f503d72eafa6c918"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"833762547610f70a3dd284e340eaa875e4646661","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":115,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":116,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":117,"context_line":"            raise exceptions.QosRuleVersionUnavailable()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_a2f35a09","line":117,"in_reply_to":"1aa78d24_0e9319fb","updated":"2016-07-11 13:45:56.000000000","message":"Done","commit_id":"ba8995f07925fb06d217d5a5f503d72eafa6c918"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"4959b49a2b28fac0d70548773cc5e0a4dde83478","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":115,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":116,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":117,"context_line":"            raise exceptions.QosRuleVersionUnavailable()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_0e9319fb","line":117,"in_reply_to":"1aa78d24_46c34f57","updated":"2016-07-07 08:41:24.000000000","message":"Can we check oslo.versionedobjects to see which kinds of exceptions can we throw in there?, e.NotFound seems more HTTP related., And this kind of conversion will happen mostly on a push from the RPC layer.","commit_id":"ba8995f07925fb06d217d5a5f503d72eafa6c918"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"833762547610f70a3dd284e340eaa875e4646661","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":115,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":116,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":117,"context_line":"            raise exceptions.QosRuleVersionUnavailable()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_42ec3629","line":117,"in_reply_to":"1aa78d24_46c34f57","updated":"2016-07-11 13:45:56.000000000","message":"Done","commit_id":"ba8995f07925fb06d217d5a5f503d72eafa6c918"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"ac75c7e7a8266e14d19a93f7a6c286478a69f724","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":116,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":117,"context_line":"            raise exception.IncompatibleObjectVersion("},{"line_number":118,"context_line":"                                 objver\u003dstr(_target_version),"},{"line_number":119,"context_line":"                                 objname\u003d\"QosDscpMarkingRule\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_7605940f","line":118,"range":{"start_line":118,"start_character":40,"end_line":118,"end_character":60},"updated":"2016-07-12 01:46:38.000000000","message":"Why not use just target_version?","commit_id":"1bc2bc8711cadcb0bd4c8e3605e505e8dc328b39"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"247f53be7558c06b94ceec2c7ed65eb88b138d2e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":116,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":117,"context_line":"            raise exception.IncompatibleObjectVersion("},{"line_number":118,"context_line":"                                 objver\u003dstr(_target_version),"},{"line_number":119,"context_line":"                                 objname\u003d\"QosDscpMarkingRule\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_59499730","line":118,"range":{"start_line":118,"start_character":40,"end_line":118,"end_character":60},"in_reply_to":"1aa78d24_7605940f","updated":"2016-07-12 09:55:33.000000000","message":"Done","commit_id":"1bc2bc8711cadcb0bd4c8e3605e505e8dc328b39"}],"neutron/objects/qos/rule_type.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"78818a2f6721d9f2892a6a55afd419b5c86bf480","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":49,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":50,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":51,"context_line":"            self.fields[\u0027type\u0027].AUTO_TYPE \u003d obj_fields.Enum("},{"line_number":52,"context_line":"                valid_values\u003d[qos_consts.RULE_TYPE_BANDWIDTH_LIMIT])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_72a40a4a","line":51,"updated":"2016-04-01 15:01:21.000000000","message":"And what if type is dscp? Shouldn\u0027t we raise?","commit_id":"379b17e5859e2d07ddf4f8e685eda4e41254d006"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"23a3a724122ec26ab4ecc2862c82bb2d8b73969d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":49,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":50,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":51,"context_line":"            self.fields[\u0027type\u0027].AUTO_TYPE \u003d obj_fields.Enum("},{"line_number":52,"context_line":"                valid_values\u003d[qos_consts.RULE_TYPE_BANDWIDTH_LIMIT])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_e5ffb363","line":51,"in_reply_to":"ba0121b8_050e27e4","updated":"2016-04-01 15:56:46.000000000","message":"Could be. The class represents a single type, not a list of them.","commit_id":"379b17e5859e2d07ddf4f8e685eda4e41254d006"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"3d84c4f1a50024a5d4e9ccb3b3a98871c24679dd","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":49,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":50,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":51,"context_line":"            self.fields[\u0027type\u0027].AUTO_TYPE \u003d obj_fields.Enum("},{"line_number":52,"context_line":"                valid_values\u003d[qos_consts.RULE_TYPE_BANDWIDTH_LIMIT])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_f87d9b6d","line":51,"in_reply_to":"ba0121b8_72a40a4a","updated":"2016-04-01 15:21:07.000000000","message":"This class is only to list the available rules, the QoSRules all inherit from a different class in rule.py","commit_id":"379b17e5859e2d07ddf4f8e685eda4e41254d006"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"60ebe4628602ef1a51b45d7ab7ef29bf19ded986","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":49,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":50,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":51,"context_line":"            self.fields[\u0027type\u0027].AUTO_TYPE \u003d obj_fields.Enum("},{"line_number":52,"context_line":"                valid_values\u003d[qos_consts.RULE_TYPE_BANDWIDTH_LIMIT])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_050e27e4","line":51,"in_reply_to":"ba0121b8_98c73f63","updated":"2016-04-01 15:53:34.000000000","message":"There shouldn\u0027t be a time when type \u003d\u003d dscp, it just holds a class containing qos_consts.VALID_RULE_TYPES. When the object is decremented the only rule that should be available is the bandwidth limit rule.\n\nhave I misinterpreted how the class is used?","commit_id":"379b17e5859e2d07ddf4f8e685eda4e41254d006"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"250d678afec471d35b8010874e8debf849672b8c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":49,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":50,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":51,"context_line":"            self.fields[\u0027type\u0027].AUTO_TYPE \u003d obj_fields.Enum("},{"line_number":52,"context_line":"                valid_values\u003d[qos_consts.RULE_TYPE_BANDWIDTH_LIMIT])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_08f2be05","line":51,"in_reply_to":"ba0121b8_e5ffb363","updated":"2016-04-01 16:09:40.000000000","message":"Oh, this isn\u0027t a list of valid types, it\u0027s one of these values, correct?\nI\u0027ll make it similar to the QosDscpMarkingRule class and throw an invalid version exception.\n\nShould I version the RuleTypeField class to make it use this obj_make_compatible?","commit_id":"379b17e5859e2d07ddf4f8e685eda4e41254d006"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fdb8bf811e38aa490013f6ca6dc000ea7b0a93f1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":49,"context_line":"        _target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":50,"context_line":"        if _target_version \u003c (1, 1):"},{"line_number":51,"context_line":"            self.fields[\u0027type\u0027].AUTO_TYPE \u003d obj_fields.Enum("},{"line_number":52,"context_line":"                valid_values\u003d[qos_consts.RULE_TYPE_BANDWIDTH_LIMIT])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_98c73f63","line":51,"in_reply_to":"ba0121b8_f87d9b6d","updated":"2016-04-01 15:23:00.000000000","message":"So what? How are you going to represent the \u0027type\u0027 object with type \u003d\u003d dscp in 1.0?","commit_id":"379b17e5859e2d07ddf4f8e685eda4e41254d006"}],"neutron/services/qos/qos_consts.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ca07798e158201e9e900d3a693c01894ea939b48","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"RULE_TYPE_BANDWIDTH_LIMIT \u003d \u0027bandwidth_limit\u0027"},{"line_number":17,"context_line":"RULE_TYPE_DSCP_MARKING \u003d \u0027dscp_marking\u0027"},{"line_number":18,"context_line":"VALID_RULE_TYPES \u003d [RULE_TYPE_BANDWIDTH_LIMIT, RULE_TYPE_DSCP_MARKING]"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"QOS_POLICY_ID \u003d \u0027qos_policy_id\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_cc5675cd","line":17,"updated":"2016-05-20 10:03:42.000000000","message":"you should probably provide the old constant too, for out of tree plugins referencing that. Note: we probably should move those constants to neutronlib or something like that.","commit_id":"379b17e5859e2d07ddf4f8e685eda4e41254d006"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"58fb9244b8977a94a8a84676530e6fd399293f5b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"RULE_TYPE_BANDWIDTH_LIMIT \u003d \u0027bandwidth_limit\u0027"},{"line_number":17,"context_line":"RULE_TYPE_DSCP_MARKING \u003d \u0027dscp_marking\u0027"},{"line_number":18,"context_line":"VALID_RULE_TYPES \u003d [RULE_TYPE_BANDWIDTH_LIMIT, RULE_TYPE_DSCP_MARKING]"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"QOS_POLICY_ID \u003d \u0027qos_policy_id\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_085ea243","line":17,"in_reply_to":"bab6814e_cc5675cd","updated":"2016-05-20 13:14:10.000000000","message":"Done","commit_id":"379b17e5859e2d07ddf4f8e685eda4e41254d006"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5dd24316fb74de8471386e32c62693dac716abfe","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"RULE_TYPE_BANDWIDTH_LIMIT \u003d \u0027bandwidth_limit\u0027"},{"line_number":17,"context_line":"RULE_TYPE_DSCP_MARK \u003d \u0027dscp_marking\u0027"},{"line_number":18,"context_line":"RULE_TYPE_DSCP_MARKING \u003d \u0027dscp_marking\u0027"},{"line_number":19,"context_line":"VALID_RULE_TYPES \u003d [RULE_TYPE_BANDWIDTH_LIMIT, RULE_TYPE_DSCP_MARKING]"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_46718f43","line":17,"updated":"2016-07-07 06:50:41.000000000","message":"Why do we still need this?","commit_id":"ba8995f07925fb06d217d5a5f503d72eafa6c918"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"4959b49a2b28fac0d70548773cc5e0a4dde83478","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"RULE_TYPE_BANDWIDTH_LIMIT \u003d \u0027bandwidth_limit\u0027"},{"line_number":17,"context_line":"RULE_TYPE_DSCP_MARK \u003d \u0027dscp_marking\u0027"},{"line_number":18,"context_line":"RULE_TYPE_DSCP_MARKING \u003d \u0027dscp_marking\u0027"},{"line_number":19,"context_line":"VALID_RULE_TYPES \u003d [RULE_TYPE_BANDWIDTH_LIMIT, RULE_TYPE_DSCP_MARKING]"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_6eb8dd75","line":17,"in_reply_to":"1aa78d24_46718f43","updated":"2016-07-07 08:41:24.000000000","message":"+1 to kill it","commit_id":"ba8995f07925fb06d217d5a5f503d72eafa6c918"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"818da40c434f6ca44f0719c5be7ca31fed44f8b6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"RULE_TYPE_BANDWIDTH_LIMIT \u003d \u0027bandwidth_limit\u0027"},{"line_number":17,"context_line":"RULE_TYPE_DSCP_MARK \u003d \u0027dscp_marking\u0027"},{"line_number":18,"context_line":"RULE_TYPE_DSCP_MARKING \u003d \u0027dscp_marking\u0027"},{"line_number":19,"context_line":"VALID_RULE_TYPES \u003d [RULE_TYPE_BANDWIDTH_LIMIT, RULE_TYPE_DSCP_MARKING]"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_ce70f10d","line":17,"in_reply_to":"1aa78d24_46718f43","updated":"2016-07-07 08:41:39.000000000","message":"Because this patch hasn\u0027t been merged yet and dscp has been merged people could be using RULE_TYPE_DSCP_MARK.\nI was advised in a previous PS to include both and we could deprecate it next cycle.","commit_id":"ba8995f07925fb06d217d5a5f503d72eafa6c918"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"833762547610f70a3dd284e340eaa875e4646661","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"RULE_TYPE_BANDWIDTH_LIMIT \u003d \u0027bandwidth_limit\u0027"},{"line_number":17,"context_line":"RULE_TYPE_DSCP_MARK \u003d \u0027dscp_marking\u0027"},{"line_number":18,"context_line":"RULE_TYPE_DSCP_MARKING \u003d \u0027dscp_marking\u0027"},{"line_number":19,"context_line":"VALID_RULE_TYPES \u003d [RULE_TYPE_BANDWIDTH_LIMIT, RULE_TYPE_DSCP_MARKING]"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_02e34e34","line":17,"in_reply_to":"1aa78d24_46718f43","updated":"2016-07-11 13:45:56.000000000","message":"Done","commit_id":"ba8995f07925fb06d217d5a5f503d72eafa6c918"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"833762547610f70a3dd284e340eaa875e4646661","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"RULE_TYPE_BANDWIDTH_LIMIT \u003d \u0027bandwidth_limit\u0027"},{"line_number":17,"context_line":"RULE_TYPE_DSCP_MARK \u003d \u0027dscp_marking\u0027"},{"line_number":18,"context_line":"RULE_TYPE_DSCP_MARKING \u003d \u0027dscp_marking\u0027"},{"line_number":19,"context_line":"VALID_RULE_TYPES \u003d [RULE_TYPE_BANDWIDTH_LIMIT, RULE_TYPE_DSCP_MARKING]"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_62d05254","line":17,"in_reply_to":"1aa78d24_6eb8dd75","updated":"2016-07-11 13:45:56.000000000","message":"Done","commit_id":"ba8995f07925fb06d217d5a5f503d72eafa6c918"}],"releasenotes/notes/dscp-qos-77ea9b27d3762e48.yaml":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bb991d2ce61fa4a90477a46348f6e91f97f6fba0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    traffic\u0027s type of service packet header field."},{"line_number":9,"context_line":"  - The Open vSwitch Neutron agent has been extended to mark the Type of"},{"line_number":10,"context_line":"    Service IP header field of packets egressing from the VM when the"},{"line_number":11,"context_line":"    QoS rule has been applied."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1aa78d24_0b8e872d","line":11,"updated":"2016-07-12 14:48:07.000000000","message":"I don\u0027t particularly appreciate how we mix things in a single patch.","commit_id":"1bb95a4554a33eca1705887c2fa3fd19a6faf936"}]}
