)]}'
{"quantum/plugins/nicira/QuantumPlugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"016ad97d0c7c3d7def9aba1ab71fcb44cdb01c3b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"NVP_NOSNAT_RULES_ORDER \u003d 10"},{"line_number":72,"context_line":"NVP_FLOATINGIP_NAT_RULES_ORDER \u003d 224"},{"line_number":73,"context_line":"NVP_EXTGW_NAT_RULES_ORDER \u003d 255"},{"line_number":74,"context_line":"NVP_EXT_PATH \u003d \u0027quantum/plugins/nicira/extensions\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Provider network extension - allowed network types for the NVP Plugin"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2FwGY%3D","line":74,"updated":"2013-05-23 20:46:59.000000000","message":"Consider making this more tolerant of code moves:\n\n\u003d os.path.join(os.path.dirname(__file__), \u0027extensions\u0027)","commit_id":"052b8cd345a0ae081acdf1c21b9c090684506357"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":71,"context_line":"NVP_NOSNAT_RULES_ORDER \u003d 10"},{"line_number":72,"context_line":"NVP_FLOATINGIP_NAT_RULES_ORDER \u003d 224"},{"line_number":73,"context_line":"NVP_EXTGW_NAT_RULES_ORDER \u003d 255"},{"line_number":74,"context_line":"NVP_EXT_PATH \u003d \u0027quantum/plugins/nicira/extensions\u0027"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"# Provider network extension - allowed network types for the NVP Plugin"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Fvd8%3D","line":74,"in_reply_to":"AAAAPH%2F%2FwGY%3D","updated":"2013-05-24 00:20:58.000000000","message":"good point, thanks.","commit_id":"052b8cd345a0ae081acdf1c21b9c090684506357"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # If no api_extensions_path is provided set the following"},{"line_number":183,"context_line":"        if not cfg.CONF.api_extensions_path:"},{"line_number":184,"context_line":"            cfg.CONF.set_override(\u0027api_extensions_path\u0027, NVP_EXT_PATH)"},{"line_number":185,"context_line":"        self.nvp_opts \u003d cfg.CONF.NVP"},{"line_number":186,"context_line":"        self.cluster \u003d create_nvp_cluster(cfg.CONF,"},{"line_number":187,"context_line":"                                          self.nvp_opts.concurrent_connections,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2Fsgg%3D","line":184,"updated":"2013-05-26 05:54:35.000000000","message":"My understanding is that the CONF is read only and that this should be regarded as read only. I Must be honest I am not really sure what the policy is here.","commit_id":"95d7c5052a0192c894f75de0f630f541d2b7326f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        # If no api_extensions_path is provided set the following"},{"line_number":183,"context_line":"        if not cfg.CONF.api_extensions_path:"},{"line_number":184,"context_line":"            cfg.CONF.set_override(\u0027api_extensions_path\u0027, NVP_EXT_PATH)"},{"line_number":185,"context_line":"        self.nvp_opts \u003d cfg.CONF.NVP"},{"line_number":186,"context_line":"        self.cluster \u003d create_nvp_cluster(cfg.CONF,"},{"line_number":187,"context_line":"                                          self.nvp_opts.concurrent_connections,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2FsgI%3D","line":184,"in_reply_to":"AAAAPH%2F%2Fsgg%3D","updated":"2013-05-26 06:21:15.000000000","message":"this overrides only if the config variable is empty, and just to expose nicira extensions. I would find hard to believe a use case where people deployed NVP not to use its extensions, so I see no harm in doing this. In my humble opinion, if CONF is *read only*, then it shouldn\u0027t expose a set_override method :)","commit_id":"95d7c5052a0192c894f75de0f630f541d2b7326f"}]}
