)]}'
{"neutron/tests/unit/agent/linux/openvswitch_firewall/test_firewall.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"92e0ed746b4e453cb6d4334573a0ea257f030b2f","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            priority\u003d90,"},{"line_number":375,"context_line":"            table\u003dovs_consts.LOCAL_SWITCHING)"},{"line_number":376,"context_line":"        filter_rule \u003d mock.call("},{"line_number":377,"context_line":"            actions\u003d\u0027strip_vlan,output:{:d},\u0027"},{"line_number":378,"context_line":"            \u0027ct(commit,zone\u003dNXM_NX_REG6[0..15])\u0027.format(self.port_ofport),"},{"line_number":379,"context_line":"            dl_dst\u003dself.port_mac,"},{"line_number":380,"context_line":"            dl_type\u003d\"0x{:04x}\".format(constants.ETHERTYPE_IP),"},{"line_number":381,"context_line":"            nw_proto\u003dconstants.PROTO_NUM_TCP,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_d884175f","line":378,"range":{"start_line":377,"start_character":11,"end_line":378,"end_character":74},"updated":"2016-04-01 15:20:45.000000000","message":"im not sure about the ordering here.\ndo you have different conntrack zones per tenant? if not you will want to set the packet with the vlan to conntrack first for tenant isolation then strip and output.\n\ni would reverse to \n actions\u003d\u0027ct(commit,zone\u003dNXM_NX_REG6[0..15]),\u0027\n\u0027strip_vlan,output:{:d}\u0027.format(self.port_ofport)","commit_id":"50fd3db3e48b937cd9d818e5422bbeac13bb480a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"490db26a76b4c84025dc36e43f51a0823a9629f4","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            priority\u003d90,"},{"line_number":375,"context_line":"            table\u003dovs_consts.LOCAL_SWITCHING)"},{"line_number":376,"context_line":"        filter_rule \u003d mock.call("},{"line_number":377,"context_line":"            actions\u003d\u0027strip_vlan,output:{:d},\u0027"},{"line_number":378,"context_line":"            \u0027ct(commit,zone\u003dNXM_NX_REG6[0..15])\u0027.format(self.port_ofport),"},{"line_number":379,"context_line":"            dl_dst\u003dself.port_mac,"},{"line_number":380,"context_line":"            dl_type\u003d\"0x{:04x}\".format(constants.ETHERTYPE_IP),"},{"line_number":381,"context_line":"            nw_proto\u003dconstants.PROTO_NUM_TCP,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_930280b2","line":378,"range":{"start_line":377,"start_character":11,"end_line":378,"end_character":74},"in_reply_to":"ba0121b8_d884175f","updated":"2016-04-01 15:41:52.000000000","message":"Done, we have conntrack zones per network.","commit_id":"50fd3db3e48b937cd9d818e5422bbeac13bb480a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"63dee499751551ef32831dd271b8df925f70f178","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            priority\u003d90,"},{"line_number":375,"context_line":"            table\u003dovs_consts.LOCAL_SWITCHING)"},{"line_number":376,"context_line":"        filter_rule \u003d mock.call("},{"line_number":377,"context_line":"            actions\u003d\u0027strip_vlan,output:{:d},\u0027"},{"line_number":378,"context_line":"            \u0027ct(commit,zone\u003dNXM_NX_REG6[0..15])\u0027.format(self.port_ofport),"},{"line_number":379,"context_line":"            dl_dst\u003dself.port_mac,"},{"line_number":380,"context_line":"            dl_type\u003d\"0x{:04x}\".format(constants.ETHERTYPE_IP),"},{"line_number":381,"context_line":"            nw_proto\u003dconstants.PROTO_NUM_TCP,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_78f6ab5d","line":378,"range":{"start_line":377,"start_character":11,"end_line":378,"end_character":74},"in_reply_to":"ba0121b8_d884175f","updated":"2016-04-01 15:28:03.000000000","message":"I agree with that: https://www.opennetworking.org/images/stories/downloads/sdn-resources/onf-specifications/openflow/openflow-spec-v1.4.0.pdf\n\nSection 5.11, \"Action list\":\n\"The actions of an action list are executed in\nthe order specified by the list, and are applied immediately to the packet.\"","commit_id":"50fd3db3e48b937cd9d818e5422bbeac13bb480a"}]}