)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"19b737c4e4999f09a89febea33c6d0a31e82f392","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     venkata anil \u003canil.venkata@enovance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-04 19:45:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"create HA router resources before router creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In this patch we create HA router resources i.e"},{"line_number":10,"context_line":"HA network, HA network ports and vr_id before(and along with)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_7fbf71d0","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":49},"updated":"2016-04-05 04:51:28.000000000","message":"The sentence confused me. Do you want anything like \"Make sure resources for HA router before the router creates\"?","commit_id":"aa2b16b6cf0763af85035c541ca354dfb5ca6627"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"9a3dd82a237ecd15fe90595331d80e6685ffdd36","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     venkata anil \u003canil.venkata@enovance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-04 19:45:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"create HA router resources before router creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In this patch we create HA router resources i.e"},{"line_number":10,"context_line":"HA network, HA network ports and vr_id before(and along with)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_bd3bccea","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":49},"in_reply_to":"9a061dce_7fbf71d0","updated":"2016-04-05 08:51:21.000000000","message":"sure","commit_id":"aa2b16b6cf0763af85035c541ca354dfb5ca6627"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"111a5cb23e57f51d2339c85e8ab051219c412e72","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In this patch we create HA router resources i.e"},{"line_number":10,"context_line":"HA network, HA network ports and vr_id before(and along with)"},{"line_number":11,"context_line":"router creation, so that these resources are available when"},{"line_number":12,"context_line":"agent\u0027s rpc worker tries to sync HA router."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia017ca626ac4d9a818b65ee7f29930594af4f251"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_5af27bd3","line":12,"updated":"2016-04-05 05:43:48.000000000","message":"I\u0027m interested in the \"why\": why should we do this change? what does the switch give us that the current implementation doesn\u0027t?\n\nAlso, note that this will create an inconsistency with update_router(), where it\u0027s possible that the router might pre-exist the HA routers.","commit_id":"aa2b16b6cf0763af85035c541ca354dfb5ca6627"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"0fb21454f42a1c1eca89866396c8f7482e62b1ba","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In this patch we create HA router resources i.e"},{"line_number":10,"context_line":"HA network, HA network ports and vr_id before(and along with)"},{"line_number":11,"context_line":"router creation, so that these resources are available when"},{"line_number":12,"context_line":"agent\u0027s rpc worker tries to sync HA router."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia017ca626ac4d9a818b65ee7f29930594af4f251"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_812139b7","line":12,"in_reply_to":"9a061dce_18e5a636","updated":"2016-04-05 12:42:13.000000000","message":"A few quick notes:\n1) the router status already exists, we\u0027re just giving it extra values and meanings other than the now-always-used \u0027active\u0027 state.\n2) carefully identifying where the router can be accessed sounds like a good (albeit tedious) idea.\n3) the ALLOCATING solution currently fixes multiple issues with the code (and the next patch in the series will fix even more, like clashes between 2 concurrent schedule() calls - look there soon for more details), whereas I\u0027m not yet convinced why this change fixes them.","commit_id":"aa2b16b6cf0763af85035c541ca354dfb5ca6627"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"860c5e95fad566eb47071deaa9fa2cb6936cc4c4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In this patch we create HA router resources i.e"},{"line_number":10,"context_line":"HA network, HA network ports and vr_id before(and along with)"},{"line_number":11,"context_line":"router creation, so that these resources are available when"},{"line_number":12,"context_line":"agent\u0027s rpc worker tries to sync HA router."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia017ca626ac4d9a818b65ee7f29930594af4f251"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_5121c1fa","line":12,"in_reply_to":"9a061dce_5af27bd3","updated":"2016-04-05 07:13:46.000000000","message":"+1","commit_id":"aa2b16b6cf0763af85035c541ca354dfb5ca6627"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"9a3dd82a237ecd15fe90595331d80e6685ffdd36","unresolved":false,"context_lines":[{"line_number":9,"context_line":"In this patch we create HA router resources i.e"},{"line_number":10,"context_line":"HA network, HA network ports and vr_id before(and along with)"},{"line_number":11,"context_line":"router creation, so that these resources are available when"},{"line_number":12,"context_line":"agent\u0027s rpc worker tries to sync HA router."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia017ca626ac4d9a818b65ee7f29930594af4f251"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_18e5a636","line":12,"in_reply_to":"9a061dce_5af27bd3","updated":"2016-04-05 08:51:21.000000000","message":"I have created a bug for this https://bugs.launchpad.net/neutron/+bug/1566194 I feel with \"Add ALLOCATING state to routers\" patch,\n\n1) we are unnecessarily creating a new router status(we can avoid that with this patch)\n2) carefully identify where router can be accessed before its resources are created(and in these places we have to add code to skip the router if status is ALLOCATING).\n3) How code behaves(during its acess to router) when status transitioned from ALLOCATING to ACTIVE\n\nDo u see any issues with https://review.openstack.org/#/c/301316/ ?\n\nIn update_router also, we first create te router resources and then set the router to HA.\nhttps://review.openstack.org/#/c/301316/1/neutron/db/l3_hamode_db.py L588\n\nIn this change, we first create HA router resources then\n1)create router in DB\n2) or update router from legacy to HA(in case of update to HA)","commit_id":"aa2b16b6cf0763af85035c541ca354dfb5ca6627"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"19b737c4e4999f09a89febea33c6d0a31e82f392","unresolved":false,"context_lines":[{"line_number":10,"context_line":"HA network, HA network ports and vr_id before(and along with)"},{"line_number":11,"context_line":"router creation, so that these resources are available when"},{"line_number":12,"context_line":"agent\u0027s rpc worker tries to sync HA router."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia017ca626ac4d9a818b65ee7f29930594af4f251"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_1f96354c","line":13,"updated":"2016-04-05 04:51:28.000000000","message":"Can you file this issue in Launchpad and elaborate the issue there?","commit_id":"aa2b16b6cf0763af85035c541ca354dfb5ca6627"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"111a5cb23e57f51d2339c85e8ab051219c412e72","unresolved":false,"context_lines":[{"line_number":10,"context_line":"HA network, HA network ports and vr_id before(and along with)"},{"line_number":11,"context_line":"router creation, so that these resources are available when"},{"line_number":12,"context_line":"agent\u0027s rpc worker tries to sync HA router."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia017ca626ac4d9a818b65ee7f29930594af4f251"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_3a18671d","line":13,"in_reply_to":"9a061dce_1f96354c","updated":"2016-04-05 05:43:48.000000000","message":"+1","commit_id":"aa2b16b6cf0763af85035c541ca354dfb5ca6627"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"9a3dd82a237ecd15fe90595331d80e6685ffdd36","unresolved":false,"context_lines":[{"line_number":10,"context_line":"HA network, HA network ports and vr_id before(and along with)"},{"line_number":11,"context_line":"router creation, so that these resources are available when"},{"line_number":12,"context_line":"agent\u0027s rpc worker tries to sync HA router."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ia017ca626ac4d9a818b65ee7f29930594af4f251"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_58d55e41","line":13,"in_reply_to":"9a061dce_3a18671d","updated":"2016-04-05 08:51:21.000000000","message":"sure","commit_id":"aa2b16b6cf0763af85035c541ca354dfb5ca6627"}],"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"883bfbe63648baaf0152425e77c9296db1ba2aa5","unresolved":false,"context_lines":[{"line_number":499,"context_line":"                tenant_id \u003d router[\u0027router\u0027][\u0027tenant_id\u0027]"},{"line_number":500,"context_line":"                router_id \u003d uuidutils.generate_uuid()"},{"line_number":501,"context_line":"                router[\u0027router\u0027][\u0027id\u0027] \u003d router_id"},{"line_number":502,"context_line":"                ha_network \u003d self._create_ha_interfaces_and_ensure_network("},{"line_number":503,"context_line":"                    context, router_id, tenant_id)[1]"},{"line_number":504,"context_line":"                ha_vr_id \u003d self._allocate_vr_id("},{"line_number":505,"context_line":"                    context, ha_network.network_id, router_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_a1271d11","line":502,"range":{"start_line":502,"start_character":34,"end_line":502,"end_character":74},"updated":"2016-04-05 12:42:24.000000000","message":"This calls \u0027_create_ha_port\u0027 down the line, which accepts a router_id and sets the device_id to be some router_id. I don\u0027t like the fact that the port is created and associated to some \u0027fake\u0027 uuid, which will have meaning only when a router with the same ID will be created.\n\nIn case the process crashes somewhere in these lines (with a \u0027kill -9\u0027 for example), this will leave completely orphaned ports which the code won\u0027t be able to detect and delete once it\u0027s back on.","commit_id":"29f08f44a962bdeeb5dcb2dd3485c252f0f32585"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"a113b1b48787c0e23a41d1e590880d666e8c07ed","unresolved":false,"context_lines":[{"line_number":499,"context_line":"                tenant_id \u003d router[\u0027router\u0027][\u0027tenant_id\u0027]"},{"line_number":500,"context_line":"                router_id \u003d uuidutils.generate_uuid()"},{"line_number":501,"context_line":"                router[\u0027router\u0027][\u0027id\u0027] \u003d router_id"},{"line_number":502,"context_line":"                ha_network \u003d self._create_ha_interfaces_and_ensure_network("},{"line_number":503,"context_line":"                    context, router_id, tenant_id)[1]"},{"line_number":504,"context_line":"                ha_vr_id \u003d self._allocate_vr_id("},{"line_number":505,"context_line":"                    context, ha_network.network_id, router_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_c0d2d9ff","line":502,"range":{"start_line":502,"start_character":34,"end_line":502,"end_character":74},"in_reply_to":"9a061dce_a1271d11","updated":"2016-04-06 08:51:35.000000000","message":"agree with you.","commit_id":"29f08f44a962bdeeb5dcb2dd3485c252f0f32585"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"883bfbe63648baaf0152425e77c9296db1ba2aa5","unresolved":false,"context_lines":[{"line_number":503,"context_line":"                    context, router_id, tenant_id)[1]"},{"line_number":504,"context_line":"                ha_vr_id \u003d self._allocate_vr_id("},{"line_number":505,"context_line":"                    context, ha_network.network_id, router_id)"},{"line_number":506,"context_line":"                router[\u0027router\u0027][\u0027ha_vr_id\u0027] \u003d ha_vr_id"},{"line_number":507,"context_line":"            except Exception:"},{"line_number":508,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":509,"context_line":"                    return"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_61422512","line":506,"range":{"start_line":506,"start_character":34,"end_line":506,"end_character":42},"updated":"2016-04-05 12:42:24.000000000","message":"I\u0027m not sure this is enough to replace the call to _set_vr_id (ie. i\u0027m not sure this is setting the correct attribute).","commit_id":"29f08f44a962bdeeb5dcb2dd3485c252f0f32585"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"a113b1b48787c0e23a41d1e590880d666e8c07ed","unresolved":false,"context_lines":[{"line_number":503,"context_line":"                    context, router_id, tenant_id)[1]"},{"line_number":504,"context_line":"                ha_vr_id \u003d self._allocate_vr_id("},{"line_number":505,"context_line":"                    context, ha_network.network_id, router_id)"},{"line_number":506,"context_line":"                router[\u0027router\u0027][\u0027ha_vr_id\u0027] \u003d ha_vr_id"},{"line_number":507,"context_line":"            except Exception:"},{"line_number":508,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":509,"context_line":"                    return"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_00c69147","line":506,"range":{"start_line":506,"start_character":34,"end_line":506,"end_character":42},"in_reply_to":"9a061dce_61422512","updated":"2016-04-06 08:51:35.000000000","message":"it is setting attribute properly.","commit_id":"29f08f44a962bdeeb5dcb2dd3485c252f0f32585"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"883bfbe63648baaf0152425e77c9296db1ba2aa5","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                    return"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        router_dict \u003d super(L3_HA_NAT_db_mixin,"},{"line_number":512,"context_line":"                            self).create_router(context, router)"},{"line_number":513,"context_line":"        if is_ha:"},{"line_number":514,"context_line":"            try:"},{"line_number":515,"context_line":"                # todo: _notify_ha_interfaces_updated shouldn\u0027t raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_81fe5936","line":512,"range":{"start_line":512,"start_character":34,"end_line":512,"end_character":47},"updated":"2016-04-05 12:42:24.000000000","message":"If there\u0027s an exception while creating the router (for whatever reason), this patch changes the behaviour - whereas today no HA resources will be created, this patch already added them. In other words, in cases of exceptions the resources should be cleaned.","commit_id":"29f08f44a962bdeeb5dcb2dd3485c252f0f32585"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5861ce333a4eb9ac1b2902ac5daa6c1a3dc51105","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                    return"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        router_dict \u003d super(L3_HA_NAT_db_mixin,"},{"line_number":512,"context_line":"                            self).create_router(context, router)"},{"line_number":513,"context_line":"        if is_ha:"},{"line_number":514,"context_line":"            try:"},{"line_number":515,"context_line":"                # todo: _notify_ha_interfaces_updated shouldn\u0027t raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_bbd0af20","line":512,"range":{"start_line":512,"start_character":34,"end_line":512,"end_character":47},"in_reply_to":"9a061dce_80e90183","updated":"2016-04-06 10:38:26.000000000","message":"That\u0027s probably a good idea if we want to conserve as much as the original code\u0027s behaviour.","commit_id":"29f08f44a962bdeeb5dcb2dd3485c252f0f32585"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"a113b1b48787c0e23a41d1e590880d666e8c07ed","unresolved":false,"context_lines":[{"line_number":509,"context_line":"                    return"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"        router_dict \u003d super(L3_HA_NAT_db_mixin,"},{"line_number":512,"context_line":"                            self).create_router(context, router)"},{"line_number":513,"context_line":"        if is_ha:"},{"line_number":514,"context_line":"            try:"},{"line_number":515,"context_line":"                # todo: _notify_ha_interfaces_updated shouldn\u0027t raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_80e90183","line":512,"range":{"start_line":512,"start_character":34,"end_line":512,"end_character":47},"in_reply_to":"9a061dce_81fe5936","updated":"2016-04-06 08:51:35.000000000","message":"I am not sure about exception here, because \n\nrouter_dict \u003d super(L3_HA_NAT_db_mixin,\n                            self).create_router(context, router)\n\nthese lines(in original code) are never under try block.\nIf you think so, we can move this under try.. block and do cleanup.","commit_id":"29f08f44a962bdeeb5dcb2dd3485c252f0f32585"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"883bfbe63648baaf0152425e77c9296db1ba2aa5","unresolved":false,"context_lines":[{"line_number":512,"context_line":"                            self).create_router(context, router)"},{"line_number":513,"context_line":"        if is_ha:"},{"line_number":514,"context_line":"            try:"},{"line_number":515,"context_line":"                # todo: _notify_ha_interfaces_updated shouldn\u0027t raise"},{"line_number":516,"context_line":"                # exceptions"},{"line_number":517,"context_line":"                self._notify_ha_interfaces_updated(context, router_id)"},{"line_number":518,"context_line":"            except Exception:"},{"line_number":519,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_01c089df","line":516,"range":{"start_line":515,"start_character":16,"end_line":516,"end_character":28},"updated":"2016-04-05 12:42:24.000000000","message":"Why not?","commit_id":"29f08f44a962bdeeb5dcb2dd3485c252f0f32585"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"a113b1b48787c0e23a41d1e590880d666e8c07ed","unresolved":false,"context_lines":[{"line_number":512,"context_line":"                            self).create_router(context, router)"},{"line_number":513,"context_line":"        if is_ha:"},{"line_number":514,"context_line":"            try:"},{"line_number":515,"context_line":"                # todo: _notify_ha_interfaces_updated shouldn\u0027t raise"},{"line_number":516,"context_line":"                # exceptions"},{"line_number":517,"context_line":"                self._notify_ha_interfaces_updated(context, router_id)"},{"line_number":518,"context_line":"            except Exception:"},{"line_number":519,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_20c0f5df","line":516,"range":{"start_line":515,"start_character":16,"end_line":516,"end_character":28},"in_reply_to":"9a061dce_01c089df","updated":"2016-04-06 08:51:35.000000000","message":"I want to add in todo that you have separate patches for addressing these exceptions :)","commit_id":"29f08f44a962bdeeb5dcb2dd3485c252f0f32585"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5861ce333a4eb9ac1b2902ac5daa6c1a3dc51105","unresolved":false,"context_lines":[{"line_number":512,"context_line":"                            self).create_router(context, router)"},{"line_number":513,"context_line":"        if is_ha:"},{"line_number":514,"context_line":"            try:"},{"line_number":515,"context_line":"                # todo: _notify_ha_interfaces_updated shouldn\u0027t raise"},{"line_number":516,"context_line":"                # exceptions"},{"line_number":517,"context_line":"                self._notify_ha_interfaces_updated(context, router_id)"},{"line_number":518,"context_line":"            except Exception:"},{"line_number":519,"context_line":"                with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_9b94cb43","line":516,"range":{"start_line":515,"start_character":16,"end_line":516,"end_character":28},"in_reply_to":"9a061dce_20c0f5df","updated":"2016-04-06 10:38:26.000000000","message":"OK. So the TODO note needs to be a bit clearer on the subject (and it should match other TODO comments in the code:\n\n#TODO(anilvenkata): ...","commit_id":"29f08f44a962bdeeb5dcb2dd3485c252f0f32585"}]}
