)]}'
{"neutron/api/v2/base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6e5d2dacf0dd808c7904dfe676107a30f57687ce","unresolved":false,"context_lines":[{"line_number":263,"context_line":"        pagination_helper.update_fields(original_fields, fields_to_add)"},{"line_number":264,"context_line":"        if parent_id:"},{"line_number":265,"context_line":"            kwargs[self._parent_id_name] \u003d parent_id"},{"line_number":266,"context_line":"        LOG.warning(\"helper \u003d %s, kwargs \u003d %s\", sorting_helper, kwargs)"},{"line_number":267,"context_line":"        obj_getter \u003d getattr(self._plugin, self._plugin_handlers[self.LIST])"},{"line_number":268,"context_line":"        obj_list \u003d obj_getter(request.context, **kwargs)"},{"line_number":269,"context_line":"        obj_list \u003d sorting_helper.sort(obj_list)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_37134bba","line":266,"updated":"2016-04-05 13:09:27.000000000","message":"meh","commit_id":"374e301ef59fead002f962d618c77a9959a09f77"}],"neutron/common/config.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"9b7d7413956cd8a34693664f290f68cd1e3102f5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027allow_bulk\u0027, default\u003dTrue,"},{"line_number":67,"context_line":"                help\u003d_(\"Allow the usage of the bulk API\")),"},{"line_number":68,"context_line":"    cfg.BoolOpt(\u0027allow_pagination\u0027, default\u003dTrue,"},{"line_number":69,"context_line":"                help\u003d_(\"Allow the usage of the pagination\")),"},{"line_number":70,"context_line":"    cfg.BoolOpt(\u0027allow_sorting\u0027, default\u003dTrue,"},{"line_number":71,"context_line":"                help\u003d_(\"Allow the usage of the sorting\")),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027pagination_max_limit\u0027, default\u003d\"-1\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_d2d77deb","line":69,"range":{"start_line":69,"start_character":24,"end_line":69,"end_character":57},"updated":"2016-04-05 13:36:58.000000000","message":"I think that the description of this help is poor, I should be better to have something like \"Enable pagination of the information retrieved.  Page size will be defined on pagination_max_limit configuration value\"","commit_id":"374e301ef59fead002f962d618c77a9959a09f77"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0035898e7783741cd0db9b5272cf3a6f3947ecdb","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    cfg.BoolOpt(\u0027allow_bulk\u0027, default\u003dTrue,"},{"line_number":67,"context_line":"                help\u003d_(\"Allow the usage of the bulk API\")),"},{"line_number":68,"context_line":"    cfg.BoolOpt(\u0027allow_pagination\u0027, default\u003dTrue,"},{"line_number":69,"context_line":"                help\u003d_(\"Allow the usage of the pagination\")),"},{"line_number":70,"context_line":"    cfg.BoolOpt(\u0027allow_sorting\u0027, default\u003dTrue,"},{"line_number":71,"context_line":"                help\u003d_(\"Allow the usage of the sorting\")),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027pagination_max_limit\u0027, default\u003d\"-1\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_b0a2aaac","line":69,"range":{"start_line":69,"start_character":24,"end_line":69,"end_character":57},"in_reply_to":"9a061dce_d2d77deb","updated":"2016-04-05 19:45:04.000000000","message":"You are welcome to work on a patch to fix that, if you think it\u0027s worth it. :) I prefer to just deprecate and remove it eventually.","commit_id":"374e301ef59fead002f962d618c77a9959a09f77"}],"neutron/tests/api/base.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"c63b25b1b31f6d284794792216c17d8dc974faa4","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    # under testing"},{"line_number":462,"context_line":"    resource \u003d None"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    resource_names \u003d (\u0027test1\u0027, \u0027abc1\u0027, \u0027test10\u0027, \u0027123test\u0027)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    force_tenant_isolation \u003d True"},{"line_number":467,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_1807fd18","line":464,"range":{"start_line":464,"start_character":23,"end_line":464,"end_character":28},"updated":"2016-04-07 15:00:50.000000000","message":"What about a duplicated item? it\u0027s going to cause an error or just order them in an indistinct way?","commit_id":"1b6a52a3e27df38b92d8271d9f58e25e60a942f7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b8bdfda4eb2a63fe3b33ae745d057d36a63e8588","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    # under testing"},{"line_number":462,"context_line":"    resource \u003d None"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    resource_names \u003d (\u0027test1\u0027, \u0027abc1\u0027, \u0027test10\u0027, \u0027123test\u0027)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    force_tenant_isolation \u003d True"},{"line_number":467,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_6d156a9a","line":464,"range":{"start_line":464,"start_character":23,"end_line":464,"end_character":28},"in_reply_to":"9a061dce_1807fd18","updated":"2016-04-07 15:04:31.000000000","message":"The latter. But let\u0027s test it!","commit_id":"1b6a52a3e27df38b92d8271d9f58e25e60a942f7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"09abf75e23b77ee4ad1719cebc6132b6a26d8a21","unresolved":false,"context_lines":[{"line_number":461,"context_line":"    # under testing"},{"line_number":462,"context_line":"    resource \u003d None"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    resource_names \u003d (\u0027test1\u0027, \u0027abc1\u0027, \u0027test10\u0027, \u0027123test\u0027)"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"    force_tenant_isolation \u003d True"},{"line_number":467,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9a061dce_00c3d557","line":464,"range":{"start_line":464,"start_character":23,"end_line":464,"end_character":28},"in_reply_to":"9a061dce_6d156a9a","updated":"2016-04-07 15:17:44.000000000","message":"Done","commit_id":"1b6a52a3e27df38b92d8271d9f58e25e60a942f7"}],"neutron/tests/api/test_networks.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"9b7d7413956cd8a34693664f290f68cd1e3102f5","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # (_) are sorted differently depending on whether the plugin implements"},{"line_number":101,"context_line":"        # native sorting support, or not. So we avoid any such cases here,"},{"line_number":102,"context_line":"        # sticking to alphanumeric."},{"line_number":103,"context_line":"        for name in (\u0027test1\u0027, \u0027abc1\u0027, \u0027test10\u0027, \u0027123test\u0027):"},{"line_number":104,"context_line":"            self.create_network(network_name\u003dname)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        sort_args \u003d {"},{"line_number":107,"context_line":"            \u0027sort_dir\u0027: direction,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_cdffe0a8","line":104,"range":{"start_line":103,"start_character":8,"end_line":104,"end_character":50},"updated":"2016-04-05 13:36:58.000000000","message":"These lines seem to be common among some tests.","commit_id":"374e301ef59fead002f962d618c77a9959a09f77"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"9b7d7413956cd8a34693664f290f68cd1e3102f5","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        for name in names:"},{"line_number":134,"context_line":"            self.create_network(network_name\u003dname)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        for limit in range(1, len(names) + 1):"},{"line_number":137,"context_line":"            pagination_args \u003d {"},{"line_number":138,"context_line":"                \u0027limit\u0027: limit,"},{"line_number":139,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_8dc0487e","line":136,"range":{"start_line":136,"start_character":27,"end_line":136,"end_character":44},"updated":"2016-04-05 13:36:58.000000000","message":"Is it necessary to evaluate all the possible cases?\nWhat about if the limit is 0 or negative?","commit_id":"374e301ef59fead002f962d618c77a9959a09f77"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8dce9941cc732b624c83f2a22f9a891b80750776","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        for name in names:"},{"line_number":134,"context_line":"            self.create_network(network_name\u003dname)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        for limit in range(1, len(names) + 1):"},{"line_number":137,"context_line":"            pagination_args \u003d {"},{"line_number":138,"context_line":"                \u0027limit\u0027: limit,"},{"line_number":139,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_c03d5d2c","line":136,"range":{"start_line":136,"start_character":27,"end_line":136,"end_character":44},"in_reply_to":"9a061dce_8dc0487e","updated":"2016-04-07 15:17:36.000000000","message":"Added testing for limit \u003d 0","commit_id":"374e301ef59fead002f962d618c77a9959a09f77"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"dcdd5d8e6c060b9df0f9d2032ac9cebe685435d1","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":123,"context_line":"    @test.idempotent_id(\u002779a52810-2156-4ab6-b577-9e46e58d4b58\u0027)"},{"line_number":124,"context_line":"    def _test_list_pagination_page_reverse(self):"},{"line_number":125,"context_line":"        self._test_list_pagination_page_reverse()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_8d0c833c","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":9},"updated":"2016-04-06 14:32:57.000000000","message":"Remove leading underscore or test won\u0027t run.","commit_id":"bcc135c6630dc7ca414f408fef8bde333febafbb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d9427e4617084f4cb03a32503ad150bc11a1ed8f","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":123,"context_line":"    @test.idempotent_id(\u002779a52810-2156-4ab6-b577-9e46e58d4b58\u0027)"},{"line_number":124,"context_line":"    def _test_list_pagination_page_reverse(self):"},{"line_number":125,"context_line":"        self._test_list_pagination_page_reverse()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_8db3e3e8","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":9},"in_reply_to":"9a061dce_8d0c833c","updated":"2016-04-06 14:36:40.000000000","message":"Ouch.","commit_id":"bcc135c6630dc7ca414f408fef8bde333febafbb"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cdb4afe1d4465f9afebf6f84095d1f2e75029d8b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"class NetworksSearchCriteriaTest(base.BaseSearchCriteriaTest):"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    resource \u003d \u0027network\u0027"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":103,"context_line":"    @test.idempotent_id(\u0027de27d34a-bd9d-4516-83d6-81ef723f7d0d\u0027)"},{"line_number":104,"context_line":"    def test_list_sorts_asc(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_a33af3e4","line":101,"updated":"2016-04-07 15:28:46.000000000","message":"Can the test methods live entirely in the base class so you just have to define the resource?","commit_id":"01de08a0404ff185be7f83180e6abe1b825d0f88"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"77680bfbd8287e578fa2fdeab10030a950b02331","unresolved":false,"context_lines":[{"line_number":98,"context_line":"class NetworksSearchCriteriaTest(base.BaseSearchCriteriaTest):"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    resource \u003d \u0027network\u0027"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":103,"context_line":"    @test.idempotent_id(\u0027de27d34a-bd9d-4516-83d6-81ef723f7d0d\u0027)"},{"line_number":104,"context_line":"    def test_list_sorts_asc(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_f9e1382b","line":101,"in_reply_to":"9a061dce_a33af3e4","updated":"2016-04-07 15:43:44.000000000","message":"I keep them here because I need to define stable IDs for each test case.","commit_id":"01de08a0404ff185be7f83180e6abe1b825d0f88"}],"neutron/tests/contrib/gate_hook.sh":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"afe615c872f201e54c0dd8948dcfddd17fff8747","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"[DEFAULT]"},{"line_number":49,"context_line":"allow_sorting\u003dTrue"},{"line_number":50,"context_line":"allow_pagination\u003dTrue"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"EOF"},{"line_number":53,"context_line":"    if [ \"$VENV\" \u003d\u003d \"api-pecan\" -o \"$VENV\" \u003d\u003d \"full-pecan\" ]"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a061dce_a7f711f4","line":50,"updated":"2016-04-05 20:25:09.000000000","message":"Can you touch a non-test source file so we can see the results of some tempest jobs?","commit_id":"a826eaf021c9fdbf10e2f0b71897487096a5fbef"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"49222056ccfadb7cd309532bd51fba93a18f13a9","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"[DEFAULT]"},{"line_number":49,"context_line":"allow_sorting\u003dTrue"},{"line_number":50,"context_line":"allow_pagination\u003dTrue"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"EOF"},{"line_number":53,"context_line":"    if [ \"$VENV\" \u003d\u003d \"api-pecan\" -o \"$VENV\" \u003d\u003d \"full-pecan\" ]"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a061dce_6730599f","line":50,"in_reply_to":"9a061dce_a7f711f4","updated":"2016-04-05 20:29:44.000000000","message":"I pushed https://review.openstack.org/301900 to test it.","commit_id":"a826eaf021c9fdbf10e2f0b71897487096a5fbef"}]}
