)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds several unit tests that verify a floating IP\u0027s DNS"},{"line_number":10,"context_line":"information is properly sent to the external DNS service in all cases"},{"line_number":11,"context_line":"where a new DNS recordset would need to be created."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: If9bdfa31624bbf0c403f0c447a9e75978bde172d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a061dce_801b9372","line":11,"updated":"2016-04-06 21:40:39.000000000","message":"What we are testing is that record sets are created and deleted from the external dns service based on the floating ip and its associated port data","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"}],"neutron/tests/unit/extensions/test_l3.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import contextlib"},{"line_number":18,"context_line":"import copy"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import jsonutils"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"import netaddr"},{"line_number":23,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_32d022f6","line":20,"updated":"2016-04-06 21:40:39.000000000","message":"This import is wrong. If you wanted to import it, you should be importing:\n\nfrom oslo_serialization import jsonutils\n\nBut you don\u0027t really need to import this either. Please remove this import and look my comments below","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import contextlib"},{"line_number":18,"context_line":"import copy"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import jsonutils"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"import netaddr"},{"line_number":23,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_1203d90e","line":20,"in_reply_to":"9a061dce_32d022f6","updated":"2016-04-08 19:33:56.000000000","message":"Done, thanks for the info!","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class L3NatExtensionTestCase(test_extensions_base.ExtensionTestCase):"},{"line_number":91,"context_line":"    fmt \u003d \u0027jsonutils\u0027"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def setUp(self):"},{"line_number":94,"context_line":"        super(L3NatExtensionTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_32f7828c","line":91,"updated":"2016-04-06 21:40:39.000000000","message":"Please return this to its original value:\n\nfmt \u003d \u0027json\u0027","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class L3NatExtensionTestCase(test_extensions_base.ExtensionTestCase):"},{"line_number":91,"context_line":"    fmt \u003d \u0027jsonutils\u0027"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def setUp(self):"},{"line_number":94,"context_line":"        super(L3NatExtensionTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_bf0bd62a","line":91,"in_reply_to":"9a061dce_32f7828c","updated":"2016-04-08 19:33:56.000000000","message":"Done, unintended consequence of a bad search/replace","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3222,"context_line":"                                L3NatDBTestCaseMixin):"},{"line_number":3223,"context_line":"    \"\"\"Unit tests for floating ip functionality.\"\"\""},{"line_number":3224,"context_line":""},{"line_number":3225,"context_line":"    fmt \u003d \u0027jsonutils\u0027"},{"line_number":3226,"context_line":"    DNSNAME \u003d \u0027test\u0027"},{"line_number":3227,"context_line":"    DNSDOMAIN \u003d \u0027test-domain.org.\u0027"},{"line_number":3228,"context_line":"    PUBLIC_CIDR \u003d \u002711.0.0.0/24\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_5204b648","line":3225,"updated":"2016-04-06 21:40:39.000000000","message":"This should be:\n\nfmt \u003d \u0027json\u0027","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3222,"context_line":"                                L3NatDBTestCaseMixin):"},{"line_number":3223,"context_line":"    \"\"\"Unit tests for floating ip functionality.\"\"\""},{"line_number":3224,"context_line":""},{"line_number":3225,"context_line":"    fmt \u003d \u0027jsonutils\u0027"},{"line_number":3226,"context_line":"    DNSNAME \u003d \u0027test\u0027"},{"line_number":3227,"context_line":"    DNSDOMAIN \u003d \u0027test-domain.org.\u0027"},{"line_number":3228,"context_line":"    PUBLIC_CIDR \u003d \u002711.0.0.0/24\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_ff2eeea3","line":3225,"in_reply_to":"9a061dce_5204b648","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3229,"context_line":"    PRIVATE_CIDR \u003d \u002710.0.0.0/24\u0027"},{"line_number":3230,"context_line":"    mock_client \u003d mock.MagicMock()"},{"line_number":3231,"context_line":"    mock_admin_client \u003d mock.MagicMock()"},{"line_number":3232,"context_line":"    mock_path \u003d \u0027neutron.services.externaldns.drivers.\u0027 +\\"},{"line_number":3233,"context_line":"                \u0027designate.driver.get_clients\u0027"},{"line_number":3234,"context_line":"    mock_config \u003d {\u0027return_value\u0027: (mock_client, mock_admin_client)}"},{"line_number":3235,"context_line":"    _extension_drivers \u003d [\u0027dns\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_af832855","line":3232,"updated":"2016-04-06 21:40:39.000000000","message":"Please don\u0027t use \u0027\\\u0027 to continue your lines","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3229,"context_line":"    PRIVATE_CIDR \u003d \u002710.0.0.0/24\u0027"},{"line_number":3230,"context_line":"    mock_client \u003d mock.MagicMock()"},{"line_number":3231,"context_line":"    mock_admin_client \u003d mock.MagicMock()"},{"line_number":3232,"context_line":"    mock_path \u003d \u0027neutron.services.externaldns.drivers.\u0027 +\\"},{"line_number":3233,"context_line":"                \u0027designate.driver.get_clients\u0027"},{"line_number":3234,"context_line":"    mock_config \u003d {\u0027return_value\u0027: (mock_client, mock_admin_client)}"},{"line_number":3235,"context_line":"    _extension_drivers \u003d [\u0027dns\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_1f1c8276","line":3232,"in_reply_to":"9a061dce_af832855","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3273,"context_line":"                                        **kwargs)"},{"line_number":3274,"context_line":""},{"line_number":3275,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3276,"context_line":"    def test_floating_ip_create(self, *mocks):"},{"line_number":3277,"context_line":"        with self.network() as n,\\"},{"line_number":3278,"context_line":"                self.subnet(cidr\u003dself.PUBLIC_CIDR, network\u003dn):"},{"line_number":3279,"context_line":"            data \u003d {\u0027floatingip\u0027: {\u0027floating_network_id\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_3d1f5309","line":3276,"updated":"2016-04-06 21:40:39.000000000","message":"This test case would be useful if you tested that the external dns service was not called","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3273,"context_line":"                                        **kwargs)"},{"line_number":3274,"context_line":""},{"line_number":3275,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3276,"context_line":"    def test_floating_ip_create(self, *mocks):"},{"line_number":3277,"context_line":"        with self.network() as n,\\"},{"line_number":3278,"context_line":"                self.subnet(cidr\u003dself.PUBLIC_CIDR, network\u003dn):"},{"line_number":3279,"context_line":"            data \u003d {\u0027floatingip\u0027: {\u0027floating_network_id\u0027:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_f233c5f4","line":3276,"in_reply_to":"9a061dce_3d1f5309","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3286,"context_line":""},{"line_number":3287,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3288,"context_line":"    def test_floating_ip_create_with_dns(self, *mocks):"},{"line_number":3289,"context_line":"        with self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub:"},{"line_number":3290,"context_line":"            data \u003d {\u0027floatingip\u0027: {\u0027floating_network_id\u0027:"},{"line_number":3291,"context_line":"                                   public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":3292,"context_line":"                                   \u0027tenant_id\u0027: _uuid(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_2c28c6e1","line":3289,"updated":"2016-04-06 21:40:39.000000000","message":"You keep repeating in all the test cases the same (or similar) code to setup subnets, routers, ports etc. You have methods in L3NatTestCaseMixin (from which you inherit) like floatingip_with_assoc that take care of all of that. If they don\u0027t fit you perfectly, just redefine them like you cleverly did with _create_network and _create_port above. Your method(s) should:\n\ncreate network\ncreate subnet\nset network public\ncreate router\nset router gateway\nset router interface\ncreate the floating ip\nassert the floating ip was created correctly\ndeserialize the floating ip response\nreturn just the floating ip dictionary (i.e. self.deserialize(self.fmt, res)[\u0027floatingip\u0027])\n\nJust settle on as few alternatives as possible that can support your test cases","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3286,"context_line":""},{"line_number":3287,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3288,"context_line":"    def test_floating_ip_create_with_dns(self, *mocks):"},{"line_number":3289,"context_line":"        with self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub:"},{"line_number":3290,"context_line":"            data \u003d {\u0027floatingip\u0027: {\u0027floating_network_id\u0027:"},{"line_number":3291,"context_line":"                                   public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":3292,"context_line":"                                   \u0027tenant_id\u0027: _uuid(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_f24aa554","line":3289,"in_reply_to":"9a061dce_2c28c6e1","updated":"2016-04-08 19:33:56.000000000","message":"Agreed, this was definitely in need of a refactor. Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3299,"context_line":"        # The recordsets.create function should be called with:"},{"line_number":3300,"context_line":"        # dns_domain, dns_name, \u0027A\u0027, ip_address (\u0027A\u0027 for IPv4, \u0027AAAA\u0027 for IPv6)"},{"line_number":3301,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3302,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3303,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3304,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3305,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_6fc2b035","line":3302,"updated":"2016-04-06 21:40:39.000000000","message":"Why mock.ANY? You have all the data to test for specific values in these two arguments. The first one is the record type, with is \u0027A\u0027 for IPv4 and \u0027AAAA\u0027 for IPv6. The second one is the floatingip ip address\n\nAlso, I don\u0027t see that you are checking the PTR records. They also should be tested","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3299,"context_line":"        # The recordsets.create function should be called with:"},{"line_number":3300,"context_line":"        # dns_domain, dns_name, \u0027A\u0027, ip_address (\u0027A\u0027 for IPv4, \u0027AAAA\u0027 for IPv6)"},{"line_number":3301,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3302,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3303,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3304,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3305,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_726df5cb","line":3302,"in_reply_to":"9a061dce_6fc2b035","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3301,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3302,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3303,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3304,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3305,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"},{"line_number":3306,"context_line":"        self.assertEqual(dns_name, self.DNSNAME)"},{"line_number":3307,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_92e3eea3","line":3304,"updated":"2016-04-06 21:40:39.000000000","message":"You inherit method self.deserialize, so you don\u0027t need jsonutils in lines 3303 and 3304. Just do:\n\nfloatingip \u003d self.deserialize(self.fmt, res)[\u0027floatingip\u0027]\n\nand then you can access the dns_domain and dns_name attributes as:\n\nfloatingip[\u0027dns_domain\u0027]\nfloatingip[\u0027dns_name\u0027]","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3301,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3302,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3303,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3304,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3305,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"},{"line_number":3306,"context_line":"        self.assertEqual(dns_name, self.DNSNAME)"},{"line_number":3307,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_926409e6","line":3304,"in_reply_to":"9a061dce_92e3eea3","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3306,"context_line":"        self.assertEqual(dns_name, self.DNSNAME)"},{"line_number":3307,"context_line":""},{"line_number":3308,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3309,"context_line":"    def test_floating_ip_create_with_inherited_dns(self, *mocks):"},{"line_number":3310,"context_line":"        config.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNSDOMAIN)"},{"line_number":3311,"context_line":"        with self.network(dns_domain\u003dself.DNSDOMAIN) as n,\\"},{"line_number":3312,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub,\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_05cdd584","line":3309,"updated":"2016-04-06 21:40:39.000000000","message":"\u0027inherited\u0027 is not reflective of what is being tested here. You are testing that when the floatingip doesn\u0027t have dns_name and dns_domain, then, it the associated port has does attributes, they are sent to the external dns service. I suggest changing the name to reflect this","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3306,"context_line":"        self.assertEqual(dns_name, self.DNSNAME)"},{"line_number":3307,"context_line":""},{"line_number":3308,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3309,"context_line":"    def test_floating_ip_create_with_inherited_dns(self, *mocks):"},{"line_number":3310,"context_line":"        config.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNSDOMAIN)"},{"line_number":3311,"context_line":"        with self.network(dns_domain\u003dself.DNSDOMAIN) as n,\\"},{"line_number":3312,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub,\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_329a5dc6","line":3309,"in_reply_to":"9a061dce_05cdd584","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3308,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3309,"context_line":"    def test_floating_ip_create_with_inherited_dns(self, *mocks):"},{"line_number":3310,"context_line":"        config.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNSDOMAIN)"},{"line_number":3311,"context_line":"        with self.network(dns_domain\u003dself.DNSDOMAIN) as n,\\"},{"line_number":3312,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub,\\"},{"line_number":3313,"context_line":"                self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub,\\"},{"line_number":3314,"context_line":"                self.port(private_sub, dns_name\u003dself.DNSNAME) as p,\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_6c1e3ebc","line":3311,"updated":"2016-04-06 21:40:39.000000000","message":"See my comment to line 3289\nPlease don\u0027t use \u0027\\\u0027 to continue your lines","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3308,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3309,"context_line":"    def test_floating_ip_create_with_inherited_dns(self, *mocks):"},{"line_number":3310,"context_line":"        config.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNSDOMAIN)"},{"line_number":3311,"context_line":"        with self.network(dns_domain\u003dself.DNSDOMAIN) as n,\\"},{"line_number":3312,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub,\\"},{"line_number":3313,"context_line":"                self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub,\\"},{"line_number":3314,"context_line":"                self.port(private_sub, dns_name\u003dself.DNSNAME) as p,\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_129f59b5","line":3311,"in_reply_to":"9a061dce_6c1e3ebc","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3330,"context_line":"            res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3331,"context_line":"        self.assertEqual(201, res.status_code)"},{"line_number":3332,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3333,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3334,"context_line":""},{"line_number":3335,"context_line":"    # If both network+port and the floating ip have dns domain and dns name,"},{"line_number":3336,"context_line":"    # floating ip\u0027s information should take priority"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_4fd6ccf1","line":3333,"updated":"2016-04-06 21:40:39.000000000","message":"See my comment for line 3302","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3330,"context_line":"            res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3331,"context_line":"        self.assertEqual(201, res.status_code)"},{"line_number":3332,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3333,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3334,"context_line":""},{"line_number":3335,"context_line":"    # If both network+port and the floating ip have dns domain and dns name,"},{"line_number":3336,"context_line":"    # floating ip\u0027s information should take priority"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_52a9d1de","line":3333,"in_reply_to":"9a061dce_4fd6ccf1","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3337,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3338,"context_line":"    def test_floating_ip_create_with_conflicting_dns(self, *mocks):"},{"line_number":3339,"context_line":"        config.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNSDOMAIN)"},{"line_number":3340,"context_line":"        with self.network(dns_domain\u003d\u0027junk-domain.org.\u0027) as n,\\"},{"line_number":3341,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub,\\"},{"line_number":3342,"context_line":"                self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub,\\"},{"line_number":3343,"context_line":"                self.port(private_sub, dns_name\u003d\u0027junk\u0027) as p,\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_ec57ee57","line":3340,"updated":"2016-04-06 21:40:39.000000000","message":"See my comment to line 3289\nPlease don\u0027t use \u0027\\\u0027 to continue your lines","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3337,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3338,"context_line":"    def test_floating_ip_create_with_conflicting_dns(self, *mocks):"},{"line_number":3339,"context_line":"        config.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNSDOMAIN)"},{"line_number":3340,"context_line":"        with self.network(dns_domain\u003d\u0027junk-domain.org.\u0027) as n,\\"},{"line_number":3341,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub,\\"},{"line_number":3342,"context_line":"                self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub,\\"},{"line_number":3343,"context_line":"                self.port(private_sub, dns_name\u003d\u0027junk\u0027) as p,\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_b2ae6de5","line":3340,"in_reply_to":"9a061dce_ec57ee57","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3363,"context_line":"        # External DNS service should have been called with floating ip\u0027s"},{"line_number":3364,"context_line":"        # dns information, not the network+port\u0027s dns information"},{"line_number":3365,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3366,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3367,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3368,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3369,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_af05e87a","line":3366,"updated":"2016-04-06 21:40:39.000000000","message":"See my comment for line 3302","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3363,"context_line":"        # External DNS service should have been called with floating ip\u0027s"},{"line_number":3364,"context_line":"        # dns information, not the network+port\u0027s dns information"},{"line_number":3365,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3366,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3367,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3368,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3369,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_f2b8e52c","line":3366,"in_reply_to":"9a061dce_af05e87a","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3365,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3366,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3367,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3368,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3369,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"},{"line_number":3370,"context_line":"        self.assertEqual(dns_name, self.DNSNAME)"},{"line_number":3371,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_9db77f39","line":3368,"updated":"2016-04-06 21:40:39.000000000","message":"Please see my comment to lines 3303 and 3304","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3365,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3366,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3367,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3368,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3369,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"},{"line_number":3370,"context_line":"        self.assertEqual(dns_name, self.DNSNAME)"},{"line_number":3371,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_d2b5e131","line":3368,"in_reply_to":"9a061dce_9db77f39","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3370,"context_line":"        self.assertEqual(dns_name, self.DNSNAME)"},{"line_number":3371,"context_line":""},{"line_number":3372,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3373,"context_line":"    def test_floating_ip_associate_port(self, *mocks):"},{"line_number":3374,"context_line":"        with self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub,\\"},{"line_number":3375,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR) as private_sub,\\"},{"line_number":3376,"context_line":"                self.port(private_sub) as p:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_e5ad4185","line":3373,"updated":"2016-04-06 21:40:39.000000000","message":"This test case would be useful if you tested that the external dns service was not called","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3370,"context_line":"        self.assertEqual(dns_name, self.DNSNAME)"},{"line_number":3371,"context_line":""},{"line_number":3372,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3373,"context_line":"    def test_floating_ip_associate_port(self, *mocks):"},{"line_number":3374,"context_line":"        with self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub,\\"},{"line_number":3375,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR) as private_sub,\\"},{"line_number":3376,"context_line":"                self.port(private_sub) as p:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_9292499e","line":3373,"in_reply_to":"9a061dce_e5ad4185","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3371,"context_line":""},{"line_number":3372,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3373,"context_line":"    def test_floating_ip_associate_port(self, *mocks):"},{"line_number":3374,"context_line":"        with self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub,\\"},{"line_number":3375,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR) as private_sub,\\"},{"line_number":3376,"context_line":"                self.port(private_sub) as p:"},{"line_number":3377,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_eccece2b","line":3374,"updated":"2016-04-06 21:40:39.000000000","message":"See my comment to line 3289\nPlease don\u0027t use \u0027\\\u0027 to continue your lines","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3371,"context_line":""},{"line_number":3372,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3373,"context_line":"    def test_floating_ip_associate_port(self, *mocks):"},{"line_number":3374,"context_line":"        with self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub,\\"},{"line_number":3375,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR) as private_sub,\\"},{"line_number":3376,"context_line":"                self.port(private_sub) as p:"},{"line_number":3377,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_d28cc181","line":3374,"in_reply_to":"9a061dce_eccece2b","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3388,"context_line":"                res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3389,"context_line":"                # res.body is a string representation of the floatingip dict"},{"line_number":3390,"context_line":"                # The jsonutils.loads call converts that string to a real dict"},{"line_number":3391,"context_line":"        flip_port_id \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027port_id\u0027]"},{"line_number":3392,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3393,"context_line":"        self.assertEqual(p[\u0027port\u0027][\u0027id\u0027], flip_port_id)"},{"line_number":3394,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_fd7e7b68","line":3391,"updated":"2016-04-06 21:40:39.000000000","message":"Please see my comments to lines 3303 and 3304","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3388,"context_line":"                res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3389,"context_line":"                # res.body is a string representation of the floatingip dict"},{"line_number":3390,"context_line":"                # The jsonutils.loads call converts that string to a real dict"},{"line_number":3391,"context_line":"        flip_port_id \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027port_id\u0027]"},{"line_number":3392,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3393,"context_line":"        self.assertEqual(p[\u0027port\u0027][\u0027id\u0027], flip_port_id)"},{"line_number":3394,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_32e89d16","line":3391,"in_reply_to":"9a061dce_fd7e7b68","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3396,"context_line":"    # I\u0027m not opposed to changing the whole naming scheme"},{"line_number":3397,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3398,"context_line":"    def test_floating_ip_associate_port_with_dns(self, *mocks):"},{"line_number":3399,"context_line":"        with self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub,\\"},{"line_number":3400,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR) as private_sub,\\"},{"line_number":3401,"context_line":"                self.port(private_sub) as p,\\"},{"line_number":3402,"context_line":"                self.router() as r:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_0cda22e8","line":3399,"updated":"2016-04-06 21:40:39.000000000","message":"See my comment to line 3289\nPlease don\u0027t use \u0027\\\u0027 to continue your lines","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3396,"context_line":"    # I\u0027m not opposed to changing the whole naming scheme"},{"line_number":3397,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3398,"context_line":"    def test_floating_ip_associate_port_with_dns(self, *mocks):"},{"line_number":3399,"context_line":"        with self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub,\\"},{"line_number":3400,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR) as private_sub,\\"},{"line_number":3401,"context_line":"                self.port(private_sub) as p,\\"},{"line_number":3402,"context_line":"                self.router() as r:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_52f711f5","line":3399,"in_reply_to":"9a061dce_0cda22e8","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3419,"context_line":""},{"line_number":3420,"context_line":"            req \u003d self.new_create_request(\u0027floatingips\u0027, data, self.fmt)"},{"line_number":3421,"context_line":"            res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3422,"context_line":"            flip_id \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027id\u0027]"},{"line_number":3423,"context_line":""},{"line_number":3424,"context_line":"            data \u003d {\u0027floatingip\u0027: {\u0027port_id\u0027: p[\u0027port\u0027][\u0027id\u0027]}}"},{"line_number":3425,"context_line":"            req \u003d self.new_update_request(\u0027floatingips\u0027, data, flip_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_ddea970e","line":3422,"updated":"2016-04-06 21:40:39.000000000","message":"Please see my comment to lines 3303 and 3304","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3419,"context_line":""},{"line_number":3420,"context_line":"            req \u003d self.new_create_request(\u0027floatingips\u0027, data, self.fmt)"},{"line_number":3421,"context_line":"            res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3422,"context_line":"            flip_id \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027id\u0027]"},{"line_number":3423,"context_line":""},{"line_number":3424,"context_line":"            data \u003d {\u0027floatingip\u0027: {\u0027port_id\u0027: p[\u0027port\u0027][\u0027id\u0027]}}"},{"line_number":3425,"context_line":"            req \u003d self.new_update_request(\u0027floatingips\u0027, data, flip_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_92d9a986","line":3422,"in_reply_to":"9a061dce_ddea970e","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3426,"context_line":"            res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3427,"context_line":"            # res.body is a string representation of the floatingip dict"},{"line_number":3428,"context_line":"            # The jsonutils.loads call converts that string to a real dict"},{"line_number":3429,"context_line":"        flip_port_id \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027port_id\u0027]"},{"line_number":3430,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3431,"context_line":"        self.assertEqual(p[\u0027port\u0027][\u0027id\u0027], flip_port_id)"},{"line_number":3432,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_fdf5dbec","line":3429,"updated":"2016-04-06 21:40:39.000000000","message":"Please see my comment to lines 3303 and 3304","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3426,"context_line":"            res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3427,"context_line":"            # res.body is a string representation of the floatingip dict"},{"line_number":3428,"context_line":"            # The jsonutils.loads call converts that string to a real dict"},{"line_number":3429,"context_line":"        flip_port_id \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027port_id\u0027]"},{"line_number":3430,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3431,"context_line":"        self.assertEqual(p[\u0027port\u0027][\u0027id\u0027], flip_port_id)"},{"line_number":3432,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_12d47945","line":3429,"in_reply_to":"9a061dce_fdf5dbec","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3430,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3431,"context_line":"        self.assertEqual(p[\u0027port\u0027][\u0027id\u0027], flip_port_id)"},{"line_number":3432,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3433,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3434,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3435,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3436,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_af1328b7","line":3433,"updated":"2016-04-06 21:40:39.000000000","message":"See my comment for line 3302","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3430,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3431,"context_line":"        self.assertEqual(p[\u0027port\u0027][\u0027id\u0027], flip_port_id)"},{"line_number":3432,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3433,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3434,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3435,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3436,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_72c975ac","line":3433,"in_reply_to":"9a061dce_af1328b7","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3439,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3440,"context_line":"    def test_floating_ip_associate_port_with_inherited_dns(self, *mocks):"},{"line_number":3441,"context_line":"        config.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNSDOMAIN)"},{"line_number":3442,"context_line":"        with self.network(dns_domain\u003dself.DNSDOMAIN) as n,\\"},{"line_number":3443,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub,\\"},{"line_number":3444,"context_line":"                self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub,\\"},{"line_number":3445,"context_line":"                self.port(private_sub, dns_name\u003dself.DNSNAME) as p:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_4ce09a96","line":3442,"updated":"2016-04-06 21:40:39.000000000","message":"See my comment to line 3289\nPlease don\u0027t use \u0027\\\u0027 to continue your lines","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3439,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3440,"context_line":"    def test_floating_ip_associate_port_with_inherited_dns(self, *mocks):"},{"line_number":3441,"context_line":"        config.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNSDOMAIN)"},{"line_number":3442,"context_line":"        with self.network(dns_domain\u003dself.DNSDOMAIN) as n,\\"},{"line_number":3443,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub,\\"},{"line_number":3444,"context_line":"                self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub,\\"},{"line_number":3445,"context_line":"                self.port(private_sub, dns_name\u003dself.DNSNAME) as p:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_b2c30d8a","line":3442,"in_reply_to":"9a061dce_4ce09a96","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3453,"context_line":"                res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3454,"context_line":"        # res.body is a string representation of the floatingip dict"},{"line_number":3455,"context_line":"        # The jsonutils.loads call converts that string to a real dict"},{"line_number":3456,"context_line":"        flip_port_id \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027port_id\u0027]"},{"line_number":3457,"context_line":""},{"line_number":3458,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3459,"context_line":"        self.assertEqual(p[\u0027port\u0027][\u0027id\u0027], flip_port_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_5ddfa768","line":3456,"updated":"2016-04-06 21:40:39.000000000","message":"Please see my comment to lines 3303 and 3304","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3453,"context_line":"                res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3454,"context_line":"        # res.body is a string representation of the floatingip dict"},{"line_number":3455,"context_line":"        # The jsonutils.loads call converts that string to a real dict"},{"line_number":3456,"context_line":"        flip_port_id \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027port_id\u0027]"},{"line_number":3457,"context_line":""},{"line_number":3458,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3459,"context_line":"        self.assertEqual(p[\u0027port\u0027][\u0027id\u0027], flip_port_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_d2ba010a","line":3456,"in_reply_to":"9a061dce_5ddfa768","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3458,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3459,"context_line":"        self.assertEqual(p[\u0027port\u0027][\u0027id\u0027], flip_port_id)"},{"line_number":3460,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3461,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3462,"context_line":""},{"line_number":3463,"context_line":"    # If both network+port and the floating ip have dns domain and dns name,"},{"line_number":3464,"context_line":"    # floating ip\u0027s information should take priority"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_ef09a085","line":3461,"updated":"2016-04-06 21:40:39.000000000","message":"See my comment for line 3302","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3458,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3459,"context_line":"        self.assertEqual(p[\u0027port\u0027][\u0027id\u0027], flip_port_id)"},{"line_number":3460,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3461,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3462,"context_line":""},{"line_number":3463,"context_line":"    # If both network+port and the floating ip have dns domain and dns name,"},{"line_number":3464,"context_line":"    # floating ip\u0027s information should take priority"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_123bd99d","line":3461,"in_reply_to":"9a061dce_ef09a085","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3460,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3461,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3462,"context_line":""},{"line_number":3463,"context_line":"    # If both network+port and the floating ip have dns domain and dns name,"},{"line_number":3464,"context_line":"    # floating ip\u0027s information should take priority"},{"line_number":3465,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3466,"context_line":"    def test_floating_ip_associate_port_with_conflicting_dns(self, *mocks):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_8fc2a4e7","line":3463,"updated":"2016-04-06 21:40:39.000000000","message":"I think these comment lines will be more useful if you move them inside the method","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3460,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3461,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3462,"context_line":""},{"line_number":3463,"context_line":"    # If both network+port and the floating ip have dns domain and dns name,"},{"line_number":3464,"context_line":"    # floating ip\u0027s information should take priority"},{"line_number":3465,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3466,"context_line":"    def test_floating_ip_associate_port_with_conflicting_dns(self, *mocks):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_52455115","line":3463,"in_reply_to":"9a061dce_8fc2a4e7","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3463,"context_line":"    # If both network+port and the floating ip have dns domain and dns name,"},{"line_number":3464,"context_line":"    # floating ip\u0027s information should take priority"},{"line_number":3465,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3466,"context_line":"    def test_floating_ip_associate_port_with_conflicting_dns(self, *mocks):"},{"line_number":3467,"context_line":"        config.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNSDOMAIN)"},{"line_number":3468,"context_line":"        with self.network(dns_domain\u003d\u0027junk-domain.org.\u0027) as n,\\"},{"line_number":3469,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub,\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_cf465c7a","line":3466,"updated":"2016-04-06 21:40:39.000000000","message":"\u0027conflicting suggests you are testing for an error condition. Your are not. You are testing expected functionality. I would change this name","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3463,"context_line":"    # If both network+port and the floating ip have dns domain and dns name,"},{"line_number":3464,"context_line":"    # floating ip\u0027s information should take priority"},{"line_number":3465,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3466,"context_line":"    def test_floating_ip_associate_port_with_conflicting_dns(self, *mocks):"},{"line_number":3467,"context_line":"        config.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNSDOMAIN)"},{"line_number":3468,"context_line":"        with self.network(dns_domain\u003d\u0027junk-domain.org.\u0027) as n,\\"},{"line_number":3469,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub,\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_b24aed25","line":3466,"in_reply_to":"9a061dce_cf465c7a","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3465,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3466,"context_line":"    def test_floating_ip_associate_port_with_conflicting_dns(self, *mocks):"},{"line_number":3467,"context_line":"        config.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNSDOMAIN)"},{"line_number":3468,"context_line":"        with self.network(dns_domain\u003d\u0027junk-domain.org.\u0027) as n,\\"},{"line_number":3469,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub,\\"},{"line_number":3470,"context_line":"                self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub,\\"},{"line_number":3471,"context_line":"                self.port(private_sub, dns_name\u003d\u0027junk\u0027) as p,\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_8cf4725b","line":3468,"updated":"2016-04-06 21:40:39.000000000","message":"See my comment to line 3289\nPlease don\u0027t use \u0027\\\u0027 to continue your lines","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3465,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3466,"context_line":"    def test_floating_ip_associate_port_with_conflicting_dns(self, *mocks):"},{"line_number":3467,"context_line":"        config.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNSDOMAIN)"},{"line_number":3468,"context_line":"        with self.network(dns_domain\u003d\u0027junk-domain.org.\u0027) as n,\\"},{"line_number":3469,"context_line":"                self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub,\\"},{"line_number":3470,"context_line":"                self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub,\\"},{"line_number":3471,"context_line":"                self.port(private_sub, dns_name\u003d\u0027junk\u0027) as p,\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_9247e91c","line":3468,"in_reply_to":"9a061dce_8cf4725b","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3492,"context_line":"            res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3493,"context_line":"        # res.body is a string representation of the floatingip dict"},{"line_number":3494,"context_line":"        # The jsonutils.loads call converts that string to a real dict"},{"line_number":3495,"context_line":"        flip_port_id \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027port_id\u0027]"},{"line_number":3496,"context_line":""},{"line_number":3497,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3498,"context_line":"        self.assertEqual(p[\u0027port\u0027][\u0027id\u0027], flip_port_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_9de5bf39","line":3495,"updated":"2016-04-06 21:40:39.000000000","message":"Please see my comment to lines 3303 and 3304","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3492,"context_line":"            res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3493,"context_line":"        # res.body is a string representation of the floatingip dict"},{"line_number":3494,"context_line":"        # The jsonutils.loads call converts that string to a real dict"},{"line_number":3495,"context_line":"        flip_port_id \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027port_id\u0027]"},{"line_number":3496,"context_line":""},{"line_number":3497,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3498,"context_line":"        self.assertEqual(p[\u0027port\u0027][\u0027id\u0027], flip_port_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_f25465cb","line":3495,"in_reply_to":"9a061dce_9de5bf39","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3499,"context_line":"        # External DNS service should have been called with floating ip\u0027s"},{"line_number":3500,"context_line":"        # dns information, not the network+port\u0027s dns information"},{"line_number":3501,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3502,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3503,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3504,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3505,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_6f1e30bc","line":3502,"updated":"2016-04-06 21:40:39.000000000","message":"See my comment for line 3302","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3499,"context_line":"        # External DNS service should have been called with floating ip\u0027s"},{"line_number":3500,"context_line":"        # dns information, not the network+port\u0027s dns information"},{"line_number":3501,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3502,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3503,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3504,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3505,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_d25161da","line":3502,"in_reply_to":"9a061dce_6f1e30bc","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3500,"context_line":"        # dns information, not the network+port\u0027s dns information"},{"line_number":3501,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3502,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3503,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3504,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3505,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"},{"line_number":3506,"context_line":"        self.assertEqual(dns_name, self.DNSNAME)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_bdd6c34c","line":3503,"updated":"2016-04-06 21:40:39.000000000","message":"Please see my comment to lines 3303 and 3304","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3500,"context_line":"        # dns information, not the network+port\u0027s dns information"},{"line_number":3501,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3502,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3503,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3504,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3505,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"},{"line_number":3506,"context_line":"        self.assertEqual(dns_name, self.DNSNAME)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_1262b9ad","line":3503,"in_reply_to":"9a061dce_bdd6c34c","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3501,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3502,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3503,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3504,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3505,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"},{"line_number":3506,"context_line":"        self.assertEqual(dns_name, self.DNSNAME)"},{"line_number":3507,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_fdccbbbc","line":3504,"updated":"2016-04-06 21:40:39.000000000","message":"Please see my comment to lines 3303 and 3304","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3501,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3502,"context_line":"                self.DNSNAME, mock.ANY, mock.ANY)"},{"line_number":3503,"context_line":"        dns_domain \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_domain\u0027]"},{"line_number":3504,"context_line":"        dns_name \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027dns_name\u0027]"},{"line_number":3505,"context_line":"        self.assertEqual(dns_domain, self.DNSDOMAIN)"},{"line_number":3506,"context_line":"        self.assertEqual(dns_name, self.DNSNAME)"},{"line_number":3507,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_525c31ed","line":3504,"in_reply_to":"9a061dce_fdccbbbc","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3506,"context_line":"        self.assertEqual(dns_name, self.DNSNAME)"},{"line_number":3507,"context_line":""},{"line_number":3508,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3509,"context_line":"    def test_floating_ip_disassociate_port(self, *mocks):"},{"line_number":3510,"context_line":"        with self.floatingip_with_assoc() as flip:"},{"line_number":3511,"context_line":"            # Port gets disassociated if port_id is not in the request body"},{"line_number":3512,"context_line":"            data \u003d {\u0027floatingip\u0027: {}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_821efb6d","line":3509,"updated":"2016-04-06 21:40:39.000000000","message":"In its present form, this test case doesn\u0027t add much value. Floating ip disassociation must be tested extensively in the classes above. It would very useful if the associated port and its network had dns_name and dns_domain attributes and you tested that upon dis-association, the external dns driver is called to remove the record sets","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3506,"context_line":"        self.assertEqual(dns_name, self.DNSNAME)"},{"line_number":3507,"context_line":""},{"line_number":3508,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3509,"context_line":"    def test_floating_ip_disassociate_port(self, *mocks):"},{"line_number":3510,"context_line":"        with self.floatingip_with_assoc() as flip:"},{"line_number":3511,"context_line":"            # Port gets disassociated if port_id is not in the request body"},{"line_number":3512,"context_line":"            data \u003d {\u0027floatingip\u0027: {}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_b2714d7a","line":3509,"in_reply_to":"9a061dce_821efb6d","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3507,"context_line":""},{"line_number":3508,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3509,"context_line":"    def test_floating_ip_disassociate_port(self, *mocks):"},{"line_number":3510,"context_line":"        with self.floatingip_with_assoc() as flip:"},{"line_number":3511,"context_line":"            # Port gets disassociated if port_id is not in the request body"},{"line_number":3512,"context_line":"            data \u003d {\u0027floatingip\u0027: {}}"},{"line_number":3513,"context_line":"            req \u003d self.new_update_request(\u0027floatingips\u0027, data,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_2c044648","line":3510,"updated":"2016-04-06 21:40:39.000000000","message":"See my comment to line 3289","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3507,"context_line":""},{"line_number":3508,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3509,"context_line":"    def test_floating_ip_disassociate_port(self, *mocks):"},{"line_number":3510,"context_line":"        with self.floatingip_with_assoc() as flip:"},{"line_number":3511,"context_line":"            # Port gets disassociated if port_id is not in the request body"},{"line_number":3512,"context_line":"            data \u003d {\u0027floatingip\u0027: {}}"},{"line_number":3513,"context_line":"            req \u003d self.new_update_request(\u0027floatingips\u0027, data,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_926ec994","line":3510,"in_reply_to":"9a061dce_2c044648","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3513,"context_line":"            req \u003d self.new_update_request(\u0027floatingips\u0027, data,"},{"line_number":3514,"context_line":"                                          flip[\u0027floatingip\u0027][\u0027id\u0027])"},{"line_number":3515,"context_line":"            res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3516,"context_line":"            flip_port_id \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027port_id\u0027]"},{"line_number":3517,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3518,"context_line":"        self.assertIsNone(flip_port_id)"},{"line_number":3519,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_5dc6879a","line":3516,"updated":"2016-04-06 21:40:39.000000000","message":"Please see my comment to lines 3303 and 3304","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3513,"context_line":"            req \u003d self.new_update_request(\u0027floatingips\u0027, data,"},{"line_number":3514,"context_line":"                                          flip[\u0027floatingip\u0027][\u0027id\u0027])"},{"line_number":3515,"context_line":"            res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3516,"context_line":"            flip_port_id \u003d jsonutils.loads(res.body)[\u0027floatingip\u0027][\u0027port_id\u0027]"},{"line_number":3517,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3518,"context_line":"        self.assertIsNone(flip_port_id)"},{"line_number":3519,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_32041dc5","line":3516,"in_reply_to":"9a061dce_5dc6879a","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2ef3dc36a68e7bebc6cecdd499e697fad68a4d19","unresolved":false,"context_lines":[{"line_number":3518,"context_line":"        self.assertIsNone(flip_port_id)"},{"line_number":3519,"context_line":""},{"line_number":3520,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3521,"context_line":"    def test_floating_ip_delete(self, *mocks):"},{"line_number":3522,"context_line":"        with self.floatingip_with_assoc() as flip:"},{"line_number":3523,"context_line":"            flip_id \u003d flip[\u0027floatingip\u0027][\u0027id\u0027]"},{"line_number":3524,"context_line":"        req \u003d self.new_show_request(\u0027floatingips\u0027, flip_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_651bf173","line":3521,"updated":"2016-04-06 21:40:39.000000000","message":"In its present form, this test case doesn\u0027t add much value. Floating ip deletion must be tested extensively in the classes above. It would very useful if the floating ip were created with dns_name and dns_domain attributes and you tested that upon deletion, the external dns driver is called to remove the record sets","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"98df5339ef96755d014d8c372d164e9ba5582ce9","unresolved":false,"context_lines":[{"line_number":3518,"context_line":"        self.assertIsNone(flip_port_id)"},{"line_number":3519,"context_line":""},{"line_number":3520,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3521,"context_line":"    def test_floating_ip_delete(self, *mocks):"},{"line_number":3522,"context_line":"        with self.floatingip_with_assoc() as flip:"},{"line_number":3523,"context_line":"            flip_id \u003d flip[\u0027floatingip\u0027][\u0027id\u0027]"},{"line_number":3524,"context_line":"        req \u003d self.new_show_request(\u0027floatingips\u0027, flip_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_92f529cd","line":3521,"in_reply_to":"9a061dce_651bf173","updated":"2016-04-08 19:33:56.000000000","message":"Done","commit_id":"398b465c8ff2d90b70239ccce517f98135061659"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f220a167cc4481a29d0d627ff4f7ecb37bc85bb5","unresolved":false,"context_lines":[{"line_number":3306,"context_line":"                                        **kwargs)"},{"line_number":3307,"context_line":""},{"line_number":3308,"context_line":"    def create_floatingip(self, net_port_dns\u003dFalse, flip_dns\u003dFalse,"},{"line_number":3309,"context_line":"                          bind_port\u003dFalse, associate_port\u003dFalse):"},{"line_number":3310,"context_line":"        # The bind_port flag is used for associating the floating ip"},{"line_number":3311,"context_line":"        # to its port at creation time; the associate_port flag is used"},{"line_number":3312,"context_line":"        # for associating it after the fact in an update call"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_7db8d475","line":3309,"range":{"start_line":3309,"start_character":26,"end_line":3309,"end_character":35},"updated":"2016-05-04 17:05:07.000000000","message":"This bind_port argument might be confusing to reviewers. Binding a port has a very specific meaning in Neutron, as you know. I recommend changing this argument\u0027s name to avoid confusion","commit_id":"966158830f5dfc5abb60346be77a8e41d6c6d2c3"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3531b8ae62cb9a741f9439b44f18941f443e847a","unresolved":false,"context_lines":[{"line_number":3306,"context_line":"                                        **kwargs)"},{"line_number":3307,"context_line":""},{"line_number":3308,"context_line":"    def create_floatingip(self, net_port_dns\u003dFalse, flip_dns\u003dFalse,"},{"line_number":3309,"context_line":"                          bind_port\u003dFalse, associate_port\u003dFalse):"},{"line_number":3310,"context_line":"        # The bind_port flag is used for associating the floating ip"},{"line_number":3311,"context_line":"        # to its port at creation time; the associate_port flag is used"},{"line_number":3312,"context_line":"        # for associating it after the fact in an update call"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_928672b7","line":3309,"range":{"start_line":3309,"start_character":26,"end_line":3309,"end_character":35},"in_reply_to":"1a122d0e_7db8d475","updated":"2016-05-04 21:33:38.000000000","message":"Done. bind_port is now assoc_port_on_creation and associate_port is now assoc_port_after_creation, to better reflect both what they do and their similarity","commit_id":"966158830f5dfc5abb60346be77a8e41d6c6d2c3"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f220a167cc4481a29d0d627ff4f7ecb37bc85bb5","unresolved":false,"context_lines":[{"line_number":3516,"context_line":"        flip_port_id \u003d self.deserialize(self.fmt, res)[\u0027floatingip\u0027][\u0027port_id\u0027]"},{"line_number":3517,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3518,"context_line":"        self.assertIsNone(flip_port_id)"},{"line_number":3519,"context_line":"        self.assertTrue(self.mock_client.recordsets.delete.called)"},{"line_number":3520,"context_line":"        self.assertTrue(self.mock_admin_client.recordsets.delete.called)"},{"line_number":3521,"context_line":""},{"line_number":3522,"context_line":"    @mock.patch(mock_path, **mock_config)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_bd71cce0","line":3519,"updated":"2016-05-04 17:05:07.000000000","message":"Please check the arguments that were passed to this method","commit_id":"966158830f5dfc5abb60346be77a8e41d6c6d2c3"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3531b8ae62cb9a741f9439b44f18941f443e847a","unresolved":false,"context_lines":[{"line_number":3516,"context_line":"        flip_port_id \u003d self.deserialize(self.fmt, res)[\u0027floatingip\u0027][\u0027port_id\u0027]"},{"line_number":3517,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3518,"context_line":"        self.assertIsNone(flip_port_id)"},{"line_number":3519,"context_line":"        self.assertTrue(self.mock_client.recordsets.delete.called)"},{"line_number":3520,"context_line":"        self.assertTrue(self.mock_admin_client.recordsets.delete.called)"},{"line_number":3521,"context_line":""},{"line_number":3522,"context_line":"    @mock.patch(mock_path, **mock_config)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_92add233","line":3519,"in_reply_to":"1a122d0e_bd71cce0","updated":"2016-05-04 21:33:38.000000000","message":"Done","commit_id":"966158830f5dfc5abb60346be77a8e41d6c6d2c3"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f220a167cc4481a29d0d627ff4f7ecb37bc85bb5","unresolved":false,"context_lines":[{"line_number":3517,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3518,"context_line":"        self.assertIsNone(flip_port_id)"},{"line_number":3519,"context_line":"        self.assertTrue(self.mock_client.recordsets.delete.called)"},{"line_number":3520,"context_line":"        self.assertTrue(self.mock_admin_client.recordsets.delete.called)"},{"line_number":3521,"context_line":""},{"line_number":3522,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3523,"context_line":"    def test_floatingip_delete(self, *mocks):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_fd7b44bc","line":3520,"updated":"2016-05-04 17:05:07.000000000","message":"Please check the arguments that were passed to this method","commit_id":"966158830f5dfc5abb60346be77a8e41d6c6d2c3"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3531b8ae62cb9a741f9439b44f18941f443e847a","unresolved":false,"context_lines":[{"line_number":3517,"context_line":"        self.assertEqual(200, res.status_code)"},{"line_number":3518,"context_line":"        self.assertIsNone(flip_port_id)"},{"line_number":3519,"context_line":"        self.assertTrue(self.mock_client.recordsets.delete.called)"},{"line_number":3520,"context_line":"        self.assertTrue(self.mock_admin_client.recordsets.delete.called)"},{"line_number":3521,"context_line":""},{"line_number":3522,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3523,"context_line":"    def test_floatingip_delete(self, *mocks):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_d2a3ca41","line":3520,"in_reply_to":"1a122d0e_fd7b44bc","updated":"2016-05-04 21:33:38.000000000","message":"Done","commit_id":"966158830f5dfc5abb60346be77a8e41d6c6d2c3"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f220a167cc4481a29d0d627ff4f7ecb37bc85bb5","unresolved":false,"context_lines":[{"line_number":3531,"context_line":"        req \u003d self.new_delete_request(\u0027floatingips\u0027, floatingip[\u0027id\u0027])"},{"line_number":3532,"context_line":"        res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3533,"context_line":"        self.assertEqual(204, res.status_code)"},{"line_number":3534,"context_line":"        self.assertTrue(self.mock_client.recordsets.delete.called)"},{"line_number":3535,"context_line":"        self.assertTrue(self.mock_admin_client.recordsets.delete.called)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_5d49988d","line":3534,"updated":"2016-05-04 17:05:07.000000000","message":"Please check the arguments that were passed to this method","commit_id":"966158830f5dfc5abb60346be77a8e41d6c6d2c3"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3531b8ae62cb9a741f9439b44f18941f443e847a","unresolved":false,"context_lines":[{"line_number":3531,"context_line":"        req \u003d self.new_delete_request(\u0027floatingips\u0027, floatingip[\u0027id\u0027])"},{"line_number":3532,"context_line":"        res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3533,"context_line":"        self.assertEqual(204, res.status_code)"},{"line_number":3534,"context_line":"        self.assertTrue(self.mock_client.recordsets.delete.called)"},{"line_number":3535,"context_line":"        self.assertTrue(self.mock_admin_client.recordsets.delete.called)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_32631e1c","line":3534,"in_reply_to":"1a122d0e_5d49988d","updated":"2016-05-04 21:33:38.000000000","message":"Done","commit_id":"966158830f5dfc5abb60346be77a8e41d6c6d2c3"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f220a167cc4481a29d0d627ff4f7ecb37bc85bb5","unresolved":false,"context_lines":[{"line_number":3532,"context_line":"        res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3533,"context_line":"        self.assertEqual(204, res.status_code)"},{"line_number":3534,"context_line":"        self.assertTrue(self.mock_client.recordsets.delete.called)"},{"line_number":3535,"context_line":"        self.assertTrue(self.mock_admin_client.recordsets.delete.called)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_3d4c9c9c","line":3535,"updated":"2016-05-04 17:05:07.000000000","message":"Please check the arguments that were passed to this method","commit_id":"966158830f5dfc5abb60346be77a8e41d6c6d2c3"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3531b8ae62cb9a741f9439b44f18941f443e847a","unresolved":false,"context_lines":[{"line_number":3532,"context_line":"        res \u003d req.get_response(self._api_for_resource(\u0027floatingip\u0027))"},{"line_number":3533,"context_line":"        self.assertEqual(204, res.status_code)"},{"line_number":3534,"context_line":"        self.assertTrue(self.mock_client.recordsets.delete.called)"},{"line_number":3535,"context_line":"        self.assertTrue(self.mock_admin_client.recordsets.delete.called)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_1268a2f4","line":3535,"in_reply_to":"1a122d0e_3d4c9c9c","updated":"2016-05-04 21:33:38.000000000","message":"Done","commit_id":"966158830f5dfc5abb60346be77a8e41d6c6d2c3"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"437d3b480d046900a7e272470e859b022ea11584","unresolved":false,"context_lines":[{"line_number":3330,"context_line":"            net_dns_domain \u003d self.DNSDOMAIN"},{"line_number":3331,"context_line":"            port_dns_name \u003d self.DNSNAME"},{"line_number":3332,"context_line":""},{"line_number":3333,"context_line":"        with self.network(dns_domain\u003dnet_dns_domain) as n:"},{"line_number":3334,"context_line":"            with self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub:"},{"line_number":3335,"context_line":"                with self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub:"},{"line_number":3336,"context_line":"                    with self.port(private_sub, dns_name\u003dport_dns_name) as p:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a122d0e_9d48432f","line":3333,"updated":"2016-05-04 21:48:56.000000000","message":"See around ~L420. It seems like you\u0027ve essentially re-implemented _create_floatingip() in here, is there a way we can re-use some of the helper methods we inherit from our mixins? I would suggest looking over the methods defined up in some of these mixins and leverage them as much as we can.","commit_id":"ab77b7e1426f78ba051c6c4bbd5a3403b489294e"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7909dc5a41c25e41858fb04addd56a973e7aaf3d","unresolved":false,"context_lines":[{"line_number":3330,"context_line":"            net_dns_domain \u003d self.DNSDOMAIN"},{"line_number":3331,"context_line":"            port_dns_name \u003d self.DNSNAME"},{"line_number":3332,"context_line":""},{"line_number":3333,"context_line":"        with self.network(dns_domain\u003dnet_dns_domain) as n:"},{"line_number":3334,"context_line":"            with self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub:"},{"line_number":3335,"context_line":"                with self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub:"},{"line_number":3336,"context_line":"                    with self.port(private_sub, dns_name\u003dport_dns_name) as p:"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_03af477d","line":3333,"in_reply_to":"1a122d0e_9d48432f","updated":"2016-05-23 17:21:38.000000000","message":"I think is worth exploring Ryan\u0027s proposal. You already inherit from L3NatTestCaseMixin, which contains the method Ryan is talking about. The answer might be that it is not that easy because we are going to break other test cases or some other reason. But at least, let\u0027s give it a try","commit_id":"ab77b7e1426f78ba051c6c4bbd5a3403b489294e"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"48a7790cb6a29d4b17307be279ce9ead0a63752f","unresolved":false,"context_lines":[{"line_number":3330,"context_line":"            net_dns_domain \u003d self.DNSDOMAIN"},{"line_number":3331,"context_line":"            port_dns_name \u003d self.DNSNAME"},{"line_number":3332,"context_line":""},{"line_number":3333,"context_line":"        with self.network(dns_domain\u003dnet_dns_domain) as n:"},{"line_number":3334,"context_line":"            with self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub:"},{"line_number":3335,"context_line":"                with self.subnet(cidr\u003dself.PUBLIC_CIDR) as public_sub:"},{"line_number":3336,"context_line":"                    with self.port(private_sub, dns_name\u003dport_dns_name) as p:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_b3956541","line":3333,"in_reply_to":"bab6814e_03af477d","updated":"2016-06-12 06:51:35.000000000","message":"The changes to the inherited method are thankfully minimal, but the new create_floatingip is a bit unwieldy. I\u0027m going to look into this a bit more tomorrow and see if there\u0027s a cleaner way to do the function calls, rather than four separate invocations with slightly tweaked arguments.\n\nBut for now, the next revision is up. I\u0027d appreciate any ideas about tidying the code up :)","commit_id":"ab77b7e1426f78ba051c6c4bbd5a3403b489294e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"49c280e357bfd4b57164e590582b5f2a4ac9ca55","unresolved":false,"context_lines":[{"line_number":3456,"context_line":"                                        public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":3457,"context_line":"                                        tenant_id\u003dn[\u0027network\u0027][\u0027tenant_id\u0027],"},{"line_number":3458,"context_line":"                                        dns_domain\u003dself.DNSDOMAIN,"},{"line_number":3459,"context_line":"                                        dns_name\u003dself.DNSNAME)  "},{"line_number":3460,"context_line":"                            elif not flip_dns and assoc_port_on_creation:"},{"line_number":3461,"context_line":"                                floatingip \u003d self._create_floatingip(self.fmt,"},{"line_number":3462,"context_line":"                                        public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_a7f7d8d1","line":3459,"updated":"2016-06-12 18:11:27.000000000","message":"whitespace","commit_id":"ab3a42dd76715bbbc21484034f73c5aef79c5da6"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"793663ad5e0890ec096deca7555b115384bb0188","unresolved":false,"context_lines":[{"line_number":3456,"context_line":"                                        public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"},{"line_number":3457,"context_line":"                                        tenant_id\u003dn[\u0027network\u0027][\u0027tenant_id\u0027],"},{"line_number":3458,"context_line":"                                        dns_domain\u003dself.DNSDOMAIN,"},{"line_number":3459,"context_line":"                                        dns_name\u003dself.DNSNAME)  "},{"line_number":3460,"context_line":"                            elif not flip_dns and assoc_port_on_creation:"},{"line_number":3461,"context_line":"                                floatingip \u003d self._create_floatingip(self.fmt,"},{"line_number":3462,"context_line":"                                        public_sub[\u0027subnet\u0027][\u0027network_id\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_5db7ce39","line":3459,"in_reply_to":"7aa08908_a7f7d8d1","updated":"2016-06-13 14:06:19.000000000","message":"Done","commit_id":"ab3a42dd76715bbbc21484034f73c5aef79c5da6"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"10d4ab621270d45317a8d4659e77ced4f09a571b","unresolved":false,"context_lines":[{"line_number":3399,"context_line":"                                        tenant_id\u003dtenant_id,"},{"line_number":3400,"context_line":"                                        **kwargs)"},{"line_number":3401,"context_line":""},{"line_number":3402,"context_line":"    def create_floatingip(self, net_port_dns\u003dFalse, flip_dns\u003dFalse,"},{"line_number":3403,"context_line":"                          assoc_port_on_creation\u003dFalse,"},{"line_number":3404,"context_line":"                          assoc_port_after_creation\u003dFalse):"},{"line_number":3405,"context_line":"        # The assoc_port_on_creation flag is used for associating the floating"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_ce12d4b3","line":3402,"updated":"2016-06-13 20:20:00.000000000","message":"In my opinion, this has to be an internal method, starting with _","commit_id":"d0e1cd64d26bf1e1afc379ed87e1302dbaec43ad"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"24f338ef2a8b6161cca94653da8f5b1ab4d4828a","unresolved":false,"context_lines":[{"line_number":3399,"context_line":"                                        tenant_id\u003dtenant_id,"},{"line_number":3400,"context_line":"                                        **kwargs)"},{"line_number":3401,"context_line":""},{"line_number":3402,"context_line":"    def create_floatingip(self, net_port_dns\u003dFalse, flip_dns\u003dFalse,"},{"line_number":3403,"context_line":"                          assoc_port_on_creation\u003dFalse,"},{"line_number":3404,"context_line":"                          assoc_port_after_creation\u003dFalse):"},{"line_number":3405,"context_line":"        # The assoc_port_on_creation flag is used for associating the floating"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_95901198","line":3402,"in_reply_to":"7aa08908_ce12d4b3","updated":"2016-06-17 06:40:18.000000000","message":"Done","commit_id":"d0e1cd64d26bf1e1afc379ed87e1302dbaec43ad"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"90f2c96733fd5e150c6e2950ae891984ff0bf870","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                           floating_ip\u003dNone, subnet_id\u003dFalse,"},{"line_number":428,"context_line":"                           tenant_id\u003dNone, dns_domain\u003dNone,"},{"line_number":429,"context_line":"                           dns_name\u003dNone):"},{"line_number":430,"context_line":"        tenant_id \u003d tenant_id or self._tenant_id"},{"line_number":431,"context_line":"        data \u003d {\u0027floatingip\u0027: {\u0027tenant_id\u0027: tenant_id}}"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"        if network_id:"},{"line_number":434,"context_line":"            data[\u0027floatingip\u0027][\u0027floating_network_id\u0027] \u003d network_id"},{"line_number":435,"context_line":"        if port_id:"},{"line_number":436,"context_line":"            data[\u0027floatingip\u0027][\u0027port_id\u0027] \u003d port_id"},{"line_number":437,"context_line":"            if fixed_ip:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_cf627416","line":434,"range":{"start_line":430,"start_character":8,"end_line":434,"end_character":66},"updated":"2016-06-22 15:57:46.000000000","message":"This change seems unnecessary. If I re-store this to its previous state, the 12 test cases for DNS still succeed","commit_id":"5f6fb73f08a3a67b8eb9d4a765ddc80f3cc1fb53"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"90f2c96733fd5e150c6e2950ae891984ff0bf870","unresolved":false,"context_lines":[{"line_number":3418,"context_line":""},{"line_number":3419,"context_line":"        # If net_port_dns is not set, the variable names still need to"},{"line_number":3420,"context_line":"        # be valid for the later call. Set them to empty string so that"},{"line_number":3421,"context_line":"        # they are valid varaibles but will not trigger a call to external DNS"},{"line_number":3422,"context_line":"        # This seems kinda hacky to me, but I can\u0027t think of a better way"},{"line_number":3423,"context_line":"        # that doesn\u0027t involve a lot of copied code. Any ideas?"},{"line_number":3424,"context_line":"        if not net_port_dns:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_787831c5","line":3421,"range":{"start_line":3421,"start_character":25,"end_line":3421,"end_character":34},"updated":"2016-06-22 15:57:46.000000000","message":"variables","commit_id":"5f6fb73f08a3a67b8eb9d4a765ddc80f3cc1fb53"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"d4d63f06cd5294e9a1927e9abeb4298609f400a6","unresolved":false,"context_lines":[{"line_number":3418,"context_line":""},{"line_number":3419,"context_line":"        # If net_port_dns is not set, the variable names still need to"},{"line_number":3420,"context_line":"        # be valid for the later call. Set them to empty string so that"},{"line_number":3421,"context_line":"        # they are valid varaibles but will not trigger a call to external DNS"},{"line_number":3422,"context_line":"        # This seems kinda hacky to me, but I can\u0027t think of a better way"},{"line_number":3423,"context_line":"        # that doesn\u0027t involve a lot of copied code. Any ideas?"},{"line_number":3424,"context_line":"        if not net_port_dns:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_6684d9d3","line":3421,"range":{"start_line":3421,"start_character":25,"end_line":3421,"end_character":34},"in_reply_to":"3aaa91ec_787831c5","updated":"2016-06-23 14:24:48.000000000","message":"Done","commit_id":"5f6fb73f08a3a67b8eb9d4a765ddc80f3cc1fb53"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"71bb26870bf2a11bf5ce993f05670cbbe118459f","unresolved":false,"context_lines":[{"line_number":3419,"context_line":"        # If net_port_dns is not set, the variable names still need to"},{"line_number":3420,"context_line":"        # be valid for the later call. Set them to empty string so that"},{"line_number":3421,"context_line":"        # they are valid varaibles but will not trigger a call to external DNS"},{"line_number":3422,"context_line":"        # This seems kinda hacky to me, but I can\u0027t think of a better way"},{"line_number":3423,"context_line":"        # that doesn\u0027t involve a lot of copied code. Any ideas?"},{"line_number":3424,"context_line":"        if not net_port_dns:"},{"line_number":3425,"context_line":"            net_dns_domain \u003d \u0027\u0027"},{"line_number":3426,"context_line":"            port_dns_name \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_ce219cfd","line":3423,"range":{"start_line":3422,"start_character":8,"end_line":3423,"end_character":63},"updated":"2016-06-22 17:03:17.000000000","message":"I would remove these 2 lines. I don\u0027t think it is too hacky :-)","commit_id":"5f6fb73f08a3a67b8eb9d4a765ddc80f3cc1fb53"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"d4d63f06cd5294e9a1927e9abeb4298609f400a6","unresolved":false,"context_lines":[{"line_number":3419,"context_line":"        # If net_port_dns is not set, the variable names still need to"},{"line_number":3420,"context_line":"        # be valid for the later call. Set them to empty string so that"},{"line_number":3421,"context_line":"        # they are valid varaibles but will not trigger a call to external DNS"},{"line_number":3422,"context_line":"        # This seems kinda hacky to me, but I can\u0027t think of a better way"},{"line_number":3423,"context_line":"        # that doesn\u0027t involve a lot of copied code. Any ideas?"},{"line_number":3424,"context_line":"        if not net_port_dns:"},{"line_number":3425,"context_line":"            net_dns_domain \u003d \u0027\u0027"},{"line_number":3426,"context_line":"            port_dns_name \u003d \u0027\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_267ad1f1","line":3423,"range":{"start_line":3422,"start_character":8,"end_line":3423,"end_character":63},"in_reply_to":"3aaa91ec_ce219cfd","updated":"2016-06-23 14:24:48.000000000","message":"Done","commit_id":"5f6fb73f08a3a67b8eb9d4a765ddc80f3cc1fb53"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"90f2c96733fd5e150c6e2950ae891984ff0bf870","unresolved":false,"context_lines":[{"line_number":3436,"context_line":""},{"line_number":3437,"context_line":"        with self.network(dns_domain\u003dnet_dns_domain) as n:"},{"line_number":3438,"context_line":"            with self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub:"},{"line_number":3439,"context_line":"                 with self.port(private_sub, dns_name\u003dport_dns_name) as p:"},{"line_number":3440,"context_line":""},{"line_number":3441,"context_line":"                    data \u003d {\u0027fmt\u0027: self.fmt}"},{"line_number":3442,"context_line":"                    if flip_dns:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_5847351d","line":3439,"range":{"start_line":3439,"start_character":16,"end_line":3439,"end_character":17},"updated":"2016-06-22 15:57:46.000000000","message":"You have one space too many. Your local pep8 checks didn\u0027t catch because there was a bug in tox.ini that was fixed here: https://review.openstack.org/#/c/332059/","commit_id":"5f6fb73f08a3a67b8eb9d4a765ddc80f3cc1fb53"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"d4d63f06cd5294e9a1927e9abeb4298609f400a6","unresolved":false,"context_lines":[{"line_number":3436,"context_line":""},{"line_number":3437,"context_line":"        with self.network(dns_domain\u003dnet_dns_domain) as n:"},{"line_number":3438,"context_line":"            with self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub:"},{"line_number":3439,"context_line":"                 with self.port(private_sub, dns_name\u003dport_dns_name) as p:"},{"line_number":3440,"context_line":""},{"line_number":3441,"context_line":"                    data \u003d {\u0027fmt\u0027: self.fmt}"},{"line_number":3442,"context_line":"                    if flip_dns:"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_c61cadc3","line":3439,"range":{"start_line":3439,"start_character":16,"end_line":3439,"end_character":17},"in_reply_to":"3aaa91ec_5847351d","updated":"2016-06-23 14:24:48.000000000","message":"Done","commit_id":"5f6fb73f08a3a67b8eb9d4a765ddc80f3cc1fb53"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"90f2c96733fd5e150c6e2950ae891984ff0bf870","unresolved":false,"context_lines":[{"line_number":3489,"context_line":""},{"line_number":3490,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3491,"context_line":"    def test_floatingip_create(self, *mocks):"},{"line_number":3492,"context_line":"        with self._create_floatingip_with_dns() as flip:"},{"line_number":3493,"context_line":"            pass"},{"line_number":3494,"context_line":"        self.mock_client.recordsets.create.assert_not_called()"},{"line_number":3495,"context_line":"        self.mock_admin_client.recordsets.create.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_c73a2898","line":3492,"range":{"start_line":3492,"start_character":47,"end_line":3492,"end_character":55},"updated":"2016-06-22 15:57:46.000000000","message":"Not needed. Please remove. Your local pep8 checks didn\u0027t catch because there was a bug in tox.ini that was fixed here: https://review.openstack.org/#/c/332059/","commit_id":"5f6fb73f08a3a67b8eb9d4a765ddc80f3cc1fb53"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"d4d63f06cd5294e9a1927e9abeb4298609f400a6","unresolved":false,"context_lines":[{"line_number":3489,"context_line":""},{"line_number":3490,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3491,"context_line":"    def test_floatingip_create(self, *mocks):"},{"line_number":3492,"context_line":"        with self._create_floatingip_with_dns() as flip:"},{"line_number":3493,"context_line":"            pass"},{"line_number":3494,"context_line":"        self.mock_client.recordsets.create.assert_not_called()"},{"line_number":3495,"context_line":"        self.mock_admin_client.recordsets.create.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_e621e9fc","line":3492,"range":{"start_line":3492,"start_character":47,"end_line":3492,"end_character":55},"in_reply_to":"3aaa91ec_c73a2898","updated":"2016-06-23 14:24:48.000000000","message":"Done","commit_id":"5f6fb73f08a3a67b8eb9d4a765ddc80f3cc1fb53"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"90f2c96733fd5e150c6e2950ae891984ff0bf870","unresolved":false,"context_lines":[{"line_number":3546,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3547,"context_line":"    def test_floatingip_associate_port(self, *mocks):"},{"line_number":3548,"context_line":"        with self._create_floatingip_with_dns("},{"line_number":3549,"context_line":"                assoc_port_after_creation\u003dTrue) as flip:"},{"line_number":3550,"context_line":"            pass"},{"line_number":3551,"context_line":"        self.mock_client.recordsets.create.assert_not_called()"},{"line_number":3552,"context_line":"        self.mock_admin_client.recordsets.create.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_47d758bf","line":3549,"range":{"start_line":3549,"start_character":47,"end_line":3549,"end_character":55},"updated":"2016-06-22 15:57:46.000000000","message":"Not needed. Please remove. Your local pep8 checks didn\u0027t catch because there was a bug in tox.ini that was fixed here: https://review.openstack.org/#/c/332059/","commit_id":"5f6fb73f08a3a67b8eb9d4a765ddc80f3cc1fb53"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"d4d63f06cd5294e9a1927e9abeb4298609f400a6","unresolved":false,"context_lines":[{"line_number":3546,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3547,"context_line":"    def test_floatingip_associate_port(self, *mocks):"},{"line_number":3548,"context_line":"        with self._create_floatingip_with_dns("},{"line_number":3549,"context_line":"                assoc_port_after_creation\u003dTrue) as flip:"},{"line_number":3550,"context_line":"            pass"},{"line_number":3551,"context_line":"        self.mock_client.recordsets.create.assert_not_called()"},{"line_number":3552,"context_line":"        self.mock_admin_client.recordsets.create.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_4610bda8","line":3549,"range":{"start_line":3549,"start_character":47,"end_line":3549,"end_character":55},"in_reply_to":"3aaa91ec_47d758bf","updated":"2016-06-23 14:24:48.000000000","message":"Done","commit_id":"5f6fb73f08a3a67b8eb9d4a765ddc80f3cc1fb53"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0db25ea72a0f07869fd3145db4dff4dc7b0688e8","unresolved":false,"context_lines":[{"line_number":3363,"context_line":"    PRIVATE_CIDR \u003d \u002710.0.0.0/24\u0027"},{"line_number":3364,"context_line":"    mock_client \u003d mock.MagicMock()"},{"line_number":3365,"context_line":"    mock_admin_client \u003d mock.MagicMock()"},{"line_number":3366,"context_line":"    mock_path \u003d (\u0027neutron.services.externaldns.drivers.\u0027 +"},{"line_number":3367,"context_line":"                 \u0027designate.driver.get_clients\u0027)"},{"line_number":3368,"context_line":"    mock_config \u003d {\u0027return_value\u0027: (mock_client, mock_admin_client)}"},{"line_number":3369,"context_line":"    _extension_drivers \u003d [\u0027dns\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_cff8a17f","line":3366,"range":{"start_line":3366,"start_character":56,"end_line":3366,"end_character":58},"updated":"2016-07-04 08:10:52.000000000","message":"nit: you don\u0027t need the \"+\" here.","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c4eba279893283f891a5c72076d04091d4f59dbc","unresolved":false,"context_lines":[{"line_number":3363,"context_line":"    PRIVATE_CIDR \u003d \u002710.0.0.0/24\u0027"},{"line_number":3364,"context_line":"    mock_client \u003d mock.MagicMock()"},{"line_number":3365,"context_line":"    mock_admin_client \u003d mock.MagicMock()"},{"line_number":3366,"context_line":"    mock_path \u003d (\u0027neutron.services.externaldns.drivers.\u0027 +"},{"line_number":3367,"context_line":"                 \u0027designate.driver.get_clients\u0027)"},{"line_number":3368,"context_line":"    mock_config \u003d {\u0027return_value\u0027: (mock_client, mock_admin_client)}"},{"line_number":3369,"context_line":"    _extension_drivers \u003d [\u0027dns\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_085a4d4f","line":3366,"range":{"start_line":3366,"start_character":56,"end_line":3366,"end_character":58},"in_reply_to":"1aa78d24_cff8a17f","updated":"2016-07-05 22:35:09.000000000","message":"Done","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0db25ea72a0f07869fd3145db4dff4dc7b0688e8","unresolved":false,"context_lines":[{"line_number":3410,"context_line":"    def _create_floatingip_with_dns(self, net_port_dns\u003dFalse, flip_dns\u003dFalse,"},{"line_number":3411,"context_line":"                                    assoc_port_on_creation\u003dFalse,"},{"line_number":3412,"context_line":"                                    assoc_port_after_creation\u003dFalse):"},{"line_number":3413,"context_line":"        # The assoc_port_on_creation flag is used for associating the floating"},{"line_number":3414,"context_line":"        # ip to its port at creation time; the assoc_port_after_creation flag"},{"line_number":3415,"context_line":"        # is used for associating it after the fact in an update call"},{"line_number":3416,"context_line":""},{"line_number":3417,"context_line":"        # If net_port_dns is not set, the variable names still need to"},{"line_number":3418,"context_line":"        # be valid for the later call. Set them to empty string so that"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_12776e3b","line":3415,"range":{"start_line":3413,"start_character":0,"end_line":3415,"end_character":69},"updated":"2016-07-04 08:10:52.000000000","message":"maybe better with a standard comment for parameters. \n\n\"\"\"\n\n:param assoc_port_on_creation:\n\"\"\"","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c4eba279893283f891a5c72076d04091d4f59dbc","unresolved":false,"context_lines":[{"line_number":3410,"context_line":"    def _create_floatingip_with_dns(self, net_port_dns\u003dFalse, flip_dns\u003dFalse,"},{"line_number":3411,"context_line":"                                    assoc_port_on_creation\u003dFalse,"},{"line_number":3412,"context_line":"                                    assoc_port_after_creation\u003dFalse):"},{"line_number":3413,"context_line":"        # The assoc_port_on_creation flag is used for associating the floating"},{"line_number":3414,"context_line":"        # ip to its port at creation time; the assoc_port_after_creation flag"},{"line_number":3415,"context_line":"        # is used for associating it after the fact in an update call"},{"line_number":3416,"context_line":""},{"line_number":3417,"context_line":"        # If net_port_dns is not set, the variable names still need to"},{"line_number":3418,"context_line":"        # be valid for the later call. Set them to empty string so that"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_d3c5968e","line":3415,"range":{"start_line":3413,"start_character":0,"end_line":3415,"end_character":69},"in_reply_to":"1aa78d24_12776e3b","updated":"2016-07-05 22:35:09.000000000","message":"Done","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0db25ea72a0f07869fd3145db4dff4dc7b0688e8","unresolved":false,"context_lines":[{"line_number":3423,"context_line":"        # If both network+port and the floatingip have dns information,"},{"line_number":3424,"context_line":"        # make that information different so we can verify the correct"},{"line_number":3425,"context_line":"        # source of information was used"},{"line_number":3426,"context_line":"        elif net_port_dns and flip_dns:"},{"line_number":3427,"context_line":"            net_dns_domain \u003d \u0027junkdomain.org.\u0027"},{"line_number":3428,"context_line":"            port_dns_name \u003d \u0027junk\u0027"},{"line_number":3429,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_322b8a84","line":3426,"range":{"start_line":3426,"start_character":12,"end_line":3426,"end_character":29},"updated":"2016-07-04 08:10:52.000000000","message":"this is not required.","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c4eba279893283f891a5c72076d04091d4f59dbc","unresolved":false,"context_lines":[{"line_number":3423,"context_line":"        # If both network+port and the floatingip have dns information,"},{"line_number":3424,"context_line":"        # make that information different so we can verify the correct"},{"line_number":3425,"context_line":"        # source of information was used"},{"line_number":3426,"context_line":"        elif net_port_dns and flip_dns:"},{"line_number":3427,"context_line":"            net_dns_domain \u003d \u0027junkdomain.org.\u0027"},{"line_number":3428,"context_line":"            port_dns_name \u003d \u0027junk\u0027"},{"line_number":3429,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_53c88622","line":3426,"range":{"start_line":3426,"start_character":12,"end_line":3426,"end_character":29},"in_reply_to":"1aa78d24_322b8a84","updated":"2016-07-05 22:35:09.000000000","message":"Done","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0db25ea72a0f07869fd3145db4dff4dc7b0688e8","unresolved":false,"context_lines":[{"line_number":3433,"context_line":"        with self.network(dns_domain\u003dnet_dns_domain) as n:"},{"line_number":3434,"context_line":"            with self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub:"},{"line_number":3435,"context_line":"                with self.port(private_sub, dns_name\u003dport_dns_name) as p:"},{"line_number":3436,"context_line":""},{"line_number":3437,"context_line":"                    data \u003d {\u0027fmt\u0027: self.fmt}"},{"line_number":3438,"context_line":"                    if flip_dns:"},{"line_number":3439,"context_line":"                        data[\u0027dns_domain\u0027] \u003d self.DNSDOMAIN"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_f2e4623c","line":3436,"updated":"2016-07-04 08:10:52.000000000","message":"nit: extra empty line","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c4eba279893283f891a5c72076d04091d4f59dbc","unresolved":false,"context_lines":[{"line_number":3433,"context_line":"        with self.network(dns_domain\u003dnet_dns_domain) as n:"},{"line_number":3434,"context_line":"            with self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub:"},{"line_number":3435,"context_line":"                with self.port(private_sub, dns_name\u003dport_dns_name) as p:"},{"line_number":3436,"context_line":""},{"line_number":3437,"context_line":"                    data \u003d {\u0027fmt\u0027: self.fmt}"},{"line_number":3438,"context_line":"                    if flip_dns:"},{"line_number":3439,"context_line":"                        data[\u0027dns_domain\u0027] \u003d self.DNSDOMAIN"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_283589f6","line":3436,"in_reply_to":"1aa78d24_f2e4623c","updated":"2016-07-05 22:35:09.000000000","message":"Done","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0db25ea72a0f07869fd3145db4dff4dc7b0688e8","unresolved":false,"context_lines":[{"line_number":3442,"context_line":"                    # Set ourselves up to call the right function with"},{"line_number":3443,"context_line":"                    # the right arguments for the with block"},{"line_number":3444,"context_line":"                    if assoc_port_on_creation:"},{"line_number":3445,"context_line":"                        data[\u0027fmt\u0027] \u003d self.fmt"},{"line_number":3446,"context_line":"                        data[\u0027tenant_id\u0027] \u003d n[\u0027network\u0027][\u0027tenant_id\u0027]"},{"line_number":3447,"context_line":"                        data[\u0027port_id\u0027] \u003d p[\u0027port\u0027][\u0027id\u0027]"},{"line_number":3448,"context_line":"                        create_floatingip \u003d self.floatingip_with_assoc"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_72f872e6","line":3445,"range":{"start_line":3445,"start_character":24,"end_line":3445,"end_character":46},"updated":"2016-07-04 08:10:52.000000000","message":"I think you have assigned the value at line 3437.","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c4eba279893283f891a5c72076d04091d4f59dbc","unresolved":false,"context_lines":[{"line_number":3442,"context_line":"                    # Set ourselves up to call the right function with"},{"line_number":3443,"context_line":"                    # the right arguments for the with block"},{"line_number":3444,"context_line":"                    if assoc_port_on_creation:"},{"line_number":3445,"context_line":"                        data[\u0027fmt\u0027] \u003d self.fmt"},{"line_number":3446,"context_line":"                        data[\u0027tenant_id\u0027] \u003d n[\u0027network\u0027][\u0027tenant_id\u0027]"},{"line_number":3447,"context_line":"                        data[\u0027port_id\u0027] \u003d p[\u0027port\u0027][\u0027id\u0027]"},{"line_number":3448,"context_line":"                        create_floatingip \u003d self.floatingip_with_assoc"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_d3147645","line":3445,"range":{"start_line":3445,"start_character":24,"end_line":3445,"end_character":46},"in_reply_to":"1aa78d24_72f872e6","updated":"2016-07-05 22:35:09.000000000","message":"Ah, so I have. Done","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0db25ea72a0f07869fd3145db4dff4dc7b0688e8","unresolved":false,"context_lines":[{"line_number":3451,"context_line":"                        create_floatingip \u003d self.floatingip_no_assoc"},{"line_number":3452,"context_line":""},{"line_number":3453,"context_line":"                    with create_floatingip(**data) as flip:"},{"line_number":3454,"context_line":""},{"line_number":3455,"context_line":"                        if assoc_port_after_creation:"},{"line_number":3456,"context_line":"                            flip_id \u003d flip[\u0027floatingip\u0027][\u0027id\u0027]"},{"line_number":3457,"context_line":"                            data \u003d {\u0027floatingip\u0027: {\u0027port_id\u0027: p[\u0027port\u0027][\u0027id\u0027]}}"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_92419e0e","line":3454,"updated":"2016-07-04 08:10:52.000000000","message":"nit: extra empty line","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c4eba279893283f891a5c72076d04091d4f59dbc","unresolved":false,"context_lines":[{"line_number":3451,"context_line":"                        create_floatingip \u003d self.floatingip_no_assoc"},{"line_number":3452,"context_line":""},{"line_number":3453,"context_line":"                    with create_floatingip(**data) as flip:"},{"line_number":3454,"context_line":""},{"line_number":3455,"context_line":"                        if assoc_port_after_creation:"},{"line_number":3456,"context_line":"                            flip_id \u003d flip[\u0027floatingip\u0027][\u0027id\u0027]"},{"line_number":3457,"context_line":"                            data \u003d {\u0027floatingip\u0027: {\u0027port_id\u0027: p[\u0027port\u0027][\u0027id\u0027]}}"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_b3ca8a6c","line":3454,"in_reply_to":"1aa78d24_92419e0e","updated":"2016-07-05 22:35:09.000000000","message":"Done","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0db25ea72a0f07869fd3145db4dff4dc7b0688e8","unresolved":false,"context_lines":[{"line_number":3484,"context_line":"        return in_addr_name, in_addr_zone_name"},{"line_number":3485,"context_line":""},{"line_number":3486,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3487,"context_line":"    def test_floatingip_create(self, *mocks):"},{"line_number":3488,"context_line":"        with self._create_floatingip_with_dns():"},{"line_number":3489,"context_line":"            pass"},{"line_number":3490,"context_line":"        self.mock_client.recordsets.create.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_329a6a15","line":3487,"range":{"start_line":3487,"start_character":37,"end_line":3487,"end_character":43},"updated":"2016-07-04 08:10:52.000000000","message":"why using star mark before mocks? there is only one mock for the method.","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c4eba279893283f891a5c72076d04091d4f59dbc","unresolved":false,"context_lines":[{"line_number":3484,"context_line":"        return in_addr_name, in_addr_zone_name"},{"line_number":3485,"context_line":""},{"line_number":3486,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3487,"context_line":"    def test_floatingip_create(self, *mocks):"},{"line_number":3488,"context_line":"        with self._create_floatingip_with_dns():"},{"line_number":3489,"context_line":"            pass"},{"line_number":3490,"context_line":"        self.mock_client.recordsets.create.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_5b9c135d","line":3487,"range":{"start_line":3487,"start_character":37,"end_line":3487,"end_character":43},"in_reply_to":"1aa78d24_329a6a15","updated":"2016-07-05 22:35:09.000000000","message":"Done","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0db25ea72a0f07869fd3145db4dff4dc7b0688e8","unresolved":false,"context_lines":[{"line_number":3503,"context_line":"        self.mock_admin_client.recordsets.create.assert_called_with("},{"line_number":3504,"context_line":"                in_addr_zone_name, in_addr_name, \u0027PTR\u0027,"},{"line_number":3505,"context_line":"                [\u0027%s.%s\u0027 % (self.DNSNAME, self.DNSDOMAIN)])"},{"line_number":3506,"context_line":"        self.assertEqual(floatingip[\u0027dns_domain\u0027], self.DNSDOMAIN)"},{"line_number":3507,"context_line":"        self.assertEqual(floatingip[\u0027dns_name\u0027], self.DNSNAME)"},{"line_number":3508,"context_line":""},{"line_number":3509,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3510,"context_line":"    def test_floatingip_create_with_net_port_dns(self, *mocks):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_72d6b2c6","line":3507,"range":{"start_line":3506,"start_character":0,"end_line":3507,"end_character":62},"updated":"2016-07-04 08:10:52.000000000","message":"assertEqual should follow the pattern assertEqual(expected, observed)","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c4eba279893283f891a5c72076d04091d4f59dbc","unresolved":false,"context_lines":[{"line_number":3503,"context_line":"        self.mock_admin_client.recordsets.create.assert_called_with("},{"line_number":3504,"context_line":"                in_addr_zone_name, in_addr_name, \u0027PTR\u0027,"},{"line_number":3505,"context_line":"                [\u0027%s.%s\u0027 % (self.DNSNAME, self.DNSDOMAIN)])"},{"line_number":3506,"context_line":"        self.assertEqual(floatingip[\u0027dns_domain\u0027], self.DNSDOMAIN)"},{"line_number":3507,"context_line":"        self.assertEqual(floatingip[\u0027dns_name\u0027], self.DNSNAME)"},{"line_number":3508,"context_line":""},{"line_number":3509,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3510,"context_line":"    def test_floatingip_create_with_net_port_dns(self, *mocks):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_9bf79b8a","line":3507,"range":{"start_line":3506,"start_character":0,"end_line":3507,"end_character":62},"in_reply_to":"1aa78d24_72d6b2c6","updated":"2016-07-05 22:35:09.000000000","message":"Done","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0db25ea72a0f07869fd3145db4dff4dc7b0688e8","unresolved":false,"context_lines":[{"line_number":3568,"context_line":"        with self._create_floatingip_with_dns(net_port_dns\u003dTrue,"},{"line_number":3569,"context_line":"                assoc_port_after_creation\u003dTrue) as flip:"},{"line_number":3570,"context_line":"            floatingip \u003d flip"},{"line_number":3571,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3572,"context_line":"                self.DNSNAME, \u0027A\u0027, [floatingip[\u0027floating_ip_address\u0027]])"},{"line_number":3573,"context_line":"        in_addr_name, in_addr_zone_name \u003d self.get_in_addr("},{"line_number":3574,"context_line":"                floatingip[\u0027floating_ip_address\u0027])"},{"line_number":3575,"context_line":"        self.mock_admin_client.recordsets.create.assert_called_with("},{"line_number":3576,"context_line":"                in_addr_zone_name, in_addr_name, \u0027PTR\u0027,"},{"line_number":3577,"context_line":"                [\u0027%s.%s\u0027 % (self.DNSNAME, self.DNSDOMAIN)])"},{"line_number":3578,"context_line":""},{"line_number":3579,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3580,"context_line":"    def test_floatingip_associate_port_with_flip_and_net_port_dns(self,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_35653445","line":3577,"range":{"start_line":3571,"start_character":0,"end_line":3577,"end_character":59},"updated":"2016-07-04 08:10:52.000000000","message":"I see these code appears multiple times, can it be in one helper method to eliminate the duplication.","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c4eba279893283f891a5c72076d04091d4f59dbc","unresolved":false,"context_lines":[{"line_number":3568,"context_line":"        with self._create_floatingip_with_dns(net_port_dns\u003dTrue,"},{"line_number":3569,"context_line":"                assoc_port_after_creation\u003dTrue) as flip:"},{"line_number":3570,"context_line":"            floatingip \u003d flip"},{"line_number":3571,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNSDOMAIN,"},{"line_number":3572,"context_line":"                self.DNSNAME, \u0027A\u0027, [floatingip[\u0027floating_ip_address\u0027]])"},{"line_number":3573,"context_line":"        in_addr_name, in_addr_zone_name \u003d self.get_in_addr("},{"line_number":3574,"context_line":"                floatingip[\u0027floating_ip_address\u0027])"},{"line_number":3575,"context_line":"        self.mock_admin_client.recordsets.create.assert_called_with("},{"line_number":3576,"context_line":"                in_addr_zone_name, in_addr_name, \u0027PTR\u0027,"},{"line_number":3577,"context_line":"                [\u0027%s.%s\u0027 % (self.DNSNAME, self.DNSDOMAIN)])"},{"line_number":3578,"context_line":""},{"line_number":3579,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3580,"context_line":"    def test_floatingip_associate_port_with_flip_and_net_port_dns(self,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_5e5b61f6","line":3577,"range":{"start_line":3571,"start_character":0,"end_line":3577,"end_character":59},"in_reply_to":"1aa78d24_35653445","updated":"2016-07-05 22:35:09.000000000","message":"Done","commit_id":"3a1e3cd28cfb930ddf10fbe6f0ef0561003cef2d"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8b0cce9d19ced5965118df371037f4086e9a7415","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                           fixed_ip\u003dNone, set_context\u003dFalse,"},{"line_number":428,"context_line":"                           floating_ip\u003dNone, subnet_id\u003dFalse,"},{"line_number":429,"context_line":"                           tenant_id\u003dNone, dns_domain\u003dNone,"},{"line_number":430,"context_line":"                           dns_name\u003dNone):"},{"line_number":431,"context_line":"        tenant_id \u003d tenant_id or self._tenant_id"},{"line_number":432,"context_line":"        data \u003d {\u0027floatingip\u0027: {\u0027floating_network_id\u0027: network_id,"},{"line_number":433,"context_line":"                               \u0027tenant_id\u0027: tenant_id}}"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_f3082b94","line":430,"updated":"2016-10-04 17:27:11.000000000","message":"accept **kwargs here instead of adding these two new params","commit_id":"bd54743a88df26de4cb9a9bad6339b11c8340265"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c9e9f07666705e01d2b6b7a01a5dd6c20dedd391","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                           fixed_ip\u003dNone, set_context\u003dFalse,"},{"line_number":428,"context_line":"                           floating_ip\u003dNone, subnet_id\u003dFalse,"},{"line_number":429,"context_line":"                           tenant_id\u003dNone, dns_domain\u003dNone,"},{"line_number":430,"context_line":"                           dns_name\u003dNone):"},{"line_number":431,"context_line":"        tenant_id \u003d tenant_id or self._tenant_id"},{"line_number":432,"context_line":"        data \u003d {\u0027floatingip\u0027: {\u0027floating_network_id\u0027: network_id,"},{"line_number":433,"context_line":"                               \u0027tenant_id\u0027: tenant_id}}"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_75276312","line":430,"in_reply_to":"1a95cdbc_f3082b94","updated":"2016-10-05 19:08:17.000000000","message":"Done","commit_id":"bd54743a88df26de4cb9a9bad6339b11c8340265"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8b0cce9d19ced5965118df371037f4086e9a7415","unresolved":false,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        if subnet_id:"},{"line_number":443,"context_line":"            data[\u0027floatingip\u0027][\u0027subnet_id\u0027] \u003d subnet_id"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"        if dns_name and dns_domain:"},{"line_number":446,"context_line":"            data[\u0027floatingip\u0027][\u0027dns_domain\u0027] \u003d dns_domain"},{"line_number":447,"context_line":"            data[\u0027floatingip\u0027][\u0027dns_name\u0027] \u003d dns_name"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_d32a4fe7","line":444,"updated":"2016-10-04 17:27:11.000000000","message":"add one line here instead of the two below:\n\ndata[\u0027floatingip\u0027].update(kwargs)","commit_id":"bd54743a88df26de4cb9a9bad6339b11c8340265"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c9e9f07666705e01d2b6b7a01a5dd6c20dedd391","unresolved":false,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":"        if subnet_id:"},{"line_number":443,"context_line":"            data[\u0027floatingip\u0027][\u0027subnet_id\u0027] \u003d subnet_id"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"        if dns_name and dns_domain:"},{"line_number":446,"context_line":"            data[\u0027floatingip\u0027][\u0027dns_domain\u0027] \u003d dns_domain"},{"line_number":447,"context_line":"            data[\u0027floatingip\u0027][\u0027dns_name\u0027] \u003d dns_name"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_5510a7a8","line":444,"in_reply_to":"1a95cdbc_d32a4fe7","updated":"2016-10-05 19:08:17.000000000","message":"Done","commit_id":"bd54743a88df26de4cb9a9bad6339b11c8340265"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8b0cce9d19ced5965118df371037f4086e9a7415","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    def _make_floatingip(self, fmt, network_id, port_id\u003dNone,"},{"line_number":457,"context_line":"                         fixed_ip\u003dNone, set_context\u003dFalse, tenant_id\u003dNone,"},{"line_number":458,"context_line":"                         floating_ip\u003dNone, dns_domain\u003dNone, dns_name\u003dNone,"},{"line_number":459,"context_line":"                         http_status\u003dexc.HTTPCreated.code):"},{"line_number":460,"context_line":"        res \u003d self._create_floatingip(fmt, network_id, port_id,"},{"line_number":461,"context_line":"                                      fixed_ip, set_context, floating_ip,"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_f3e10bd2","line":458,"updated":"2016-10-04 17:27:11.000000000","message":"instead of adding these extension specific things, just allow this function to accept **kwargs","commit_id":"bd54743a88df26de4cb9a9bad6339b11c8340265"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c9e9f07666705e01d2b6b7a01a5dd6c20dedd391","unresolved":false,"context_lines":[{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    def _make_floatingip(self, fmt, network_id, port_id\u003dNone,"},{"line_number":457,"context_line":"                         fixed_ip\u003dNone, set_context\u003dFalse, tenant_id\u003dNone,"},{"line_number":458,"context_line":"                         floating_ip\u003dNone, dns_domain\u003dNone, dns_name\u003dNone,"},{"line_number":459,"context_line":"                         http_status\u003dexc.HTTPCreated.code):"},{"line_number":460,"context_line":"        res \u003d self._create_floatingip(fmt, network_id, port_id,"},{"line_number":461,"context_line":"                                      fixed_ip, set_context, floating_ip,"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_15161fa7","line":458,"in_reply_to":"1a95cdbc_f3e10bd2","updated":"2016-10-05 19:08:17.000000000","message":"Done","commit_id":"bd54743a88df26de4cb9a9bad6339b11c8340265"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8b0cce9d19ced5965118df371037f4086e9a7415","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        res \u003d self._create_floatingip(fmt, network_id, port_id,"},{"line_number":461,"context_line":"                                      fixed_ip, set_context, floating_ip,"},{"line_number":462,"context_line":"                                      tenant_id\u003dtenant_id,"},{"line_number":463,"context_line":"                                      dns_domain\u003ddns_domain, dns_name\u003ddns_name)"},{"line_number":464,"context_line":"        self.assertEqual(http_status, res.status_int)"},{"line_number":465,"context_line":"        return self.deserialize(fmt, res)"},{"line_number":466,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_53d1dffa","line":463,"updated":"2016-10-04 17:27:11.000000000","message":"then pass the **kwargs in here","commit_id":"bd54743a88df26de4cb9a9bad6339b11c8340265"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c9e9f07666705e01d2b6b7a01a5dd6c20dedd391","unresolved":false,"context_lines":[{"line_number":460,"context_line":"        res \u003d self._create_floatingip(fmt, network_id, port_id,"},{"line_number":461,"context_line":"                                      fixed_ip, set_context, floating_ip,"},{"line_number":462,"context_line":"                                      tenant_id\u003dtenant_id,"},{"line_number":463,"context_line":"                                      dns_domain\u003ddns_domain, dns_name\u003ddns_name)"},{"line_number":464,"context_line":"        self.assertEqual(http_status, res.status_int)"},{"line_number":465,"context_line":"        return self.deserialize(fmt, res)"},{"line_number":466,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_d54597b3","line":463,"in_reply_to":"1a95cdbc_53d1dffa","updated":"2016-10-05 19:08:17.000000000","message":"Done","commit_id":"bd54743a88df26de4cb9a9bad6339b11c8340265"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8b0cce9d19ced5965118df371037f4086e9a7415","unresolved":false,"context_lines":[{"line_number":477,"context_line":"    @contextlib.contextmanager"},{"line_number":478,"context_line":"    def floatingip_with_assoc(self, port_id\u003dNone, fmt\u003dNone, fixed_ip\u003dNone,"},{"line_number":479,"context_line":"                              public_cidr\u003d\u002711.0.0.0/24\u0027, set_context\u003dFalse,"},{"line_number":480,"context_line":"                              tenant_id\u003dNone, dns_domain\u003dNone, dns_name\u003dNone):"},{"line_number":481,"context_line":"        with self.subnet(cidr\u003dpublic_cidr,"},{"line_number":482,"context_line":"                         set_context\u003dset_context,"},{"line_number":483,"context_line":"                         tenant_id\u003dtenant_id) as public_sub:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_f3166ba6","line":480,"updated":"2016-10-04 17:27:11.000000000","message":"same here, let\u0027s just take **kwargs and pass it through to _make_floatingip","commit_id":"bd54743a88df26de4cb9a9bad6339b11c8340265"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c9e9f07666705e01d2b6b7a01a5dd6c20dedd391","unresolved":false,"context_lines":[{"line_number":477,"context_line":"    @contextlib.contextmanager"},{"line_number":478,"context_line":"    def floatingip_with_assoc(self, port_id\u003dNone, fmt\u003dNone, fixed_ip\u003dNone,"},{"line_number":479,"context_line":"                              public_cidr\u003d\u002711.0.0.0/24\u0027, set_context\u003dFalse,"},{"line_number":480,"context_line":"                              tenant_id\u003dNone, dns_domain\u003dNone, dns_name\u003dNone):"},{"line_number":481,"context_line":"        with self.subnet(cidr\u003dpublic_cidr,"},{"line_number":482,"context_line":"                         set_context\u003dset_context,"},{"line_number":483,"context_line":"                         tenant_id\u003dtenant_id) as public_sub:"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_b54acbc3","line":480,"in_reply_to":"1a95cdbc_f3166ba6","updated":"2016-10-05 19:08:17.000000000","message":"Done","commit_id":"bd54743a88df26de4cb9a9bad6339b11c8340265"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8b0cce9d19ced5965118df371037f4086e9a7415","unresolved":false,"context_lines":[{"line_number":520,"context_line":"    @contextlib.contextmanager"},{"line_number":521,"context_line":"    def floatingip_no_assoc_with_public_sub("},{"line_number":522,"context_line":"        self, private_sub, fmt\u003dNone, set_context\u003dFalse, public_sub\u003dNone,"},{"line_number":523,"context_line":"        dns_domain\u003dNone, dns_name\u003dNone):"},{"line_number":524,"context_line":"        self._set_net_external(public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":525,"context_line":"        with self.router() as r:"},{"line_number":526,"context_line":"            floatingip \u003d None"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_73233b06","line":523,"updated":"2016-10-04 17:27:11.000000000","message":"ditto","commit_id":"bd54743a88df26de4cb9a9bad6339b11c8340265"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c9e9f07666705e01d2b6b7a01a5dd6c20dedd391","unresolved":false,"context_lines":[{"line_number":520,"context_line":"    @contextlib.contextmanager"},{"line_number":521,"context_line":"    def floatingip_no_assoc_with_public_sub("},{"line_number":522,"context_line":"        self, private_sub, fmt\u003dNone, set_context\u003dFalse, public_sub\u003dNone,"},{"line_number":523,"context_line":"        dns_domain\u003dNone, dns_name\u003dNone):"},{"line_number":524,"context_line":"        self._set_net_external(public_sub[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":525,"context_line":"        with self.router() as r:"},{"line_number":526,"context_line":"            floatingip \u003d None"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_953b0f38","line":523,"in_reply_to":"1a95cdbc_73233b06","updated":"2016-10-05 19:08:17.000000000","message":"Done","commit_id":"bd54743a88df26de4cb9a9bad6339b11c8340265"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8b0cce9d19ced5965118df371037f4086e9a7415","unresolved":false,"context_lines":[{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    @contextlib.contextmanager"},{"line_number":548,"context_line":"    def floatingip_no_assoc(self, private_sub, fmt\u003dNone, set_context\u003dFalse,"},{"line_number":549,"context_line":"                            dns_domain\u003dNone, dns_name\u003dNone):"},{"line_number":550,"context_line":"        with self.subnet(cidr\u003d\u002712.0.0.0/24\u0027) as public_sub:"},{"line_number":551,"context_line":"            with self.floatingip_no_assoc_with_public_sub("},{"line_number":552,"context_line":"                private_sub, fmt, set_context, public_sub,"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_f37d8be8","line":549,"updated":"2016-10-04 17:27:11.000000000","message":"ditto","commit_id":"bd54743a88df26de4cb9a9bad6339b11c8340265"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"c9e9f07666705e01d2b6b7a01a5dd6c20dedd391","unresolved":false,"context_lines":[{"line_number":546,"context_line":""},{"line_number":547,"context_line":"    @contextlib.contextmanager"},{"line_number":548,"context_line":"    def floatingip_no_assoc(self, private_sub, fmt\u003dNone, set_context\u003dFalse,"},{"line_number":549,"context_line":"                            dns_domain\u003dNone, dns_name\u003dNone):"},{"line_number":550,"context_line":"        with self.subnet(cidr\u003d\u002712.0.0.0/24\u0027) as public_sub:"},{"line_number":551,"context_line":"            with self.floatingip_no_assoc_with_public_sub("},{"line_number":552,"context_line":"                private_sub, fmt, set_context, public_sub,"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a95cdbc_754043a6","line":549,"in_reply_to":"1a95cdbc_f37d8be8","updated":"2016-10-05 19:08:17.000000000","message":"Done","commit_id":"bd54743a88df26de4cb9a9bad6339b11c8340265"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a7726e025937c069883954c8e0c3a0e9a4b3151c","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        if subnet_id:"},{"line_number":442,"context_line":"            data[\u0027floatingip\u0027][\u0027subnet_id\u0027] \u003d subnet_id"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        data[\u0027floatingip\u0027].update(kwargs)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        floatingip_req \u003d self.new_create_request(\u0027floatingips\u0027, data, fmt)"},{"line_number":447,"context_line":"        if set_context and tenant_id:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_ba3ad434","line":444,"updated":"2016-10-12 22:09:17.000000000","message":"This seems cryptic to me. It took me a bit of looking through the code and it seems to be just a lazy way to pass dns_name and dns_domain through the stack from L3878, right? The problem is that it makes this code difficult to follow. Consider passing the new arguments explicitly and not taking the \"easy\" way out by passing a generic kwargs around everywhere.","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"687e05ea20d98656ee73efee723471018f531969","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        if subnet_id:"},{"line_number":442,"context_line":"            data[\u0027floatingip\u0027][\u0027subnet_id\u0027] \u003d subnet_id"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        data[\u0027floatingip\u0027].update(kwargs)"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"        floatingip_req \u003d self.new_create_request(\u0027floatingips\u0027, data, fmt)"},{"line_number":447,"context_line":"        if set_context and tenant_id:"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_b23cdf30","line":444,"in_reply_to":"fa6399be_ba3ad434","updated":"2016-11-09 22:15:05.000000000","message":"Your suggestion is how I wrote it originally, but I received feedback to the contrary last patchset. I believe the reasoning was leaving extension-specific information out of more generic methods. What do you think?","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a7726e025937c069883954c8e0c3a0e9a4b3151c","unresolved":false,"context_lines":[{"line_number":3799,"context_line":"    PRIVATE_CIDR \u003d \u002710.0.0.0/24\u0027"},{"line_number":3800,"context_line":"    mock_client \u003d mock.MagicMock()"},{"line_number":3801,"context_line":"    mock_admin_client \u003d mock.MagicMock()"},{"line_number":3802,"context_line":"    mock_path \u003d (\u0027neutron.services.externaldns.drivers.\u0027"},{"line_number":3803,"context_line":"                 \u0027designate.driver.get_clients\u0027)"},{"line_number":3804,"context_line":"    mock_config \u003d {\u0027return_value\u0027: (mock_client, mock_admin_client)}"},{"line_number":3805,"context_line":"    _extension_drivers \u003d [\u0027dns\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_196f2093","line":3802,"updated":"2016-10-12 22:09:17.000000000","message":"Usually string constant names are in all caps.","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"687e05ea20d98656ee73efee723471018f531969","unresolved":false,"context_lines":[{"line_number":3799,"context_line":"    PRIVATE_CIDR \u003d \u002710.0.0.0/24\u0027"},{"line_number":3800,"context_line":"    mock_client \u003d mock.MagicMock()"},{"line_number":3801,"context_line":"    mock_admin_client \u003d mock.MagicMock()"},{"line_number":3802,"context_line":"    mock_path \u003d (\u0027neutron.services.externaldns.drivers.\u0027"},{"line_number":3803,"context_line":"                 \u0027designate.driver.get_clients\u0027)"},{"line_number":3804,"context_line":"    mock_config \u003d {\u0027return_value\u0027: (mock_client, mock_admin_client)}"},{"line_number":3805,"context_line":"    _extension_drivers \u003d [\u0027dns\u0027]"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_3217efa4","line":3802,"in_reply_to":"fa6399be_196f2093","updated":"2016-11-09 22:15:05.000000000","message":"Done","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a7726e025937c069883954c8e0c3a0e9a4b3151c","unresolved":false,"context_lines":[{"line_number":3813,"context_line":"        super(L3NatDBFloatingIpTestCaseWithDNS, self).setUp(plugin\u003dplugin,"},{"line_number":3814,"context_line":"                                                            ext_mgr\u003dext_mgr)"},{"line_number":3815,"context_line":"        config.cfg.CONF.set_override(\u0027external_dns_driver\u0027, \u0027designate\u0027)"},{"line_number":3816,"context_line":"        self.mock_client.reset_mock()"},{"line_number":3817,"context_line":"        self.mock_admin_client.reset_mock()"},{"line_number":3818,"context_line":""},{"line_number":3819,"context_line":"    def _create_network(self, fmt, name, admin_state_up,"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_792c9c02","line":3816,"updated":"2016-10-12 22:09:17.000000000","message":"nit: I wonder if there is a reasonable way to not have these be on the class and need resetting each time. My opinion is that using reset_mock instead of proper context managers is just a little sloppier. But, I see why they are on the class, you were trying to be nice and concise by mocking the clients using decorators on the test methods below. I\u0027m just not sure it is worth it. I don\u0027t think you need to change it necessarily.","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a7726e025937c069883954c8e0c3a0e9a4b3151c","unresolved":false,"context_lines":[{"line_number":3844,"context_line":""},{"line_number":3845,"context_line":"    @contextlib.contextmanager"},{"line_number":3846,"context_line":"    def _create_floatingip_with_dns(self, net_port_dns\u003dFalse, flip_dns\u003dFalse,"},{"line_number":3847,"context_line":"                                    assoc_port_on_creation\u003dFalse,"},{"line_number":3848,"context_line":"                                    assoc_port_after_creation\u003dFalse):"},{"line_number":3849,"context_line":"        \"\"\""},{"line_number":3850,"context_line":"        :param assoc_port_on_creation: Associates floating ip to its port"},{"line_number":3851,"context_line":"                at creation time."}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_f442713d","line":3848,"range":{"start_line":3847,"start_character":36,"end_line":3848,"end_character":67},"updated":"2016-10-12 22:09:17.000000000","message":"nit: I assume you want these to be mutually exclusive. IMO, not a good pattern to use two independent args that must be mutually exclusive.\n\nIf it were me, I\u0027d have another method wrap this one and add associate on update. Sort of like this:\n\n  def _create_floatingip_with_dns_on_update(...):\n      with self._create_floatingip_with_dns(...) as flip\n           # all the update stuff here\n           yield ...\n\nThis is just the general idea. I know it isn\u0027t quite this simple but I think with a little refactoring, you could avoid this by having a few different methods that use some common code.","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"687e05ea20d98656ee73efee723471018f531969","unresolved":false,"context_lines":[{"line_number":3844,"context_line":""},{"line_number":3845,"context_line":"    @contextlib.contextmanager"},{"line_number":3846,"context_line":"    def _create_floatingip_with_dns(self, net_port_dns\u003dFalse, flip_dns\u003dFalse,"},{"line_number":3847,"context_line":"                                    assoc_port_on_creation\u003dFalse,"},{"line_number":3848,"context_line":"                                    assoc_port_after_creation\u003dFalse):"},{"line_number":3849,"context_line":"        \"\"\""},{"line_number":3850,"context_line":"        :param assoc_port_on_creation: Associates floating ip to its port"},{"line_number":3851,"context_line":"                at creation time."}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_9924e960","line":3848,"range":{"start_line":3847,"start_character":36,"end_line":3848,"end_character":67},"in_reply_to":"fa6399be_f442713d","updated":"2016-11-09 22:15:05.000000000","message":"I hadn\u0027t particularly intended them to be mutually exclusive, but I suppose setting them both to true doesn\u0027t really do anything other than trigger an extraneous update call.\n\nIt took some finagling, but I\u0027ve separated out the update call into a second function, and the creation of the prerequisites (network, subnet, and port) into a third. Agreed, it looks a lot cleaner now.","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a7726e025937c069883954c8e0c3a0e9a4b3151c","unresolved":false,"context_lines":[{"line_number":3853,"context_line":"                port after it is created, in a separate update call."},{"line_number":3854,"context_line":"        \"\"\""},{"line_number":3855,"context_line":""},{"line_number":3856,"context_line":"        # If net_port_dns is not set, the variable names still need to"},{"line_number":3857,"context_line":"        # be valid for the later call. Set them to empty string so that"},{"line_number":3858,"context_line":"        # they are valid variables but will not trigger a call to external DNS"},{"line_number":3859,"context_line":"        if not net_port_dns:"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_195ba055","line":3856,"updated":"2016-10-12 22:09:17.000000000","message":"nit: I\u0027d push L3856 - L 3871 out to the callers. See my note on L3963 for more detail.","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"687e05ea20d98656ee73efee723471018f531969","unresolved":false,"context_lines":[{"line_number":3853,"context_line":"                port after it is created, in a separate update call."},{"line_number":3854,"context_line":"        \"\"\""},{"line_number":3855,"context_line":""},{"line_number":3856,"context_line":"        # If net_port_dns is not set, the variable names still need to"},{"line_number":3857,"context_line":"        # be valid for the later call. Set them to empty string so that"},{"line_number":3858,"context_line":"        # they are valid variables but will not trigger a call to external DNS"},{"line_number":3859,"context_line":"        if not net_port_dns:"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_d922e151","line":3856,"in_reply_to":"fa6399be_195ba055","updated":"2016-11-09 22:15:05.000000000","message":"Done","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a7726e025937c069883954c8e0c3a0e9a4b3151c","unresolved":false,"context_lines":[{"line_number":3931,"context_line":"                [\u0027%s.%s\u0027 % (self.DNSNAME, self.DNSDOMAIN)])"},{"line_number":3932,"context_line":""},{"line_number":3933,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3934,"context_line":"    def test_floatingip_create(self, mock):"},{"line_number":3935,"context_line":"        with self._create_floatingip_with_dns():"},{"line_number":3936,"context_line":"            pass"},{"line_number":3937,"context_line":"        self.mock_client.recordsets.create.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_1ef386d7","line":3934,"range":{"start_line":3934,"start_character":37,"end_line":3934,"end_character":41},"updated":"2016-10-12 22:09:17.000000000","message":"This shadows the imported mock package. Ditto throughout below.","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"687e05ea20d98656ee73efee723471018f531969","unresolved":false,"context_lines":[{"line_number":3931,"context_line":"                [\u0027%s.%s\u0027 % (self.DNSNAME, self.DNSDOMAIN)])"},{"line_number":3932,"context_line":""},{"line_number":3933,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3934,"context_line":"    def test_floatingip_create(self, mock):"},{"line_number":3935,"context_line":"        with self._create_floatingip_with_dns():"},{"line_number":3936,"context_line":"            pass"},{"line_number":3937,"context_line":"        self.mock_client.recordsets.create.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_520c6394","line":3934,"range":{"start_line":3934,"start_character":37,"end_line":3934,"end_character":41},"in_reply_to":"fa6399be_1ef386d7","updated":"2016-11-09 22:15:05.000000000","message":"Done","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a7726e025937c069883954c8e0c3a0e9a4b3151c","unresolved":false,"context_lines":[{"line_number":3947,"context_line":""},{"line_number":3948,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3949,"context_line":"    def test_floatingip_create_with_net_port_dns(self, mock):"},{"line_number":3950,"context_line":"        config.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNSDOMAIN)"},{"line_number":3951,"context_line":"        with self._create_floatingip_with_dns(net_port_dns\u003dTrue,"},{"line_number":3952,"context_line":"                assoc_port_on_creation\u003dTrue) as flip:"},{"line_number":3953,"context_line":"            floatingip \u003d flip"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_14236506","line":3950,"updated":"2016-10-12 22:09:17.000000000","message":"I\u0027m just wondering, what is the scope of these overrides? Should we be worried they will leak in to other tests?","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"687e05ea20d98656ee73efee723471018f531969","unresolved":false,"context_lines":[{"line_number":3947,"context_line":""},{"line_number":3948,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3949,"context_line":"    def test_floatingip_create_with_net_port_dns(self, mock):"},{"line_number":3950,"context_line":"        config.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNSDOMAIN)"},{"line_number":3951,"context_line":"        with self._create_floatingip_with_dns(net_port_dns\u003dTrue,"},{"line_number":3952,"context_line":"                assoc_port_on_creation\u003dTrue) as flip:"},{"line_number":3953,"context_line":"            floatingip \u003d flip"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_e855881d","line":3950,"in_reply_to":"fa6399be_14236506","updated":"2016-11-09 22:15:05.000000000","message":"I just tested this, the scope of these seem to be limited to each function. A new test in the same class has dns_domain set to openstacklocal","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a7726e025937c069883954c8e0c3a0e9a4b3151c","unresolved":false,"context_lines":[{"line_number":3960,"context_line":"        with self._create_floatingip_with_dns(net_port_dns\u003dTrue,"},{"line_number":3961,"context_line":"                flip_dns\u003dTrue, assoc_port_on_creation\u003dTrue) as flip:"},{"line_number":3962,"context_line":"            floatingip \u003d flip"},{"line_number":3963,"context_line":"        # External DNS service should have been called with floating ip\u0027s"},{"line_number":3964,"context_line":"        # dns information, not the network+port\u0027s dns information"},{"line_number":3965,"context_line":"        self.assert_recordset_created(floatingip[\u0027floating_ip_address\u0027])"},{"line_number":3966,"context_line":"        self.assertEqual(self.DNSDOMAIN, floatingip[\u0027dns_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_39fea437","line":3963,"updated":"2016-10-12 22:09:17.000000000","message":"nit: It feels a little funny to me that the decision to set the dns info differently on the port and floating ip is around L3859 but this is the test that is asking for it. To me it is pushing too much specific knowledge down in to what should be a more generic common method.\n\nI wonder if instead of passing booleans (e.g. flip_dns) to _create_floatingip_with_dns, if we should directly pass the dns attributes (i.e. pass port_dns_domain, port_dns_name, flip_dns_domain, and flip_dns_domain) so that this method has that logic in it.","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"687e05ea20d98656ee73efee723471018f531969","unresolved":false,"context_lines":[{"line_number":3960,"context_line":"        with self._create_floatingip_with_dns(net_port_dns\u003dTrue,"},{"line_number":3961,"context_line":"                flip_dns\u003dTrue, assoc_port_on_creation\u003dTrue) as flip:"},{"line_number":3962,"context_line":"            floatingip \u003d flip"},{"line_number":3963,"context_line":"        # External DNS service should have been called with floating ip\u0027s"},{"line_number":3964,"context_line":"        # dns information, not the network+port\u0027s dns information"},{"line_number":3965,"context_line":"        self.assert_recordset_created(floatingip[\u0027floating_ip_address\u0027])"},{"line_number":3966,"context_line":"        self.assertEqual(self.DNSDOMAIN, floatingip[\u0027dns_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_043317f7","line":3963,"in_reply_to":"fa6399be_39fea437","updated":"2016-11-09 22:15:05.000000000","message":"Yeah, the more I look at this, the more I\u0027m tending to agree with you here. Done","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a7726e025937c069883954c8e0c3a0e9a4b3151c","unresolved":false,"context_lines":[{"line_number":3969,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3970,"context_line":"    def test_floatingip_associate_port(self, mock):"},{"line_number":3971,"context_line":"        with self._create_floatingip_with_dns("},{"line_number":3972,"context_line":"                assoc_port_after_creation\u003dTrue):"},{"line_number":3973,"context_line":"            pass"},{"line_number":3974,"context_line":"        self.mock_client.recordsets.create.assert_not_called()"},{"line_number":3975,"context_line":"        self.mock_admin_client.recordsets.create.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa6399be_99517011","line":3972,"updated":"2016-10-12 22:09:17.000000000","message":"nit: unnecessary line break.","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"687e05ea20d98656ee73efee723471018f531969","unresolved":false,"context_lines":[{"line_number":3969,"context_line":"    @mock.patch(mock_path, **mock_config)"},{"line_number":3970,"context_line":"    def test_floatingip_associate_port(self, mock):"},{"line_number":3971,"context_line":"        with self._create_floatingip_with_dns("},{"line_number":3972,"context_line":"                assoc_port_after_creation\u003dTrue):"},{"line_number":3973,"context_line":"            pass"},{"line_number":3974,"context_line":"        self.mock_client.recordsets.create.assert_not_called()"},{"line_number":3975,"context_line":"        self.mock_admin_client.recordsets.create.assert_not_called()"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a629dbe_329a8f15","line":3972,"in_reply_to":"fa6399be_99517011","updated":"2016-11-09 22:15:05.000000000","message":"Done","commit_id":"e68b1a2847efbb89bde32fd5adc0fbd90aaf5942"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d0bf7a26b01c0cb98449921a366e2f295659739f","unresolved":false,"context_lines":[{"line_number":3790,"context_line":""},{"line_number":3791,"context_line":"class L3NatDBFloatingIpTestCaseWithDNS(L3BaseForSepTests, L3NatTestCaseMixin,"},{"line_number":3792,"context_line":"                                       L3NatDBTestCaseMixin):"},{"line_number":3793,"context_line":"    \"\"\"Unit tests for floating ip functionality.\"\"\""},{"line_number":3794,"context_line":""},{"line_number":3795,"context_line":"    fmt \u003d \u0027json\u0027"},{"line_number":3796,"context_line":"    DNS_NAME \u003d \u0027test\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_0d8d107b","line":3793,"range":{"start_line":3793,"start_character":34,"end_line":3793,"end_character":47},"updated":"2016-11-16 22:50:31.000000000","message":"with external DNS integration","commit_id":"ae427f0d8f7ce3e9eb9bcb2cf419e5213a65d582"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3711b3a36fcb049ac8e64a047df53859cf787cc9","unresolved":false,"context_lines":[{"line_number":3790,"context_line":""},{"line_number":3791,"context_line":"class L3NatDBFloatingIpTestCaseWithDNS(L3BaseForSepTests, L3NatTestCaseMixin,"},{"line_number":3792,"context_line":"                                       L3NatDBTestCaseMixin):"},{"line_number":3793,"context_line":"    \"\"\"Unit tests for floating ip functionality.\"\"\""},{"line_number":3794,"context_line":""},{"line_number":3795,"context_line":"    fmt \u003d \u0027json\u0027"},{"line_number":3796,"context_line":"    DNS_NAME \u003d \u0027test\u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_f9bf1d5e","line":3793,"range":{"start_line":3793,"start_character":34,"end_line":3793,"end_character":47},"in_reply_to":"7a77a97e_0d8d107b","updated":"2016-11-21 15:32:57.000000000","message":"Done","commit_id":"ae427f0d8f7ce3e9eb9bcb2cf419e5213a65d582"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d0bf7a26b01c0cb98449921a366e2f295659739f","unresolved":false,"context_lines":[{"line_number":3842,"context_line":"                                        tenant_id\u003dtenant_id,"},{"line_number":3843,"context_line":"                                        **kwargs)"},{"line_number":3844,"context_line":""},{"line_number":3845,"context_line":"    def create_net_sub_port(self, dns_domain\u003d\u0027\u0027, dns_name\u003d\u0027\u0027):"},{"line_number":3846,"context_line":"        with self.network(dns_domain\u003ddns_domain) as n:"},{"line_number":3847,"context_line":"            with self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub:"},{"line_number":3848,"context_line":"                with self.port(private_sub, dns_name\u003ddns_name) as p:"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_2d648c20","line":3845,"range":{"start_line":3845,"start_character":8,"end_line":3845,"end_character":27},"updated":"2016-11-16 22:50:31.000000000","message":"This should start with _. It is an internal method","commit_id":"ae427f0d8f7ce3e9eb9bcb2cf419e5213a65d582"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3711b3a36fcb049ac8e64a047df53859cf787cc9","unresolved":false,"context_lines":[{"line_number":3842,"context_line":"                                        tenant_id\u003dtenant_id,"},{"line_number":3843,"context_line":"                                        **kwargs)"},{"line_number":3844,"context_line":""},{"line_number":3845,"context_line":"    def create_net_sub_port(self, dns_domain\u003d\u0027\u0027, dns_name\u003d\u0027\u0027):"},{"line_number":3846,"context_line":"        with self.network(dns_domain\u003ddns_domain) as n:"},{"line_number":3847,"context_line":"            with self.subnet(cidr\u003dself.PRIVATE_CIDR, network\u003dn) as private_sub:"},{"line_number":3848,"context_line":"                with self.port(private_sub, dns_name\u003ddns_name) as p:"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_d9ba6171","line":3845,"range":{"start_line":3845,"start_character":8,"end_line":3845,"end_character":27},"in_reply_to":"7a77a97e_2d648c20","updated":"2016-11-21 15:32:57.000000000","message":"Done","commit_id":"ae427f0d8f7ce3e9eb9bcb2cf419e5213a65d582"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d0bf7a26b01c0cb98449921a366e2f295659739f","unresolved":false,"context_lines":[{"line_number":3858,"context_line":"                    dns_domain\u003dnet_dns_domain, dns_name\u003dport_dns_name)"},{"line_number":3859,"context_line":""},{"line_number":3860,"context_line":"        data \u003d {\u0027fmt\u0027: self.fmt}"},{"line_number":3861,"context_line":"        # Remove if statement? Might be unneeded"},{"line_number":3862,"context_line":"        if flip_dns_domain and flip_dns_name:"},{"line_number":3863,"context_line":"            data[\u0027dns_domain\u0027] \u003d flip_dns_domain"},{"line_number":3864,"context_line":"            data[\u0027dns_name\u0027] \u003d flip_dns_name"},{"line_number":3865,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_ed6374da","line":3862,"range":{"start_line":3861,"start_character":1,"end_line":3862,"end_character":45},"updated":"2016-11-16 22:50:31.000000000","message":"Yes, remove it. Not needed","commit_id":"ae427f0d8f7ce3e9eb9bcb2cf419e5213a65d582"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3711b3a36fcb049ac8e64a047df53859cf787cc9","unresolved":false,"context_lines":[{"line_number":3858,"context_line":"                    dns_domain\u003dnet_dns_domain, dns_name\u003dport_dns_name)"},{"line_number":3859,"context_line":""},{"line_number":3860,"context_line":"        data \u003d {\u0027fmt\u0027: self.fmt}"},{"line_number":3861,"context_line":"        # Remove if statement? Might be unneeded"},{"line_number":3862,"context_line":"        if flip_dns_domain and flip_dns_name:"},{"line_number":3863,"context_line":"            data[\u0027dns_domain\u0027] \u003d flip_dns_domain"},{"line_number":3864,"context_line":"            data[\u0027dns_name\u0027] \u003d flip_dns_name"},{"line_number":3865,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_9992a9f5","line":3862,"range":{"start_line":3861,"start_character":1,"end_line":3862,"end_character":45},"in_reply_to":"7a77a97e_ed6374da","updated":"2016-11-21 15:32:57.000000000","message":"Done","commit_id":"ae427f0d8f7ce3e9eb9bcb2cf419e5213a65d582"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d0bf7a26b01c0cb98449921a366e2f295659739f","unresolved":false,"context_lines":[{"line_number":3904,"context_line":"                32 - config.cfg.CONF.designate.ipv4_ptr_zone_prefix_size) / 8)"},{"line_number":3905,"context_line":"        return (128 - config.cfg.CONF.designate.ipv6_ptr_zone_prefix_size) / 4"},{"line_number":3906,"context_line":""},{"line_number":3907,"context_line":"    def get_in_addr(self, record):"},{"line_number":3908,"context_line":"        in_addr_name \u003d netaddr.IPAddress(record).reverse_dns"},{"line_number":3909,"context_line":"        in_addr_zone_name \u003d self._get_in_addr_zone_name(in_addr_name)"},{"line_number":3910,"context_line":"        return in_addr_name, in_addr_zone_name"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_0d7ef0ad","line":3907,"range":{"start_line":3907,"start_character":8,"end_line":3907,"end_character":19},"updated":"2016-11-16 22:50:31.000000000","message":"This should start with _. It is an internal method","commit_id":"ae427f0d8f7ce3e9eb9bcb2cf419e5213a65d582"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3711b3a36fcb049ac8e64a047df53859cf787cc9","unresolved":false,"context_lines":[{"line_number":3904,"context_line":"                32 - config.cfg.CONF.designate.ipv4_ptr_zone_prefix_size) / 8)"},{"line_number":3905,"context_line":"        return (128 - config.cfg.CONF.designate.ipv6_ptr_zone_prefix_size) / 4"},{"line_number":3906,"context_line":""},{"line_number":3907,"context_line":"    def get_in_addr(self, record):"},{"line_number":3908,"context_line":"        in_addr_name \u003d netaddr.IPAddress(record).reverse_dns"},{"line_number":3909,"context_line":"        in_addr_zone_name \u003d self._get_in_addr_zone_name(in_addr_name)"},{"line_number":3910,"context_line":"        return in_addr_name, in_addr_zone_name"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_7985cdab","line":3907,"range":{"start_line":3907,"start_character":8,"end_line":3907,"end_character":19},"in_reply_to":"7a77a97e_0d7ef0ad","updated":"2016-11-21 15:32:57.000000000","message":"Done","commit_id":"ae427f0d8f7ce3e9eb9bcb2cf419e5213a65d582"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d0bf7a26b01c0cb98449921a366e2f295659739f","unresolved":false,"context_lines":[{"line_number":3909,"context_line":"        in_addr_zone_name \u003d self._get_in_addr_zone_name(in_addr_name)"},{"line_number":3910,"context_line":"        return in_addr_name, in_addr_zone_name"},{"line_number":3911,"context_line":""},{"line_number":3912,"context_line":"    def assert_recordset_created(self, floating_ip_address):"},{"line_number":3913,"context_line":"        # The recordsets.create function should be called with:"},{"line_number":3914,"context_line":"        # dns_domain, dns_name, \u0027A\u0027, ip_address (\u0027A\u0027 for IPv4, \u0027AAAA\u0027 for IPv6)"},{"line_number":3915,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNS_DOMAIN,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_6d45a46e","line":3912,"range":{"start_line":3912,"start_character":8,"end_line":3912,"end_character":32},"updated":"2016-11-16 22:50:31.000000000","message":"This should start with _. It is an internal method","commit_id":"ae427f0d8f7ce3e9eb9bcb2cf419e5213a65d582"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3711b3a36fcb049ac8e64a047df53859cf787cc9","unresolved":false,"context_lines":[{"line_number":3909,"context_line":"        in_addr_zone_name \u003d self._get_in_addr_zone_name(in_addr_name)"},{"line_number":3910,"context_line":"        return in_addr_name, in_addr_zone_name"},{"line_number":3911,"context_line":""},{"line_number":3912,"context_line":"    def assert_recordset_created(self, floating_ip_address):"},{"line_number":3913,"context_line":"        # The recordsets.create function should be called with:"},{"line_number":3914,"context_line":"        # dns_domain, dns_name, \u0027A\u0027, ip_address (\u0027A\u0027 for IPv4, \u0027AAAA\u0027 for IPv6)"},{"line_number":3915,"context_line":"        self.mock_client.recordsets.create.assert_called_with(self.DNS_DOMAIN,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a77a97e_598811c7","line":3912,"range":{"start_line":3912,"start_character":8,"end_line":3912,"end_character":32},"in_reply_to":"7a77a97e_6d45a46e","updated":"2016-11-21 15:32:57.000000000","message":"Done","commit_id":"ae427f0d8f7ce3e9eb9bcb2cf419e5213a65d582"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"956933de9239efc5e3cb9f4d09896a9acc9a2ab9","unresolved":false,"context_lines":[{"line_number":3872,"context_line":""},{"line_number":3873,"context_line":""},{"line_number":3874,"context_line":"class L3NatDBFloatingIpTestCaseWithDNS(L3BaseForSepTests, L3NatTestCaseMixin,"},{"line_number":3875,"context_line":"                                       L3NatDBTestCaseMixin):"},{"line_number":3876,"context_line":"    \"\"\"Unit tests for floating ip with external DNS integration\"\"\""},{"line_number":3877,"context_line":""},{"line_number":3878,"context_line":"    fmt \u003d \u0027json\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_5477ca01","line":3875,"range":{"start_line":3875,"start_character":39,"end_line":3875,"end_character":59},"updated":"2017-01-10 20:14:50.000000000","message":"I downloaded the patchset and ran this class test. I noticed that we are running 12 tests cases (http://paste.openstack.org/show/594467/) but I can only count 11 in the code. The reason is that we are also running this test case: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/extensions/test_l3.py#L3805. We don\u0027t need to inherit from the highlighted class. After removing it from here, we run 11 test cases","commit_id":"840371e11efd079978ce9cc42d7415df7acc5d7b"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"535a9fdceb833ca98e6b97dc9dfd70cf7271575a","unresolved":false,"context_lines":[{"line_number":3872,"context_line":""},{"line_number":3873,"context_line":""},{"line_number":3874,"context_line":"class L3NatDBFloatingIpTestCaseWithDNS(L3BaseForSepTests, L3NatTestCaseMixin,"},{"line_number":3875,"context_line":"                                       L3NatDBTestCaseMixin):"},{"line_number":3876,"context_line":"    \"\"\"Unit tests for floating ip with external DNS integration\"\"\""},{"line_number":3877,"context_line":""},{"line_number":3878,"context_line":"    fmt \u003d \u0027json\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_0109832c","line":3875,"range":{"start_line":3875,"start_character":39,"end_line":3875,"end_character":59},"in_reply_to":"ba5201f7_5477ca01","updated":"2017-01-10 20:30:22.000000000","message":"Done","commit_id":"840371e11efd079978ce9cc42d7415df7acc5d7b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"956933de9239efc5e3cb9f4d09896a9acc9a2ab9","unresolved":false,"context_lines":[{"line_number":4028,"context_line":"    @mock.patch(MOCK_PATH, **mock_config)"},{"line_number":4029,"context_line":"    def test_floatingip_create_with_flip_and_net_port_dns(self, mock_args):"},{"line_number":4030,"context_line":"        # If both network+port and the floating ip have dns domain and"},{"line_number":4031,"context_line":"        # dns name, floating ip\u0027s information should take priority"},{"line_number":4032,"context_line":"        with self._create_floatingip_with_dns(net_dns_domain\u003d\u0027junkdomain.org.\u0027,"},{"line_number":4033,"context_line":"                port_dns_name\u003d\u0027junk\u0027, flip_dns_domain\u003dself.DNS_DOMAIN,"},{"line_number":4034,"context_line":"                flip_dns_name\u003dself.DNS_NAME, assoc_port\u003dTrue) as flip:"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_6fb4fb34","line":4031,"updated":"2017-01-10 20:14:50.000000000","message":"To completely test what we want to test here, we need to add this line:\n\nconfig.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNS_DOMAIN)\n\nWithout it, you are creating a port with the default dns_name / dns_domain configuration: http://paste.openstack.org/show/594470/. After adding the line indicated above, we get a port like this http://paste.openstack.org/show/594471/, which is what we want for this test case. It is similar to what you have in line 4073","commit_id":"840371e11efd079978ce9cc42d7415df7acc5d7b"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"535a9fdceb833ca98e6b97dc9dfd70cf7271575a","unresolved":false,"context_lines":[{"line_number":4028,"context_line":"    @mock.patch(MOCK_PATH, **mock_config)"},{"line_number":4029,"context_line":"    def test_floatingip_create_with_flip_and_net_port_dns(self, mock_args):"},{"line_number":4030,"context_line":"        # If both network+port and the floating ip have dns domain and"},{"line_number":4031,"context_line":"        # dns name, floating ip\u0027s information should take priority"},{"line_number":4032,"context_line":"        with self._create_floatingip_with_dns(net_dns_domain\u003d\u0027junkdomain.org.\u0027,"},{"line_number":4033,"context_line":"                port_dns_name\u003d\u0027junk\u0027, flip_dns_domain\u003dself.DNS_DOMAIN,"},{"line_number":4034,"context_line":"                flip_dns_name\u003dself.DNS_NAME, assoc_port\u003dTrue) as flip:"}],"source_content_type":"text/x-python","patch_set":17,"id":"ba5201f7_c1fe9b04","line":4031,"in_reply_to":"ba5201f7_6fb4fb34","updated":"2017-01-10 20:30:22.000000000","message":"Done","commit_id":"840371e11efd079978ce9cc42d7415df7acc5d7b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"acbca4d8085d3762e3ae4011eac560e647b7ecc7","unresolved":false,"context_lines":[{"line_number":3871,"context_line":"        return l3.L3.get_resources()"},{"line_number":3872,"context_line":""},{"line_number":3873,"context_line":""},{"line_number":3874,"context_line":"class L3NatDBFloatingIpTestCaseWithDNS(L3BaseForSepTests, L3NatTestCaseMixin)"},{"line_number":3875,"context_line":"    \"\"\"Unit tests for floating ip with external DNS integration\"\"\""},{"line_number":3876,"context_line":""},{"line_number":3877,"context_line":"    fmt \u003d \u0027json\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"ba5201f7_64209db1","line":3874,"updated":"2017-01-10 21:25:04.000000000","message":"Missing \":\" at EOL","commit_id":"c5521e0cc380c52d064c1dcb8b44d602e2dd28d9"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e88641e00a126371420142c400580f119d5bdf36","unresolved":false,"context_lines":[{"line_number":3864,"context_line":"        # This is done here as the setup process won\u0027t"},{"line_number":3865,"context_line":"        # initialize the main API router which extends"},{"line_number":3866,"context_line":"        # the global attribute map"},{"line_number":3867,"context_line":"        attributes.RESOURCE_ATTRIBUTE_MAP.update("},{"line_number":3868,"context_line":"            l3.RESOURCE_ATTRIBUTE_MAP)"},{"line_number":3869,"context_line":"        attributes.RESOURCE_ATTRIBUTE_MAP[l3.FLOATINGIPS].update("},{"line_number":3870,"context_line":"            dns.EXTENDED_ATTRIBUTES_2_0[l3.FLOATINGIPS])"},{"line_number":3871,"context_line":"        return l3.L3.get_resources()"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5201f7_d58ad119","line":3868,"range":{"start_line":3867,"start_character":8,"end_line":3868,"end_character":38},"updated":"2017-01-10 23:13:28.000000000","message":"I think this is not needed. can a get_resources of parent couldn\u0027t be called ?","commit_id":"dd36243caea7a6e18ee042da72c7327534cb1f16"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e88641e00a126371420142c400580f119d5bdf36","unresolved":false,"context_lines":[{"line_number":3889,"context_line":"    def setUp(self):"},{"line_number":3890,"context_line":"        ext_mgr \u003d L3TestExtensionManagerWithDNS()"},{"line_number":3891,"context_line":"        plugin \u003d \u0027neutron.plugins.ml2.plugin.Ml2Plugin\u0027"},{"line_number":3892,"context_line":"        config.cfg.CONF.set_override(\u0027extension_drivers\u0027,"},{"line_number":3893,"context_line":"                                     self._extension_drivers,"},{"line_number":3894,"context_line":"                                     group\u003d\u0027ml2\u0027)"},{"line_number":3895,"context_line":"        super(L3NatDBFloatingIpTestCaseWithDNS, self).setUp(plugin\u003dplugin,"},{"line_number":3896,"context_line":"                                                            ext_mgr\u003dext_mgr)"},{"line_number":3897,"context_line":"        config.cfg.CONF.set_override(\u0027external_dns_driver\u0027, \u0027designate\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5201f7_b52aade5","line":3894,"range":{"start_line":3892,"start_character":8,"end_line":3894,"end_character":49},"updated":"2017-01-10 23:13:28.000000000","message":"why do we need to override, can\u0027t be append dns to existing drivers or alternatively first fetch extension drivers from conf and then check param is there or not based on that extend the driver.","commit_id":"dd36243caea7a6e18ee042da72c7327534cb1f16"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e88641e00a126371420142c400580f119d5bdf36","unresolved":false,"context_lines":[{"line_number":3980,"context_line":""},{"line_number":3981,"context_line":"    def _get_bytes_or_nybles_to_skip(self, in_addr_name):"},{"line_number":3982,"context_line":"        if \u0027in-addr.arpa\u0027 in in_addr_name:"},{"line_number":3983,"context_line":"            return (("},{"line_number":3984,"context_line":"                32 - config.cfg.CONF.designate.ipv4_ptr_zone_prefix_size) / 8)"},{"line_number":3985,"context_line":"        return (128 - config.cfg.CONF.designate.ipv6_ptr_zone_prefix_size) / 4"},{"line_number":3986,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5201f7_50634fdd","line":3983,"range":{"start_line":3983,"start_character":19,"end_line":3983,"end_character":21},"updated":"2017-01-10 23:13:28.000000000","message":"nit double parenthesis isn\u0027t needed same as return statement below","commit_id":"dd36243caea7a6e18ee042da72c7327534cb1f16"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e88641e00a126371420142c400580f119d5bdf36","unresolved":false,"context_lines":[{"line_number":4011,"context_line":"    def test_floatingip_create_with_flip_dns(self, mock_args):"},{"line_number":4012,"context_line":"        with self._create_floatingip_with_dns(flip_dns_domain\u003dself.DNS_DOMAIN,"},{"line_number":4013,"context_line":"                flip_dns_name\u003dself.DNS_NAME) as flip:"},{"line_number":4014,"context_line":"            floatingip \u003d flip"},{"line_number":4015,"context_line":"        self._assert_recordset_created(floatingip[\u0027floating_ip_address\u0027])"},{"line_number":4016,"context_line":"        self.assertEqual(self.DNS_DOMAIN, floatingip[\u0027dns_domain\u0027])"},{"line_number":4017,"context_line":"        self.assertEqual(self.DNS_NAME, floatingip[\u0027dns_name\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5201f7_d0073fc7","line":4014,"range":{"start_line":4014,"start_character":12,"end_line":4014,"end_character":29},"updated":"2017-01-10 23:13:28.000000000","message":"why is it needed ? can directly use flip below","commit_id":"dd36243caea7a6e18ee042da72c7327534cb1f16"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e88641e00a126371420142c400580f119d5bdf36","unresolved":false,"context_lines":[{"line_number":4021,"context_line":"        config.cfg.CONF.set_override(\u0027dns_domain\u0027, self.DNS_DOMAIN)"},{"line_number":4022,"context_line":"        with self._create_floatingip_with_dns(net_dns_domain\u003dself.DNS_DOMAIN,"},{"line_number":4023,"context_line":"                port_dns_name\u003dself.DNS_NAME, assoc_port\u003dTrue) as flip:"},{"line_number":4024,"context_line":"            floatingip \u003d flip"},{"line_number":4025,"context_line":"        self._assert_recordset_created(floatingip[\u0027floating_ip_address\u0027])"},{"line_number":4026,"context_line":""},{"line_number":4027,"context_line":"    @mock.patch(MOCK_PATH, **mock_config)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5201f7_90ecd7f4","line":4024,"range":{"start_line":4024,"start_character":12,"end_line":4024,"end_character":29},"updated":"2017-01-10 23:13:28.000000000","message":"same here","commit_id":"dd36243caea7a6e18ee042da72c7327534cb1f16"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e88641e00a126371420142c400580f119d5bdf36","unresolved":false,"context_lines":[{"line_number":4035,"context_line":"            floatingip \u003d flip"},{"line_number":4036,"context_line":"        # External DNS service should have been called with floating ip\u0027s"},{"line_number":4037,"context_line":"        # dns information, not the network+port\u0027s dns information"},{"line_number":4038,"context_line":"        self._assert_recordset_created(floatingip[\u0027floating_ip_address\u0027])"},{"line_number":4039,"context_line":"        self.assertEqual(self.DNS_DOMAIN, floatingip[\u0027dns_domain\u0027])"},{"line_number":4040,"context_line":"        self.assertEqual(self.DNS_NAME, floatingip[\u0027dns_name\u0027])"},{"line_number":4041,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5201f7_d0bc9fdd","line":4038,"range":{"start_line":4038,"start_character":39,"end_line":4038,"end_character":72},"updated":"2017-01-10 23:13:28.000000000","message":"same directly use flip[\u0027floating_ip_address\u0027]","commit_id":"dd36243caea7a6e18ee042da72c7327534cb1f16"}]}
