)]}'
{"neutron/tests/unit/db/test_model_base.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4dc1001a107c166cf7d0a54ca1945a15b2cf32ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_be860111","line":1,"updated":"2016-04-05 17:40:50.000000000","message":"# Copyright (c) 2016 OpenStack Foundation.\n#","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4dd6fdc6caf4d19fdd854369500dfaf8d390fda8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_81e122d3","line":1,"in_reply_to":"9a061dce_be860111","updated":"2016-04-05 18:00:12.000000000","message":"No.","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b2f4ee91f5f2d4583a0885bba0c0cb2ab11731f6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def setUp(self):"},{"line_number":23,"context_line":"        # NOTE(ihrachys): make a copy of the declarative base so that the"},{"line_number":24,"context_line":"        # original one is not polluted by test models"},{"line_number":25,"context_line":"        declbase \u003d copy.deepcopy(model_base.BASEV2)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        class ObjectWithDescription(model_base.HasStandardAttributes,"},{"line_number":28,"context_line":"                                    model_base.HasId,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_a4c8b423","line":25,"updated":"2016-04-05 18:27:52.000000000","message":"Could this just go in SqlFixture?","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"681e13cd7fde54a7335ea9e5e5bb58b00e6ea5a5","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def setUp(self):"},{"line_number":23,"context_line":"        # NOTE(ihrachys): make a copy of the declarative base so that the"},{"line_number":24,"context_line":"        # original one is not polluted by test models"},{"line_number":25,"context_line":"        declbase \u003d copy.deepcopy(model_base.BASEV2)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        class ObjectWithDescription(model_base.HasStandardAttributes,"},{"line_number":28,"context_line":"                                    model_base.HasId,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_eaa0b345","line":25,"in_reply_to":"9a061dce_a4c8b423","updated":"2016-04-05 19:11:16.000000000","message":"No, because we need to define the new class before we create all tables from metadata.","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"c9f775f5b3e622ca9f6dce9f5fa89c7004d0c304","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    def setUp(self):"},{"line_number":23,"context_line":"        # NOTE(ihrachys): make a copy of the declarative base so that the"},{"line_number":24,"context_line":"        # original one is not polluted by test models"},{"line_number":25,"context_line":"        declbase \u003d copy.deepcopy(model_base.BASEV2)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        class ObjectWithDescription(model_base.HasStandardAttributes,"},{"line_number":28,"context_line":"                                    model_base.HasId,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_b5ef3c86","line":25,"in_reply_to":"9a061dce_eaa0b345","updated":"2016-04-05 19:30:54.000000000","message":"Bah.","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4dd6fdc6caf4d19fdd854369500dfaf8d390fda8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.ctx \u003d context.get_admin_context()"},{"line_number":35,"context_line":"        super(HasStandardAttributesTest, self).setUp(declbase\u003ddeclbase)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_description(self):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        description \u003d \u0027test-description\u0027"},{"line_number":40,"context_line":"        with self.ctx.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_61ddee0d","line":37,"updated":"2016-04-05 18:00:12.000000000","message":"todo: rename test case.","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"681e13cd7fde54a7335ea9e5e5bb58b00e6ea5a5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.ctx \u003d context.get_admin_context()"},{"line_number":35,"context_line":"        super(HasStandardAttributesTest, self).setUp(declbase\u003ddeclbase)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_description(self):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        description \u003d \u0027test-description\u0027"},{"line_number":40,"context_line":"        with self.ctx.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_8a677724","line":37,"in_reply_to":"9a061dce_61ddee0d","updated":"2016-04-05 19:11:16.000000000","message":"Done","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4dc1001a107c166cf7d0a54ca1945a15b2cf32ee","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                           description\u003ddescription)"},{"line_number":44,"context_line":"            )"},{"line_number":45,"context_line":"            obj \u003d (self.ctx.session.query(self.model).one())"},{"line_number":46,"context_line":"        self.assertEqual(description, obj.description)"},{"line_number":47,"context_line":"        self.assertTrue(obj.created_at)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_beb441d1","line":46,"updated":"2016-04-05 17:40:50.000000000","message":"Why don\u0027t you check against id instead of description?","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4dd6fdc6caf4d19fdd854369500dfaf8d390fda8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                           description\u003ddescription)"},{"line_number":44,"context_line":"            )"},{"line_number":45,"context_line":"            obj \u003d (self.ctx.session.query(self.model).one())"},{"line_number":46,"context_line":"        self.assertEqual(description, obj.description)"},{"line_number":47,"context_line":"        self.assertTrue(obj.created_at)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_c1eb1aaf","line":46,"in_reply_to":"9a061dce_beb441d1","updated":"2016-04-05 18:00:12.000000000","message":"Because I want to check that description is correct. That\u0027s the goal here.","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4dd6fdc6caf4d19fdd854369500dfaf8d390fda8","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            )"},{"line_number":45,"context_line":"            obj \u003d (self.ctx.session.query(self.model).one())"},{"line_number":46,"context_line":"        self.assertEqual(description, obj.description)"},{"line_number":47,"context_line":"        self.assertTrue(obj.created_at)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_81080293","line":47,"updated":"2016-04-05 18:00:12.000000000","message":"todo: check updated_at.","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"681e13cd7fde54a7335ea9e5e5bb58b00e6ea5a5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            )"},{"line_number":45,"context_line":"            obj \u003d (self.ctx.session.query(self.model).one())"},{"line_number":46,"context_line":"        self.assertEqual(description, obj.description)"},{"line_number":47,"context_line":"        self.assertTrue(obj.created_at)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_0a7407cd","line":47,"in_reply_to":"9a061dce_81080293","updated":"2016-04-05 19:11:16.000000000","message":"Done","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"}],"neutron/tests/unit/testlib_api.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4dc1001a107c166cf7d0a54ca1945a15b2cf32ee","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # flag to indicate that the models have been loaded"},{"line_number":63,"context_line":"    _TABLES_ESTABLISHED \u003d False"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def __init__(self, declbase\u003dNone):"},{"line_number":66,"context_line":"        super(SqlFixture, self).__init__()"},{"line_number":67,"context_line":"        self._declbase \u003d declbase"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_7e2f49f6","line":65,"range":{"start_line":65,"start_character":32,"end_line":65,"end_character":36},"updated":"2016-04-05 17:40:50.000000000","message":"s/None/model_base.BASEV2","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"681e13cd7fde54a7335ea9e5e5bb58b00e6ea5a5","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    # flag to indicate that the models have been loaded"},{"line_number":63,"context_line":"    _TABLES_ESTABLISHED \u003d False"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def __init__(self, declbase\u003dNone):"},{"line_number":66,"context_line":"        super(SqlFixture, self).__init__()"},{"line_number":67,"context_line":"        self._declbase \u003d declbase"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_4a555f1b","line":65,"range":{"start_line":65,"start_character":32,"end_line":65,"end_character":36},"in_reply_to":"9a061dce_7e2f49f6","updated":"2016-04-05 19:11:16.000000000","message":"See below.","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b2f4ee91f5f2d4583a0885bba0c0cb2ab11731f6","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def __init__(self, declbase\u003dNone):"},{"line_number":66,"context_line":"        super(SqlFixture, self).__init__()"},{"line_number":67,"context_line":"        self._declbase \u003d declbase"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _setUp(self):"},{"line_number":70,"context_line":"        if self._declbase is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_242784cb","line":67,"updated":"2016-04-05 18:27:52.000000000","message":"Since this is a fixture, wouldn\u0027t it make sense to make a deepcopy of BASEV2 here?","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"681e13cd7fde54a7335ea9e5e5bb58b00e6ea5a5","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def __init__(self, declbase\u003dNone):"},{"line_number":66,"context_line":"        super(SqlFixture, self).__init__()"},{"line_number":67,"context_line":"        self._declbase \u003d declbase"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _setUp(self):"},{"line_number":70,"context_line":"        if self._declbase is None:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_0a09a731","line":67,"in_reply_to":"9a061dce_242784cb","updated":"2016-04-05 19:11:16.000000000","message":"No, because the test class does not control when the fixture is \u0027used\u0027 (and hence when tables are created), while we need to make sure that metadata knows about test models before we get to \u0027usage\u0027.","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"4dc1001a107c166cf7d0a54ca1945a15b2cf32ee","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self._declbase \u003d declbase"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _setUp(self):"},{"line_number":70,"context_line":"        if self._declbase is None:"},{"line_number":71,"context_line":"            self._declbase \u003d model_base.BASEV2"},{"line_number":72,"context_line":"        # Register all data models"},{"line_number":73,"context_line":"        engine \u003d db_api.get_engine()"},{"line_number":74,"context_line":"        if not SqlFixture._TABLES_ESTABLISHED:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_be8721d6","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":46},"updated":"2016-04-05 17:40:50.000000000","message":"I think that these two lines can be avoid providing a default value in the line 65","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"681e13cd7fde54a7335ea9e5e5bb58b00e6ea5a5","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self._declbase \u003d declbase"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _setUp(self):"},{"line_number":70,"context_line":"        if self._declbase is None:"},{"line_number":71,"context_line":"            self._declbase \u003d model_base.BASEV2"},{"line_number":72,"context_line":"        # Register all data models"},{"line_number":73,"context_line":"        engine \u003d db_api.get_engine()"},{"line_number":74,"context_line":"        if not SqlFixture._TABLES_ESTABLISHED:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_2a60eb00","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":46},"in_reply_to":"9a061dce_be8721d6","updated":"2016-04-05 19:11:16.000000000","message":"In that way I would need to set the default BASEV2 value in multiple places, and I want to isolate it just here.","commit_id":"552e423bc6401717acdd9cd6e4a183efbefc8d07"}]}