)]}'
{"neutron/db/securitygroups_db.py":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"fec9eed1fbe97f66d53eafe9be0f6adef6763cc1","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        rule2_copy \u003d rule2.copy()"},{"line_number":563,"context_line":"        rule1_copy.pop(\u0027id\u0027, None)"},{"line_number":564,"context_line":"        rule2_copy.pop(\u0027id\u0027, None)"},{"line_number":565,"context_line":"        if(rule1_copy \u003d\u003d rule2_copy):"},{"line_number":566,"context_line":"            return True"},{"line_number":567,"context_line":"        else:"},{"line_number":568,"context_line":"            return False"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def _check_for_duplicate_rules(self, context, security_group_rules):"},{"line_number":571,"context_line":"        for i in security_group_rules:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_f16b3fb7","line":568,"range":{"start_line":565,"start_character":8,"end_line":568,"end_character":24},"updated":"2016-04-06 23:06:29.000000000","message":"this could replaced as \n\n\nreturn bool(rule1_copy \u003d\u003d rule2_copy)","commit_id":"43b9c2e8f6db521871aa85f1e6e339bf8dfaf367"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"90658cc022b947a7e8422352bf7998adf48768df","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        rule2_copy \u003d rule2.copy()"},{"line_number":563,"context_line":"        rule1_copy.pop(\u0027id\u0027, None)"},{"line_number":564,"context_line":"        rule2_copy.pop(\u0027id\u0027, None)"},{"line_number":565,"context_line":"        if(rule1_copy \u003d\u003d rule2_copy):"},{"line_number":566,"context_line":"            return True"},{"line_number":567,"context_line":"        else:"},{"line_number":568,"context_line":"            return False"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"    def _check_for_duplicate_rules(self, context, security_group_rules):"},{"line_number":571,"context_line":"        for i in security_group_rules:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_d13d5bde","line":568,"range":{"start_line":565,"start_character":8,"end_line":568,"end_character":24},"in_reply_to":"9a061dce_f16b3fb7","updated":"2016-04-06 23:55:31.000000000","message":"Done","commit_id":"43b9c2e8f6db521871aa85f1e6e339bf8dfaf367"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"26462206fa0765eaa3729754f0b5ddbd7277e9ff","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        rule2_copy \u003d rule2.copy()"},{"line_number":563,"context_line":"        rule1_copy.pop(\u0027id\u0027, None)"},{"line_number":564,"context_line":"        rule2_copy.pop(\u0027id\u0027, None)"},{"line_number":565,"context_line":"        return bool(rule1_copy \u003d\u003d rule2_copy)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def _check_for_duplicate_rules(self, context, security_group_rules):"},{"line_number":568,"context_line":"        for i in security_group_rules:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_92b91718","line":565,"range":{"start_line":565,"start_character":15,"end_line":565,"end_character":19},"updated":"2016-04-07 07:51:24.000000000","message":"Why do we need bool() here?","commit_id":"25f4966ed357a84ffb366c7c396cbb173c544ee0"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"91bcc15fdac056d8d068ca4cc1b4e9623ab94084","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        rule2_copy \u003d rule2.copy()"},{"line_number":563,"context_line":"        rule1_copy.pop(\u0027id\u0027, None)"},{"line_number":564,"context_line":"        rule2_copy.pop(\u0027id\u0027, None)"},{"line_number":565,"context_line":"        return bool(rule1_copy \u003d\u003d rule2_copy)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def _check_for_duplicate_rules(self, context, security_group_rules):"},{"line_number":568,"context_line":"        for i in security_group_rules:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_fc6c6ad1","line":565,"range":{"start_line":565,"start_character":15,"end_line":565,"end_character":19},"in_reply_to":"9a061dce_6917fe44","updated":"2016-04-08 02:30:48.000000000","message":"Done","commit_id":"25f4966ed357a84ffb366c7c396cbb173c544ee0"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5bc4dac4c5ba48b01d4ff73bbb7f70e32da4a684","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        rule2_copy \u003d rule2.copy()"},{"line_number":563,"context_line":"        rule1_copy.pop(\u0027id\u0027, None)"},{"line_number":564,"context_line":"        rule2_copy.pop(\u0027id\u0027, None)"},{"line_number":565,"context_line":"        return bool(rule1_copy \u003d\u003d rule2_copy)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def _check_for_duplicate_rules(self, context, security_group_rules):"},{"line_number":568,"context_line":"        for i in security_group_rules:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_6917fe44","line":565,"range":{"start_line":565,"start_character":15,"end_line":565,"end_character":19},"in_reply_to":"9a061dce_8671a60e","updated":"2016-04-08 01:46:06.000000000","message":"I understand. However, it means bool(boolean) and it\u0027s useless. And also I can look at similar codes throughout tree and they use just \"return xxx \u003d\u003d yyy\". So I prefer \"return rule1_copy \u003d\u003d rule2_copy\".","commit_id":"25f4966ed357a84ffb366c7c396cbb173c544ee0"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"02ad0c218ad4cd15674f678eb0fddcd418eb8b6a","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        rule2_copy \u003d rule2.copy()"},{"line_number":563,"context_line":"        rule1_copy.pop(\u0027id\u0027, None)"},{"line_number":564,"context_line":"        rule2_copy.pop(\u0027id\u0027, None)"},{"line_number":565,"context_line":"        return bool(rule1_copy \u003d\u003d rule2_copy)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def _check_for_duplicate_rules(self, context, security_group_rules):"},{"line_number":568,"context_line":"        for i in security_group_rules:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_8671a60e","line":565,"range":{"start_line":565,"start_character":15,"end_line":565,"end_character":19},"in_reply_to":"9a061dce_92b91718","updated":"2016-04-07 22:59:28.000000000","message":"We shouldn\u0027t i only added that because of one the the reviews suggested that. It\u0027s fine either way.","commit_id":"25f4966ed357a84ffb366c7c396cbb173c544ee0"}]}