)]}'
{"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":20257,"name":"liujie","email":"liu.jie3@zte.com.cn","username":"liujie"},"change_message_id":"48f7f38421e81ea131d50d56d54ceb7882a064f1","unresolved":false,"context_lines":[{"line_number":775,"context_line":"            for port in ports:"},{"line_number":776,"context_line":"                fixed_ips \u003d []"},{"line_number":777,"context_line":"                for ip in port[\u0027fixed_ips\u0027]:"},{"line_number":778,"context_line":"                    if ip[\u0027subnet_id\u0027] \u003d\u003d s[\u0027id\u0027]:"},{"line_number":779,"context_line":"                        fixed_ip \u003d {\u0027subnet_id\u0027: s[\u0027id\u0027]}"},{"line_number":780,"context_line":"                        if (port[\u0027device_owner\u0027] in"},{"line_number":781,"context_line":"                            constants.ROUTER_INTERFACE_OWNERS):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_2725345b","line":778,"updated":"2016-04-21 07:22:37.000000000","message":"this line should remove, because the filter had assured the ip[\u0027subnet_id\u0027] \u003d\u003d s[\u0027id\u0027]","commit_id":"8693d21ef34f4b3a4273862894838d47e924b63f"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"692adbf0cc38ddf1b04768b440501a67f03438be","unresolved":false,"context_lines":[{"line_number":775,"context_line":"            for port in ports:"},{"line_number":776,"context_line":"                fixed_ips \u003d []"},{"line_number":777,"context_line":"                for ip in port[\u0027fixed_ips\u0027]:"},{"line_number":778,"context_line":"                    if ip[\u0027subnet_id\u0027] \u003d\u003d s[\u0027id\u0027]:"},{"line_number":779,"context_line":"                        fixed_ip \u003d {\u0027subnet_id\u0027: s[\u0027id\u0027]}"},{"line_number":780,"context_line":"                        if (port[\u0027device_owner\u0027] in"},{"line_number":781,"context_line":"                            constants.ROUTER_INTERFACE_OWNERS):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_f65928fe","line":778,"in_reply_to":"1a122d0e_2725345b","updated":"2016-04-21 09:11:10.000000000","message":"No. Filter at 772 will gives the ports with that subnet_id i.e it excludes ports without that subnet_id.\n\nBut still the filtered ports will have other subnets in fixed_ip along with the filtered subnet_id. We are excluding those subnets in L778.","commit_id":"8693d21ef34f4b3a4273862894838d47e924b63f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"68ac6692630f019254c76ae487da43749c68a7b7","unresolved":false,"context_lines":[{"line_number":782,"context_line":"                            routers.append(port[\u0027device_id\u0027])"},{"line_number":783,"context_line":"                            fixed_ip[\u0027ip_address\u0027] \u003d s[\u0027gateway_ip\u0027]"},{"line_number":784,"context_line":"                        fixed_ips.append(fixed_ip)"},{"line_number":785,"context_line":"                new_port \u003d {\u0027port\u0027: port}"},{"line_number":786,"context_line":"                new_port[\u0027port\u0027][\u0027fixed_ips\u0027] \u003d fixed_ips"},{"line_number":787,"context_line":"                self.update_port(context, port[\u0027id\u0027], new_port)"},{"line_number":788,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_ed45d66e","line":785,"updated":"2016-04-21 09:58:13.000000000","message":"why did you drop the pervious if?","commit_id":"8693d21ef34f4b3a4273862894838d47e924b63f"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"a185ef36d31c38462ff80870dfa2f51e0a413763","unresolved":false,"context_lines":[{"line_number":782,"context_line":"                            routers.append(port[\u0027device_id\u0027])"},{"line_number":783,"context_line":"                            fixed_ip[\u0027ip_address\u0027] \u003d s[\u0027gateway_ip\u0027]"},{"line_number":784,"context_line":"                        fixed_ips.append(fixed_ip)"},{"line_number":785,"context_line":"                new_port \u003d {\u0027port\u0027: port}"},{"line_number":786,"context_line":"                new_port[\u0027port\u0027][\u0027fixed_ips\u0027] \u003d fixed_ips"},{"line_number":787,"context_line":"                self.update_port(context, port[\u0027id\u0027], new_port)"},{"line_number":788,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_fe0a9a77","line":785,"in_reply_to":"1a122d0e_ed45d66e","updated":"2016-04-21 10:48:34.000000000","message":"Because we are already filtering ports based on subnet_id at line 772. So now update_port has to be called for all filtered ports we got at line 772.","commit_id":"8693d21ef34f4b3a4273862894838d47e924b63f"}]}
