)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"70a9e018b4f14b1d6ab034a84483aa5316dfa82d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"If the agent is restarted, the agent should be able to remove the"},{"line_number":18,"context_line":"snat_namespace since it is no more hosted by the current agent."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This functionality was broken since the agent was not checking"},{"line_number":21,"context_line":"for the existing namespace in the node and just comparing it with"},{"line_number":22,"context_line":"the namespace in the namespace manager."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch provides a fix for cleaning up the stale snat namespace."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_043e5cc0","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":38},"updated":"2016-04-07 10:50:24.000000000","message":"Actually l3 agent is checking existing namespaces on the system and does delete orphaned namespaces for routers which were not returned by the server. For DVR router server will return info to the l3 agent if there are dvr serviceable ports on the node so here is the issue: l3 agent doesn\u0027t check if it should handle snat for the router and simply preserve both namespaces (qrouter- and snat-).","commit_id":"dc114739a552d00a35b4bc8a8d81b19ca75a33a6"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"d8f0d8c8188dbd2044f700160d40cb6f2a1ab825","unresolved":false,"context_lines":[{"line_number":17,"context_line":"If the agent is restarted, the agent should be able to remove the"},{"line_number":18,"context_line":"snat_namespace since it is no more hosted by the current agent."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This functionality was broken since the agent was not checking"},{"line_number":21,"context_line":"for the existing namespace in the node and just comparing it with"},{"line_number":22,"context_line":"the namespace in the namespace manager."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch provides a fix for cleaning up the stale snat namespace."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_d929d4e7","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":38},"in_reply_to":"9a061dce_043e5cc0","updated":"2016-04-07 15:50:39.000000000","message":"Oleg, yes it checks for existing namespaces and deletes the orphaned namespaces, only when it receives the update message in the first place.\nIf the agent was down while we remove and the agent comes up later, it does not remove the orphanes namespace.\n\nProbably I should be more clear in the commit message on the   particular issue with the \"Restart\" case here.","commit_id":"dc114739a552d00a35b4bc8a8d81b19ca75a33a6"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"776fa6197bead29fe9513e22abf8492fd0069907","unresolved":false,"context_lines":[{"line_number":17,"context_line":"If the agent is restarted, the agent should be able to remove the"},{"line_number":18,"context_line":"snat_namespace since it is no more hosted by the current agent."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This functionality was broken since the agent was not checking"},{"line_number":21,"context_line":"for the existing namespace in the node and just comparing it with"},{"line_number":22,"context_line":"the namespace in the namespace manager."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch provides a fix for cleaning up the stale snat namespace."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_83a7d8a5","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":38},"in_reply_to":"9a061dce_54a46bb8","updated":"2016-04-07 22:15:54.000000000","message":"Oleg, Yes I see that there is already code to cleanup during the full sync.\nBut this patch addresses an issue where when we send a router_update message with just to remove the snat_namespace, and at that time when the agent dies and after the agent recovers, id does not clean up the namespace. That is what this patch is addressing.\n\nI am not sure if I am missing something here.","commit_id":"dc114739a552d00a35b4bc8a8d81b19ca75a33a6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4eee5e07289c78682a1281d8999d9029fea0144e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"If the agent is restarted, the agent should be able to remove the"},{"line_number":18,"context_line":"snat_namespace since it is no more hosted by the current agent."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This functionality was broken since the agent was not checking"},{"line_number":21,"context_line":"for the existing namespace in the node and just comparing it with"},{"line_number":22,"context_line":"the namespace in the namespace manager."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch provides a fix for cleaning up the stale snat namespace."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_54a46bb8","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":38},"in_reply_to":"9a061dce_74436f13","updated":"2016-04-07 15:59:56.000000000","message":"please see https://github.com/openstack/neutron/blob/master/neutron/agent/l3/agent.py#L540\nand \nhttps://github.com/openstack/neutron/blob/master/neutron/agent/l3/namespace_manager.py#L86-L90","commit_id":"dc114739a552d00a35b4bc8a8d81b19ca75a33a6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c155225dfcff8875d8c0810b4cbc2d1e5c7dbf2d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"If the agent is restarted, the agent should be able to remove the"},{"line_number":18,"context_line":"snat_namespace since it is no more hosted by the current agent."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This functionality was broken since the agent was not checking"},{"line_number":21,"context_line":"for the existing namespace in the node and just comparing it with"},{"line_number":22,"context_line":"the namespace in the namespace manager."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch provides a fix for cleaning up the stale snat namespace."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_4ba78aa6","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":38},"in_reply_to":"9a061dce_83a7d8a5","updated":"2016-04-08 06:29:31.000000000","message":"\u003e\u003eafter the agent recovers, id does not clean up the namespace.\nWell, it does actually.\n\nWhen agent is started it\u0027s doing a fullsync - after it the agent cleans up all stale namespaces. Namespace manager is responsible for this. I think that namespace cleanup logic should be in one place, not throughout the code.","commit_id":"dc114739a552d00a35b4bc8a8d81b19ca75a33a6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b40b55d0c7ebca835a8b11442a50793e6036deba","unresolved":false,"context_lines":[{"line_number":17,"context_line":"If the agent is restarted, the agent should be able to remove the"},{"line_number":18,"context_line":"snat_namespace since it is no more hosted by the current agent."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This functionality was broken since the agent was not checking"},{"line_number":21,"context_line":"for the existing namespace in the node and just comparing it with"},{"line_number":22,"context_line":"the namespace in the namespace manager."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"This patch provides a fix for cleaning up the stale snat namespace."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_74436f13","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":38},"in_reply_to":"9a061dce_d929d4e7","updated":"2016-04-07 15:58:03.000000000","message":"stale namespases are cleaned up during each resync, including resync on agent start or after agent revival","commit_id":"dc114739a552d00a35b4bc8a8d81b19ca75a33a6"}],"neutron/agent/l3/dvr_edge_router.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ea7a338a93d3867b38392238ddcb356e2eb027e4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            # is added, we need to call routes_updated here."},{"line_number":44,"context_line":"            self.routes_updated([], self.router[\u0027routes\u0027])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def external_gateway_updated(self, ex_gw_port, interface_name):"},{"line_number":47,"context_line":"        if not self._is_this_snat_host():"},{"line_number":48,"context_line":"            # no centralized SNAT gateway for this node/agent"},{"line_number":49,"context_line":"            LOG.debug(\"not hosting snat for router: %s\", self.router[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_387641d7","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":32},"updated":"2016-04-14 14:16:13.000000000","message":"will this always be called on agent start (the agent that no longer handles snat for the router). What if gw port was deleted during agent was down?","commit_id":"5967f98e9ca0db4de05671a25c0d719aade1ec2d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"85bb8f23f91a70843f4f4c3b2e2bbe82a88aefe5","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            # is added, we need to call routes_updated here."},{"line_number":44,"context_line":"            self.routes_updated([], self.router[\u0027routes\u0027])"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def external_gateway_updated(self, ex_gw_port, interface_name):"},{"line_number":47,"context_line":"        if not self._is_this_snat_host():"},{"line_number":48,"context_line":"            # no centralized SNAT gateway for this node/agent"},{"line_number":49,"context_line":"            LOG.debug(\"not hosting snat for router: %s\", self.router[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_d9645cba","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":32},"in_reply_to":"5a18252c_387641d7","updated":"2016-04-14 20:19:16.000000000","message":"Oleg I think I need to abandon this patch, since the issue is with the logic were it checks for the self.snat_namespace.\n\nSee the patch below.\nhttps://review.openstack.org/306065","commit_id":"5967f98e9ca0db4de05671a25c0d719aade1ec2d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ea7a338a93d3867b38392238ddcb356e2eb027e4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                          \"namespace.\", self.router.get(\u0027gw_port_host\u0027))"},{"line_number":53,"context_line":"                return self.external_gateway_removed("},{"line_number":54,"context_line":"                    ex_gw_port, interface_name)"},{"line_number":55,"context_line":"            ns_name \u003d self._check_and_get_valid_system_namespace_name("},{"line_number":56,"context_line":"                self.router[\u0027id\u0027])"},{"line_number":57,"context_line":"            if (ns_name is not None and"},{"line_number":58,"context_line":"                not self._get_router_snat_namespace_name()):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_78fef9ae","line":55,"range":{"start_line":55,"start_character":27,"end_line":55,"end_character":69},"updated":"2016-04-14 14:16:13.000000000","message":"why not _get_valid_snat_namespace_name?","commit_id":"5967f98e9ca0db4de05671a25c0d719aade1ec2d"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"85bb8f23f91a70843f4f4c3b2e2bbe82a88aefe5","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                          \"namespace.\", self.router.get(\u0027gw_port_host\u0027))"},{"line_number":53,"context_line":"                return self.external_gateway_removed("},{"line_number":54,"context_line":"                    ex_gw_port, interface_name)"},{"line_number":55,"context_line":"            ns_name \u003d self._check_and_get_valid_system_namespace_name("},{"line_number":56,"context_line":"                self.router[\u0027id\u0027])"},{"line_number":57,"context_line":"            if (ns_name is not None and"},{"line_number":58,"context_line":"                not self._get_router_snat_namespace_name()):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_79742867","line":55,"range":{"start_line":55,"start_character":27,"end_line":55,"end_character":69},"in_reply_to":"5a18252c_78fef9ae","updated":"2016-04-14 20:19:16.000000000","message":"See above for the comments.","commit_id":"5967f98e9ca0db4de05671a25c0d719aade1ec2d"}]}
