)]}'
{"neutron/plugins/ml2/config.py":[{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"84f29f9ebc3485cedb2d7e8274289d7b78160458","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                       \"For example: extension_drivers \u003d port_security,qos\")),"},{"line_number":43,"context_line":"    cfg.IntOpt(\u0027path_mtu\u0027, default\u003dconstants.DEFAULT_NETWORK_MTU,"},{"line_number":44,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":45,"context_line":"               help\u003d_(\u0027Deprecated: use [DEFAULT] global_physnet_mtu instead. \u0027"},{"line_number":46,"context_line":"                      \u0027Maximum size of an IP packet (MTU) that can traverse \u0027"},{"line_number":47,"context_line":"                      \u0027the underlying physical network infrastructure without \u0027"},{"line_number":48,"context_line":"                      \u0027fragmentation. For instances using a \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_58b17546","line":45,"updated":"2016-04-06 19:46:58.000000000","message":"Suggestion: Use [DEFAULT] global_physnet_mtu.","commit_id":"3578b0ba97ca879203e23ed47dcf61600913e146"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"aa2727a7f41df4a4fbfd3beca5922aa3b050f1c6","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                       \"For example: extension_drivers \u003d port_security,qos\")),"},{"line_number":43,"context_line":"    cfg.IntOpt(\u0027path_mtu\u0027, default\u003dconstants.DEFAULT_NETWORK_MTU,"},{"line_number":44,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":45,"context_line":"               help\u003d_(\u0027Deprecated: use [DEFAULT] global_physnet_mtu instead. \u0027"},{"line_number":46,"context_line":"                      \u0027Maximum size of an IP packet (MTU) that can traverse \u0027"},{"line_number":47,"context_line":"                      \u0027the underlying physical network infrastructure without \u0027"},{"line_number":48,"context_line":"                      \u0027fragmentation. For instances using a \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_f8dfa937","line":45,"in_reply_to":"9a061dce_58b17546","updated":"2016-04-06 19:50:45.000000000","message":"I don\u0027t follow what\u0027s the suggestion here. Do you suggest dropping \u0027Deprecated: \u0027 part or what?","commit_id":"3578b0ba97ca879203e23ed47dcf61600913e146"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2ac163e00e72c7fef78e3bb0329adf27b022744c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                       \"For example: extension_drivers \u003d port_security,qos\")),"},{"line_number":43,"context_line":"    cfg.IntOpt(\u0027path_mtu\u0027, default\u003dconstants.DEFAULT_NETWORK_MTU,"},{"line_number":44,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":45,"context_line":"               help\u003d_(\u0027Deprecated: use [DEFAULT] global_physnet_mtu instead. \u0027"},{"line_number":46,"context_line":"                      \u0027Maximum size of an IP packet (MTU) that can traverse \u0027"},{"line_number":47,"context_line":"                      \u0027the underlying physical network infrastructure without \u0027"},{"line_number":48,"context_line":"                      \u0027fragmentation. For instances using a \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_7715553e","line":45,"in_reply_to":"9a061dce_c237534b","updated":"2016-04-07 07:29:45.000000000","message":"Done","commit_id":"3578b0ba97ca879203e23ed47dcf61600913e146"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"8bf8a82261727aca1ea5c37df35abc1184eab7af","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                       \"For example: extension_drivers \u003d port_security,qos\")),"},{"line_number":43,"context_line":"    cfg.IntOpt(\u0027path_mtu\u0027, default\u003dconstants.DEFAULT_NETWORK_MTU,"},{"line_number":44,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":45,"context_line":"               help\u003d_(\u0027Deprecated: use [DEFAULT] global_physnet_mtu instead. \u0027"},{"line_number":46,"context_line":"                      \u0027Maximum size of an IP packet (MTU) that can traverse \u0027"},{"line_number":47,"context_line":"                      \u0027the underlying physical network infrastructure without \u0027"},{"line_number":48,"context_line":"                      \u0027fragmentation. For instances using a \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_c237534b","line":45,"in_reply_to":"9a061dce_f8dfa937","updated":"2016-04-06 21:06:01.000000000","message":"Oh, keep the \"Deprecated:\" ... just capitalize \"U\" and drop the \"instead\".","commit_id":"3578b0ba97ca879203e23ed47dcf61600913e146"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"59bdc53db9a5c961749f5710c0391b3d4379dfbb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                      \u0027fragmentation when tunneling tenant traffic. For \u0027"},{"line_number":46,"context_line":"                      \u0027instances using a self-service/private network, \u0027"},{"line_number":47,"context_line":"                      \u0027neutron subtracts the overlay protocol overhead from \u0027"},{"line_number":48,"context_line":"                      \u0027this value and, assuming advertise_mtu is enabled, \u0027"},{"line_number":49,"context_line":"                      \u0027advertises it to instances. This mapping allows \u0027"},{"line_number":50,"context_line":"                      \u0027specifying a physical network MTU value that differs \u0027"},{"line_number":51,"context_line":"                      \u0027from the default global_physnet_mtu value.\u0027)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_56736f80","line":48,"range":{"start_line":48,"start_character":39,"end_line":48,"end_character":47},"updated":"2016-05-09 11:03:46.000000000","message":"s/assuming/if/ ?","commit_id":"f3228de532ed80e36d955e2cac956c584326e39e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"750175e933776425b8c699b97f01329a40827387","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                      \u0027fragmentation when tunneling tenant traffic. For \u0027"},{"line_number":46,"context_line":"                      \u0027instances using a self-service/private network, \u0027"},{"line_number":47,"context_line":"                      \u0027neutron subtracts the overlay protocol overhead from \u0027"},{"line_number":48,"context_line":"                      \u0027this value and, assuming advertise_mtu is enabled, \u0027"},{"line_number":49,"context_line":"                      \u0027advertises it to instances. This mapping allows \u0027"},{"line_number":50,"context_line":"                      \u0027specifying a physical network MTU value that differs \u0027"},{"line_number":51,"context_line":"                      \u0027from the default global_physnet_mtu value.\u0027)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_15d0861e","line":48,"range":{"start_line":48,"start_character":39,"end_line":48,"end_character":47},"in_reply_to":"dab17558_4f262ecf","updated":"2016-05-16 09:54:51.000000000","message":"I think I applied the suggestion. Mainly, I removed the notion of MTU calculation and advertise_mtu, and left the same text as in physical_network_mtus.","commit_id":"f3228de532ed80e36d955e2cac956c584326e39e"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"1dabc1be93870f240433a4ef6147aa1f241053f4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                      \u0027fragmentation when tunneling tenant traffic. For \u0027"},{"line_number":46,"context_line":"                      \u0027instances using a self-service/private network, \u0027"},{"line_number":47,"context_line":"                      \u0027neutron subtracts the overlay protocol overhead from \u0027"},{"line_number":48,"context_line":"                      \u0027this value and, assuming advertise_mtu is enabled, \u0027"},{"line_number":49,"context_line":"                      \u0027advertises it to instances. This mapping allows \u0027"},{"line_number":50,"context_line":"                      \u0027specifying a physical network MTU value that differs \u0027"},{"line_number":51,"context_line":"                      \u0027from the default global_physnet_mtu value.\u0027)),"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_4f262ecf","line":48,"range":{"start_line":48,"start_character":39,"end_line":48,"end_character":47},"in_reply_to":"dab17558_56736f80","updated":"2016-05-09 12:51:42.000000000","message":"I believe neutron subtracts the overlay protocol overhead regardless of advertise_mtu. The latter just enables DHCP and RA to advertise it to instances. Thus, consider the following wording:\n\nMaximum size of an IP packet (MTU) that can traverse the underlying physical network infrastructure, specifically for overlay (tunnel) networks. In most cases, use the global_physnet_mtu value. However, if overlay networks traverse underlying physical network infrastructure with a different MTU, use that value.\n\nI think we can drop the part about advertise_mtu because it is enabled by default and documented elsewhere.","commit_id":"f3228de532ed80e36d955e2cac956c584326e39e"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8eda7f4ed635cfcd7b4b779076aff1ac0139e553","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                      \u0027fragmentation when tunneling tenant traffic. This \u0027"},{"line_number":46,"context_line":"                      \u0027mapping allows specifying a physical network MTU value \u0027"},{"line_number":47,"context_line":"                      \u0027that differs from the default global_physnet_mtu \u0027"},{"line_number":48,"context_line":"                      \u0027value.\u0027)),"},{"line_number":49,"context_line":"    cfg.ListOpt(\u0027physical_network_mtus\u0027,"},{"line_number":50,"context_line":"                default\u003d[],"},{"line_number":51,"context_line":"                help\u003d_(\"A list of mappings of physical networks to MTU \""}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_ded8b255","line":48,"updated":"2016-05-17 00:46:06.000000000","message":"+1","commit_id":"0c9de5ea1e858eac271198bf06340edc6624b7f7"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"77d6ac4d942f075fc591e1b656ce3995bbd90755","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                      \u0027fragmentation when tunneling tenant traffic. This \u0027"},{"line_number":46,"context_line":"                      \u0027mapping allows specifying a physical network MTU value \u0027"},{"line_number":47,"context_line":"                      \u0027that differs from the default global_physnet_mtu \u0027"},{"line_number":48,"context_line":"                      \u0027value.\u0027)),"},{"line_number":49,"context_line":"    cfg.ListOpt(\u0027physical_network_mtus\u0027,"},{"line_number":50,"context_line":"                default\u003d[],"},{"line_number":51,"context_line":"                help\u003d_(\"A list of mappings of physical networks to MTU \""}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_c722c7a2","line":48,"updated":"2016-05-16 12:59:11.000000000","message":"Looking better, but I\u0027d like to change \"when tunneling tenant traffic\" to \"when using an overlay/tunnel protocol\" and change \"mapping\" to \"option\" because this option doesn\u0027t use key-value pairs.\n\nOf course, in Mitaka, this value need to be specified and is usually the same as global_physnet_mtu. I hope we change it in Newton to be completely optional, and ideally change the name to something more friendly.","commit_id":"0c9de5ea1e858eac271198bf06340edc6624b7f7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d94f3e20dc897df3c46601f4302ab2864b4227cd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                      \u0027fragmentation when tunneling tenant traffic. This \u0027"},{"line_number":46,"context_line":"                      \u0027mapping allows specifying a physical network MTU value \u0027"},{"line_number":47,"context_line":"                      \u0027that differs from the default global_physnet_mtu \u0027"},{"line_number":48,"context_line":"                      \u0027value.\u0027)),"},{"line_number":49,"context_line":"    cfg.ListOpt(\u0027physical_network_mtus\u0027,"},{"line_number":50,"context_line":"                default\u003d[],"},{"line_number":51,"context_line":"                help\u003d_(\"A list of mappings of physical networks to MTU \""}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_7f0d248e","line":48,"in_reply_to":"dab17558_c722c7a2","updated":"2016-05-17 13:10:32.000000000","message":"Done","commit_id":"0c9de5ea1e858eac271198bf06340edc6624b7f7"},{"author":{"_account_id":20839,"name":"xiewj","email":"xie.wenjun2@zte.com.cn","username":"xiewj"},"change_message_id":"068f2a047d27febca5db6f0a54ec5dac7cb0124b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                       \"entrypoints to be loaded from the \""},{"line_number":40,"context_line":"                       \"neutron.ml2.extension_drivers namespace. \""},{"line_number":41,"context_line":"                       \"For example: extension_drivers \u003d port_security,qos\")),"},{"line_number":42,"context_line":"    cfg.IntOpt(\u0027path_mtu\u0027, default\u003d0,"},{"line_number":43,"context_line":"               help\u003d_(\u0027Maximum size of an IP packet (MTU) that can traverse \u0027"},{"line_number":44,"context_line":"                      \u0027the underlying physical network infrastructure without \u0027"},{"line_number":45,"context_line":"                      \u0027fragmentation when using an overlay/tunnel protocol. \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_5d051c78","line":42,"range":{"start_line":42,"start_character":27,"end_line":42,"end_character":34},"updated":"2016-05-26 01:03:25.000000000","message":"In Mitaka, default\u003d1500,I think it should be 1500","commit_id":"403e5a07f51dee1efd335011cdd6b4454d1e7fde"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c267a83e9c4a8a8910f97e8dddf24d3df033b3d4","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                       \"entrypoints to be loaded from the \""},{"line_number":40,"context_line":"                       \"neutron.ml2.extension_drivers namespace. \""},{"line_number":41,"context_line":"                       \"For example: extension_drivers \u003d port_security,qos\")),"},{"line_number":42,"context_line":"    cfg.IntOpt(\u0027path_mtu\u0027, default\u003d0,"},{"line_number":43,"context_line":"               help\u003d_(\u0027Maximum size of an IP packet (MTU) that can traverse \u0027"},{"line_number":44,"context_line":"                      \u0027the underlying physical network infrastructure without \u0027"},{"line_number":45,"context_line":"                      \u0027fragmentation when using an overlay/tunnel protocol. \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_af75e098","line":42,"range":{"start_line":42,"start_character":27,"end_line":42,"end_character":34},"in_reply_to":"bab6814e_5d051c78","updated":"2016-05-26 09:31:06.000000000","message":"No, it was explicitly changed in Newton so that in case of usual setup with consistent underlying physical network MTU for all network types, you need to override just a single option - global_physnet_mtu. In Mitaka, you need to override two - both the global one as well as path_mtu, which is not optimal.\n\nAlso, your comment does not apply to this patch intent.","commit_id":"403e5a07f51dee1efd335011cdd6b4454d1e7fde"}],"releasenotes/notes/deprecate-ml2-path-mtu-f7bfbc9f8b61dfc8.yaml":[{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"84f29f9ebc3485cedb2d7e8274289d7b78160458","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The [ml2] \u0027path_mtu\u0027 option is deprecated and will be removed in the"},{"line_number":4,"context_line":"    \u0027Ocata\u0027 cycle. Instead of this option, use [DEFAULT] global_physnet_mtu to"},{"line_number":5,"context_line":"    make neutron-server calculate network MTU values for you."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a061dce_98494d63","line":5,"updated":"2016-04-06 19:46:58.000000000","message":"Suggestion: Use the [DEFAULT] global_physnet_mtu option to enable calculation of MTU values for virtual networks by the neutron server component.","commit_id":"3578b0ba97ca879203e23ed47dcf61600913e146"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"aa2727a7f41df4a4fbfd3beca5922aa3b050f1c6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The [ml2] \u0027path_mtu\u0027 option is deprecated and will be removed in the"},{"line_number":4,"context_line":"    \u0027Ocata\u0027 cycle. Instead of this option, use [DEFAULT] global_physnet_mtu to"},{"line_number":5,"context_line":"    make neutron-server calculate network MTU values for you."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a061dce_98ef8de8","line":5,"in_reply_to":"9a061dce_98494d63","updated":"2016-04-06 19:50:45.000000000","message":"Will do.","commit_id":"3578b0ba97ca879203e23ed47dcf61600913e146"}]}