)]}'
{"quantum/scheduler/dhcp_agent_scheduler.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4523e334264d074db7d09dfd26a2db2f7180832c","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                for net_id in net_ids:"},{"line_number":111,"context_line":"                    agents \u003d plugin.get_dhcp_agents_hosting_networks("},{"line_number":112,"context_line":"                        context, [net_id], active\u003dTrue)"},{"line_number":113,"context_line":"                    len_active_agents \u003d 0"},{"line_number":114,"context_line":"                    for agent in agents:"},{"line_number":115,"context_line":"                        if agent.id \u003d\u003d dhcp_agent.id:"},{"line_number":116,"context_line":"                            # It means this agent has already hosted the net"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FyDU%3D","line":113,"updated":"2013-05-23 06:03:07.000000000","message":"maybe consider num_active_agents instead of len?\n\nmaybe we should also try and have a private method here that will return the number of active agents per network. it may make the code easier to understand","commit_id":"2635c9c4b6cf3736f13ce6e39c717e0d4bd31f0c"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"7779152293450f18a97b6a4bec1e5ce540c1459a","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                for net_id in net_ids:"},{"line_number":111,"context_line":"                    agents \u003d plugin.get_dhcp_agents_hosting_networks("},{"line_number":112,"context_line":"                        context, [net_id], active\u003dTrue)"},{"line_number":113,"context_line":"                    len_active_agents \u003d 0"},{"line_number":114,"context_line":"                    for agent in agents:"},{"line_number":115,"context_line":"                        if agent.id \u003d\u003d dhcp_agent.id:"},{"line_number":116,"context_line":"                            # It means this agent has already hosted the net"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2Fx6c%3D","line":113,"in_reply_to":"AAAAPH%2F%2FyDU%3D","updated":"2013-05-23 07:31:02.000000000","message":"Done","commit_id":"2635c9c4b6cf3736f13ce6e39c717e0d4bd31f0c"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"ed4e62c758cf37b07d0ec9e37bef77a79ebbea40","unresolved":false,"context_lines":[{"line_number":119,"context_line":"                            hosted_flag \u003d True"},{"line_number":120,"context_line":"                            break"},{"line_number":121,"context_line":"                    if hosted_flag:"},{"line_number":122,"context_line":"                        continue"},{"line_number":123,"context_line":"                    binding \u003d agentschedulers_db.NetworkDhcpAgentBinding()"},{"line_number":124,"context_line":"                    binding.dhcp_agent \u003d dhcp_agent"},{"line_number":125,"context_line":"                    binding.network_id \u003d net_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2FxdE%3D","line":122,"updated":"2013-05-23 12:46:47.000000000","message":"or:\n\nhosted_agent \u003d [True for agent in agents if agent.id \u003d\u003d dhcp_agent.id]\nif hosted_agent:\n   continue\n\nmore clear? But I\u0027m ok with this.","commit_id":"99d96eaac77f77b888c7f156a42dec0d7f9d068c"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":119,"context_line":"                            hosted_flag \u003d True"},{"line_number":120,"context_line":"                            break"},{"line_number":121,"context_line":"                    if hosted_flag:"},{"line_number":122,"context_line":"                        continue"},{"line_number":123,"context_line":"                    binding \u003d agentschedulers_db.NetworkDhcpAgentBinding()"},{"line_number":124,"context_line":"                    binding.dhcp_agent \u003d dhcp_agent"},{"line_number":125,"context_line":"                    binding.network_id \u003d net_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2FxQI%3D","line":122,"in_reply_to":"AAAAPH%2F%2FxS8%3D","updated":"2013-05-23 13:54:16.000000000","message":"Done","commit_id":"99d96eaac77f77b888c7f156a42dec0d7f9d068c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":119,"context_line":"                            hosted_flag \u003d True"},{"line_number":120,"context_line":"                            break"},{"line_number":121,"context_line":"                    if hosted_flag:"},{"line_number":122,"context_line":"                        continue"},{"line_number":123,"context_line":"                    binding \u003d agentschedulers_db.NetworkDhcpAgentBinding()"},{"line_number":124,"context_line":"                    binding.dhcp_agent \u003d dhcp_agent"},{"line_number":125,"context_line":"                    binding.network_id \u003d net_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2FxS8%3D","line":122,"in_reply_to":"AAAAPH%2F%2FxdE%3D","updated":"2013-05-23 13:36:19.000000000","message":"Or:\n\nif any(agent.id \u003d\u003d dhcp_agent.id for agent in agents):\n  continue","commit_id":"99d96eaac77f77b888c7f156a42dec0d7f9d068c"}]}