)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"1a79f5ead28c8bb3beb2641ec6c76f0b951061b0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"place and modifies functional tests accordingly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 1566934"},{"line_number":14,"context_line":"[1] http://bit.ly/1SS5M1t"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iaae46ce7362fedfc53af958600d6d712eb382e9f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a061dce_dd98ae6c","line":14,"updated":"2016-04-07 12:47:44.000000000","message":"nitpicking is it ok to use bit.ly? \n\nThis link could also be interesting:\n\nhttps://github.com/openstack/neutron/blob/1efed3a5321a259d27ec4a6e80352d35fc423c11/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py#L821","commit_id":"4189376a0c41fe9cf78653a6db490ca6d0eea8bc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a385f2af8a83392a2be8ce1b7efe5138faba8998","unresolved":false,"context_lines":[{"line_number":11,"context_line":"place and modifies functional tests accordingly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 1566934"},{"line_number":14,"context_line":"[1] http://bit.ly/1SS5M1t"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Iaae46ce7362fedfc53af958600d6d712eb382e9f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a061dce_dd0b8e7b","line":14,"in_reply_to":"9a061dce_dd98ae6c","updated":"2016-04-07 12:50:52.000000000","message":"I was thinking whether use the link directly but it was insanely long. So if that\u0027s not a problem I\u0027ll add the full link.","commit_id":"4189376a0c41fe9cf78653a6db490ca6d0eea8bc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a7ccae67e85abaa86652ef309b252a4a1d3c2f6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovsfw: Load vlan tag from other_config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVS agent stores vlan tag to other_config only before"},{"line_number":10,"context_line":"setup_port_filter() is called [1]. This patch loads it from correct"},{"line_number":11,"context_line":"place and modifies functional tests accordingly."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a1b2928_0d60f734","line":9,"range":{"start_line":9,"start_character":42,"end_line":9,"end_character":46},"updated":"2016-04-11 10:22:03.000000000","message":"(minor suggestion)\n\nThis sentence confused me :(\n\nI first read the sentence as \"other_config only\", but when I read it next time, I read it as \"only before ...\".\n\nPersonally I would suggest to \"stores vlan tag only to other_config\" or some clearer one.","commit_id":"334300c827e35727f0be11780b511b76f343389c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c55eae19868127688492b70dbbeda6e74d915ec1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ovsfw: Load vlan tag from other_config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVS agent stores vlan tag to other_config only before"},{"line_number":10,"context_line":"setup_port_filter() is called [1]. This patch loads it from correct"},{"line_number":11,"context_line":"place and modifies functional tests accordingly."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a1b2928_93ef08b0","line":9,"range":{"start_line":9,"start_character":42,"end_line":9,"end_character":46},"in_reply_to":"7a1b2928_0d60f734","updated":"2016-04-11 10:56:41.000000000","message":"Done","commit_id":"334300c827e35727f0be11780b511b76f343389c"}],"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"17c539914220f0543b14f05dd7669ea245a09d10","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            \u0027Port\u0027, columns\u003d[\u0027name\u0027, \u0027tag\u0027], if_exists\u003dTrue)"},{"line_number":488,"context_line":"        return {p[\u0027name\u0027]: p[\u0027tag\u0027] for p in results}"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    def get_port_other_config(self, port_name):"},{"line_number":491,"context_line":"        self.db_get_val(\u0027Port\u0027, port_name, \u0027other_config\u0027)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def get_vifs_by_ids(self, port_ids):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_f13bb536","line":490,"updated":"2016-04-09 15:24:29.000000000","message":"This method is defined but it seems it is not used anywhere.","commit_id":"25da22be0ec75fb8e14db7bc6d5bd4eb74c9fdca"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7fd8e2e0d72865c9fb0c43355e84e3305cf70b5a","unresolved":false,"context_lines":[{"line_number":487,"context_line":"            \u0027Port\u0027, columns\u003d[\u0027name\u0027, \u0027tag\u0027], if_exists\u003dTrue)"},{"line_number":488,"context_line":"        return {p[\u0027name\u0027]: p[\u0027tag\u0027] for p in results}"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    def get_port_other_config(self, port_name):"},{"line_number":491,"context_line":"        self.db_get_val(\u0027Port\u0027, port_name, \u0027other_config\u0027)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def get_vifs_by_ids(self, port_ids):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a1b2928_6c6d3432","line":490,"in_reply_to":"9a061dce_f13bb536","updated":"2016-04-11 09:14:46.000000000","message":"Whoops, I planned to use it then I decided to go with passing parameters I\u0027m interested in.","commit_id":"25da22be0ec75fb8e14db7bc6d5bd4eb74c9fdca"}],"neutron/agent/linux/openvswitch_firewall/firewall.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"17c539914220f0543b14f05dd7669ea245a09d10","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"            try:"},{"line_number":248,"context_line":"                other_config \u003d self.int_br.br.db_get_val("},{"line_number":249,"context_line":"                    \u0027Port\u0027, ovs_port.port_name, \u0027other_config\u0027)"},{"line_number":250,"context_line":"                port_vlan_id \u003d int(other_config[\u0027tag\u0027])"},{"line_number":251,"context_line":"            except (KeyError, TypeError):"},{"line_number":252,"context_line":"                LOG.warning(_LW(\"Can\u0027t get tag for port %(port_id)s from its \""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_712fa5f6","line":249,"updated":"2016-04-09 15:24:29.000000000","message":"Is there any reason not to use get_port_other_config()?","commit_id":"25da22be0ec75fb8e14db7bc6d5bd4eb74c9fdca"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7fd8e2e0d72865c9fb0c43355e84e3305cf70b5a","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"            try:"},{"line_number":248,"context_line":"                other_config \u003d self.int_br.br.db_get_val("},{"line_number":249,"context_line":"                    \u0027Port\u0027, ovs_port.port_name, \u0027other_config\u0027)"},{"line_number":250,"context_line":"                port_vlan_id \u003d int(other_config[\u0027tag\u0027])"},{"line_number":251,"context_line":"            except (KeyError, TypeError):"},{"line_number":252,"context_line":"                LOG.warning(_LW(\"Can\u0027t get tag for port %(port_id)s from its \""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a1b2928_07873910","line":249,"in_reply_to":"9a061dce_712fa5f6","updated":"2016-04-11 09:14:46.000000000","message":"I\u0027ll drop that method, it was pushed accidentally. /me should get rid of bad habit using \"git -a\"","commit_id":"25da22be0ec75fb8e14db7bc6d5bd4eb74c9fdca"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"17c539914220f0543b14f05dd7669ea245a09d10","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                LOG.warning(_LW(\"Can\u0027t get tag for port %(port_id)s from its \""},{"line_number":253,"context_line":"                                \"other_config: %(other_config)s\"),"},{"line_number":254,"context_line":"                         port_id\u003dport_id,"},{"line_number":255,"context_line":"                         other_config\u003dother_config)"},{"line_number":256,"context_line":"                port_vlan_id \u003d ovs_consts.DEAD_VLAN_TAG"},{"line_number":257,"context_line":"            of_port \u003d OFPort(port, ovs_port, port_vlan_id)"},{"line_number":258,"context_line":"            self.sg_port_map.create_port(of_port, port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_b1393d44","line":255,"updated":"2016-04-09 15:24:29.000000000","message":"Indent level is wrong..","commit_id":"25da22be0ec75fb8e14db7bc6d5bd4eb74c9fdca"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"7fd8e2e0d72865c9fb0c43355e84e3305cf70b5a","unresolved":false,"context_lines":[{"line_number":252,"context_line":"                LOG.warning(_LW(\"Can\u0027t get tag for port %(port_id)s from its \""},{"line_number":253,"context_line":"                                \"other_config: %(other_config)s\"),"},{"line_number":254,"context_line":"                         port_id\u003dport_id,"},{"line_number":255,"context_line":"                         other_config\u003dother_config)"},{"line_number":256,"context_line":"                port_vlan_id \u003d ovs_consts.DEAD_VLAN_TAG"},{"line_number":257,"context_line":"            of_port \u003d OFPort(port, ovs_port, port_vlan_id)"},{"line_number":258,"context_line":"            self.sg_port_map.create_port(of_port, port)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a1b2928_677c2d21","line":255,"in_reply_to":"9a061dce_b1393d44","updated":"2016-04-11 09:14:46.000000000","message":"Done","commit_id":"25da22be0ec75fb8e14db7bc6d5bd4eb74c9fdca"}],"neutron/tests/common/conn_testers.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"1a79f5ead28c8bb3beb2641ec6c76f0b951061b0","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    def set_tag(self, port_name, tag):"},{"line_number":359,"context_line":"        self.bridge.set_db_attribute(\u0027Port\u0027, port_name, \u0027tag\u0027, tag)"},{"line_number":360,"context_line":"        other_config \u003d self.bridge.db_get_val("},{"line_number":361,"context_line":"            \u0027Port\u0027, port_name, \u0027other_config\u0027)"},{"line_number":362,"context_line":"        other_config[\u0027tag\u0027] \u003d tag"},{"line_number":363,"context_line":"        self.bridge.set_db_attribute("},{"line_number":364,"context_line":"            \u0027Port\u0027, port_name, \u0027other_config\u0027, other_config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_bdb69af6","line":361,"updated":"2016-04-07 12:47:44.000000000","message":"Is there any way we could guarantee we\u0027re sticking to whatever the ovs agent does?, I see we emulate that here in the tests.\n\nI guess it\u0027s something we may want to check in fullstack at some point, right?","commit_id":"4189376a0c41fe9cf78653a6db490ca6d0eea8bc"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"5082ea20bf21cec03a92b35b59cf88266fe205a4","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    def set_tag(self, port_name, tag):"},{"line_number":359,"context_line":"        self.bridge.set_db_attribute(\u0027Port\u0027, port_name, \u0027tag\u0027, tag)"},{"line_number":360,"context_line":"        other_config \u003d self.bridge.db_get_val("},{"line_number":361,"context_line":"            \u0027Port\u0027, port_name, \u0027other_config\u0027)"},{"line_number":362,"context_line":"        other_config[\u0027tag\u0027] \u003d tag"},{"line_number":363,"context_line":"        self.bridge.set_db_attribute("},{"line_number":364,"context_line":"            \u0027Port\u0027, port_name, \u0027other_config\u0027, other_config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_01be44fe","line":361,"in_reply_to":"9a061dce_bd37ba4b","updated":"2016-04-07 13:01:00.000000000","message":"\u0027\u0027:D\n\nWhat\u0027s your name?\nfullstack? \n\nFullstack what?\n\nFullstack fullstack.","commit_id":"4189376a0c41fe9cf78653a6db490ca6d0eea8bc"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a385f2af8a83392a2be8ce1b7efe5138faba8998","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    def set_tag(self, port_name, tag):"},{"line_number":359,"context_line":"        self.bridge.set_db_attribute(\u0027Port\u0027, port_name, \u0027tag\u0027, tag)"},{"line_number":360,"context_line":"        other_config \u003d self.bridge.db_get_val("},{"line_number":361,"context_line":"            \u0027Port\u0027, port_name, \u0027other_config\u0027)"},{"line_number":362,"context_line":"        other_config[\u0027tag\u0027] \u003d tag"},{"line_number":363,"context_line":"        self.bridge.set_db_attribute("},{"line_number":364,"context_line":"            \u0027Port\u0027, port_name, \u0027other_config\u0027, other_config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_bd37ba4b","line":361,"in_reply_to":"9a061dce_bdb69af6","updated":"2016-04-07 12:50:52.000000000","message":"Fullstack is always the universal answer :D Right","commit_id":"4189376a0c41fe9cf78653a6db490ca6d0eea8bc"}]}
