)]}'
{"neutron/db/agents_db.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"abb44baae3ad89eeda79b14848bbeb7ca10b1952","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                res[\u0027availability_zone\u0027] \u003d agent_state[\u0027availability_zone\u0027]"},{"line_number":350,"context_line":"            configurations_dict \u003d agent_state.get(\u0027configurations\u0027, {})"},{"line_number":351,"context_line":"            res[\u0027configurations\u0027] \u003d jsonutils.dumps(configurations_dict)"},{"line_number":352,"context_line":"            resource_versions_dict \u003d agent_state.get(\u0027resource_versions\u0027)"},{"line_number":353,"context_line":"            if resource_versions_dict is not None:"},{"line_number":354,"context_line":"                res[\u0027resource_versions\u0027] \u003d jsonutils.dumps("},{"line_number":355,"context_line":"                    resource_versions_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_8bb38197","line":352,"updated":"2016-04-07 16:50:27.000000000","message":"can we add a note here of why do we \"None\" when not there, or add the note in L477 ?\n\nnit stupid comment: I\u0027d extract this to a separate function this one is growing too much.","commit_id":"b58785953caf475fdac6dfb8595af550d07e2a2d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c1ea8fd6907a603b237c021b75bbee3f67ad1b44","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                res[\u0027availability_zone\u0027] \u003d agent_state[\u0027availability_zone\u0027]"},{"line_number":350,"context_line":"            configurations_dict \u003d agent_state.get(\u0027configurations\u0027, {})"},{"line_number":351,"context_line":"            res[\u0027configurations\u0027] \u003d jsonutils.dumps(configurations_dict)"},{"line_number":352,"context_line":"            resource_versions_dict \u003d agent_state.get(\u0027resource_versions\u0027)"},{"line_number":353,"context_line":"            if resource_versions_dict is not None:"},{"line_number":354,"context_line":"                res[\u0027resource_versions\u0027] \u003d jsonutils.dumps("},{"line_number":355,"context_line":"                    resource_versions_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_89251b0c","line":352,"in_reply_to":"9a061dce_8bb38197","updated":"2016-04-08 12:08:25.000000000","message":"Actually I\u0027m not sure we should explicitly check for None here: is there a case when agent wants to clear its resource_versions? I\u0027ll change to just \"if resource_versions_dict\" to remove confusion","commit_id":"b58785953caf475fdac6dfb8595af550d07e2a2d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"abb44baae3ad89eeda79b14848bbeb7ca10b1952","unresolved":false,"context_lines":[{"line_number":475,"context_line":""},{"line_number":476,"context_line":"    def _update_local_agent_resource_versions(self, context, agent_state):"},{"line_number":477,"context_line":"        resource_versions_dict \u003d agent_state.get(\u0027resource_versions\u0027)"},{"line_number":478,"context_line":"        if resource_versions_dict is None:"},{"line_number":479,"context_line":"            return"},{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        version_manager.update_versions("}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_94b5637f","line":478,"range":{"start_line":478,"start_character":22,"end_line":478,"end_character":23},"updated":"2016-04-07 16:50:27.000000000","message":"I was going to say, \"this won\u0027t work\", because, update_version needs to find about specific agents which don\u0027t report their versions on liberty, but consume QosPolicy v1.0\n\nBut as @ihar pointed out, not including DSCP changes were not included in mitaka at the end. Resulting of that we have:\n\n\nliberty:  sriov-agent \u0026 ovs-agent consume QosPolicy 1.0\nmitaka: sriov-agent \u0026 ovs-agent consume QosPolicy 1.0, and report it\nnewton: we don\u0027t need anymore the special handling in https://github.com/openstack/neutron/blob/c007960ab8ebc56e5c3d0c8cad99c921615a1915/neutron/api/rpc/callbacks/version_manager.py#L143 which I will remove as a separate patch.\n\nAnd, I believe your optimization works.","commit_id":"b58785953caf475fdac6dfb8595af550d07e2a2d"}],"neutron/plugins/ml2/drivers/agent/_common_agent.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"abb44baae3ad89eeda79b14848bbeb7ca10b1952","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                    resources.LOCAL_RESOURCE_VERSIONS)"},{"line_number":129,"context_line":"            else:"},{"line_number":130,"context_line":"                # we only want to update resource versions on startup or"},{"line_number":131,"context_line":"                # after agent revival"},{"line_number":132,"context_line":"                self.agent_state.pop(\u0027resource_versions\u0027, None)"},{"line_number":133,"context_line":"            self.agent_state.pop(\u0027start_flag\u0027, None)"},{"line_number":134,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_5159188d","line":131,"updated":"2016-04-07 16:50:27.000000000","message":"hmm, I think this branch could also be hit the first time we start, if the down time of the agent (during update) is \u003c agent_down time, so.. shouldn\u0027t we check?:\n\n    if not \u0027start_flag\u0027 in self.agent_state:\n         self.agent_state.pop(\u0027resource_versions\u0027, None)","commit_id":"b58785953caf475fdac6dfb8595af550d07e2a2d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c1ea8fd6907a603b237c021b75bbee3f67ad1b44","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                    resources.LOCAL_RESOURCE_VERSIONS)"},{"line_number":129,"context_line":"            else:"},{"line_number":130,"context_line":"                # we only want to update resource versions on startup or"},{"line_number":131,"context_line":"                # after agent revival"},{"line_number":132,"context_line":"                self.agent_state.pop(\u0027resource_versions\u0027, None)"},{"line_number":133,"context_line":"            self.agent_state.pop(\u0027start_flag\u0027, None)"},{"line_number":134,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_cc1c416d","line":131,"in_reply_to":"9a061dce_5159188d","updated":"2016-04-08 12:08:25.000000000","message":"On start resource_versions is included into state report at #91 and reported at #118 so here we can pop it from report. Am I missing something?","commit_id":"b58785953caf475fdac6dfb8595af550d07e2a2d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"322553ad82c61f4e9b6ec23d3cc9503cfba9c3d2","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                self.fullsync \u003d True"},{"line_number":126,"context_line":"                # update agent resources versions on server after revival"},{"line_number":127,"context_line":"                self.agent_state[\u0027resource_versions\u0027] \u003d ("},{"line_number":128,"context_line":"                    resources.LOCAL_RESOURCE_VERSIONS)"},{"line_number":129,"context_line":"            else:"},{"line_number":130,"context_line":"                # we only want to update resource versions on startup or"},{"line_number":131,"context_line":"                # after agent revival"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_fd244db3","line":128,"updated":"2016-04-08 12:58:41.000000000","message":"As we discussed in IRC, this would leave a window where version_manager could be outdated.\n\nIdeally at revival, the agents_db side may detect the agent revival, fetch the resource_versions from db, and call version_manager.update_versions , and then fanout to other servers.\n\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-neutron/%23openstack-neutron.2016-04-08.log.html#t2016-04-08T12:27:52\n\nWe thought of other possible optimizations, but those are probably not necessary.","commit_id":"b5a8554755968e7bc753895efab35871ddea9095"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"58bc67adcb561b3e0617a64c3d8f6acd36182d9c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                self.fullsync \u003d True"},{"line_number":126,"context_line":"                # update agent resources versions on server after revival"},{"line_number":127,"context_line":"                self.agent_state[\u0027resource_versions\u0027] \u003d ("},{"line_number":128,"context_line":"                    resources.LOCAL_RESOURCE_VERSIONS)"},{"line_number":129,"context_line":"            else:"},{"line_number":130,"context_line":"                # we only want to update resource versions on startup or"},{"line_number":131,"context_line":"                # after agent revival"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_281160b0","line":128,"in_reply_to":"9a061dce_fd244db3","updated":"2016-04-08 14:36:58.000000000","message":"Done","commit_id":"b5a8554755968e7bc753895efab35871ddea9095"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"81d9b84c653dad1efbdffac5d52485c499653488","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                                        self.agent_state)"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"            # we only want to update resource versions on startup"},{"line_number":179,"context_line":"            self.agent_state.pop(\u0027resource_versions\u0027, None)"},{"line_number":180,"context_line":"            self.agent_state.pop(\u0027start_flag\u0027, None)"},{"line_number":181,"context_line":"        except Exception:"},{"line_number":182,"context_line":"            LOG.exception(_LE(\"Failed reporting state!\"))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a1b2928_3a7360b3","line":179,"updated":"2016-04-11 13:29:20.000000000","message":"We should take care of \n\nneutron/plugins/ml2/drivers/agent/_common_agent.py   now too, that\u0027s used in linuxbridge.","commit_id":"72ee30f458d2667dfa10c13c630202163e3a12ba"}]}
