)]}'
{"neutron/tests/base.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4454e7f4815572feaeb35a9c1fdc48d0fbedb9ab","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        # don\u0027t actually start RPC listeners when testing"},{"line_number":342,"context_line":"        mock.patch("},{"line_number":343,"context_line":"            \u0027neutron.common.rpc.Connection.consume_in_threads\u0027,"},{"line_number":344,"context_line":"            return_value\u003d[]).start()"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":347,"context_line":"            \u0027oslo_messaging.Notifier\u0027, fake_notifier.FakeNotifier))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_17b82b74","line":344,"updated":"2016-04-07 18:47:11.000000000","message":"Don\u0027t you want to clean up this mock after the test is finished? Otherwise you end up stacking mock on top of mock for every test, and presumably you have some tests where you don\u0027t want it mocked?","commit_id":"2af86b8f6f749bf7b42a2c04b48c9a2dc28a46c9"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ac5d492572ff5bf8183ef68fc17827ae7dc42f19","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        # don\u0027t actually start RPC listeners when testing"},{"line_number":342,"context_line":"        mock.patch("},{"line_number":343,"context_line":"            \u0027neutron.common.rpc.Connection.consume_in_threads\u0027,"},{"line_number":344,"context_line":"            return_value\u003d[]).start()"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":347,"context_line":"            \u0027oslo_messaging.Notifier\u0027, fake_notifier.FakeNotifier))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_57ae232e","line":344,"updated":"2016-04-07 18:47:08.000000000","message":"there is no cleanup on this, so this mock never ends.","commit_id":"2af86b8f6f749bf7b42a2c04b48c9a2dc28a46c9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"535a9ac565b60a1ed2588ba2898c2e54165bf554","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        # don\u0027t actually start RPC listeners when testing"},{"line_number":342,"context_line":"        mock.patch("},{"line_number":343,"context_line":"            \u0027neutron.common.rpc.Connection.consume_in_threads\u0027,"},{"line_number":344,"context_line":"            return_value\u003d[]).start()"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":347,"context_line":"            \u0027oslo_messaging.Notifier\u0027, fake_notifier.FakeNotifier))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_ed9de8bc","line":344,"in_reply_to":"9a061dce_17b82b74","updated":"2016-04-07 19:13:41.000000000","message":"iirc we have a stopall() buried in the base class somewhere, but if this is addressed by capping for now, we have more time to find a better solution.","commit_id":"2af86b8f6f749bf7b42a2c04b48c9a2dc28a46c9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5e23f0419887476ce3a5f7716c387880b8ea1cb9","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        # don\u0027t actually start RPC listeners when testing"},{"line_number":342,"context_line":"        mock.patch("},{"line_number":343,"context_line":"            \u0027neutron.common.rpc.Connection.consume_in_threads\u0027,"},{"line_number":344,"context_line":"            return_value\u003d[]).start()"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        self.useFixture(fixtures.MonkeyPatch("},{"line_number":347,"context_line":"            \u0027oslo_messaging.Notifier\u0027, fake_notifier.FakeNotifier))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a061dce_6d4278af","line":344,"in_reply_to":"9a061dce_ed9de8bc","updated":"2016-04-07 19:25:30.000000000","message":"Yes, it\u0027s line 173 this file.","commit_id":"2af86b8f6f749bf7b42a2c04b48c9a2dc28a46c9"}]}
