)]}'
{"neutron/extensions/portbindings.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e747685988d003233587a515e9bf8f78c425032c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"VIF_TYPE_UNBOUND \u003d \u0027unbound\u0027"},{"line_number":80,"context_line":"VIF_TYPE_BINDING_FAILED \u003d \u0027binding_failed\u0027"},{"line_number":81,"context_line":"VIF_TYPE_DISTRIBUTED \u003d \u0027distributed\u0027"},{"line_number":82,"context_line":"VIF_TYPE_OVS \u003d \u0027ovs\u0027"},{"line_number":83,"context_line":"VIF_TYPE_BRIDGE \u003d \u0027bridge\u0027"},{"line_number":84,"context_line":"VIF_TYPE_OTHER \u003d \u0027other\u0027"},{"line_number":85,"context_line":"# vif_type_macvtap: Tells Nova that the macvtap vif_driver should be used to"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_6ce87111","line":82,"updated":"2016-04-17 09:12:14.000000000","message":"Please add VIF_TYPE_DVS \u003d \u0027dvs\u0027\n\nThe change below will cause the VMware_nsx dvs driver to fail with objects","commit_id":"5f9423dcf88d1b46aa474d558d91ca92bc9a4162"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"ef8069cfc044148d0e95aa9aa0e30ff3a97a032c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"VIF_TYPE_UNBOUND \u003d \u0027unbound\u0027"},{"line_number":80,"context_line":"VIF_TYPE_BINDING_FAILED \u003d \u0027binding_failed\u0027"},{"line_number":81,"context_line":"VIF_TYPE_DISTRIBUTED \u003d \u0027distributed\u0027"},{"line_number":82,"context_line":"VIF_TYPE_OVS \u003d \u0027ovs\u0027"},{"line_number":83,"context_line":"VIF_TYPE_BRIDGE \u003d \u0027bridge\u0027"},{"line_number":84,"context_line":"VIF_TYPE_OTHER \u003d \u0027other\u0027"},{"line_number":85,"context_line":"# vif_type_macvtap: Tells Nova that the macvtap vif_driver should be used to"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_c402270b","line":82,"in_reply_to":"1a122d0e_37fd153b","updated":"2016-04-18 11:06:03.000000000","message":"so we go back and make it a string field so that all values are accepted or what are you suggesting?","commit_id":"5f9423dcf88d1b46aa474d558d91ca92bc9a4162"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"81fafe077a472990a99e1219d36867a684fbd795","unresolved":false,"context_lines":[{"line_number":79,"context_line":"VIF_TYPE_UNBOUND \u003d \u0027unbound\u0027"},{"line_number":80,"context_line":"VIF_TYPE_BINDING_FAILED \u003d \u0027binding_failed\u0027"},{"line_number":81,"context_line":"VIF_TYPE_DISTRIBUTED \u003d \u0027distributed\u0027"},{"line_number":82,"context_line":"VIF_TYPE_OVS \u003d \u0027ovs\u0027"},{"line_number":83,"context_line":"VIF_TYPE_BRIDGE \u003d \u0027bridge\u0027"},{"line_number":84,"context_line":"VIF_TYPE_OTHER \u003d \u0027other\u0027"},{"line_number":85,"context_line":"# vif_type_macvtap: Tells Nova that the macvtap vif_driver should be used to"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_fc3f0223","line":82,"in_reply_to":"1a122d0e_6ce87111","updated":"2016-04-18 08:12:44.000000000","message":"Hm. Do we have a limited list of types supported?","commit_id":"5f9423dcf88d1b46aa474d558d91ca92bc9a4162"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"66a3ac313c9c45930bfd9d1ff01f7ac0991f06dd","unresolved":false,"context_lines":[{"line_number":79,"context_line":"VIF_TYPE_UNBOUND \u003d \u0027unbound\u0027"},{"line_number":80,"context_line":"VIF_TYPE_BINDING_FAILED \u003d \u0027binding_failed\u0027"},{"line_number":81,"context_line":"VIF_TYPE_DISTRIBUTED \u003d \u0027distributed\u0027"},{"line_number":82,"context_line":"VIF_TYPE_OVS \u003d \u0027ovs\u0027"},{"line_number":83,"context_line":"VIF_TYPE_BRIDGE \u003d \u0027bridge\u0027"},{"line_number":84,"context_line":"VIF_TYPE_OTHER \u003d \u0027other\u0027"},{"line_number":85,"context_line":"# vif_type_macvtap: Tells Nova that the macvtap vif_driver should be used to"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_9a69a4c1","line":82,"in_reply_to":"1a122d0e_c402270b","updated":"2016-04-18 11:25:39.000000000","message":"I believe that\u0027s the only direction that does not break out of tree code right now. :( We may want to add a TODO to switch to a stricter field type though.\n\nI will also support anyone who would take on the burden of introducing a hooking mechanism.","commit_id":"5f9423dcf88d1b46aa474d558d91ca92bc9a4162"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"722cd776e27d8cf87aebc2a3bf362aaee96abbfe","unresolved":false,"context_lines":[{"line_number":79,"context_line":"VIF_TYPE_UNBOUND \u003d \u0027unbound\u0027"},{"line_number":80,"context_line":"VIF_TYPE_BINDING_FAILED \u003d \u0027binding_failed\u0027"},{"line_number":81,"context_line":"VIF_TYPE_DISTRIBUTED \u003d \u0027distributed\u0027"},{"line_number":82,"context_line":"VIF_TYPE_OVS \u003d \u0027ovs\u0027"},{"line_number":83,"context_line":"VIF_TYPE_BRIDGE \u003d \u0027bridge\u0027"},{"line_number":84,"context_line":"VIF_TYPE_OTHER \u003d \u0027other\u0027"},{"line_number":85,"context_line":"# vif_type_macvtap: Tells Nova that the macvtap vif_driver should be used to"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_37fd153b","line":82,"in_reply_to":"1a122d0e_fc3f0223","updated":"2016-04-18 08:37:43.000000000","message":"Hm, actually there is more! VIF_TYPE_HW_VEB or VIF_TYPE_HOSTDEV_PHY in neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py. Or VIF_TYPE_802_QBH in cisco driver.\n\nI guess we can\u0027t really enforce the values here before this is implemented: http://git.openstack.org/cgit/openstack/neutron/tree/doc/source/devref/contribute.rst#n571","commit_id":"5f9423dcf88d1b46aa474d558d91ca92bc9a4162"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e747685988d003233587a515e9bf8f78c425032c","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"VIF_TYPES \u003d [VIF_TYPE_VHOST_USER, VIF_TYPE_UNBOUND, VIF_TYPE_BINDING_FAILED,"},{"line_number":92,"context_line":"             VIF_TYPE_DISTRIBUTED, VIF_TYPE_OVS, VIF_TYPE_BRIDGE,"},{"line_number":93,"context_line":"             VIF_TYPE_OTHER, VIF_TYPE_MACVTAP]"},{"line_number":94,"context_line":"# VNIC_TYPE: It\u0027s used to determine which mechanism driver to use to bind a"},{"line_number":95,"context_line":"#            port. It can be specified via the Neutron API. Default is normal,"},{"line_number":96,"context_line":"#            used by OVS and LinuxBridge agent."}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_4ce5b535","line":93,"updated":"2016-04-17 09:12:14.000000000","message":"please add the dvs type here","commit_id":"5f9423dcf88d1b46aa474d558d91ca92bc9a4162"}],"neutron/objects/common_types.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"becbf75abff2995d129984b552ee803e9f95b69d","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"class VnicTypeEnum(obj_fields.Enum):"},{"line_number":147,"context_line":"    def __init__(self, **kwargs):"},{"line_number":148,"context_line":"        super(VnicTypeEnum, self).__init__("},{"line_number":149,"context_line":"            valid_values\u003dportbindings.VNIC_TYPES, **kwargs)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_55454d15","line":148,"updated":"2016-04-08 14:12:55.000000000","message":"it could be worth adopting the approach as in line 125 avoiding a new class definition here.","commit_id":"68b082a21a91f9da4688b6f2efbb07839438653d"}]}
