)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"46e8bd3e15b5af6c8bdd9b2c8b3b8810fd8275b2","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://review.openstack.org/292778"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Example:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"OVS Controller"},{"line_number":21,"context_line":"--------------"},{"line_number":22,"context_line":"Make sure that the controller"},{"line_number":23,"context_line":"- loads the macvtap ml2 driver"},{"line_number":24,"context_line":"- uses vlan or flat networking"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Macvtap Compute Node local.conf"},{"line_number":27,"context_line":"-------------------------------"},{"line_number":28,"context_line":"[[local|localrc]]"},{"line_number":29,"context_line":"SERVICE_HOST\u003d1.2.3.4"},{"line_number":30,"context_line":"MYSQL_HOST\u003d$SERVICE_HOST"},{"line_number":31,"context_line":"RABBIT_HOST\u003d$SERVICE_HOST"},{"line_number":32,"context_line":"disable_all_services"},{"line_number":33,"context_line":"enable_plugin neutron git://git.openstack.org/openstack/neutron"},{"line_number":34,"context_line":"enable_service n-cpu"},{"line_number":35,"context_line":"enable_service q-agt"},{"line_number":36,"context_line":"Q_AGENT\u003dmacvtap"},{"line_number":37,"context_line":"PHYSICAL_NETWORK\u003ddefault"},{"line_number":38,"context_line":"[[post-config|/$Q_PLUGIN_CONF_FILE]]"},{"line_number":39,"context_line":"[macvtap]"},{"line_number":40,"context_line":"physical_interface_mappings \u003d $PHYSICAL_NETWORK:eth1"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Closes-Bug: #1557407"},{"line_number":43,"context_line":"Change-Id: I0dd4c0d34d5f1c35b397e5e392ce107fb984b0ba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9abb7d3a_7f7b49be","line":40,"range":{"start_line":18,"start_character":0,"end_line":40,"end_character":52},"updated":"2016-06-02 02:37:53.000000000","message":"nit: Do we need to put this useful configure in CommitMessage?","commit_id":"d443433c7319d2ea950f71dfaad2f2eea674c9fe"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"b23792629c72c16a5f79f6e18fb533b926e0f518","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://review.openstack.org/292778"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Example:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"OVS Controller"},{"line_number":21,"context_line":"--------------"},{"line_number":22,"context_line":"Make sure that the controller"},{"line_number":23,"context_line":"- loads the macvtap ml2 driver"},{"line_number":24,"context_line":"- uses vlan or flat networking"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Macvtap Compute Node local.conf"},{"line_number":27,"context_line":"-------------------------------"},{"line_number":28,"context_line":"[[local|localrc]]"},{"line_number":29,"context_line":"SERVICE_HOST\u003d1.2.3.4"},{"line_number":30,"context_line":"MYSQL_HOST\u003d$SERVICE_HOST"},{"line_number":31,"context_line":"RABBIT_HOST\u003d$SERVICE_HOST"},{"line_number":32,"context_line":"disable_all_services"},{"line_number":33,"context_line":"enable_plugin neutron git://git.openstack.org/openstack/neutron"},{"line_number":34,"context_line":"enable_service n-cpu"},{"line_number":35,"context_line":"enable_service q-agt"},{"line_number":36,"context_line":"Q_AGENT\u003dmacvtap"},{"line_number":37,"context_line":"PHYSICAL_NETWORK\u003ddefault"},{"line_number":38,"context_line":"[[post-config|/$Q_PLUGIN_CONF_FILE]]"},{"line_number":39,"context_line":"[macvtap]"},{"line_number":40,"context_line":"physical_interface_mappings \u003d $PHYSICAL_NETWORK:eth1"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Closes-Bug: #1557407"},{"line_number":43,"context_line":"Change-Id: I0dd4c0d34d5f1c35b397e5e392ce107fb984b0ba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9abb7d3a_dd3cf8e2","line":40,"range":{"start_line":18,"start_character":0,"end_line":40,"end_character":52},"in_reply_to":"9abb7d3a_7f7b49be","updated":"2016-06-02 06:44:35.000000000","message":"I will also add some docs (still WIP)! But does it really hurt? If you insist on it, I can remove it of course here.","commit_id":"d443433c7319d2ea950f71dfaad2f2eea674c9fe"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"383562716bbfdb22dd605e4177db8653c51ade0e","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://review.openstack.org/292778"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Example:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"OVS Controller"},{"line_number":21,"context_line":"--------------"},{"line_number":22,"context_line":"Make sure that the controller"},{"line_number":23,"context_line":"- loads the macvtap ml2 driver"},{"line_number":24,"context_line":"- uses vlan or flat networking"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Macvtap Compute Node local.conf"},{"line_number":27,"context_line":"-------------------------------"},{"line_number":28,"context_line":"[[local|localrc]]"},{"line_number":29,"context_line":"SERVICE_HOST\u003d1.2.3.4"},{"line_number":30,"context_line":"MYSQL_HOST\u003d$SERVICE_HOST"},{"line_number":31,"context_line":"RABBIT_HOST\u003d$SERVICE_HOST"},{"line_number":32,"context_line":"disable_all_services"},{"line_number":33,"context_line":"enable_plugin neutron git://git.openstack.org/openstack/neutron"},{"line_number":34,"context_line":"enable_service n-cpu"},{"line_number":35,"context_line":"enable_service q-agt"},{"line_number":36,"context_line":"Q_AGENT\u003dmacvtap"},{"line_number":37,"context_line":"PHYSICAL_NETWORK\u003ddefault"},{"line_number":38,"context_line":"[[post-config|/$Q_PLUGIN_CONF_FILE]]"},{"line_number":39,"context_line":"[macvtap]"},{"line_number":40,"context_line":"physical_interface_mappings \u003d $PHYSICAL_NETWORK:eth1"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Closes-Bug: #1557407"},{"line_number":43,"context_line":"Change-Id: I0dd4c0d34d5f1c35b397e5e392ce107fb984b0ba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9abb7d3a_ef078116","line":40,"range":{"start_line":18,"start_character":0,"end_line":40,"end_character":52},"in_reply_to":"9abb7d3a_dd3cf8e2","updated":"2016-06-02 07:36:05.000000000","message":"I wouldn\u0027t insist. I\u0027m OK.","commit_id":"d443433c7319d2ea950f71dfaad2f2eea674c9fe"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f2e9cc89d0ac8090daa03be5f7e40e00dd4687b6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Macvtap agent can now be configured via this devstack."},{"line_number":10,"context_line":"Note that it is only supported in multinode environments"},{"line_number":11,"context_line":"as compute node. The controller node still needs to run"},{"line_number":12,"context_line":"linuxbridge or ovs."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Documentation will be added in devstack via [1]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9abb7d3a_8f85155b","line":11,"range":{"start_line":11,"start_character":21,"end_line":11,"end_character":36},"updated":"2016-06-02 07:39:38.000000000","message":"network node? I sounds like controller node points the node for neutron server.","commit_id":"8e5623d624a9855fe842baca3cf9b11948113592"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c839c9d182bf69f690ce01b8ac9d58a5b47e53b2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Macvtap agent can now be configured via this devstack."},{"line_number":10,"context_line":"Note that it is only supported in multinode environments"},{"line_number":11,"context_line":"as compute node. The controller node still needs to run"},{"line_number":12,"context_line":"linuxbridge or ovs."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Documentation will be added in devstack via [1]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9abb7d3a_6a56c807","line":11,"range":{"start_line":11,"start_character":21,"end_line":11,"end_character":36},"in_reply_to":"9abb7d3a_8f85155b","updated":"2016-06-02 14:20:18.000000000","message":"I guess Andreas describes architecture where you have both external connectivity and API handled on the same node.","commit_id":"8e5623d624a9855fe842baca3cf9b11948113592"}],"devstack/lib/macvtap_agent":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b4447656213b17da1d427b459a2adfcf7b1137b4","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"function neutron_plugin_configure_plugin_agent {"},{"line_number":36,"context_line":"    # Only the NooPFirewallDriver is supported. If not set, the agent will terminate."},{"line_number":37,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE securitygroup firewall_driver neutron.agent.firewall.NoopFirewallDriver"},{"line_number":38,"context_line":"    AGENT_BINARY\u003d\"$NEUTRON_BIN_DIR/neutron-macvtap-agent\""},{"line_number":39,"context_line":"}"},{"line_number":40,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9abb7d3a_579e9263","line":37,"updated":"2016-05-31 13:40:42.000000000","message":"Please use alias (noop) not import path. The latter is discouraged by stevedore folks.","commit_id":"9f5b1943e497195384179a3951f2edc827e2b85b"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"3d009c671b9ceac79c5d2bbf600662dd0b2480e1","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"function neutron_plugin_configure_plugin_agent {"},{"line_number":36,"context_line":"    # Only the NooPFirewallDriver is supported. If not set, the agent will terminate."},{"line_number":37,"context_line":"    iniset /$Q_PLUGIN_CONF_FILE securitygroup firewall_driver neutron.agent.firewall.NoopFirewallDriver"},{"line_number":38,"context_line":"    AGENT_BINARY\u003d\"$NEUTRON_BIN_DIR/neutron-macvtap-agent\""},{"line_number":39,"context_line":"}"},{"line_number":40,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"9abb7d3a_26babe0a","line":37,"in_reply_to":"9abb7d3a_579e9263","updated":"2016-05-31 14:39:31.000000000","message":"cool! Wasn\u0027t aware of that! I need to enable this alias in the agent code first. Please see the underlying review https://review.openstack.org/323414\n\nThx","commit_id":"9f5b1943e497195384179a3951f2edc827e2b85b"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"46e8bd3e15b5af6c8bdd9b2c8b3b8810fd8275b2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Neutron Macvtap L2 agent"},{"line_number":4,"context_line":"# -----------------------------"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9abb7d3a_ff0a991e","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":11},"updated":"2016-06-02 02:37:53.000000000","message":"Please remove it because it depends on env. You might want \"#!/usr/bin/env bash\" but I like removing.","commit_id":"d443433c7319d2ea950f71dfaad2f2eea674c9fe"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c6ed1404fca03bfb4c843086f6c10e188e71e689","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Neutron Macvtap L2 agent"},{"line_number":4,"context_line":"# -----------------------------"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9abb7d3a_b8282287","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":11},"in_reply_to":"9abb7d3a_7d486ccc","updated":"2016-06-02 06:46:44.000000000","message":"+1 for \"#!/usr/bin/env bash\"","commit_id":"d443433c7319d2ea950f71dfaad2f2eea674c9fe"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"35663c2bf51f227735e738a1a21fd8710148473f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Neutron Macvtap L2 agent"},{"line_number":4,"context_line":"# -----------------------------"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9abb7d3a_09e75dad","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":11},"in_reply_to":"9abb7d3a_b8282287","updated":"2016-06-02 09:37:41.000000000","message":"I removed it, as non of the other devstack scripts is defining it.","commit_id":"d443433c7319d2ea950f71dfaad2f2eea674c9fe"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"b23792629c72c16a5f79f6e18fb533b926e0f518","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Neutron Macvtap L2 agent"},{"line_number":4,"context_line":"# -----------------------------"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"9abb7d3a_7d486ccc","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":11},"in_reply_to":"9abb7d3a_ff0a991e","updated":"2016-06-02 06:44:35.000000000","message":"makes sense!","commit_id":"d443433c7319d2ea950f71dfaad2f2eea674c9fe"}]}