)]}'
{"neutron/extensions/l3.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"139b8638a5924d574cb569bf88110e642d8dcd62","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        return ["},{"line_number":214,"context_line":"            pecan_utils.PecanResourceExtension("},{"line_number":215,"context_line":"                ROUTERS, controllers.RoutersController()),"},{"line_number":216,"context_line":"            pecan_utils.PecanResourceExtension("},{"line_number":217,"context_line":"                FLOATINGIPS, controllers.CollectionsController("},{"line_number":218,"context_line":"                    FLOATINGIPS, FLOATINGIP))"},{"line_number":219,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_c1034072","line":216,"updated":"2016-05-06 20:43:52.000000000","message":"I think maybe he meant why aren\u0027t you naming them in the construction here... maybe?","commit_id":"65cd85a03eb6c1866e015ac53de7ee48c28175b4"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a306b4187413b8d6eb4412b11e23024b7a14e716","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        return ["},{"line_number":214,"context_line":"            pecan_utils.PecanResourceExtension("},{"line_number":215,"context_line":"                ROUTERS, controllers.RoutersController()),"},{"line_number":216,"context_line":"            pecan_utils.PecanResourceExtension("},{"line_number":217,"context_line":"                FLOATINGIPS, controllers.CollectionsController("},{"line_number":218,"context_line":"                    FLOATINGIPS, FLOATINGIP))"},{"line_number":219,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_5e944fe1","line":216,"updated":"2016-05-06 20:22:11.000000000","message":"I think the confusion wasn\u0027t around the construction so much as the referencing later.","commit_id":"65cd85a03eb6c1866e015ac53de7ee48c28175b4"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"0aad76e0ba9654cae560788a6755adc4ce2444c2","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        return ["},{"line_number":214,"context_line":"            pecan_utils.PecanResourceExtension("},{"line_number":215,"context_line":"                ROUTERS, controllers.RoutersController()),"},{"line_number":216,"context_line":"            pecan_utils.PecanResourceExtension("},{"line_number":217,"context_line":"                FLOATINGIPS, controllers.CollectionsController("},{"line_number":218,"context_line":"                    FLOATINGIPS, FLOATINGIP))"},{"line_number":219,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_5e4f2fbd","line":216,"updated":"2016-05-06 20:19:25.000000000","message":"If you wanted this clearer than a magic tuple, I\u0027m curious why you didn\u0027t go with kwargs on the class and named args here.","commit_id":"65cd85a03eb6c1866e015ac53de7ee48c28175b4"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"c65b248d3a8f45a4105be842e059a00cadb71946","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        return ["},{"line_number":214,"context_line":"            pecan_utils.PecanResourceExtension("},{"line_number":215,"context_line":"                ROUTERS, controllers.RoutersController()),"},{"line_number":216,"context_line":"            pecan_utils.PecanResourceExtension("},{"line_number":217,"context_line":"                FLOATINGIPS, controllers.CollectionsController("},{"line_number":218,"context_line":"                    FLOATINGIPS, FLOATINGIP))"},{"line_number":219,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_c1b500ce","line":216,"in_reply_to":"dab17558_5e944fe1","updated":"2016-05-06 20:42:12.000000000","message":"well it depends on what you believe kwargs are used for.  To me, kwargs are best for optional arguments and positional args are best or required args, so I wanted to keep these parameters as required.  The positional arguments are still named though, just in the definition.","commit_id":"65cd85a03eb6c1866e015ac53de7ee48c28175b4"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"7ca83e590445fcf91f5d3c95d3285ae49b9c35e2","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        return ["},{"line_number":214,"context_line":"            pecan_utils.PecanResourceExtension("},{"line_number":215,"context_line":"                ROUTERS, controllers.RoutersController()),"},{"line_number":216,"context_line":"            pecan_utils.PecanResourceExtension("},{"line_number":217,"context_line":"                FLOATINGIPS, controllers.CollectionsController("},{"line_number":218,"context_line":"                    FLOATINGIPS, FLOATINGIP))"},{"line_number":219,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_43b4eb80","line":216,"in_reply_to":"dab17558_819ad812","updated":"2016-05-11 01:47:00.000000000","message":"It only feels wrong if you hate self-documenting code. But ok.","commit_id":"65cd85a03eb6c1866e015ac53de7ee48c28175b4"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"631ea2ba33aec67712ed5808f1b3068e6f726306","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        return ["},{"line_number":214,"context_line":"            pecan_utils.PecanResourceExtension("},{"line_number":215,"context_line":"                ROUTERS, controllers.RoutersController()),"},{"line_number":216,"context_line":"            pecan_utils.PecanResourceExtension("},{"line_number":217,"context_line":"                FLOATINGIPS, controllers.CollectionsController("},{"line_number":218,"context_line":"                    FLOATINGIPS, FLOATINGIP))"},{"line_number":219,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_819ad812","line":216,"in_reply_to":"dab17558_c1034072","updated":"2016-05-06 20:50:11.000000000","message":"you mean don\u0027t define them as kwargs in the definition but instantiate like PecanResourceExtension(collection\u003dblah, controller\u003dblah)?\n\nThat always felt wrong to reference positional arguments by name.  Just like it always felt wrong to take advantage of the fact that you can pass in the kwargs in positional order and it works.","commit_id":"65cd85a03eb6c1866e015ac53de7ee48c28175b4"}]}