)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ff5f010ab9da371de489698a1ae00bae0afdb853","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add support for building ovs from git sources on stacking"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This eases the deployment of a devstack machine with the latest"},{"line_number":10,"context_line":"OpenvSwitch bits, adding this to local.conf provides a fully"},{"line_number":11,"context_line":"featured ovs-ct firewall setup:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  enable_plugin neutron git://git.openstack.org/openstack/neutron"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a18252c_ef776a00","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":11},"updated":"2016-04-12 11:43:44.000000000","message":"nit: Open vSwitch :)","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"}],"devstack/lib/ovs":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ff5f010ab9da371de489698a1ae00bae0afdb853","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    fi"},{"line_number":74,"context_line":"    if [ ! -f config.status ] || [ configure -nt config.status ] ; then"},{"line_number":75,"context_line":"        if [[ \"$build_modules\" \u003d\u003d \"True\" ]]; then"},{"line_number":76,"context_line":"            install_package linux-headers-$(uname-r)"},{"line_number":77,"context_line":"            ./configure $prefix $localstatedir --with-linux\u003d/lib/modules/$(uname -r)/build"},{"line_number":78,"context_line":"        else"},{"line_number":79,"context_line":"            ./configure $prefix $localstatedir"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a18252c_4fd65ec6","line":76,"range":{"start_line":76,"start_character":44,"end_line":76,"end_character":51},"updated":"2016-04-12 11:43:44.000000000","message":"Is space missing here? uname -r","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a6e980a528e2d75c11cacb533984460df1da025","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    fi"},{"line_number":74,"context_line":"    if [ ! -f config.status ] || [ configure -nt config.status ] ; then"},{"line_number":75,"context_line":"        if [[ \"$build_modules\" \u003d\u003d \"True\" ]]; then"},{"line_number":76,"context_line":"            install_package linux-headers-$(uname-r)"},{"line_number":77,"context_line":"            ./configure $prefix $localstatedir --with-linux\u003d/lib/modules/$(uname -r)/build"},{"line_number":78,"context_line":"        else"},{"line_number":79,"context_line":"            ./configure $prefix $localstatedir"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a18252c_f8dc571a","line":76,"range":{"start_line":76,"start_character":28,"end_line":76,"end_character":52},"updated":"2016-04-12 11:03:57.000000000","message":"Isn\u0027t it ubuntu specific? Shouldn\u0027t it go somewhere around lines 66-69?","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"1c2e40d97681221e128443086b4b29fffe4f5433","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    fi"},{"line_number":74,"context_line":"    if [ ! -f config.status ] || [ configure -nt config.status ] ; then"},{"line_number":75,"context_line":"        if [[ \"$build_modules\" \u003d\u003d \"True\" ]]; then"},{"line_number":76,"context_line":"            install_package linux-headers-$(uname-r)"},{"line_number":77,"context_line":"            ./configure $prefix $localstatedir --with-linux\u003d/lib/modules/$(uname -r)/build"},{"line_number":78,"context_line":"        else"},{"line_number":79,"context_line":"            ./configure $prefix $localstatedir"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a18252c_82796d32","line":76,"range":{"start_line":76,"start_character":44,"end_line":76,"end_character":51},"in_reply_to":"5a18252c_4fd65ec6","updated":"2016-04-12 11:51:31.000000000","message":"oh, it is, I guess it worked locally because I installed it manually too...\n\nfixing.\n\nI\u0027d say let\u0027s keep the header installation here, only to be done if you intend to create modules.","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"879d22326001f148e0c43f03435ffba3fab355d7","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    fi"},{"line_number":74,"context_line":"    if [ ! -f config.status ] || [ configure -nt config.status ] ; then"},{"line_number":75,"context_line":"        if [[ \"$build_modules\" \u003d\u003d \"True\" ]]; then"},{"line_number":76,"context_line":"            install_package linux-headers-$(uname-r)"},{"line_number":77,"context_line":"            ./configure $prefix $localstatedir --with-linux\u003d/lib/modules/$(uname -r)/build"},{"line_number":78,"context_line":"        else"},{"line_number":79,"context_line":"            ./configure $prefix $localstatedir"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a18252c_853e97b6","line":76,"range":{"start_line":76,"start_character":44,"end_line":76,"end_character":51},"in_reply_to":"5a18252c_82796d32","updated":"2016-04-12 12:01:41.000000000","message":"Done","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ff5f010ab9da371de489698a1ae00bae0afdb853","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    fi"},{"line_number":74,"context_line":"    if [ ! -f config.status ] || [ configure -nt config.status ] ; then"},{"line_number":75,"context_line":"        if [[ \"$build_modules\" \u003d\u003d \"True\" ]]; then"},{"line_number":76,"context_line":"            install_package linux-headers-$(uname-r)"},{"line_number":77,"context_line":"            ./configure $prefix $localstatedir --with-linux\u003d/lib/modules/$(uname -r)/build"},{"line_number":78,"context_line":"        else"},{"line_number":79,"context_line":"            ./configure $prefix $localstatedir"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a18252c_2f4a0284","line":76,"range":{"start_line":76,"start_character":28,"end_line":76,"end_character":52},"in_reply_to":"5a18252c_f8dc571a","updated":"2016-04-12 11:43:44.000000000","message":"Seems like, you need kernel-headers and kernel-devel for rhel-based systems.","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ff5f010ab9da371de489698a1ae00bae0afdb853","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    sudo /usr/share/openvswitch/scripts/ovs-ctl start"},{"line_number":100,"context_line":"}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# remove_ovs_packages() - removes old ovs packages from the system"},{"line_number":103,"context_line":"function remove_ovs_packages() {"},{"line_number":104,"context_line":"    for package in openvswitch openvswitch-switch openvswitch-common; do"},{"line_number":105,"context_line":"        if is_package_installed $package; then"},{"line_number":106,"context_line":"            uninstall_package $package"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a18252c_a241093c","line":103,"range":{"start_line":102,"start_character":28,"end_line":103,"end_character":9},"updated":"2016-04-12 11:43:44.000000000","message":"Do you plan to send patch to OVN, I think they do something similar. It would be good to re-use.","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"1c2e40d97681221e128443086b4b29fffe4f5433","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    sudo /usr/share/openvswitch/scripts/ovs-ctl start"},{"line_number":100,"context_line":"}"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# remove_ovs_packages() - removes old ovs packages from the system"},{"line_number":103,"context_line":"function remove_ovs_packages() {"},{"line_number":104,"context_line":"    for package in openvswitch openvswitch-switch openvswitch-common; do"},{"line_number":105,"context_line":"        if is_package_installed $package; then"},{"line_number":106,"context_line":"            uninstall_package $package"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a18252c_423ab537","line":103,"range":{"start_line":102,"start_character":28,"end_line":103,"end_character":9},"in_reply_to":"5a18252c_a241093c","updated":"2016-04-12 11:51:31.000000000","message":"no, but we can ping them :-)","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3a6e980a528e2d75c11cacb533984460df1da025","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# remove_ovs_packages() - removes old ovs packages from the system"},{"line_number":103,"context_line":"function remove_ovs_packages() {"},{"line_number":104,"context_line":"    for package in openvswitch openvswitch-switch openvswitch-common; do"},{"line_number":105,"context_line":"        if is_package_installed $package; then"},{"line_number":106,"context_line":"            uninstall_package $package"},{"line_number":107,"context_line":"        fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a18252c_f811f7b0","line":104,"range":{"start_line":104,"start_character":31,"end_line":104,"end_character":68},"updated":"2016-04-12 11:03:57.000000000","message":"I don\u0027t see those packages in Red Hat systems. It\u0027s a shame you test it on Ubuntu! :)","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"293af4ba690a55e20770054612b076b974fc09f3","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# remove_ovs_packages() - removes old ovs packages from the system"},{"line_number":103,"context_line":"function remove_ovs_packages() {"},{"line_number":104,"context_line":"    for package in openvswitch openvswitch-switch openvswitch-common; do"},{"line_number":105,"context_line":"        if is_package_installed $package; then"},{"line_number":106,"context_line":"            uninstall_package $package"},{"line_number":107,"context_line":"        fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a18252c_c21d25bf","line":104,"range":{"start_line":104,"start_character":31,"end_line":104,"end_character":68},"in_reply_to":"5a18252c_af89f2cc","updated":"2016-04-12 11:52:26.000000000","message":"Maybe. But it\u0027s unneeded work that we can knowingly skip.","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"1c2e40d97681221e128443086b4b29fffe4f5433","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# remove_ovs_packages() - removes old ovs packages from the system"},{"line_number":103,"context_line":"function remove_ovs_packages() {"},{"line_number":104,"context_line":"    for package in openvswitch openvswitch-switch openvswitch-common; do"},{"line_number":105,"context_line":"        if is_package_installed $package; then"},{"line_number":106,"context_line":"            uninstall_package $package"},{"line_number":107,"context_line":"        fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a18252c_e2adc189","line":104,"range":{"start_line":104,"start_character":31,"end_line":104,"end_character":68},"in_reply_to":"5a18252c_af89f2cc","updated":"2016-04-12 11:51:31.000000000","message":"yes, this specifically works for both :)\n\nIt\u0027s a shame, I agree.","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ff5f010ab9da371de489698a1ae00bae0afdb853","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"# remove_ovs_packages() - removes old ovs packages from the system"},{"line_number":103,"context_line":"function remove_ovs_packages() {"},{"line_number":104,"context_line":"    for package in openvswitch openvswitch-switch openvswitch-common; do"},{"line_number":105,"context_line":"        if is_package_installed $package; then"},{"line_number":106,"context_line":"            uninstall_package $package"},{"line_number":107,"context_line":"        fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a18252c_af89f2cc","line":104,"range":{"start_line":104,"start_character":31,"end_line":104,"end_character":68},"in_reply_to":"5a18252c_f811f7b0","updated":"2016-04-12 11:43:44.000000000","message":"It doesn\u0027t do any harm to anything. rhel-like based systems have openvswitch only so on rhel-like systems it would be skipped by L105","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8926f194d63188ea962e61d16941d6ea7621f557","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    if is_fedora ; then"},{"line_number":67,"context_line":"        # is_fedora covers Fedora, RHEL, CentOS, etc..."},{"line_number":68,"context_line":"        install_package kernel-devel"},{"line_number":69,"context_line":"        install_package kernel-headers"},{"line_number":70,"context_line":"    fi"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if is_ubuntu ; then"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5a18252c_252ce349","line":69,"range":{"start_line":69,"start_character":24,"end_line":69,"end_character":38},"updated":"2016-04-12 12:07:47.000000000","message":"I think we should keep the kernel version here like we do with Ubuntu:\n\n kernel-devel-$(uname -r)\n kernel-headers-$(uname -r)","commit_id":"f81f1244dff1b7bc61b6051849b61c1813bae2d7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8926f194d63188ea962e61d16941d6ea7621f557","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        # is_fedora covers Fedora, RHEL, CentOS, etc..."},{"line_number":68,"context_line":"        install_package kernel-devel"},{"line_number":69,"context_line":"        install_package kernel-headers"},{"line_number":70,"context_line":"    fi"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if is_ubuntu ; then"},{"line_number":73,"context_line":"        install_package linux-headers-$(uname -r)"},{"line_number":74,"context_line":"    fi"},{"line_number":75,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5a18252c_c5eecfeb","line":72,"range":{"start_line":70,"start_character":0,"end_line":72,"end_character":6},"updated":"2016-04-12 12:07:47.000000000","message":"nit: elif is_ubuntu","commit_id":"f81f1244dff1b7bc61b6051849b61c1813bae2d7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f347550527550dafdd9f503507a4b5dad506ae6a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        # is_fedora covers Fedora, RHEL, CentOS, etc..."},{"line_number":68,"context_line":"        echo NOTE: if kernel-devel-$(uname -r) or kernel-headers-$(uname -r) installation"},{"line_number":69,"context_line":"        echo failed, please, provide a repository with the package, or yum update / reboot"},{"line_number":70,"context_line":"        echo your machine to get the latest kernel."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        install_package kernel-devel-$(uname -r)"},{"line_number":73,"context_line":"        install_package kernel-headers-$(uname -r)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a18252c_914fc6bc","line":70,"updated":"2016-04-13 10:22:05.000000000","message":"Not sure what we are trying to guard against here if both packages are in core repos.","commit_id":"2390064efa8f741ebf9e0fe15774af13e5e6fc8c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3a0ebd8e896b7b0c9ad0c32670cbe2a34768f950","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        # is_fedora covers Fedora, RHEL, CentOS, etc..."},{"line_number":68,"context_line":"        echo NOTE: if kernel-devel-$(uname -r) or kernel-headers-$(uname -r) installation"},{"line_number":69,"context_line":"        echo failed, please, provide a repository with the package, or yum update / reboot"},{"line_number":70,"context_line":"        echo your machine to get the latest kernel."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        install_package kernel-devel-$(uname -r)"},{"line_number":73,"context_line":"        install_package kernel-headers-$(uname -r)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a18252c_6327b312","line":70,"in_reply_to":"5a18252c_914fc6bc","updated":"2016-04-13 13:17:15.000000000","message":"From my experience I fetched a centos image that had old kernel. The kernel-devel packages were removed from default repos so without updating your kernel and rebooting you won\u0027t be able to compile.","commit_id":"2390064efa8f741ebf9e0fe15774af13e5e6fc8c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f347550527550dafdd9f503507a4b5dad506ae6a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        echo your machine to get the latest kernel."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        install_package kernel-devel-$(uname -r)"},{"line_number":73,"context_line":"        install_package kernel-headers-$(uname -r)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    elif is_ubuntu ; then"},{"line_number":76,"context_line":"        install_package linux-headers-$(uname -r)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a18252c_31223202","line":73,"range":{"start_line":73,"start_character":24,"end_line":73,"end_character":50},"updated":"2016-04-13 10:22:05.000000000","message":"Why do we need headers specifically? kernel-devel should be enough to build kernel modules.","commit_id":"2390064efa8f741ebf9e0fe15774af13e5e6fc8c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3a0ebd8e896b7b0c9ad0c32670cbe2a34768f950","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        echo your machine to get the latest kernel."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        install_package kernel-devel-$(uname -r)"},{"line_number":73,"context_line":"        install_package kernel-headers-$(uname -r)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    elif is_ubuntu ; then"},{"line_number":76,"context_line":"        install_package linux-headers-$(uname -r)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a18252c_c307a77f","line":73,"range":{"start_line":73,"start_character":24,"end_line":73,"end_character":50},"in_reply_to":"5a18252c_31223202","updated":"2016-04-13 13:17:15.000000000","message":"Kernel modules compilation requires specific version, it looks at /usr/src/kernels/\u003ccurrent_kernel_version\u003e. When you have a mismatch between your booted kernel and kernel-devel, you\u0027ll get failure.","commit_id":"2390064efa8f741ebf9e0fe15774af13e5e6fc8c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5267be02ae217f0328bd70360fcd5ecf743e53e4","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        echo your machine to get the latest kernel."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        install_package kernel-devel-$(uname -r)"},{"line_number":73,"context_line":"        install_package kernel-headers-$(uname -r)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    elif is_ubuntu ; then"},{"line_number":76,"context_line":"        install_package linux-headers-$(uname -r)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a18252c_e3bc636e","line":73,"range":{"start_line":73,"start_character":24,"end_line":73,"end_character":50},"in_reply_to":"5a18252c_c307a77f","updated":"2016-04-13 13:19:36.000000000","message":"Yeah, but why do we need -headers in addition to -devel? The latter should be enough.","commit_id":"2390064efa8f741ebf9e0fe15774af13e5e6fc8c"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"6b576c7eb6fd1da697bd045cb26a232d7be4510e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        echo your machine to get the latest kernel."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        install_package kernel-devel-$(uname -r)"},{"line_number":73,"context_line":"        install_package kernel-headers-$(uname -r)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    elif is_ubuntu ; then"},{"line_number":76,"context_line":"        install_package linux-headers-$(uname -r)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a18252c_3e22f201","line":73,"range":{"start_line":73,"start_character":24,"end_line":73,"end_character":50},"in_reply_to":"5a18252c_e3bc636e","updated":"2016-04-13 13:29:11.000000000","message":"It didn\u0027t work for me until I installed -headers. Are we sure this is always pulled via depts? it didn\u0027t seem like the case for me in centos.","commit_id":"2390064efa8f741ebf9e0fe15774af13e5e6fc8c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"72373e9008609f942902605f2135bde583eb980d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        echo your machine to get the latest kernel."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        install_package kernel-devel-$(uname -r)"},{"line_number":73,"context_line":"        install_package kernel-headers-$(uname -r)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    elif is_ubuntu ; then"},{"line_number":76,"context_line":"        install_package linux-headers-$(uname -r)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a18252c_fe86bad9","line":73,"range":{"start_line":73,"start_character":24,"end_line":73,"end_character":50},"in_reply_to":"5a18252c_e3bc636e","updated":"2016-04-13 13:29:31.000000000","message":"Sorry, I totally misread the first comment :) You\u0027re right. I\u0027m not experienced enough with kernel-headers so I\u0027m not sure whether we can get missing symbols or something when compiling with different headers version.","commit_id":"2390064efa8f741ebf9e0fe15774af13e5e6fc8c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a8cbf48dc10557358c862cb4b38e58b94ce7ec3c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        echo your machine to get the latest kernel."},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        install_package kernel-devel-$(uname -r)"},{"line_number":73,"context_line":"        install_package kernel-headers-$(uname -r)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    elif is_ubuntu ; then"},{"line_number":76,"context_line":"        install_package linux-headers-$(uname -r)"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"5a18252c_b9ec5c2a","line":73,"range":{"start_line":73,"start_character":24,"end_line":73,"end_character":50},"in_reply_to":"5a18252c_fe86bad9","updated":"2016-04-13 13:38:33.000000000","message":"OK, anyway however dependencies are set between packages, ovs is both userland and kmod, so probably it\u0027s wise indeed to install both explicitly.","commit_id":"2390064efa8f741ebf9e0fe15774af13e5e6fc8c"}],"devstack/plugin.sh":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ff5f010ab9da371de489698a1ae00bae0afdb853","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            if is_service_enabled q-bgp; then"},{"line_number":23,"context_line":"                configure_bgp"},{"line_number":24,"context_line":"            fi"},{"line_number":25,"context_line":"            if [[ $Q_AGENT \u003d\u003d \"openvswitch\" ]] \u0026\u0026 \\"},{"line_number":26,"context_line":"               [[ $Q_BUILD_OVS_FROM_GIT \u003d\u003d \"True\" ]]; then"},{"line_number":27,"context_line":"                remove_ovs_packages"},{"line_number":28,"context_line":"                compile_ovs True /usr/ /var/"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a18252c_22ffb902","line":25,"range":{"start_line":25,"start_character":18,"end_line":25,"end_character":26},"updated":"2016-04-12 11:43:44.000000000","message":"\"$Q_AGENT\"","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"879d22326001f148e0c43f03435ffba3fab355d7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"            if is_service_enabled q-bgp; then"},{"line_number":23,"context_line":"                configure_bgp"},{"line_number":24,"context_line":"            fi"},{"line_number":25,"context_line":"            if [[ $Q_AGENT \u003d\u003d \"openvswitch\" ]] \u0026\u0026 \\"},{"line_number":26,"context_line":"               [[ $Q_BUILD_OVS_FROM_GIT \u003d\u003d \"True\" ]]; then"},{"line_number":27,"context_line":"                remove_ovs_packages"},{"line_number":28,"context_line":"                compile_ovs True /usr/ /var/"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a18252c_c58d2f7d","line":25,"range":{"start_line":25,"start_character":18,"end_line":25,"end_character":26},"in_reply_to":"5a18252c_22ffb902","updated":"2016-04-12 12:01:41.000000000","message":"Done","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ff5f010ab9da371de489698a1ae00bae0afdb853","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                configure_bgp"},{"line_number":24,"context_line":"            fi"},{"line_number":25,"context_line":"            if [[ $Q_AGENT \u003d\u003d \"openvswitch\" ]] \u0026\u0026 \\"},{"line_number":26,"context_line":"               [[ $Q_BUILD_OVS_FROM_GIT \u003d\u003d \"True\" ]]; then"},{"line_number":27,"context_line":"                remove_ovs_packages"},{"line_number":28,"context_line":"                compile_ovs True /usr/ /var/"},{"line_number":29,"context_line":"                start_new_ovs"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a18252c_e21dc167","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":39},"updated":"2016-04-12 11:43:44.000000000","message":"\"$Q_BUILD_OVS_FROM_GIT\" - if it would be undefined, it\u0027s gonna crash.","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"879d22326001f148e0c43f03435ffba3fab355d7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                configure_bgp"},{"line_number":24,"context_line":"            fi"},{"line_number":25,"context_line":"            if [[ $Q_AGENT \u003d\u003d \"openvswitch\" ]] \u0026\u0026 \\"},{"line_number":26,"context_line":"               [[ $Q_BUILD_OVS_FROM_GIT \u003d\u003d \"True\" ]]; then"},{"line_number":27,"context_line":"                remove_ovs_packages"},{"line_number":28,"context_line":"                compile_ovs True /usr/ /var/"},{"line_number":29,"context_line":"                start_new_ovs"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a18252c_859337a3","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":39},"in_reply_to":"5a18252c_c2c1a530","updated":"2016-04-12 12:01:41.000000000","message":"Done","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"1c2e40d97681221e128443086b4b29fffe4f5433","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                configure_bgp"},{"line_number":24,"context_line":"            fi"},{"line_number":25,"context_line":"            if [[ $Q_AGENT \u003d\u003d \"openvswitch\" ]] \u0026\u0026 \\"},{"line_number":26,"context_line":"               [[ $Q_BUILD_OVS_FROM_GIT \u003d\u003d \"True\" ]]; then"},{"line_number":27,"context_line":"                remove_ovs_packages"},{"line_number":28,"context_line":"                compile_ovs True /usr/ /var/"},{"line_number":29,"context_line":"                start_new_ovs"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a18252c_c2c1a530","line":26,"range":{"start_line":26,"start_character":18,"end_line":26,"end_character":39},"in_reply_to":"5a18252c_e21dc167","updated":"2016-04-12 11:51:31.000000000","message":"Can\u0027t be undefined from L11","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ff5f010ab9da371de489698a1ae00bae0afdb853","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            if [[ $Q_AGENT \u003d\u003d \"openvswitch\" ]] \u0026\u0026 \\"},{"line_number":26,"context_line":"               [[ $Q_BUILD_OVS_FROM_GIT \u003d\u003d \"True\" ]]; then"},{"line_number":27,"context_line":"                remove_ovs_packages"},{"line_number":28,"context_line":"                compile_ovs True /usr/ /var/"},{"line_number":29,"context_line":"                start_new_ovs"},{"line_number":30,"context_line":"            fi"},{"line_number":31,"context_line":"            ;;"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a18252c_a23aa9cb","line":28,"range":{"start_line":28,"start_character":33,"end_line":28,"end_character":44},"updated":"2016-04-12 11:43:44.000000000","message":"/usr /var should be just fine :)","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"879d22326001f148e0c43f03435ffba3fab355d7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"            if [[ $Q_AGENT \u003d\u003d \"openvswitch\" ]] \u0026\u0026 \\"},{"line_number":26,"context_line":"               [[ $Q_BUILD_OVS_FROM_GIT \u003d\u003d \"True\" ]]; then"},{"line_number":27,"context_line":"                remove_ovs_packages"},{"line_number":28,"context_line":"                compile_ovs True /usr/ /var/"},{"line_number":29,"context_line":"                start_new_ovs"},{"line_number":30,"context_line":"            fi"},{"line_number":31,"context_line":"            ;;"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a18252c_45811f4a","line":28,"range":{"start_line":28,"start_character":33,"end_line":28,"end_character":44},"in_reply_to":"5a18252c_a23aa9cb","updated":"2016-04-12 12:01:41.000000000","message":"Done","commit_id":"4b20c660de53ac9a23b9566c5c035c9d09bf5785"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8926f194d63188ea962e61d16941d6ea7621f557","unresolved":false,"context_lines":[{"line_number":8,"context_line":"source $LIBDIR/qos"},{"line_number":9,"context_line":"source $LIBDIR/ovs"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Q_BUILD_OVS_FROM_GIT\u003d${Q_BUILD_OVS_FROM_GIT:-False}"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"if [[ \"$1\" \u003d\u003d \"stack\" ]]; then"},{"line_number":14,"context_line":"    case \"$2\" in"}],"source_content_type":"text/x-sh","patch_set":2,"id":"5a18252c_a5cab34d","line":11,"range":{"start_line":11,"start_character":21,"end_line":11,"end_character":51},"updated":"2016-04-12 12:07:47.000000000","message":"To not rely on case sensitiveness:\n\n Q_BUILD_FROM_OVS_FROM_GIT\u003d$(trueorfalse False Q_BUILD_OVS_FROM_GIT)","commit_id":"f81f1244dff1b7bc61b6051849b61c1813bae2d7"}]}