)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"91b0338c6edfb0c9f9e9c125ff6fb43dd9c2c794","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-06-02 13:57:52 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP]L2-Adjacency support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id2d4331568886bee52e78e1c138f1475cc89342b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9abb7d3a_e34823cf","line":8,"updated":"2016-06-02 15:06:45.000000000","message":"Do we have any bug for this? Or could you elaborate a little bit more L2-Adjacency?","commit_id":"de4b4d5c9632ab3577b92a99a4c778a283480a6e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d827b5587a9b56566cd0d8f41157912830d9549b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-06-02 13:57:52 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP]L2-Adjacency support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Id2d4331568886bee52e78e1c138f1475cc89342b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9abb7d3a_23d786ee","line":8,"in_reply_to":"9abb7d3a_e34823cf","updated":"2016-06-03 14:54:30.000000000","message":"This should include this line:\n\n  Partially-Implements: blueprint routed-networks","commit_id":"de4b4d5c9632ab3577b92a99a4c778a283480a6e"}],"neutron/db/l2_adjacency_db.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4f908fd7a4c83b913eec1219b82b146c136c58ef","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 NEC Technologies Ltd. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_068d167b","line":1,"updated":"2016-04-19 08:16:14.000000000","message":"Can it just be part of segment_db? I think it is not necessary to create a separate file for this attribute.","commit_id":"2acbc3be1617ebfb0156a886ed9177e7b4cd99de"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c802144d4e5185ebb1f128a8d66f41aaaf140b63","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 NEC Technologies Ltd. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_9dc97d28","line":1,"in_reply_to":"1a122d0e_068d167b","updated":"2016-06-01 04:56:29.000000000","message":"I am keeping this file for now, lets see if this is a popular consensus....","commit_id":"2acbc3be1617ebfb0156a886ed9177e7b4cd99de"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d827b5587a9b56566cd0d8f41157912830d9549b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9abb7d3a_c6f32809","updated":"2016-06-03 14:54:30.000000000","message":"I don\u0027t think we should have this file.  I think this stuff should go in the segments service plugin.","commit_id":"de4b4d5c9632ab3577b92a99a4c778a283480a6e"}],"neutron/db/migration/alembic_migrations/versions/newton/expand/db933eb79caf_l2_adjacency.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c124978dcb1fb5a99b5772a05cfc0a172517a60a","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade():"},{"line_number":34,"context_line":"    op.add_column(\u0027networks\u0027,"},{"line_number":35,"context_line":"                  sa.Column(\u0027l2_adjacency\u0027,"},{"line_number":36,"context_line":"                            sa.Boolean(),"},{"line_number":37,"context_line":"                            server_default\u003dsql.false(),"},{"line_number":38,"context_line":"                            nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_cf6b6584","line":35,"range":{"start_line":35,"start_character":29,"end_line":35,"end_character":41},"updated":"2016-05-03 19:26:54.000000000","message":"I don\u0027t think we need a database column.  Can\u0027t this be computed at runtime?","commit_id":"2acbc3be1617ebfb0156a886ed9177e7b4cd99de"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c802144d4e5185ebb1f128a8d66f41aaaf140b63","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def upgrade():"},{"line_number":34,"context_line":"    op.add_column(\u0027networks\u0027,"},{"line_number":35,"context_line":"                  sa.Column(\u0027l2_adjacency\u0027,"},{"line_number":36,"context_line":"                            sa.Boolean(),"},{"line_number":37,"context_line":"                            server_default\u003dsql.false(),"},{"line_number":38,"context_line":"                            nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_3ddb31ef","line":35,"range":{"start_line":35,"start_character":29,"end_line":35,"end_character":41},"in_reply_to":"1a122d0e_cf6b6584","updated":"2016-06-01 04:56:29.000000000","message":"I think it can be computed at runtime","commit_id":"2acbc3be1617ebfb0156a886ed9177e7b4cd99de"}],"neutron/db/models_v2.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4f908fd7a4c83b913eec1219b82b146c136c58ef","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    dhcp_agents \u003d orm.relationship("},{"line_number":282,"context_line":"        \u0027Agent\u0027, lazy\u003d\u0027joined\u0027, viewonly\u003dTrue,"},{"line_number":283,"context_line":"        secondary\u003dagt.NetworkDhcpAgentBinding.__table__)"},{"line_number":284,"context_line":"    l2_adjacency \u003d sa.Column(sa.Boolean, nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_6675ea96","line":284,"range":{"start_line":284,"start_character":0,"end_line":284,"end_character":55},"updated":"2016-04-19 08:16:14.000000000","message":"If it is a derived, read-only attribute, I think it could be out of the db model. Just generate it every time the network is retrieved.","commit_id":"2acbc3be1617ebfb0156a886ed9177e7b4cd99de"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c124978dcb1fb5a99b5772a05cfc0a172517a60a","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    dhcp_agents \u003d orm.relationship("},{"line_number":282,"context_line":"        \u0027Agent\u0027, lazy\u003d\u0027joined\u0027, viewonly\u003dTrue,"},{"line_number":283,"context_line":"        secondary\u003dagt.NetworkDhcpAgentBinding.__table__)"},{"line_number":284,"context_line":"    l2_adjacency \u003d sa.Column(sa.Boolean, nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_0f043dc4","line":284,"range":{"start_line":284,"start_character":0,"end_line":284,"end_character":55},"in_reply_to":"1a122d0e_6675ea96","updated":"2016-05-03 19:26:54.000000000","message":"+1, I just left a similar comment in the file before.","commit_id":"2acbc3be1617ebfb0156a886ed9177e7b4cd99de"}],"neutron/extensions/l2_adjacency.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c124978dcb1fb5a99b5772a05cfc0a172517a60a","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def get_l2_adjacency(network):"},{"line_number":31,"context_line":"    if \u0027provider:segmentation_id\u0027 in network:"},{"line_number":32,"context_line":"        return True"},{"line_number":33,"context_line":"    return False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class L2_adjacency(extensions.ExtensionDescriptor):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_4ffd956d","line":33,"range":{"start_line":31,"start_character":4,"end_line":33,"end_character":16},"updated":"2016-05-03 19:26:54.000000000","message":"This code probably shouldn\u0027t be in this file.  Since other plugins (like Calico) are likely to implement this totally differently.  They\u0027ll want the extension but not the code.\n\nFor our purposes, this isn\u0027t quite the right logic.  It might be my fault if I did not update the spec correctly.  Here is the logic which should be applied:\n\nThis attribute should be False if the subnets on the network are associated with segments (i.e. they have non-null segment_ids).  It should return True otherwise.","commit_id":"2acbc3be1617ebfb0156a886ed9177e7b4cd99de"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c802144d4e5185ebb1f128a8d66f41aaaf140b63","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def get_l2_adjacency(network):"},{"line_number":31,"context_line":"    if \u0027provider:segmentation_id\u0027 in network:"},{"line_number":32,"context_line":"        return True"},{"line_number":33,"context_line":"    return False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class L2_adjacency(extensions.ExtensionDescriptor):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_c0fe7c04","line":33,"range":{"start_line":31,"start_character":4,"end_line":33,"end_character":16},"in_reply_to":"1a122d0e_4ffd956d","updated":"2016-06-01 04:56:29.000000000","message":"\u003e\u003e This code probably shouldn\u0027t be in this file.\nCan you elaborate a bit ?\nWhere should the code be placed? Any suggestions?","commit_id":"2acbc3be1617ebfb0156a886ed9177e7b4cd99de"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"91b0338c6edfb0c9f9e9c125ff6fb43dd9c2c794","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def get_l2_adjacency(network):"},{"line_number":31,"context_line":"    if \u0027provider:segmentation_id\u0027 in network:"},{"line_number":32,"context_line":"        return True"},{"line_number":33,"context_line":"    return False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class L2_adjacency(extensions.ExtensionDescriptor):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_e3aca38e","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":16},"updated":"2016-06-02 15:06:45.000000000","message":"You can simplify this condition to sth like:\n\n  return (\u0027provider:segmentation_id\u0027 in network)","commit_id":"de4b4d5c9632ab3577b92a99a4c778a283480a6e"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"98d136dba61584856b6860be1986900dc62f2449","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def get_l2_adjacency(network):"},{"line_number":31,"context_line":"    if \u0027provider:segmentation_id\u0027 in network:"},{"line_number":32,"context_line":"        return True"},{"line_number":33,"context_line":"    return False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class L2_adjacency(extensions.ExtensionDescriptor):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_723eb7b9","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":16},"in_reply_to":"9abb7d3a_43828a95","updated":"2016-06-06 06:20:15.000000000","message":"+1","commit_id":"de4b4d5c9632ab3577b92a99a4c778a283480a6e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d827b5587a9b56566cd0d8f41157912830d9549b","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def get_l2_adjacency(network):"},{"line_number":31,"context_line":"    if \u0027provider:segmentation_id\u0027 in network:"},{"line_number":32,"context_line":"        return True"},{"line_number":33,"context_line":"    return False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class L2_adjacency(extensions.ExtensionDescriptor):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_43828a95","line":33,"range":{"start_line":31,"start_character":0,"end_line":33,"end_character":16},"in_reply_to":"9abb7d3a_e3aca38e","updated":"2016-06-03 14:54:30.000000000","message":"I\u0027m thinking that this logic should go with the segments service plugin, somewhere under neutron/services/segments/ probably.  That service plugin should implement this extension and provide its own implementation of it. That\u0027s what I\u0027m thinking.\n\nThis way, the extension is free to be used by other plugins, Calico being the main one that I think will implement this in a different way.","commit_id":"de4b4d5c9632ab3577b92a99a4c778a283480a6e"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"91b0338c6edfb0c9f9e9c125ff6fb43dd9c2c794","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @classmethod"},{"line_number":54,"context_line":"    def get_description(cls):"},{"line_number":55,"context_line":"        return (\"Display L2 Adjacency for Neutron Networks.\")"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def get_updated(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_63e6f3e9","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":61},"updated":"2016-06-02 15:06:45.000000000","message":"Missing translation.","commit_id":"de4b4d5c9632ab3577b92a99a4c778a283480a6e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d827b5587a9b56566cd0d8f41157912830d9549b","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @classmethod"},{"line_number":54,"context_line":"    def get_description(cls):"},{"line_number":55,"context_line":"        return (\"Display L2 Adjacency for Neutron Networks.\")"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def get_updated(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_a671c4aa","line":55,"range":{"start_line":55,"start_character":15,"end_line":55,"end_character":16},"updated":"2016-06-03 14:54:30.000000000","message":"The parentheses should not be here.","commit_id":"de4b4d5c9632ab3577b92a99a4c778a283480a6e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d827b5587a9b56566cd0d8f41157912830d9549b","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @classmethod"},{"line_number":54,"context_line":"    def get_description(cls):"},{"line_number":55,"context_line":"        return (\"Display L2 Adjacency for Neutron Networks.\")"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def get_updated(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_862640b8","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":61},"in_reply_to":"9abb7d3a_63e6f3e9","updated":"2016-06-03 14:54:30.000000000","message":"Other extensions do not provide translations for descriptions.  I wouldn\u0027t add it here.  If we decide to start providing translations for this value then we should add it consistently across them all.","commit_id":"de4b4d5c9632ab3577b92a99a4c778a283480a6e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"70a57790862955820872e3fdcb0fae0a24446353","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    @classmethod"},{"line_number":54,"context_line":"    def get_description(cls):"},{"line_number":55,"context_line":"        return (\"Display L2 Adjacency for Neutron Networks.\")"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def get_updated(cls):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_a4ef4be8","line":55,"range":{"start_line":55,"start_character":15,"end_line":55,"end_character":16},"in_reply_to":"9abb7d3a_a671c4aa","updated":"2016-06-15 12:16:31.000000000","message":"Done","commit_id":"de4b4d5c9632ab3577b92a99a4c778a283480a6e"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"6a1541f1f7e01a0abd985e15cb86702291c4b0aa","unresolved":false,"context_lines":[{"line_number":31,"context_line":"class L2_adjacency(extensions.ExtensionDescriptor):"},{"line_number":32,"context_line":"    \"\"\"Extension class supporting L2 Adjacency for Routed Networks"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    The following class is used by neutrons\u0027s extension framework"},{"line_number":35,"context_line":"    to provide metadata related to the L2 Adjacency for Neutron"},{"line_number":36,"context_line":"    Routed Network, exposing the same to clients."},{"line_number":37,"context_line":"    No new resources have been defined by this extension."}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_d6b1f448","line":34,"range":{"start_line":34,"start_character":35,"end_line":34,"end_character":45},"updated":"2016-06-23 17:34:24.000000000","message":"typo, should be neutron\u0027s","commit_id":"101c58576d856b38306208693503a36465a3625f"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"61529243d0d2084791c39040c640daa428aafac5","unresolved":false,"context_lines":[{"line_number":21,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":22,"context_line":"    \u0027networks\u0027: {"},{"line_number":23,"context_line":"        L2_ADJACENCY: {\u0027allow_post\u0027: False, \u0027allow_put\u0027: False,"},{"line_number":24,"context_line":"                       \u0027convert_to\u0027: attr.convert_to_boolean,"},{"line_number":25,"context_line":"                       \u0027is_visible\u0027: True}"},{"line_number":26,"context_line":"    }"},{"line_number":27,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_fb279460","line":24,"range":{"start_line":24,"start_character":23,"end_line":24,"end_character":60},"updated":"2016-06-30 06:22:21.000000000","message":"This shouldn\u0027t be needed as it\u0027s not going to be accepted in any body and the convert_to is only used for request bodies.","commit_id":"d8176d39dc3875fb6381f41a29761f54bff686e4"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"86abddfa27973ddb3ddf633c5b9eeb96fbdd5aac","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron.api import extensions"},{"line_number":17,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"L2_ADJACENCY \u003d \u0027l2_adjacency\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_a143e840","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":45},"updated":"2016-07-01 01:44:18.000000000","message":"PEP8 ./neutron/extensions/l2_adjacency.py:17:1: F401 \u0027attr\u0027 imported but unused","commit_id":"f7a3073ef04687d241304d38b008f3ff675a590e"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c124978dcb1fb5a99b5772a05cfc0a172517a60a","unresolved":false,"context_lines":[{"line_number":693,"context_line":"                result[\u0027vlan_transparent\u0027] \u003d vlt"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"            # Update the transparent vlan if configured"},{"line_number":696,"context_line":"            if utils.is_extension_supported(self, \u0027l2-adjacency\u0027):"},{"line_number":697,"context_line":"                l2 \u003d l2_adjacency.get_l2_adjacency(net_data)"},{"line_number":698,"context_line":"                net_db[\u0027vlan_transparent\u0027] \u003d l2"},{"line_number":699,"context_line":"                result[\u0027vlan_transparent\u0027] \u003d l2"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_fd61b239","line":696,"range":{"start_line":696,"start_character":21,"end_line":696,"end_character":43},"updated":"2016-05-03 19:26:54.000000000","message":"You might consider using the extension manager [1].  We might also look at putting this in the segments service plugin.  Anyway, putting it in ML2 is too coupled to the ML2 plugin.  We need a place where it could be shared between ML2 and the OVN plugin, at least.\n\n[1] http://docs.openstack.org/developer/neutron/devref/effective_neutron.html#plugin-development","commit_id":"2acbc3be1617ebfb0156a886ed9177e7b4cd99de"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"4f908fd7a4c83b913eec1219b82b146c136c58ef","unresolved":false,"context_lines":[{"line_number":695,"context_line":"            # Update the transparent vlan if configured"},{"line_number":696,"context_line":"            if utils.is_extension_supported(self, \u0027l2-adjacency\u0027):"},{"line_number":697,"context_line":"                l2 \u003d l2_adjacency.get_l2_adjacency(net_data)"},{"line_number":698,"context_line":"                net_db[\u0027vlan_transparent\u0027] \u003d l2"},{"line_number":699,"context_line":"                result[\u0027vlan_transparent\u0027] \u003d l2"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        self._apply_dict_extend_functions(\u0027networks\u0027, result, net_db)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_0b523fdd","line":698,"range":{"start_line":698,"start_character":24,"end_line":698,"end_character":40},"updated":"2016-04-19 08:16:14.000000000","message":"You want \"l2_adjacency\" here, right?","commit_id":"2acbc3be1617ebfb0156a886ed9177e7b4cd99de"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"086c32a0be8491b78d91388f7de8cc4f31ad7dc5","unresolved":false,"context_lines":[{"line_number":695,"context_line":"            # Update the transparent vlan if configured"},{"line_number":696,"context_line":"            if utils.is_extension_supported(self, \u0027l2-adjacency\u0027):"},{"line_number":697,"context_line":"                l2 \u003d l2_adjacency.get_l2_adjacency(net_data)"},{"line_number":698,"context_line":"                net_db[\u0027vlan_transparent\u0027] \u003d l2"},{"line_number":699,"context_line":"                result[\u0027vlan_transparent\u0027] \u003d l2"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"        self._apply_dict_extend_functions(\u0027networks\u0027, result, net_db)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_867126e3","line":698,"range":{"start_line":698,"start_character":24,"end_line":698,"end_character":40},"in_reply_to":"1a122d0e_0b523fdd","updated":"2016-04-19 08:31:01.000000000","message":"Yes, but this patch is WIP :)\nActually I was rebooting my system before going home and this patch was not complete, so I uploaded it so that I can check it from my home as well ( though I didnt do it at home :P)\nAnyways, thanks for the catch and your review!","commit_id":"2acbc3be1617ebfb0156a886ed9177e7b4cd99de"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d827b5587a9b56566cd0d8f41157912830d9549b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9abb7d3a_865e40e7","updated":"2016-06-03 14:54:30.000000000","message":"I don\u0027t think this file should be changed.  I think all the changes should go in the segments service plugin, except the definition of the API extension itself.","commit_id":"de4b4d5c9632ab3577b92a99a4c778a283480a6e"}],"neutron/services/segments/l2_adjacency_plugin.py":[{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"6a1541f1f7e01a0abd985e15cb86702291c4b0aa","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutron.api.v2 import attributes"},{"line_number":17,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":18,"context_line":"from neutron.extensions import l2_adjacency"},{"line_number":19,"context_line":"from neutron.services.segments import db"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class l2_adjacency_db_mixin(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_d76c4b37","line":19,"updated":"2016-06-23 17:34:24.000000000","message":"I believe this import is not used.","commit_id":"101c58576d856b38306208693503a36465a3625f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"af6c28fe7c0459cd09756800ad296f34daa1958e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from neutron.api.v2 import attributes"},{"line_number":17,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":18,"context_line":"from neutron.extensions import l2_adjacency"},{"line_number":19,"context_line":"from neutron.services.segments import db"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class l2_adjacency_db_mixin(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_493a22e8","line":19,"in_reply_to":"3aaa91ec_d76c4b37","updated":"2016-06-27 04:59:38.000000000","message":"Done","commit_id":"101c58576d856b38306208693503a36465a3625f"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"6a1541f1f7e01a0abd985e15cb86702291c4b0aa","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        attributes.NETWORKS, [\u0027_extend_network_dict_network_adjacency\u0027])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_l2_adjacency(cls, network):"},{"line_number":34,"context_line":"\t    return not(\u0027provider:segementation_id\u0027 in network)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_f6b99016","line":34,"range":{"start_line":34,"start_character":26,"end_line":34,"end_character":42},"updated":"2016-06-23 17:34:24.000000000","message":"typo, should be segmentation_id (I believe - please check)","commit_id":"101c58576d856b38306208693503a36465a3625f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"af6c28fe7c0459cd09756800ad296f34daa1958e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        attributes.NETWORKS, [\u0027_extend_network_dict_network_adjacency\u0027])"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_l2_adjacency(cls, network):"},{"line_number":34,"context_line":"\t    return not(\u0027provider:segementation_id\u0027 in network)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_293d16dd","line":34,"range":{"start_line":34,"start_character":26,"end_line":34,"end_character":42},"in_reply_to":"3aaa91ec_f6b99016","updated":"2016-06-27 04:59:38.000000000","message":"Done","commit_id":"101c58576d856b38306208693503a36465a3625f"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"6a1541f1f7e01a0abd985e15cb86702291c4b0aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3aaa91ec_76e000fb","line":35,"updated":"2016-06-23 17:34:24.000000000","message":"More importantly, is that actually the correct implementation?  I was expecting an independent field in the Neutron DB for a Network object, that the plugin would determine how to set.","commit_id":"101c58576d856b38306208693503a36465a3625f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"af6c28fe7c0459cd09756800ad296f34daa1958e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3aaa91ec_a900e602","line":35,"in_reply_to":"3aaa91ec_76e000fb","updated":"2016-06-27 04:59:38.000000000","message":"No, no need for the DB, this can be computed at runtime as specified in earlier comments.","commit_id":"101c58576d856b38306208693503a36465a3625f"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"61529243d0d2084791c39040c640daa428aafac5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.extensions import l2_adjacency"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class l2_adjacency_db_mixin(object):"},{"line_number":22,"context_line":"    \"\"\"Mixin class to add L2 Adjacency methods to db_base_plugin_v2.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def _extend_network_dict_network_adjacency(self, network_res, network_db):"}],"source_content_type":"text/x-python","patch_set":9,"id":"3aaa91ec_dbd3b836","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":27},"updated":"2016-06-30 06:22:21.000000000","message":"any reason this isn\u0027t CamelCase?","commit_id":"d8176d39dc3875fb6381f41a29761f54bff686e4"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"86abddfa27973ddb3ddf633c5b9eeb96fbdd5aac","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.extensions import l2_adjacency"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class L2adjacencydbmixin(object):"},{"line_number":22,"context_line":"    \"\"\"Mixin class to add L2 Adjacency methods to db_base_plugin_v2.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def _extend_network_dict_network_adjacency(self, network_res, network_db):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_2184185c","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":33},"updated":"2016-07-01 01:44:18.000000000","message":"I know that this is still WIP, but where are you planning to use this mixin?","commit_id":"f7a3073ef04687d241304d38b008f3ff675a590e"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"2781236efada469d42a37f9520739687e810ee13","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.extensions import l2_adjacency"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class L2adjacencydbmixin(object):"},{"line_number":22,"context_line":"    \"\"\"Mixin class to add L2 Adjacency methods to db_base_plugin_v2.\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def _extend_network_dict_network_adjacency(self, network_res, network_db):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_0c506131","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":24},"updated":"2016-06-30 10:35:58.000000000","message":"L2AdjacencyDbMixin","commit_id":"f7a3073ef04687d241304d38b008f3ff675a590e"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"2781236efada469d42a37f9520739687e810ee13","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        attributes.NETWORKS, [\u0027_extend_network_dict_network_adjacency\u0027])"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_l2_adjacency(cls, network):"},{"line_number":33,"context_line":"        return not(\u0027provider:segmentation_id\u0027 in network)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3aaa91ec_a7d206fe","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":57},"updated":"2016-06-30 10:35:58.000000000","message":"Is it not the case that l2_adjacency should be True in the case of a single segment and false otherwise? If so then this doesn\u0027t seem to be the correct logic.","commit_id":"f7a3073ef04687d241304d38b008f3ff675a590e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"f7eaeeedb847909bee369da3131c21eb1ac6b5a3","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        attributes.NETWORKS, [\u0027_extend_network_dict_network_adjacency\u0027])"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_l2_adjacency(cls, network):"},{"line_number":33,"context_line":"        return not(\u0027provider:segmentation_id\u0027 in network)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_9cbb2de5","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":57},"in_reply_to":"3aaa91ec_a7d206fe","updated":"2016-07-05 14:22:44.000000000","message":"This attribute should be False if the subnets on the network are associated with segments (i.e. they have non-null segment_ids).  It should return True otherwise.\n\nI am not sure about single segments though","commit_id":"f7a3073ef04687d241304d38b008f3ff675a590e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1397ae0b6b4e6bd12091e90ea082d09ca75a9c57","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("},{"line_number":30,"context_line":"        attributes.NETWORKS, [\u0027_extend_network_dict_network_adjacency\u0027])"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_l2_adjacency(cls, network):"},{"line_number":33,"context_line":"        return not(\u0027provider:segmentation_id\u0027 in network)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_583ffed5","line":33,"range":{"start_line":32,"start_character":8,"end_line":33,"end_character":57},"updated":"2016-07-05 20:10:06.000000000","message":"This isn\u0027t quite the right logic.  We need to look for subnets on the network with a non-null segment_id.","commit_id":"56ddb5bd693501319689b6067cc1da8cffc63a47"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"da9768183ed38589296d9fb0469ae485e6a14868","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("},{"line_number":30,"context_line":"        attributes.NETWORKS, [\u0027_extend_network_dict_network_adjacency\u0027])"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_l2_adjacency(cls, network):"},{"line_number":33,"context_line":"        return not(\u0027provider:segmentation_id\u0027 in network)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_f397a845","line":33,"range":{"start_line":32,"start_character":8,"end_line":33,"end_character":57},"in_reply_to":"1aa78d24_09719844","updated":"2016-07-12 17:30:20.000000000","message":"For the record, below is the discussion from today\u0027s routed networks IRC meeting.  I believe the summary is that Reedip/Carl will continue working on this change _without_ allowing the ML2 driver to override that l2-adjacency should be False, and that I will work on a further change that adds that ability - i.e. that allows an ML2 driver to say that l2-adjacency should be False for a particular Network.\n\nJul 12 15:36:09 \u003ccarl_baldwin\u003e\t#topic L2 Adjacency Extension\nJul 12 15:36:21 \u003ccarl_baldwin\u003e\treedip: neiljerram: hi\nJul 12 15:36:31 \u003ccarl_baldwin\u003e\tneiljerram: I saw your comments on the patch set.\nJul 12 15:36:34 \u003cneiljerram\u003e\tcarl_baldwin, hi\nJul 12 15:36:46 \u003ccarl_baldwin\u003e\tDid you see my reply?\nJul 12 15:36:50 \u003cneiljerram\u003e\tcarl_baldwin, thanks; I saw your response too\nJul 12 15:37:20 \u003ccarl_baldwin\u003e\tneiljerram: Calico is ML2, right?\nJul 12 15:37:59 \u003cneiljerram\u003e\tnetworking-calico can currently be a core plugin or an ML2 driver - but the clear steer from Neutron as a whole is for it to focus on being ML2, I believe.\nJul 12 15:38:47 \u003ccarl_baldwin\u003e\tneiljerram: That might explain my confusion.  I wasn\u0027t aware of the duality.\nJul 12 15:39:07 \u003cneiljerram\u003e\t(I\u0027d like to keep networking-calico in the Neutron stadium, and I believe that being ML2 is more-or-less a requirement for that, as it encourages us all to align our implementation approaches)\nJul 12 15:39:16 \u003ccarl_baldwin\u003e\tWhen I made my original comments, I was thinking of it as a core plugin.  I thought it could just implement the extension on its own.\nJul 12 15:39:22 \u003cneiljerram\u003e\tUnderstood.\nJul 12 15:40:28 \u003ccarl_baldwin\u003e\tI\u0027m thinking we might need our implementation to call the core plugin and pass the network.  Then, in ML2, the mechanism driver could answer for the particular network.  Does that sound about right?\nJul 12 15:40:29 \u003cneiljerram\u003e\tWell how about if the current review proceeds on the assumption that an ML2 driver cannot control l2-adjacency, and then I take on whatever work is needed so that a driver can influence that?\nJul 12 15:41:24 \u003ccarl_baldwin\u003e\tneiljerram: That sounds fine.\nJul 12 15:41:31 \u003cneiljerram\u003e\tThe only think is, I\u0027m not sure it\u0027s correct (in all scenarios) that a Network is \u0027owned\u0027 by one mechanism driver.\nJul 12 15:42:23 \u003cneiljerram\u003e\tRemembering rkukura\u0027s talk in Austin, I think there are scenarios where multiple ML2 drivers cooperate to do setup for a Network - e.g. at different levels.\nJul 12 15:42:24 \u003ccarl_baldwin\u003e\tneiljerram: Yes, the driver \"owns\" the segment, right?\nJul 12 15:43:21 \u003cneiljerram\u003e\tI\u0027m not sure, I\u0027m afraid (in general).\nJul 12 15:43:52 \u003cmlavalle\u003e\tThat is for Hierarchichal Port Binding\nJul 12 15:44:07 \u003cneiljerram\u003e\tmlavalle, right.\nJul 12 15:44:21 \u003ccarl_baldwin\u003e\tI\u0027m thinking the segments service plugin could have the first chance to answer \"not adjacent\".  Then, maybe the mechanism drivers could have a chance to answer \"not adjacent\" too.\nJul 12 15:44:55 \u003cneiljerram\u003e\tThat sounds like it could make sense.\nJul 12 15:45:35 \u003cneiljerram\u003e\tIf one thinks of what mechanism drivers actually do, those things would influence whether or not there was real l2 adjacency.\nJul 12 15:45:54 \u003ccarl_baldwin\u003e\tneiljerram: I agree.\nJul 12 15:45:56 \u003cneiljerram\u003e\tAnd if any of them says \"not\", that breaks the chain.\nJul 12 15:46:24 \u003ccarl_baldwin\u003e\tneiljerram: I also think this could be done in two stages as you suggest.  Let\u0027s work together to get these lined up.\nJul 12 15:46:53 \u003cneiljerram\u003e\tOK, will do.  I will put up a separate patch that builds on reedip\u0027s.\nJul 12 15:46:55 \u003ccarl_baldwin\u003e\tneiljerram: I\u0027ll try to get the patch that\u0027s up in to shape for the segments service plugin piece.\nJul 12 15:47:12 \u003ccarl_baldwin\u003e\t#action carl_baldwin will get l2 adjacency patch in to shape.\nJul 12 15:47:50 \u003ccarl_baldwin\u003e\tneiljerram: Sounds like a plan.","commit_id":"56ddb5bd693501319689b6067cc1da8cffc63a47"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"f8668d1fc9f7e8f148a7a3c29620e2a6bf3b6cff","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("},{"line_number":30,"context_line":"        attributes.NETWORKS, [\u0027_extend_network_dict_network_adjacency\u0027])"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_l2_adjacency(cls, network):"},{"line_number":33,"context_line":"        return not(\u0027provider:segmentation_id\u0027 in network)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_f774c236","line":33,"range":{"start_line":32,"start_character":8,"end_line":33,"end_character":57},"in_reply_to":"1aa78d24_583ffed5","updated":"2016-07-06 17:26:13.000000000","message":"I think it\u0027s wrong for l2-adjacency to be a derived property.  After reviewing the comments on this change, it\u0027s clear that other people think this is correct - but that doesn\u0027t make sense to me, for two reasons.\n\n1. If it has always been possible for l2-adjacency to be derived from other objects/properties in the data model, there was arguably never a need for l2-adjacency to exist at all.\n\n2. The networking-calico mechanism driver would like to be able to indicate l2-adjacency False for its networks, regardless of other properties.\n\nMy understanding during review of the routed networks spec was that (2) would be possible, and more generally that l2-adjacency needs to be an independent driver-controllable property - but there appears to be no mechanism for that in the currently proposed implementation.\n\nAm I missing or misunderstanding something?","commit_id":"56ddb5bd693501319689b6067cc1da8cffc63a47"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a73de8b99c9468f45592633cafd0dc96db75935b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("},{"line_number":30,"context_line":"        attributes.NETWORKS, [\u0027_extend_network_dict_network_adjacency\u0027])"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_l2_adjacency(cls, network):"},{"line_number":33,"context_line":"        return not(\u0027provider:segmentation_id\u0027 in network)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_4bc23854","line":33,"range":{"start_line":32,"start_character":8,"end_line":33,"end_character":57},"in_reply_to":"1aa78d24_f397a845","updated":"2016-07-12 22:10:26.000000000","message":"http://eavesdrop.openstack.org/meetings/neutron_routed_networks/2016/neutron_routed_networks.2016-07-12-14.03.log.html#l-102","commit_id":"56ddb5bd693501319689b6067cc1da8cffc63a47"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"38156e59b03d7999a965cd61423ecbc36bf44909","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("},{"line_number":30,"context_line":"        attributes.NETWORKS, [\u0027_extend_network_dict_network_adjacency\u0027])"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def get_l2_adjacency(cls, network):"},{"line_number":33,"context_line":"        return not(\u0027provider:segmentation_id\u0027 in network)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1aa78d24_09719844","line":33,"range":{"start_line":32,"start_character":8,"end_line":33,"end_character":57},"in_reply_to":"1aa78d24_f774c236","updated":"2016-07-11 23:47:42.000000000","message":"Neil.  That is the idea.  We might have to think about this.  I was thinking that in the context of the segments service plugin, we could derive this.  I was also thinking that this service plugin wouldn\u0027t be loaded when Calico is used.  That\u0027s what I was thinking that Calico was a monolithic plugin and could implement the extension on its own.\n\nBut, now I\u0027m realizing that Calico is an ML2 plugin.  Are there situations where the segments service plugin could exist in the same deployment as Calico?  If so, we might have to think about this a little bit more.","commit_id":"56ddb5bd693501319689b6067cc1da8cffc63a47"}],"neutron/services/segments/plugin.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2b06b759ac038cd658427ca1b0897037fda37864","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    if not manager.NeutronManager.get_service_plugins().get(\u0027segments\u0027):"},{"line_number":31,"context_line":"        return"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    is_adjacent \u003d True"},{"line_number":34,"context_line":"    for subnet in network_db.subnets:"},{"line_number":35,"context_line":"        if subnet.segment_id:"},{"line_number":36,"context_line":"            is_adjacent \u003d False"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    network_res[l2_adjacency.L2_ADJACENCY] \u003d is_adjacent"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def _extend_subnet_dict_binding(plugin, subnet_res, subnet_db):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_2aaf142b","line":38,"range":{"start_line":33,"start_character":0,"end_line":38,"end_character":56},"updated":"2016-08-01 00:40:19.000000000","message":"Given that:\n\n1) All of the subnets on a network must either all be associated with segments or all not associated with any segment\n\n2) The segment_id attribute of a subnet cannot be updated (https://github.com/openstack/neutron/blob/master/neutron/extensions/segment.py#L71)\n\nWhy not just do the following instead of iterating over all the subnets:\n\n    if network_db.subnets and network_db.subnets[0].segment_id:\n        network_res[l2_adjacency.L2_ADJACENCY] \u003d False\n    else:\n        network_res[l2_adjacency.L2_ADJACENCY] \u003d True\n\nThe unit tests pass with the change I propose","commit_id":"d86abec8ec65bb373b4caa1d828da8ba0407ef99"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"43d13a30ad21b00797e3b1ac802cdf11e99e8a10","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    if not manager.NeutronManager.get_service_plugins().get(\u0027segments\u0027):"},{"line_number":31,"context_line":"        return"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    is_adjacent \u003d True"},{"line_number":34,"context_line":"    for subnet in network_db.subnets:"},{"line_number":35,"context_line":"        if subnet.segment_id:"},{"line_number":36,"context_line":"            is_adjacent \u003d False"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    network_res[l2_adjacency.L2_ADJACENCY] \u003d is_adjacent"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def _extend_subnet_dict_binding(plugin, subnet_res, subnet_db):"}],"source_content_type":"text/x-python","patch_set":15,"id":"bacf61ea_15aa0c19","line":38,"range":{"start_line":33,"start_character":0,"end_line":38,"end_character":56},"in_reply_to":"bacf61ea_2aaf142b","updated":"2016-08-01 15:48:17.000000000","message":"#1 will be relaxed a little bit under certain conditions when service subnets are implemented. But, that is true either way. So, I\u0027m fine with this simplification. You might even simplify a little bit further like this:\n\n  is_adj \u003d not network_db.subnets or not network_db.subnets[0].segment_id:\n  network_res[l2_adjacency.L2_ADJACENCY] \u003d is_adj","commit_id":"d86abec8ec65bb373b4caa1d828da8ba0407ef99"}],"releasenotes/notes/l2_adjacency-e6e54e5ff9aad9b7.yaml":[{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"6a1541f1f7e01a0abd985e15cb86702291c4b0aa","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    L2 adjacency feature is added with segments for supporting"},{"line_number":5,"context_line":"    routed networks."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3aaa91ec_774c779e","line":5,"updated":"2016-06-23 17:34:24.000000000","message":"For my interest (networking-calico) it is an important detail of the routed networks spec that the new l2-adjacency field can be used independently of whether any segments are being defined or used.  Therefore (1) I hope that this is still the case, in the implementation, and (2) I think it would be better for the feature to be described in terms that do not imply a strong dependency on segments.\n\nMy description of this feature would be: \"A Neutron driver or plugin can now use the l2_adjacency field, on each Network that it provides, to indicate whether or not there is guaranteed L2 adjacency between the ports on that Network.  Routed network implementations would typically set l2_adjacency to False.\"","commit_id":"101c58576d856b38306208693503a36465a3625f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"af6c28fe7c0459cd09756800ad296f34daa1958e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    L2 adjacency feature is added with segments for supporting"},{"line_number":5,"context_line":"    routed networks."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3aaa91ec_695c3e4b","line":5,"in_reply_to":"3aaa91ec_774c779e","updated":"2016-06-27 04:59:38.000000000","message":"I agree with the description , mostly.\nI was confused with the first paragraph of your comments, though.\nThe second is more or less what I also aim to do in this patch","commit_id":"101c58576d856b38306208693503a36465a3625f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ae4a32640a2c06b95ceedf9c8d2a02b9f4093c58","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A Neutron driver or plugin can now use the l2_adjacency field, on each Network that"},{"line_number":5,"context_line":"    it provides, to indicate whether or not there is guaranteed L2 adjacency between"},{"line_number":6,"context_line":"    the ports on that Network.  Routed network implementations would typically set"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3aaa91ec_ed7677a2","line":3,"updated":"2016-06-27 06:46:19.000000000","message":"nit: I think there is no need to add a new line here.","commit_id":"66e7ef06fb9d6c5a35fb859d6f7dd942e329a4a3"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"86abddfa27973ddb3ddf633c5b9eeb96fbdd5aac","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A Neutron driver or plugin can now use the l2_adjacency field, on each Network that"},{"line_number":5,"context_line":"    it provides, to indicate whether or not there is guaranteed L2 adjacency between"},{"line_number":6,"context_line":"    the ports on that Network.  Routed network implementations would typically set"},{"line_number":7,"context_line":"    l2_adjacency to False."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3aaa91ec_219d38bc","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":87},"updated":"2016-07-01 01:44:18.000000000","message":"I don\u0027t know if we have any rules about length of lines, but could you rewrite it to just 80 chars?","commit_id":"f7a3073ef04687d241304d38b008f3ff675a590e"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"86abddfa27973ddb3ddf633c5b9eeb96fbdd5aac","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    A Neutron driver or plugin can now use the l2_adjacency field, on each Network that"},{"line_number":5,"context_line":"    it provides, to indicate whether or not there is guaranteed L2 adjacency between"},{"line_number":6,"context_line":"    the ports on that Network.  Routed network implementations would typically set"},{"line_number":7,"context_line":"    l2_adjacency to False."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"3aaa91ec_416fa4c3","line":6,"range":{"start_line":6,"start_character":30,"end_line":6,"end_character":32},"updated":"2016-07-01 01:44:18.000000000","message":"extra whitespace","commit_id":"f7a3073ef04687d241304d38b008f3ff675a590e"}]}
