)]}'
{"neutron/tests/unit/agent/linux/test_dhcp.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"82c6a31de3f40b86dba541d8f3d341b47921ebb1","unresolved":false,"context_lines":[{"line_number":538,"context_line":"    # Use instance rather than class attributes here, so that we get"},{"line_number":539,"context_line":"    # an independent set of ports each time FakeDualNetworkReserved"},{"line_number":540,"context_line":"    # is used."},{"line_number":541,"context_line":"    id \u003d \u0027cccccccc-cccc-cccc-cccc-cccccccccccc\u0027"},{"line_number":542,"context_line":"    subnets \u003d [FakeV4Subnet(), FakeV6SubnetDHCPStateful()]"},{"line_number":543,"context_line":"    namespace \u003d \u0027qdhcp-ns\u0027"},{"line_number":544,"context_line":""},{"line_number":545,"context_line":"    def __init__(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_90be5763","line":542,"range":{"start_line":541,"start_character":0,"end_line":542,"end_character":58},"updated":"2016-04-14 12:27:58.000000000","message":"The same fate could happen to these attributes in the future when someone changes code in a derived class so that one of these ends up being mocked. IMO it is better to make all the FakeX classes use instance variables. That should be done in a separate patch before this one.","commit_id":"2ef611273a1bf7a8fc1b117df27d0c76ef42bb56"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"63ae2c74fad3bec55b0748d55c248995448b66d7","unresolved":false,"context_lines":[{"line_number":540,"context_line":"    # is used."},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    def __init__(self):"},{"line_number":543,"context_line":"        self.id \u003d \u0027cccccccc-cccc-cccc-cccc-cccccccccccc\u0027"},{"line_number":544,"context_line":"        self.subnets \u003d [FakeV4Subnet(), FakeV6SubnetDHCPStateful()]"},{"line_number":545,"context_line":"        self.ports \u003d [FakePort1(), FakeV6Port(), FakeDualPort(),"},{"line_number":546,"context_line":"                      FakeRouterPort(), FakeReservedPort()]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_8aa712bc","line":543,"updated":"2016-04-15 06:56:14.000000000","message":"IMO, this change is un-related and needs to be submitted as a separate patch as suggested by Herny in PS1.","commit_id":"9b9f9b5a079e6998c5c06d1b25587ad4e6e40359"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"7d076a9f27bb08c199f460d21a276b7df532c57d","unresolved":false,"context_lines":[{"line_number":2130,"context_line":"            plugin.update_dhcp_port.assert_called_with(reserved_port.id,"},{"line_number":2131,"context_line":"                                                       mock.ANY)"},{"line_number":2132,"context_line":""},{"line_number":2133,"context_line":"            except_ips \u003d [\u0027192.168.0.6/24\u0027]"},{"line_number":2134,"context_line":"            if enable_isolated_metadata or force_metadata:"},{"line_number":2135,"context_line":"                except_ips.append(dhcp.METADATA_DEFAULT_CIDR)"},{"line_number":2136,"context_line":"            mgr.driver.init_l3.assert_called_with(\u0027ns-XXX\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_7553053a","line":2133,"updated":"2016-05-25 10:09:49.000000000","message":"why except_ips? reserved_port_cidr would be more clear","commit_id":"dfacba0f2d7586df51962c2b927e5272358ea3c1"}]}