)]}'
{"neutron/db/agentschedulers_db.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f6d38621c6eb231ecb62a7eebad3cf27c71dd366","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        # update_port passing and another failing"},{"line_number":394,"context_line":"        for port in ports:"},{"line_number":395,"context_line":"            port[\u0027device_id\u0027] \u003d constants.DEVICE_ID_RESERVED_DHCP_PORT"},{"line_number":396,"context_line":"            self.update_port(context, port[\u0027id\u0027], dict(port\u003dport))"},{"line_number":397,"context_line":"        with context.session.begin():"},{"line_number":398,"context_line":"            context.session.delete(binding)"},{"line_number":399,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_63c9eeab","line":396,"range":{"start_line":396,"start_character":17,"end_line":396,"end_character":28},"updated":"2016-04-20 22:24:17.000000000","message":"This is the important part of this change.  Shouldn\u0027t we test somehow that this isn\u0027t run under a transaction?","commit_id":"a2ceec28647d835aaa5228578537230ff571cee3"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"867f1da165e283ed75b2660ce16b9fe20202c661","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        # update_port passing and another failing"},{"line_number":394,"context_line":"        for port in ports:"},{"line_number":395,"context_line":"            port[\u0027device_id\u0027] \u003d constants.DEVICE_ID_RESERVED_DHCP_PORT"},{"line_number":396,"context_line":"            self.update_port(context, port[\u0027id\u0027], dict(port\u003dport))"},{"line_number":397,"context_line":"        with context.session.begin():"},{"line_number":398,"context_line":"            context.session.delete(binding)"},{"line_number":399,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_e1eb2c11","line":396,"updated":"2016-04-21 06:18:37.000000000","message":"Yeah, the one at the end of this chain will prevent all calls inside of a transaction","commit_id":"a2ceec28647d835aaa5228578537230ff571cee3"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2931ed97d37bf711318634f30a39e4c152db8dfe","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        # update_port passing and another failing"},{"line_number":394,"context_line":"        for port in ports:"},{"line_number":395,"context_line":"            port[\u0027device_id\u0027] \u003d constants.DEVICE_ID_RESERVED_DHCP_PORT"},{"line_number":396,"context_line":"            self.update_port(context, port[\u0027id\u0027], dict(port\u003dport))"},{"line_number":397,"context_line":"        with context.session.begin():"},{"line_number":398,"context_line":"            context.session.delete(binding)"},{"line_number":399,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_3ea1c946","line":396,"range":{"start_line":396,"start_character":17,"end_line":396,"end_character":28},"in_reply_to":"1a122d0e_63c9eeab","updated":"2016-04-20 23:08:13.000000000","message":"I guess this is what the last patch in the chain is doing: https://review.openstack.org/#/c/275110","commit_id":"a2ceec28647d835aaa5228578537230ff571cee3"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"5f173b45d9997b040fccf1357e5ab941a1006b10","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        # update_port passing and another failing"},{"line_number":394,"context_line":"        for port in ports:"},{"line_number":395,"context_line":"            port[\u0027device_id\u0027] \u003d constants.DEVICE_ID_RESERVED_DHCP_PORT"},{"line_number":396,"context_line":"            self.update_port(context, port[\u0027id\u0027], dict(port\u003dport))"},{"line_number":397,"context_line":"        with context.session.begin():"},{"line_number":398,"context_line":"            context.session.delete(binding)"},{"line_number":399,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_9d81c7fe","line":396,"in_reply_to":"1a122d0e_e1eb2c11","updated":"2016-04-22 00:06:48.000000000","message":"Fair enough.","commit_id":"a2ceec28647d835aaa5228578537230ff571cee3"}]}
