)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"44bb65344a524da9577de3eef57ab2e514b25a74","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor test_ipam functional testing module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use existing testing ifrastructure to better integrate with the rest of"},{"line_number":10,"context_line":"Neutron tests. This change allows test_ipam module to work with future"},{"line_number":11,"context_line":"db engine facade changes."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_50252fc0","line":9,"updated":"2016-05-25 13:20:02.000000000","message":"nit: infrastructure","commit_id":"71ccd79103fe005b83126282ab6d6778afa26fd3"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"f16dad004fe8aff596c8d63036e567b1453a3054","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor test_ipam functional testing module"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use existing testing ifrastructure to better integrate with the rest of"},{"line_number":10,"context_line":"Neutron tests. This change allows test_ipam module to work with future"},{"line_number":11,"context_line":"db engine facade changes."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bab6814e_04e35f34","line":9,"in_reply_to":"bab6814e_50252fc0","updated":"2016-05-25 13:35:19.000000000","message":"Done","commit_id":"71ccd79103fe005b83126282ab6d6778afa26fd3"}],"neutron/tests/functional/db/test_ipam.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"44bb65344a524da9577de3eef57ab2e514b25a74","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        super(IpamTestCase, self).setUp()"},{"line_number":39,"context_line":"        cfg.CONF.set_override(\u0027notify_nova_on_port_status_changes\u0027, False)"},{"line_number":40,"context_line":"        self.useFixture(testlib_api.SqlFixture())"},{"line_number":41,"context_line":"        if self.use_pluggable_ipam:"},{"line_number":42,"context_line":"            self._turn_on_pluggable_ipam()"},{"line_number":43,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_419ef9b8","line":40,"updated":"2016-05-25 13:20:02.000000000","message":"With this line the tests are running again sqlite, right? we already have unit tests that use that, functional tests were supposed to use something closer to a production environment. Why did you change this?","commit_id":"71ccd79103fe005b83126282ab6d6778afa26fd3"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"f16dad004fe8aff596c8d63036e567b1453a3054","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        super(IpamTestCase, self).setUp()"},{"line_number":39,"context_line":"        cfg.CONF.set_override(\u0027notify_nova_on_port_status_changes\u0027, False)"},{"line_number":40,"context_line":"        self.useFixture(testlib_api.SqlFixture())"},{"line_number":41,"context_line":"        if self.use_pluggable_ipam:"},{"line_number":42,"context_line":"            self._turn_on_pluggable_ipam()"},{"line_number":43,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_61797dfc","line":40,"in_reply_to":"bab6814e_419ef9b8","updated":"2016-05-25 13:35:19.000000000","message":"Test do not run against sqlite after this change, this means that used SQLFixture that provides creation of tables and its cleanup https://github.com/openstack/neutron/blob/master/neutron/tests/unit/testlib_api.py#L60-L78. Backend for running tests is set with common_base.MySQLTestCase/common_base.PostgreSQLTestCase below.","commit_id":"71ccd79103fe005b83126282ab6d6778afa26fd3"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"0e74d9ae936b208515c0472cceaab45845036d7e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        super(IpamTestCase, self).setUp()"},{"line_number":39,"context_line":"        cfg.CONF.set_override(\u0027notify_nova_on_port_status_changes\u0027, False)"},{"line_number":40,"context_line":"        self.useFixture(testlib_api.SqlFixture())"},{"line_number":41,"context_line":"        if self.use_pluggable_ipam:"},{"line_number":42,"context_line":"            self._turn_on_pluggable_ipam()"},{"line_number":43,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_0f67cce9","line":40,"in_reply_to":"bab6814e_61797dfc","updated":"2016-05-26 09:32:20.000000000","message":"got it, thanks!","commit_id":"71ccd79103fe005b83126282ab6d6778afa26fd3"}]}
