)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b4c93cd555e470586af3a172214471ae6bb7d0b7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"existing agent host, in this particular use case, when the agent"},{"line_number":23,"context_line":"restarts, the self.snat_namespace is always set to \u0027None\u0027 in the"},{"line_number":24,"context_line":"dvr_edge_router init call."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I30524dc77b743429ef70941479c9b6cccb21c23c"},{"line_number":27,"context_line":"Closes-Bug: #1557909"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a1531f4_b78e8225","line":25,"updated":"2016-04-15 08:56:34.000000000","message":"Please add what this patch actually does to fix the issue","commit_id":"28cb158df9c76e273703b6e296170966af196be4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3054c769ba3595ad111a3d685eebb530200ef9ce","unresolved":false,"context_lines":[{"line_number":22,"context_line":"existing agent host, in this particular use case, when the agent"},{"line_number":23,"context_line":"restarts, the self.snat_namespace is always set to \u0027None\u0027 in the"},{"line_number":24,"context_line":"dvr_edge_router init call."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I30524dc77b743429ef70941479c9b6cccb21c23c"},{"line_number":27,"context_line":"Closes-Bug: #1557909"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_2ab75087","line":25,"in_reply_to":"1a122d0e_4fc61e4a","updated":"2016-04-18 17:11:53.000000000","message":"+1.  Most of this description would be more appropriate for the bug report.  IMO, bug reports describe and discuss what is wrong with the code and commit messages describe the change, maybe with a short blurb describing how it fixes the bug if it isn\u0027t already obvious.  I don\u0027t think commit messages need to repeat was is in the bug report.\n\nMy $0.02.","commit_id":"28cb158df9c76e273703b6e296170966af196be4"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"a197eb981d2fecfe6b60e86e7c3885d7b0c0c1d7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"existing agent host, in this particular use case, when the agent"},{"line_number":23,"context_line":"restarts, the self.snat_namespace is always set to \u0027None\u0027 in the"},{"line_number":24,"context_line":"dvr_edge_router init call."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I30524dc77b743429ef70941479c9b6cccb21c23c"},{"line_number":27,"context_line":"Closes-Bug: #1557909"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_4fc61e4a","line":25,"in_reply_to":"3a1531f4_b78e8225","updated":"2016-04-18 16:28:32.000000000","message":"Will add a line to address your comments.","commit_id":"28cb158df9c76e273703b6e296170966af196be4"}],"neutron/agent/l3/dvr_edge_router.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b4c93cd555e470586af3a172214471ae6bb7d0b7","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, agent, host, *args, **kwargs):"},{"line_number":31,"context_line":"        super(DvrEdgeRouter, self).__init__(agent, host, *args, **kwargs)"},{"line_number":32,"context_line":"        self.snat_namespace \u003d None"},{"line_number":33,"context_line":"        # NOTE: Initialize the snat_namespace object here."},{"line_number":34,"context_line":"        # It can be created later, just to align with the"},{"line_number":35,"context_line":"        # parent init."}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1531f4_f798fa6c","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":34},"updated":"2016-04-15 08:56:34.000000000","message":"not needed","commit_id":"28cb158df9c76e273703b6e296170966af196be4"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"b2a4e3cede929db2131b98368d41661b7c59e0a4","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def __init__(self, agent, host, *args, **kwargs):"},{"line_number":31,"context_line":"        super(DvrEdgeRouter, self).__init__(agent, host, *args, **kwargs)"},{"line_number":32,"context_line":"        self.snat_namespace \u003d None"},{"line_number":33,"context_line":"        # NOTE: Initialize the snat_namespace object here."},{"line_number":34,"context_line":"        # It can be created later, just to align with the"},{"line_number":35,"context_line":"        # parent init."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_2f9ac263","line":32,"range":{"start_line":32,"start_character":8,"end_line":32,"end_character":34},"in_reply_to":"3a1531f4_f798fa6c","updated":"2016-04-18 16:27:27.000000000","message":"Will fix it.","commit_id":"28cb158df9c76e273703b6e296170966af196be4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3a68ec3ef76523662fda07f1c738b50e37027d8d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # NOTE: Initialize the snat_namespace object here."},{"line_number":34,"context_line":"        # It can be created later, just to align with the"},{"line_number":35,"context_line":"        # parent init."},{"line_number":36,"context_line":"        self.snat_namespace \u003d dvr_snat_ns.SnatNamespace("},{"line_number":37,"context_line":"            self.router_id, self.agent_conf,"},{"line_number":38,"context_line":"            self.driver, self.use_ipv6)"},{"line_number":39,"context_line":"        self.snat_iptables_manager \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a1531f4_9716e6a5","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":55},"updated":"2016-04-15 08:58:57.000000000","message":"won\u0027t it always create snat_namespace before checking if the agent should host snat for the router? At least it looks so which is not good imo","commit_id":"28cb158df9c76e273703b6e296170966af196be4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4844b1ecda4a83352ce257441a69c98c0db5bf56","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # NOTE: Initialize the snat_namespace object here."},{"line_number":34,"context_line":"        # It can be created later, just to align with the"},{"line_number":35,"context_line":"        # parent init."},{"line_number":36,"context_line":"        self.snat_namespace \u003d dvr_snat_ns.SnatNamespace("},{"line_number":37,"context_line":"            self.router_id, self.agent_conf,"},{"line_number":38,"context_line":"            self.driver, self.use_ipv6)"},{"line_number":39,"context_line":"        self.snat_iptables_manager \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_8e030f0d","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":55},"in_reply_to":"1a122d0e_25cb03a7","updated":"2016-04-18 20:25:27.000000000","message":"I see. My concern is that we\u0027re creating something that we might not need actually. Can we create the object when we see stale snat namespace just in order to properly clean it? Not insisting, just want to know what you think.","commit_id":"28cb158df9c76e273703b6e296170966af196be4"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"50c824e956293b918bddfc3d02d9e282753886b4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # NOTE: Initialize the snat_namespace object here."},{"line_number":34,"context_line":"        # It can be created later, just to align with the"},{"line_number":35,"context_line":"        # parent init."},{"line_number":36,"context_line":"        self.snat_namespace \u003d dvr_snat_ns.SnatNamespace("},{"line_number":37,"context_line":"            self.router_id, self.agent_conf,"},{"line_number":38,"context_line":"            self.driver, self.use_ipv6)"},{"line_number":39,"context_line":"        self.snat_iptables_manager \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_aae6c0b1","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":55},"in_reply_to":"1a122d0e_8f54b621","updated":"2016-04-18 16:55:26.000000000","message":"Just for your information. this is not creating the actual namespace but just initializing the snat namespace object.\nSo this should not affect anything in the current logic.","commit_id":"28cb158df9c76e273703b6e296170966af196be4"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"27f8424e1ad906956da840c4b7be69f6cc6e2311","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # NOTE: Initialize the snat_namespace object here."},{"line_number":34,"context_line":"        # It can be created later, just to align with the"},{"line_number":35,"context_line":"        # parent init."},{"line_number":36,"context_line":"        self.snat_namespace \u003d dvr_snat_ns.SnatNamespace("},{"line_number":37,"context_line":"            self.router_id, self.agent_conf,"},{"line_number":38,"context_line":"            self.driver, self.use_ipv6)"},{"line_number":39,"context_line":"        self.snat_iptables_manager \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_aafd203c","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":55},"in_reply_to":"1a122d0e_aae6c0b1","updated":"2016-04-18 16:56:24.000000000","message":"Also this is how the router namespace object is also initialized.","commit_id":"28cb158df9c76e273703b6e296170966af196be4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3054c769ba3595ad111a3d685eebb530200ef9ce","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # NOTE: Initialize the snat_namespace object here."},{"line_number":34,"context_line":"        # It can be created later, just to align with the"},{"line_number":35,"context_line":"        # parent init."},{"line_number":36,"context_line":"        self.snat_namespace \u003d dvr_snat_ns.SnatNamespace("},{"line_number":37,"context_line":"            self.router_id, self.agent_conf,"},{"line_number":38,"context_line":"            self.driver, self.use_ipv6)"},{"line_number":39,"context_line":"        self.snat_iptables_manager \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_45f55fc9","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":55},"in_reply_to":"1a122d0e_aafd203c","updated":"2016-04-18 17:11:53.000000000","message":"One has to call \"create\" on this object to actually create the namespace.  This is called in _create_snat_namespace through _create_dvr_gateway and finally through external_gateway_added where _is_this_snat_host is checked.  So, I don\u0027t think any namespace will be created.  But, the object may be needed to successfully delete the namespace.","commit_id":"28cb158df9c76e273703b6e296170966af196be4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"df82f9d308e1c04d53e25aa55f64aaa4e87a2faf","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # NOTE: Initialize the snat_namespace object here."},{"line_number":34,"context_line":"        # It can be created later, just to align with the"},{"line_number":35,"context_line":"        # parent init."},{"line_number":36,"context_line":"        self.snat_namespace \u003d dvr_snat_ns.SnatNamespace("},{"line_number":37,"context_line":"            self.router_id, self.agent_conf,"},{"line_number":38,"context_line":"            self.driver, self.use_ipv6)"},{"line_number":39,"context_line":"        self.snat_iptables_manager \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_c585ef59","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":55},"in_reply_to":"1a122d0e_aafd203c","updated":"2016-04-18 17:05:30.000000000","message":"yeah, but it\u0027s not clear that no namespace is actually created (it can be created in future btw) so my concern is that agent creates snat namespace before it knows it should host snat. router namespace is needed anyway if notification is received. The most straightforward way to fix the bug is to check for the snat namespace in the system and clear it in case gw_port_host does not match agent\u0027s host. Why can\u0027t we do this?","commit_id":"28cb158df9c76e273703b6e296170966af196be4"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"dfc331bfae8653f585db7c1c918dc78d51a3af99","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # NOTE: Initialize the snat_namespace object here."},{"line_number":34,"context_line":"        # It can be created later, just to align with the"},{"line_number":35,"context_line":"        # parent init."},{"line_number":36,"context_line":"        self.snat_namespace \u003d dvr_snat_ns.SnatNamespace("},{"line_number":37,"context_line":"            self.router_id, self.agent_conf,"},{"line_number":38,"context_line":"            self.driver, self.use_ipv6)"},{"line_number":39,"context_line":"        self.snat_iptables_manager \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_25cb03a7","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":55},"in_reply_to":"1a122d0e_c585ef59","updated":"2016-04-18 17:08:50.000000000","message":"Oleg, it is not just clearing up the namespace in the system, it also does clean up some iptable rules in the router namespace, so this would be cleanest way to do it.","commit_id":"28cb158df9c76e273703b6e296170966af196be4"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ab0bc87c31a89b7846910fe00e44a5ad712a054b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # NOTE: Initialize the snat_namespace object here."},{"line_number":34,"context_line":"        # It can be created later, just to align with the"},{"line_number":35,"context_line":"        # parent init."},{"line_number":36,"context_line":"        self.snat_namespace \u003d dvr_snat_ns.SnatNamespace("},{"line_number":37,"context_line":"            self.router_id, self.agent_conf,"},{"line_number":38,"context_line":"            self.driver, self.use_ipv6)"},{"line_number":39,"context_line":"        self.snat_iptables_manager \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_8f54b621","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":55},"in_reply_to":"1a122d0e_ef88ca24","updated":"2016-04-18 16:35:25.000000000","message":"True, but what if we have more than one l3 dvr_snat agents? Seems they all will create snat namespace, even those not hosting snat for the router (that still got router_updated notification due to dvr service ports)","commit_id":"28cb158df9c76e273703b6e296170966af196be4"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"b2a4e3cede929db2131b98368d41661b7c59e0a4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        # NOTE: Initialize the snat_namespace object here."},{"line_number":34,"context_line":"        # It can be created later, just to align with the"},{"line_number":35,"context_line":"        # parent init."},{"line_number":36,"context_line":"        self.snat_namespace \u003d dvr_snat_ns.SnatNamespace("},{"line_number":37,"context_line":"            self.router_id, self.agent_conf,"},{"line_number":38,"context_line":"            self.driver, self.use_ipv6)"},{"line_number":39,"context_line":"        self.snat_iptables_manager \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_ef88ca24","line":36,"range":{"start_line":36,"start_character":8,"end_line":36,"end_character":55},"in_reply_to":"3a1531f4_9716e6a5","updated":"2016-04-18 16:27:27.000000000","message":"Hi Oleg,\nI think the DvrEdgeRouter will only be called when there is an agent that can host the dvr snat.\n\nSee the code below.\n\nhttps://github.com/openstack/neutron/blob/dd4f1253c951d78a5b497680dfb31317ba469a58/neutron/agent/l3/agent.py#L329","commit_id":"28cb158df9c76e273703b6e296170966af196be4"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e9229b5fdfdda899153e872df650ee56414f38a6","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def delete(self, agent):"},{"line_number":220,"context_line":"        super(DvrEdgeRouter, self).delete(agent)"},{"line_number":221,"context_line":"        if self.snat_namespace:"},{"line_number":222,"context_line":"            self.snat_namespace.delete()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def process_address_scope(self):"},{"line_number":225,"context_line":"        super(DvrEdgeRouter, self).process_address_scope()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_40c096e0","line":222,"range":{"start_line":221,"start_character":0,"end_line":222,"end_character":40},"updated":"2016-04-19 07:52:04.000000000","message":"If the dvr router is deleted before setting any gateway, the delete here will fail, because the snat namespace is never created.","commit_id":"21b882a2f9b6d7b884824ee628862c93b5f325ed"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"2553f1242ff225e3c7ce132b1bc0613c01a513a9","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def delete(self, agent):"},{"line_number":220,"context_line":"        super(DvrEdgeRouter, self).delete(agent)"},{"line_number":221,"context_line":"        if self.snat_namespace:"},{"line_number":222,"context_line":"            self.snat_namespace.delete()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def process_address_scope(self):"},{"line_number":225,"context_line":"        super(DvrEdgeRouter, self).process_address_scope()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_f6b99116","line":222,"range":{"start_line":221,"start_character":0,"end_line":222,"end_character":40},"in_reply_to":"1a122d0e_40c096e0","updated":"2016-04-19 15:09:08.000000000","message":"Hi Xiao, \nI have a different patch to address the delete and add cases for the snat namespace.\nhttps://review.openstack.org/#/c/300358/\n\nSince this issue is also seen in liberty we want to make sure that this patch is portable so I have not made this patch as a dependent patch to the one shown above.\n\nOnce that patch merges that can also be back ported.\n\nHope this helps.","commit_id":"21b882a2f9b6d7b884824ee628862c93b5f325ed"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"55c89c0c671ccd839e59aab87b195330ed275de1","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def delete(self, agent):"},{"line_number":220,"context_line":"        super(DvrEdgeRouter, self).delete(agent)"},{"line_number":221,"context_line":"        if self.snat_namespace:"},{"line_number":222,"context_line":"            self.snat_namespace.delete()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def process_address_scope(self):"},{"line_number":225,"context_line":"        super(DvrEdgeRouter, self).process_address_scope()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_a9f22e99","line":222,"range":{"start_line":221,"start_character":0,"end_line":222,"end_character":40},"in_reply_to":"1a122d0e_e2bdc103","updated":"2016-05-04 18:10:20.000000000","message":"Addressed review comments.","commit_id":"21b882a2f9b6d7b884824ee628862c93b5f325ed"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"6b4e6f0db032fad6d08c6ffe5dad57bbad62cb29","unresolved":false,"context_lines":[{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def delete(self, agent):"},{"line_number":220,"context_line":"        super(DvrEdgeRouter, self).delete(agent)"},{"line_number":221,"context_line":"        if self.snat_namespace:"},{"line_number":222,"context_line":"            self.snat_namespace.delete()"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def process_address_scope(self):"},{"line_number":225,"context_line":"        super(DvrEdgeRouter, self).process_address_scope()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_e2bdc103","line":222,"range":{"start_line":221,"start_character":0,"end_line":222,"end_character":40},"in_reply_to":"1a122d0e_f6b99116","updated":"2016-04-21 20:42:08.000000000","message":"Hi Xiao,\nI am not sure if you are still looking for more information on this. Please let me know.","commit_id":"21b882a2f9b6d7b884824ee628862c93b5f325ed"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"225cd2a53d1b4ee0c5a92b1a310f4b96f7f94f73","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        if not self._is_this_snat_host():"},{"line_number":53,"context_line":"            # no centralized SNAT gateway for this node/agent"},{"line_number":54,"context_line":"            LOG.debug(\"not hosting snat for router: %s\", self.router[\u0027id\u0027])"},{"line_number":55,"context_line":"            if self.snat_namespace:"},{"line_number":56,"context_line":"                LOG.debug(\"SNAT was rescheduled to host %s. Clearing snat \""},{"line_number":57,"context_line":"                          \"namespace.\", self.router.get(\u0027gw_port_host\u0027))"},{"line_number":58,"context_line":"                return self.external_gateway_removed("}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_849d7a0c","line":55,"range":{"start_line":55,"start_character":11,"end_line":55,"end_character":34},"updated":"2016-06-07 15:26:01.000000000","message":"this will always be true now..","commit_id":"9dc70ed77e055677a4bd3257a0e9e24239ed4cce"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"225cd2a53d1b4ee0c5a92b1a310f4b96f7f94f73","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                    ex_gw_port, interface_name)"},{"line_number":60,"context_line":"            return"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        if not self.snat_namespace:"},{"line_number":63,"context_line":"            # SNAT might be rescheduled to this agent; need to process like"},{"line_number":64,"context_line":"            # newly created gateway"},{"line_number":65,"context_line":"            return self.external_gateway_added(ex_gw_port, interface_name)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_c47942ca","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":35},"updated":"2016-06-07 15:26:01.000000000","message":"this will always be false hence breaking rescheduling, going to revert the patch. https://bugs.launchpad.net/neutron/+bug/1590041","commit_id":"9dc70ed77e055677a4bd3257a0e9e24239ed4cce"}],"neutron/tests/unit/agent/l3/test_agent.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3054c769ba3595ad111a3d685eebb530200ef9ce","unresolved":false,"context_lines":[{"line_number":609,"context_line":"    def test_external_gateway_updated_dual_stack(self):"},{"line_number":610,"context_line":"        self._test_external_gateway_updated(dual_stack\u003dTrue)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"    def test_dvr_edge_router_init_for_snat_namespace_object(self):"},{"line_number":613,"context_line":"        router \u003d l3_test_common.prepare_router_data(num_internal_ports\u003d2)"},{"line_number":614,"context_line":"        ri \u003d dvr_router.DvrEdgeRouter(mock.Mock(),"},{"line_number":615,"context_line":"                                      HOSTNAME,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_052407ad","line":612,"range":{"start_line":612,"start_character":8,"end_line":612,"end_character":59},"updated":"2016-04-18 17:11:53.000000000","message":"I expected a test that asserts the namespace cleanup gets called up under the conditions described.  This doesn\u0027t directly do that.  This asserts something that might be related but isn\u0027t actually what is important.  But, at least it is something.","commit_id":"28cb158df9c76e273703b6e296170966af196be4"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"f92d5a23b11c63b5d2fd58b062e9cd9188760830","unresolved":false,"context_lines":[{"line_number":609,"context_line":"    def test_external_gateway_updated_dual_stack(self):"},{"line_number":610,"context_line":"        self._test_external_gateway_updated(dual_stack\u003dTrue)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"    def test_dvr_edge_router_init_for_snat_namespace_object(self):"},{"line_number":613,"context_line":"        router \u003d l3_test_common.prepare_router_data(num_internal_ports\u003d2)"},{"line_number":614,"context_line":"        ri \u003d dvr_router.DvrEdgeRouter(mock.Mock(),"},{"line_number":615,"context_line":"                                      HOSTNAME,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_854ad7aa","line":612,"range":{"start_line":612,"start_character":8,"end_line":612,"end_character":59},"in_reply_to":"1a122d0e_052407ad","updated":"2016-04-18 17:20:10.000000000","message":"Sure will add a functional test to address this issue.","commit_id":"28cb158df9c76e273703b6e296170966af196be4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"78ce78029243177b957ba6741d7cd216fe64a579","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        # router is initialized"},{"line_number":621,"context_line":"        self.assertIsNotNone(ri.snat_namespace)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def test_ext_gw_updated_not_calling_external_gw_removed(self):"},{"line_number":624,"context_line":"        \"\"\"Function to check the impact of snat_namespace object."},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"        This function specifically checks the impact of the snat"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_d49d965a","line":623,"range":{"start_line":623,"start_character":8,"end_line":623,"end_character":59},"updated":"2016-04-18 21:43:05.000000000","message":"I don\u0027t see what this unit test has to do with the fix in this patch.  With this patch I expected a unit test that does roughly the following:\n\n  1) Mocks SnatNamespace delete method.\n  2) Instantiate a router.\n  3) Calls the external_gateway_updated with gw_port_host not matching.\n  4) Asserts that the delete() method is called on the snat_namespace.","commit_id":"f023db2493c661dee6a2f04e02d0e08cd7f716c8"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"92c58708048d9ad68ede0e21a5fc0e84973286c5","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        # router is initialized"},{"line_number":621,"context_line":"        self.assertIsNotNone(ri.snat_namespace)"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def test_ext_gw_updated_not_calling_external_gw_removed(self):"},{"line_number":624,"context_line":"        \"\"\"Function to check the impact of snat_namespace object."},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"        This function specifically checks the impact of the snat"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_28c10e2f","line":623,"range":{"start_line":623,"start_character":8,"end_line":623,"end_character":59},"in_reply_to":"1a122d0e_d49d965a","updated":"2016-04-18 22:10:31.000000000","message":"Sure I can add one.\nBut this patch particularly makes sure that the external_gateway_removed is called when gw_port_host mismatch occurs alongs with the self.snat_namespace existence.","commit_id":"f023db2493c661dee6a2f04e02d0e08cd7f716c8"}]}
