)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"a26d04f815350069d964b11e47dc096393c743c7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"adoption for other resources."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Sadly, those tests cannot pass on every neutron cloud, at least until we"},{"line_number":14,"context_line":"enable those API features by default and remove options to disable the,"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"There is no way to determine, via neutron API, whether cloud supports"},{"line_number":17,"context_line":"those features. To work around that, we introduce two new tempest"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1a122d0e_eaba78e0","line":14,"range":{"start_line":14,"start_character":67,"end_line":14,"end_character":71},"updated":"2016-04-18 16:49:27.000000000","message":"typo?","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9fc938eb0f508f5cc754490f39757547720aa55c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"adoption for other resources."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Sadly, those tests cannot pass on every neutron cloud, at least until we"},{"line_number":14,"context_line":"enable those API features by default and remove options to disable the,"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"There is no way to determine, via neutron API, whether cloud supports"},{"line_number":17,"context_line":"those features. To work around that, we introduce two new tempest"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"bab6814e_853a06cc","line":14,"range":{"start_line":14,"start_character":67,"end_line":14,"end_character":71},"in_reply_to":"1a122d0e_eaba78e0","updated":"2016-05-18 13:07:23.000000000","message":"Done","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"792d5553a8e9c38d685575aa070e72245375e84c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"adoption for other resources."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Sadly, those tests cannot pass on every neutron cloud, at least until we"},{"line_number":14,"context_line":"enable those API features by default and remove options to disable the,"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"There is no way to determine, via neutron API, whether cloud supports"},{"line_number":17,"context_line":"those features. To work around that, we introduce two new tempest"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"dab17558_b672cd7a","line":14,"range":{"start_line":14,"start_character":67,"end_line":14,"end_character":71},"in_reply_to":"1a122d0e_eaba78e0","updated":"2016-05-16 15:46:16.000000000","message":"It seems to be missing part of commit message.","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"}],"neutron/api/__init__.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"4daf84b2a4d9a79d70129a7e34583a2e036d546c","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Default values for advanced API features"},{"line_number":14,"context_line":"DEFAULT_ALLOW_SORTING \u003d False"},{"line_number":15,"context_line":"DEFAULT_ALLOW_PAGINATION \u003d False"}],"source_content_type":"text/x-python","patch_set":16,"id":"bab6814e_a0191424","line":15,"updated":"2016-05-23 16:12:36.000000000","message":"This is actually a nice place to put such values, IMO.","commit_id":"7d021b45a0e9d6143ffe44cd855f7c9a1be1ba33"}],"neutron/common/constants.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f7b9402ef32a6c919412194f2dac6fee9eb6f1ad","unresolved":false,"context_lines":[{"line_number":166,"context_line":"METADATA_CIDR \u003d \u0027169.254.169.254/32\u0027"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Default values for advanced API features"},{"line_number":169,"context_line":"DEFAULT_ALLOW_SORTING \u003d False"},{"line_number":170,"context_line":"DEFAULT_ALLOW_PAGINATION \u003d False"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Neutron-lib migration shim. This will wrap any constants that are moved"},{"line_number":173,"context_line":"# to that library in a deprecation warning, until they can be updated to"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_3af5c156","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":32},"updated":"2016-05-20 02:14:55.000000000","message":"Why do we need these? Why not just use False in place?","commit_id":"bb169ec1c484896b8fd3175ef5c0de703ef1c7b1"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"63a9a31f12a3ec02c7901295a8493db7c8a140e0","unresolved":false,"context_lines":[{"line_number":166,"context_line":"METADATA_CIDR \u003d \u0027169.254.169.254/32\u0027"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Default values for advanced API features"},{"line_number":169,"context_line":"DEFAULT_ALLOW_SORTING \u003d False"},{"line_number":170,"context_line":"DEFAULT_ALLOW_PAGINATION \u003d False"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Neutron-lib migration shim. This will wrap any constants that are moved"},{"line_number":173,"context_line":"# to that library in a deprecation warning, until they can be updated to"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_bf050712","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":32},"in_reply_to":"bab6814e_1e7a58bd","updated":"2016-05-20 13:40:27.000000000","message":"But that\u0027s not what a constant is, surely?","commit_id":"bb169ec1c484896b8fd3175ef5c0de703ef1c7b1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b9a9400f6ee36465afa8976f04f20bbd6f4eeacd","unresolved":false,"context_lines":[{"line_number":166,"context_line":"METADATA_CIDR \u003d \u0027169.254.169.254/32\u0027"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Default values for advanced API features"},{"line_number":169,"context_line":"DEFAULT_ALLOW_SORTING \u003d False"},{"line_number":170,"context_line":"DEFAULT_ALLOW_PAGINATION \u003d False"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Neutron-lib migration shim. This will wrap any constants that are moved"},{"line_number":173,"context_line":"# to that library in a deprecation warning, until they can be updated to"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_1e7a58bd","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":32},"in_reply_to":"bab6814e_3af5c156","updated":"2016-05-20 13:24:04.000000000","message":"That was requested by Assaf, so that we later can switch to True here and get True for both tempest plugin and the code.","commit_id":"bb169ec1c484896b8fd3175ef5c0de703ef1c7b1"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7d26c08f975938d88f647b8203ca28f15405fae9","unresolved":false,"context_lines":[{"line_number":166,"context_line":"METADATA_CIDR \u003d \u0027169.254.169.254/32\u0027"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Default values for advanced API features"},{"line_number":169,"context_line":"DEFAULT_ALLOW_SORTING \u003d False"},{"line_number":170,"context_line":"DEFAULT_ALLOW_PAGINATION \u003d False"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Neutron-lib migration shim. This will wrap any constants that are moved"},{"line_number":173,"context_line":"# to that library in a deprecation warning, until they can be updated to"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_83234cbc","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":32},"in_reply_to":"bab6814e_7fa55f45","updated":"2016-05-23 12:02:56.000000000","message":"I would like to eventually get rid of constants.py.\n\nIn the end, all really common constants will be in neutron-lib, more locally applicable constants will be in sub-directories, and things that are not strict constants will be elsewhere.\n\nSo that is why I am asking you to move these two values to another module.","commit_id":"bb169ec1c484896b8fd3175ef5c0de703ef1c7b1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9549ebcdac889d9068437131b54797279b9807ed","unresolved":false,"context_lines":[{"line_number":166,"context_line":"METADATA_CIDR \u003d \u0027169.254.169.254/32\u0027"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Default values for advanced API features"},{"line_number":169,"context_line":"DEFAULT_ALLOW_SORTING \u003d False"},{"line_number":170,"context_line":"DEFAULT_ALLOW_PAGINATION \u003d False"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Neutron-lib migration shim. This will wrap any constants that are moved"},{"line_number":173,"context_line":"# to that library in a deprecation warning, until they can be updated to"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_2e2ec7fa","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":32},"in_reply_to":"bab6814e_83234cbc","updated":"2016-05-23 12:16:27.000000000","message":"Done","commit_id":"bb169ec1c484896b8fd3175ef5c0de703ef1c7b1"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"64e3f608475c079389d6abaae4323905411893bb","unresolved":false,"context_lines":[{"line_number":166,"context_line":"METADATA_CIDR \u003d \u0027169.254.169.254/32\u0027"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Default values for advanced API features"},{"line_number":169,"context_line":"DEFAULT_ALLOW_SORTING \u003d False"},{"line_number":170,"context_line":"DEFAULT_ALLOW_PAGINATION \u003d False"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Neutron-lib migration shim. This will wrap any constants that are moved"},{"line_number":173,"context_line":"# to that library in a deprecation warning, until they can be updated to"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_7fa55f45","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":32},"in_reply_to":"bab6814e_bf050712","updated":"2016-05-20 13:53:28.000000000","message":"Can we put these in another module, perhaps neutron/api/api_common.py ? I don\u0027t want them to end up in neutron-lib constants.py.","commit_id":"bb169ec1c484896b8fd3175ef5c0de703ef1c7b1"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"92db929b8b72292157be18511baee885f1191c57","unresolved":false,"context_lines":[{"line_number":166,"context_line":"METADATA_CIDR \u003d \u0027169.254.169.254/32\u0027"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# Default values for advanced API features"},{"line_number":169,"context_line":"DEFAULT_ALLOW_SORTING \u003d False"},{"line_number":170,"context_line":"DEFAULT_ALLOW_PAGINATION \u003d False"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"# Neutron-lib migration shim. This will wrap any constants that are moved"},{"line_number":173,"context_line":"# to that library in a deprecation warning, until they can be updated to"}],"source_content_type":"text/x-python","patch_set":13,"id":"bab6814e_1f97f33a","line":170,"range":{"start_line":169,"start_character":0,"end_line":170,"end_character":32},"in_reply_to":"bab6814e_bf050712","updated":"2016-05-20 13:48:53.000000000","message":"I guess we overloaded meaning for the module from what was originally intended. Now it\u0027s both constants as well as \u0027values we currently use and share in multiple places in the code\u0027.","commit_id":"bb169ec1c484896b8fd3175ef5c0de703ef1c7b1"}],"neutron/tests/contrib/gate_hook.sh":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"398b8509c6eaaae97954406a66315234bed0b9f0","unresolved":false,"context_lines":[{"line_number":8,"context_line":"NEUTRON_PATH\u003d$GATE_DEST/neutron"},{"line_number":9,"context_line":"GATE_HOOKS\u003d$NEUTRON_PATH/neutron/tests/contrib/hooks"},{"line_number":10,"context_line":"DEVSTACK_PATH\u003d$GATE_DEST/devstack"},{"line_number":11,"context_line":"LOCAL_CONF\u003d$DEVSTACK_PATH/local.conf"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Inject config from hook into localrc"}],"source_content_type":"text/x-sh","patch_set":9,"id":"dab17558_85266966","line":11,"updated":"2016-05-06 23:23:35.000000000","message":"Given that devstack-vm-gate script[1] is using relative path, I\u0027m not sure if this is value is correct \n\n[1] https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate.sh#L607","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9fc938eb0f508f5cc754490f39757547720aa55c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"NEUTRON_PATH\u003d$GATE_DEST/neutron"},{"line_number":9,"context_line":"GATE_HOOKS\u003d$NEUTRON_PATH/neutron/tests/contrib/hooks"},{"line_number":10,"context_line":"DEVSTACK_PATH\u003d$GATE_DEST/devstack"},{"line_number":11,"context_line":"LOCAL_CONF\u003d$DEVSTACK_PATH/local.conf"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Inject config from hook into localrc"}],"source_content_type":"text/x-sh","patch_set":9,"id":"bab6814e_65ac42ee","line":11,"in_reply_to":"dab17558_85266966","updated":"2016-05-18 13:07:23.000000000","message":"Line numbers are probably not valid anymore. Please link to a stable commit so that we can understand what you point to.","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"398b8509c6eaaae97954406a66315234bed0b9f0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# Inject config from hook into local.conf"},{"line_number":26,"context_line":"function load_conf_hook {"},{"line_number":27,"context_line":"    local hook\u003d\"$1\""},{"line_number":28,"context_line":"    cat $GATE_HOOKS/$hook \u003e\u003e $LOCAL_CONF"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"dab17558_04db967d","line":28,"range":{"start_line":28,"start_character":29,"end_line":28,"end_character":40},"updated":"2016-05-06 23:23:35.000000000","message":"I couldn\u0027t find local.conf file in it\u0027s folder execution[1].  I just wondering if this has to follow the same approach than localrc file[2]\n\n\n[1] http://logs.openstack.org/72/306272/9/check/gate-neutron-dsvm-api/40e1a50/\n[2] https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate.sh#L525","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9fc938eb0f508f5cc754490f39757547720aa55c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"# Inject config from hook into local.conf"},{"line_number":26,"context_line":"function load_conf_hook {"},{"line_number":27,"context_line":"    local hook\u003d\"$1\""},{"line_number":28,"context_line":"    cat $GATE_HOOKS/$hook \u003e\u003e $LOCAL_CONF"},{"line_number":29,"context_line":"}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-sh","patch_set":9,"id":"bab6814e_45581efb","line":28,"range":{"start_line":28,"start_character":29,"end_line":28,"end_character":40},"in_reply_to":"dab17558_04db967d","updated":"2016-05-18 13:07:23.000000000","message":"Both files are used. See line 14+ for localrc part","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"}],"neutron/tests/contrib/hooks/pagination":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"5fe697f2420507405aeadcbba9bfd5abc86b1079","unresolved":false,"context_lines":[{"line_number":3,"context_line":"[neutron_plugin_options]"},{"line_number":4,"context_line":"validate_pagination \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[[post-config|$NEUTRON_CONF]]"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[DEFAULT]"},{"line_number":9,"context_line":"allow_pagination\u003dTrue"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"1a122d0e_c3db5d7c","line":6,"range":{"start_line":6,"start_character":15,"end_line":6,"end_character":27},"updated":"2016-05-02 23:46:24.000000000","message":"pecan hook uses the value of the variable[1]\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/tests/contrib/hooks/pecan#L1","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9fc938eb0f508f5cc754490f39757547720aa55c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"[neutron_plugin_options]"},{"line_number":4,"context_line":"validate_pagination \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[[post-config|$NEUTRON_CONF]]"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[DEFAULT]"},{"line_number":9,"context_line":"allow_pagination\u003dTrue"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"bab6814e_b3ee65ea","line":6,"range":{"start_line":6,"start_character":15,"end_line":6,"end_character":27},"in_reply_to":"1a122d0e_c3db5d7c","updated":"2016-05-18 13:07:23.000000000","message":"It does not matter. In logs dir, we can see that the change is applied to neutron.conf (but not to tempest.conf).","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"}],"neutron/tests/contrib/hooks/quotas":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"5fe697f2420507405aeadcbba9bfd5abc86b1079","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[post-config|$NEUTRON_CONF]]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[quotas]"},{"line_number":4,"context_line":"# x10 of default quotas (at the time of writing)"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"1a122d0e_83c845aa","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":27},"updated":"2016-05-02 23:46:24.000000000","message":"ditto","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9fc938eb0f508f5cc754490f39757547720aa55c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[post-config|$NEUTRON_CONF]]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[quotas]"},{"line_number":4,"context_line":"# x10 of default quotas (at the time of writing)"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"bab6814e_ce4b8258","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":27},"in_reply_to":"1a122d0e_83c845aa","updated":"2016-05-18 13:07:23.000000000","message":"It works as per logs dir, so should be fine.","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"}],"neutron/tests/contrib/hooks/sorting":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"5fe697f2420507405aeadcbba9bfd5abc86b1079","unresolved":false,"context_lines":[{"line_number":3,"context_line":"[neutron_plugin_options]"},{"line_number":4,"context_line":"validate_sorting \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[[post-config|$NEUTRON_CONF]]"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[DEFAULT]"},{"line_number":9,"context_line":"allow_sorting\u003dTrue"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"1a122d0e_03bd5502","line":6,"range":{"start_line":6,"start_character":15,"end_line":6,"end_character":27},"updated":"2016-05-02 23:46:24.000000000","message":"ditto","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9fc938eb0f508f5cc754490f39757547720aa55c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"[neutron_plugin_options]"},{"line_number":4,"context_line":"validate_sorting \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[[post-config|$NEUTRON_CONF]]"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"[DEFAULT]"},{"line_number":9,"context_line":"allow_sorting\u003dTrue"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"bab6814e_ae48be5c","line":6,"range":{"start_line":6,"start_character":15,"end_line":6,"end_character":27},"in_reply_to":"1a122d0e_03bd5502","updated":"2016-05-18 13:07:23.000000000","message":"It works.","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"}],"neutron/tests/tempest/api/base.py":[{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"a26d04f815350069d964b11e47dc096393c743c7","unresolved":false,"context_lines":[{"line_number":464,"context_line":""},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"def _require_sorting(f):"},{"line_number":467,"context_line":"    def inner(self, *args, **kwargs):"},{"line_number":468,"context_line":"        if not CONF.neutron_plugin_options.validate_sorting:"},{"line_number":469,"context_line":"            self.skipTest(\u0027Sorting feature is required\u0027)"},{"line_number":470,"context_line":"        return f(self, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_aaba4021","line":467,"range":{"start_line":467,"start_character":4,"end_line":467,"end_character":13},"updated":"2016-04-18 16:49:27.000000000","message":"maybe use functools.wraps?","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9fc938eb0f508f5cc754490f39757547720aa55c","unresolved":false,"context_lines":[{"line_number":464,"context_line":""},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"def _require_sorting(f):"},{"line_number":467,"context_line":"    def inner(self, *args, **kwargs):"},{"line_number":468,"context_line":"        if not CONF.neutron_plugin_options.validate_sorting:"},{"line_number":469,"context_line":"            self.skipTest(\u0027Sorting feature is required\u0027)"},{"line_number":470,"context_line":"        return f(self, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_0ee90a1b","line":467,"range":{"start_line":467,"start_character":4,"end_line":467,"end_character":13},"in_reply_to":"1a122d0e_aaba4021","updated":"2016-05-18 13:07:23.000000000","message":"Done","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"a26d04f815350069d964b11e47dc096393c743c7","unresolved":false,"context_lines":[{"line_number":472,"context_line":""},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"def _require_pagination(f):"},{"line_number":475,"context_line":"    def inner(self, *args, **kwargs):"},{"line_number":476,"context_line":"        if not CONF.neutron_plugin_options.validate_pagination:"},{"line_number":477,"context_line":"            self.skipTest(\u0027Pagination feature is required\u0027)"},{"line_number":478,"context_line":"        return f(self, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_6a978890","line":475,"range":{"start_line":475,"start_character":4,"end_line":475,"end_character":13},"updated":"2016-04-18 16:49:27.000000000","message":"ditto","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9fc938eb0f508f5cc754490f39757547720aa55c","unresolved":false,"context_lines":[{"line_number":472,"context_line":""},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"def _require_pagination(f):"},{"line_number":475,"context_line":"    def inner(self, *args, **kwargs):"},{"line_number":476,"context_line":"        if not CONF.neutron_plugin_options.validate_pagination:"},{"line_number":477,"context_line":"            self.skipTest(\u0027Pagination feature is required\u0027)"},{"line_number":478,"context_line":"        return f(self, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_eeeda626","line":475,"range":{"start_line":475,"start_character":4,"end_line":475,"end_character":13},"in_reply_to":"1a122d0e_6a978890","updated":"2016-05-18 13:07:23.000000000","message":"Done","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7b643fb5340d00419f988c0b2c0e9aa8d9c9a7d6","unresolved":false,"context_lines":[{"line_number":575,"context_line":"        # paginate resources one by one, using last fetched resource as a"},{"line_number":576,"context_line":"        # marker"},{"line_number":577,"context_line":"        resources \u003d []"},{"line_number":578,"context_line":"        for i in range(1, len(expected_resources) + 1):"},{"line_number":579,"context_line":"            pagination_args \u003d sort_args.copy()"},{"line_number":580,"context_line":"            pagination_args[\u0027limit\u0027] \u003d 1"},{"line_number":581,"context_line":"            if resources:"}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_0e3783ff","line":578,"range":{"start_line":578,"start_character":17,"end_line":578,"end_character":54},"updated":"2016-05-23 12:21:34.000000000","message":"Nit: range(len(expected_resources))","commit_id":"d203abcbc68d64d2d809e51d5d30e38201809394"}],"neutron/tests/tempest/api/test_networks.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6f9294b874ed280bd95cee3c8f1996a7f1775d49","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"},{"line_number":123,"context_line":"    @test.idempotent_id(\u002779a52810-2156-4ab6-b577-9e46e58d4b58\u0027)"},{"line_number":124,"context_line":"    def test_list_pagination_page_reverse(self):"},{"line_number":125,"context_line":"        self._test_list_pagination_page_reverse()"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @test.attr(type\u003d\u0027smoke\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_9e14aaa0","line":124,"updated":"2016-04-19 18:23:58.000000000","message":"Note: I expect this to fail. See https://review.openstack.org/#/c/303864/1/neutron_lib/db/utils.py@356","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"}],"neutron/tests/tempest/config.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"6e4c22c9e26758c5113875e0514e00889c5a8f11","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                help\u003d\u0027Allow passing an IP Address of the floating ip when \u0027"},{"line_number":25,"context_line":"                     \u0027creating the floating ip\u0027),"},{"line_number":26,"context_line":"    cfg.BoolOpt(\u0027validate_pagination\u0027,"},{"line_number":27,"context_line":"                default\u003dFalse,"},{"line_number":28,"context_line":"                help\u003d\u0027Validate pagination\u0027),"},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027validate_sorting\u0027,"},{"line_number":30,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_93253dc4","line":27,"updated":"2016-04-15 20:48:17.000000000","message":"The default value should probably be taken from the default value of the \u0027allow_pagination\u0027 option itself, that way when it\u0027s turned on downstreams (That, as opposed to the gate, will probably not set these values in tempest.conf explicitly) will automatically test it.","commit_id":"7eab7d56452b8583e0fd9a34d7d02e2abdac5e8c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d94f2a456288af062e6680dce7aab395e57a403f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                help\u003d\u0027Allow passing an IP Address of the floating ip when \u0027"},{"line_number":25,"context_line":"                     \u0027creating the floating ip\u0027),"},{"line_number":26,"context_line":"    cfg.BoolOpt(\u0027validate_pagination\u0027,"},{"line_number":27,"context_line":"                default\u003dFalse,"},{"line_number":28,"context_line":"                help\u003d\u0027Validate pagination\u0027),"},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027validate_sorting\u0027,"},{"line_number":30,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_175638d2","line":27,"in_reply_to":"1a122d0e_93253dc4","updated":"2016-04-15 20:59:27.000000000","message":"I think in this context, neutron options are not registered. So the only way to extract it is by importing some module that would contain a common constant with the default value that is then reused in both places (here and in the allow_* option). Not sure what it buys us then.","commit_id":"7eab7d56452b8583e0fd9a34d7d02e2abdac5e8c"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"398b8509c6eaaae97954406a66315234bed0b9f0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                default\u003dTrue,"},{"line_number":25,"context_line":"                help\u003d\u0027Allow passing an IP Address of the floating ip when \u0027"},{"line_number":26,"context_line":"                     \u0027creating the floating ip\u0027),"},{"line_number":27,"context_line":"    cfg.BoolOpt(\u0027validate_pagination\u0027,"},{"line_number":28,"context_line":"                default\u003dconstants.DEFAULT_ALLOW_PAGINATION,"},{"line_number":29,"context_line":"                help\u003d\u0027Validate pagination\u0027),"},{"line_number":30,"context_line":"    cfg.BoolOpt(\u0027validate_sorting\u0027,"},{"line_number":31,"context_line":"                default\u003dconstants.DEFAULT_ALLOW_SORTING,"},{"line_number":32,"context_line":"                help\u003d\u0027Validate sorting\u0027)]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"},{"line_number":35,"context_line":"# transition to the Tempest plugin architecture"}],"source_content_type":"text/x-python","patch_set":9,"id":"dab17558_247dfa1c","line":32,"range":{"start_line":27,"start_character":4,"end_line":32,"end_character":41},"updated":"2016-05-06 23:23:35.000000000","message":"Shouldn\u0027t these configurations be placed in tempest project also?\n\n[1] https://github.com/openstack/tempest/blob/master/tempest/config.py","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9fc938eb0f508f5cc754490f39757547720aa55c","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                default\u003dTrue,"},{"line_number":25,"context_line":"                help\u003d\u0027Allow passing an IP Address of the floating ip when \u0027"},{"line_number":26,"context_line":"                     \u0027creating the floating ip\u0027),"},{"line_number":27,"context_line":"    cfg.BoolOpt(\u0027validate_pagination\u0027,"},{"line_number":28,"context_line":"                default\u003dconstants.DEFAULT_ALLOW_PAGINATION,"},{"line_number":29,"context_line":"                help\u003d\u0027Validate pagination\u0027),"},{"line_number":30,"context_line":"    cfg.BoolOpt(\u0027validate_sorting\u0027,"},{"line_number":31,"context_line":"                default\u003dconstants.DEFAULT_ALLOW_SORTING,"},{"line_number":32,"context_line":"                help\u003d\u0027Validate sorting\u0027)]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# TODO(amuller): Redo configuration options registration as part of the planned"},{"line_number":35,"context_line":"# transition to the Tempest plugin architecture"}],"source_content_type":"text/x-python","patch_set":9,"id":"bab6814e_3346f523","line":32,"range":{"start_line":27,"start_character":4,"end_line":32,"end_character":41},"in_reply_to":"dab17558_247dfa1c","updated":"2016-05-18 13:07:23.000000000","message":"Why?","commit_id":"75d17f8ba17846510a77ae96faaaa094ee2c602f"}]}