)]}'
{"neutron/agent/linux/iptables_manager.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7ed3e2d3f789af72380fa53e496204da08a1ef7f","unresolved":false,"context_lines":[{"line_number":704,"context_line":"        acc \u003d {\u0027pkts\u0027: 0, \u0027bytes\u0027: 0}"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        for cmd, table in cmd_tables:"},{"line_number":707,"context_line":"            args \u003d [cmd, \u0027-t\u0027, table, \u0027-L\u0027, name, \u0027-n\u0027, \u0027-v\u0027, \u0027-x\u0027, \u0027-w\u0027]"},{"line_number":708,"context_line":"            if zero:"},{"line_number":709,"context_line":"                args.append(\u0027-Z\u0027)"},{"line_number":710,"context_line":"            if self.namespace:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_7759b68d","line":707,"updated":"2016-04-20 17:39:59.000000000","message":"So my only issue with this is it could block forever, theoretically.  Later versions of iptables added an argument - \"-w [seconds]\" so this wouldn\u0027t happen.\n\nI just don\u0027t know if we can add that here since it\u0027s only in post-2014 versions of iptables, which might not be widely-distributed.  My quick check found only the (unreleased) 16.04 version of Ubuntu supported that flag :(","commit_id":"ef5f593f9b4113df51528bbdb2b1b6553521e123"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"178a43ad5724dae67c58b4dec885c76b61041825","unresolved":false,"context_lines":[{"line_number":704,"context_line":"        acc \u003d {\u0027pkts\u0027: 0, \u0027bytes\u0027: 0}"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        for cmd, table in cmd_tables:"},{"line_number":707,"context_line":"            args \u003d [cmd, \u0027-t\u0027, table, \u0027-L\u0027, name, \u0027-n\u0027, \u0027-v\u0027, \u0027-x\u0027, \u0027-w\u0027]"},{"line_number":708,"context_line":"            if zero:"},{"line_number":709,"context_line":"                args.append(\u0027-Z\u0027)"},{"line_number":710,"context_line":"            if self.namespace:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_800b6e29","line":707,"updated":"2016-05-10 21:56:35.000000000","message":"What could cause a block that lasts that long? If something does have the lock and we are throwing errors, is that really better than blocking? I\u0027m not familiar with which operations are safe to use without the lock.","commit_id":"ef5f593f9b4113df51528bbdb2b1b6553521e123"},{"author":{"_account_id":17699,"name":"Yi Jing Zhu","email":"nick.zhuyj@cn.ibm.com","username":"nick.zhuyj"},"change_message_id":"b0d0f703831e243dc8cf9f3f40a37d3f1c3903ea","unresolved":false,"context_lines":[{"line_number":704,"context_line":"        acc \u003d {\u0027pkts\u0027: 0, \u0027bytes\u0027: 0}"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        for cmd, table in cmd_tables:"},{"line_number":707,"context_line":"            args \u003d [cmd, \u0027-t\u0027, table, \u0027-L\u0027, name, \u0027-n\u0027, \u0027-v\u0027, \u0027-x\u0027, \u0027-w\u0027]"},{"line_number":708,"context_line":"            if zero:"},{"line_number":709,"context_line":"                args.append(\u0027-Z\u0027)"},{"line_number":710,"context_line":"            if self.namespace:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_d4375a4b","line":707,"range":{"start_line":707,"start_character":0,"end_line":707,"end_character":73},"updated":"2016-05-25 08:11:36.000000000","message":"what is the impact if get traffic counter failed? Maybe we can get it in next round.","commit_id":"ef5f593f9b4113df51528bbdb2b1b6553521e123"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"210a600fabfde2edbc16924389948dc770d82bc8","unresolved":false,"context_lines":[{"line_number":704,"context_line":"        acc \u003d {\u0027pkts\u0027: 0, \u0027bytes\u0027: 0}"},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"        for cmd, table in cmd_tables:"},{"line_number":707,"context_line":"            args \u003d [cmd, \u0027-t\u0027, table, \u0027-L\u0027, name, \u0027-n\u0027, \u0027-v\u0027, \u0027-x\u0027, \u0027-w\u0027]"},{"line_number":708,"context_line":"            if zero:"},{"line_number":709,"context_line":"                args.append(\u0027-Z\u0027)"},{"line_number":710,"context_line":"            if self.namespace:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_c5dd1672","line":707,"range":{"start_line":707,"start_character":0,"end_line":707,"end_character":73},"in_reply_to":"bab6814e_d4375a4b","updated":"2016-07-18 13:42:58.000000000","message":"Kevin Benton, Yi Jing Zhu, I came across this bug, when watching the iptables by using watch command and at the same time metering agent tried to collect traffic. I don\u0027t saw any other scenarios when this problem pops up. And, actually, as I know, this problem is not affects any traffic counters (traffic will gather for the next round, right, but the statistic in ceilometer will be updated only on the next round, but I don\u0027t think it\u0027s big trouble). it\u0027s just may cause a lot of unpleasant messages (tracebacks) in logs. Can you, please, suggest, what should I do with this change/bug?","commit_id":"ef5f593f9b4113df51528bbdb2b1b6553521e123"}]}
