)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"79b82bb0bc4d6aa84c89bce23a0bf4f8b54ba7b5","unresolved":false,"context_lines":[{"line_number":16,"context_line":"To fix this behavior rollback actions are covered with try-except block."},{"line_number":17,"context_line":"This way any exception during rollback operations do not replace"},{"line_number":18,"context_line":"original exception."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ifdba7c49dc4a774be5221338b003d371750374d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_7a692825","line":19,"updated":"2016-04-18 11:39:29.000000000","message":"Please file a bug.","commit_id":"332136713fb7dfe28b6b8169d54f452e6db8a2a1"},{"author":{"_account_id":13768,"name":"Pavel Bondar","email":"pbondar@infoblox.com","username":"pavel_bondar"},"change_message_id":"52bf058ac49dc97ed10e0482a119feb2c0645238","unresolved":false,"context_lines":[{"line_number":16,"context_line":"To fix this behavior rollback actions are covered with try-except block."},{"line_number":17,"context_line":"This way any exception during rollback operations do not replace"},{"line_number":18,"context_line":"original exception."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Ifdba7c49dc4a774be5221338b003d371750374d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a122d0e_0e30b69d","line":19,"in_reply_to":"1a122d0e_7a692825","updated":"2016-04-18 13:06:25.000000000","message":"will do","commit_id":"332136713fb7dfe28b6b8169d54f452e6db8a2a1"}],"neutron/db/ipam_pluggable_backend.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"197645d66b3258b9d0c831cabd2cecaef21c3d40","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                                                port, deallocated,"},{"line_number":73,"context_line":"                                                revert_on_fail\u003dFalse)"},{"line_number":74,"context_line":"                    except Exception as e:"},{"line_number":75,"context_line":"                        LOG.debug(\"Revert failed with: %s\", e)"},{"line_number":76,"context_line":"                elif not revert_on_fail and ips:"},{"line_number":77,"context_line":"                    addresses \u003d \u0027, \u0027.join(self._get_failed_ips(ips,"},{"line_number":78,"context_line":"                                                               deallocated))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_0cad7de9","line":75,"updated":"2016-04-17 09:08:15.000000000","message":"sorry for the nit but can this please be a warning or an error","commit_id":"f3cf6fea7546bb6f9c31b7561b9d35054fd0e5b7"},{"author":{"_account_id":13768,"name":"Pavel Bondar","email":"pbondar@infoblox.com","username":"pavel_bondar"},"change_message_id":"620d441dcfcfe91831328762974c45977b3dd128","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                                                port, deallocated,"},{"line_number":73,"context_line":"                                                revert_on_fail\u003dFalse)"},{"line_number":74,"context_line":"                    except Exception as e:"},{"line_number":75,"context_line":"                        LOG.debug(\"Revert failed with: %s\", e)"},{"line_number":76,"context_line":"                elif not revert_on_fail and ips:"},{"line_number":77,"context_line":"                    addresses \u003d \u0027, \u0027.join(self._get_failed_ips(ips,"},{"line_number":78,"context_line":"                                                               deallocated))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_9e8c0181","line":75,"in_reply_to":"1a122d0e_0cad7de9","updated":"2016-04-18 09:25:01.000000000","message":"sure","commit_id":"f3cf6fea7546bb6f9c31b7561b9d35054fd0e5b7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"197645d66b3258b9d0c831cabd2cecaef21c3d40","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                                                  port, allocated,"},{"line_number":142,"context_line":"                                                  revert_on_fail\u003dFalse)"},{"line_number":143,"context_line":"                    except Exception as e:"},{"line_number":144,"context_line":"                        LOG.debug(\"Revert failed with: %s\", e)"},{"line_number":145,"context_line":"                elif not revert_on_fail and ips:"},{"line_number":146,"context_line":"                    addresses \u003d \u0027, \u0027.join(self._get_failed_ips(ips,"},{"line_number":147,"context_line":"                                                               allocated))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_6cba3125","line":144,"updated":"2016-04-17 09:08:15.000000000","message":"ditto","commit_id":"f3cf6fea7546bb6f9c31b7561b9d35054fd0e5b7"},{"author":{"_account_id":13768,"name":"Pavel Bondar","email":"pbondar@infoblox.com","username":"pavel_bondar"},"change_message_id":"620d441dcfcfe91831328762974c45977b3dd128","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                                                  port, allocated,"},{"line_number":142,"context_line":"                                                  revert_on_fail\u003dFalse)"},{"line_number":143,"context_line":"                    except Exception as e:"},{"line_number":144,"context_line":"                        LOG.debug(\"Revert failed with: %s\", e)"},{"line_number":145,"context_line":"                elif not revert_on_fail and ips:"},{"line_number":146,"context_line":"                    addresses \u003d \u0027, \u0027.join(self._get_failed_ips(ips,"},{"line_number":147,"context_line":"                                                               allocated))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_de98391e","line":144,"in_reply_to":"1a122d0e_6cba3125","updated":"2016-04-18 09:25:01.000000000","message":"ok","commit_id":"f3cf6fea7546bb6f9c31b7561b9d35054fd0e5b7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"197645d66b3258b9d0c831cabd2cecaef21c3d40","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                    LOG.debug(\"An exception occurred during port creation. \""},{"line_number":189,"context_line":"                              \"Reverting IP allocation\")"},{"line_number":190,"context_line":"                    try:"},{"line_number":191,"context_line":"                        ipam_driver \u003d driver.Pool.get_instance(None, context)"},{"line_number":192,"context_line":"                        self._ipam_deallocate_ips(context, ipam_driver,"},{"line_number":193,"context_line":"                                                  port_copy[\u0027port\u0027], ips,"},{"line_number":194,"context_line":"                                                  revert_on_fail\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_cc81c54c","line":191,"updated":"2016-04-17 09:08:15.000000000","message":"this line does not need to be in the try catch","commit_id":"f3cf6fea7546bb6f9c31b7561b9d35054fd0e5b7"},{"author":{"_account_id":13768,"name":"Pavel Bondar","email":"pbondar@infoblox.com","username":"pavel_bondar"},"change_message_id":"620d441dcfcfe91831328762974c45977b3dd128","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                    LOG.debug(\"An exception occurred during port creation. \""},{"line_number":189,"context_line":"                              \"Reverting IP allocation\")"},{"line_number":190,"context_line":"                    try:"},{"line_number":191,"context_line":"                        ipam_driver \u003d driver.Pool.get_instance(None, context)"},{"line_number":192,"context_line":"                        self._ipam_deallocate_ips(context, ipam_driver,"},{"line_number":193,"context_line":"                                                  port_copy[\u0027port\u0027], ips,"},{"line_number":194,"context_line":"                                                  revert_on_fail\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_3ea04d43","line":191,"in_reply_to":"1a122d0e_cc81c54c","updated":"2016-04-18 09:25:01.000000000","message":"ok","commit_id":"f3cf6fea7546bb6f9c31b7561b9d35054fd0e5b7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"197645d66b3258b9d0c831cabd2cecaef21c3d40","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                        self._ipam_deallocate_ips(context, ipam_driver,"},{"line_number":193,"context_line":"                                                  port_copy[\u0027port\u0027], ips,"},{"line_number":194,"context_line":"                                                  revert_on_fail\u003dFalse)"},{"line_number":195,"context_line":"                    except Exception as e:"},{"line_number":196,"context_line":"                        LOG.debug(\"Revert failed with: %s\", e)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _allocate_ips_for_port(self, context, port):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_8c87cd60","line":195,"updated":"2016-04-17 09:08:15.000000000","message":"ditto","commit_id":"f3cf6fea7546bb6f9c31b7561b9d35054fd0e5b7"},{"author":{"_account_id":13768,"name":"Pavel Bondar","email":"pbondar@infoblox.com","username":"pavel_bondar"},"change_message_id":"620d441dcfcfe91831328762974c45977b3dd128","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                        self._ipam_deallocate_ips(context, ipam_driver,"},{"line_number":193,"context_line":"                                                  port_copy[\u0027port\u0027], ips,"},{"line_number":194,"context_line":"                                                  revert_on_fail\u003dFalse)"},{"line_number":195,"context_line":"                    except Exception as e:"},{"line_number":196,"context_line":"                        LOG.debug(\"Revert failed with: %s\", e)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _allocate_ips_for_port(self, context, port):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_1ea3d150","line":195,"in_reply_to":"1a122d0e_8c87cd60","updated":"2016-04-18 09:25:01.000000000","message":"ok","commit_id":"f3cf6fea7546bb6f9c31b7561b9d35054fd0e5b7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"79b82bb0bc4d6aa84c89bce23a0bf4f8b54ba7b5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                    LOG.debug(\"Reverting deallocation\")"},{"line_number":67,"context_line":"                    # In case of deadlock allocate fails with db error"},{"line_number":68,"context_line":"                    # and rewrites original exception preventing db_retry"},{"line_number":69,"context_line":"                    # wrappers from restarting entire api request."},{"line_number":70,"context_line":"                    try:"},{"line_number":71,"context_line":"                        self._ipam_allocate_ips(context, ipam_driver,"},{"line_number":72,"context_line":"                                                port, deallocated,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_ba4580b4","line":69,"updated":"2016-04-18 11:39:29.000000000","message":"If _ipam_allocate_ips below raises an exception, such IP address is not recovered (unallocated). What happens when db_retry wrapper retries an API request?","commit_id":"332136713fb7dfe28b6b8169d54f452e6db8a2a1"},{"author":{"_account_id":13768,"name":"Pavel Bondar","email":"pbondar@infoblox.com","username":"pavel_bondar"},"change_message_id":"52bf058ac49dc97ed10e0482a119feb2c0645238","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                    LOG.debug(\"Reverting deallocation\")"},{"line_number":67,"context_line":"                    # In case of deadlock allocate fails with db error"},{"line_number":68,"context_line":"                    # and rewrites original exception preventing db_retry"},{"line_number":69,"context_line":"                    # wrappers from restarting entire api request."},{"line_number":70,"context_line":"                    try:"},{"line_number":71,"context_line":"                        self._ipam_allocate_ips(context, ipam_driver,"},{"line_number":72,"context_line":"                                                port, deallocated,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_78277064","line":69,"in_reply_to":"1a122d0e_ba4580b4","updated":"2016-04-18 13:06:25.000000000","message":"For referenece ipam driver (or any ipam driver that uses only neutron db for data):\nIf _ipam_allocate_ips failes here, data is rolled back by transaction rollback. So db is restored to the point where ip deallocation is not started yet. And then db_retry wrapper restarts an API request and starts new db transaction.\n\nFor 3rd party ipam drivers (if they communicate with external servers):\n1) They should not raise RetryRequest, synchronization should be handled by remote ipam provider in this case. I.e. ipam provider should not allow to allocate the same ip for concurent ip allocations.\n2) If attempt to allocate ip address back after deallocating it failed (due to server unavailability, communication error) there is not much we can do about it (as I see). So 3rd party ipam drivers should be writen in a fault tollerant way, where for example attempt to deallocate already deallocated ip do not raise exception.","commit_id":"332136713fb7dfe28b6b8169d54f452e6db8a2a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"79b82bb0bc4d6aa84c89bce23a0bf4f8b54ba7b5","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                        self._ipam_allocate_ips(context, ipam_driver,"},{"line_number":72,"context_line":"                                                port, deallocated,"},{"line_number":73,"context_line":"                                                revert_on_fail\u003dFalse)"},{"line_number":74,"context_line":"                    except Exception as e:"},{"line_number":75,"context_line":"                        LOG.warning(_LW(\"Revert failed with: %s\"), e)"},{"line_number":76,"context_line":"                elif not revert_on_fail and ips:"},{"line_number":77,"context_line":"                    addresses \u003d \u0027, \u0027.join(self._get_failed_ips(ips,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_da4f9cbb","line":74,"range":{"start_line":74,"start_character":27,"end_line":74,"end_character":37},"updated":"2016-04-18 11:39:29.000000000","message":"I am not sure catching all exception is needed. Could you clarify?","commit_id":"332136713fb7dfe28b6b8169d54f452e6db8a2a1"},{"author":{"_account_id":13768,"name":"Pavel Bondar","email":"pbondar@infoblox.com","username":"pavel_bondar"},"change_message_id":"52bf058ac49dc97ed10e0482a119feb2c0645238","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                        self._ipam_allocate_ips(context, ipam_driver,"},{"line_number":72,"context_line":"                                                port, deallocated,"},{"line_number":73,"context_line":"                                                revert_on_fail\u003dFalse)"},{"line_number":74,"context_line":"                    except Exception as e:"},{"line_number":75,"context_line":"                        LOG.warning(_LW(\"Revert failed with: %s\"), e)"},{"line_number":76,"context_line":"                elif not revert_on_fail and ips:"},{"line_number":77,"context_line":"                    addresses \u003d \u0027, \u0027.join(self._get_failed_ips(ips,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_a94c1c43","line":74,"range":{"start_line":74,"start_character":27,"end_line":74,"end_character":37},"in_reply_to":"1a122d0e_da4f9cbb","updated":"2016-04-18 13:06:25.000000000","message":"Reason to catch all exceptions here is to prevent overriding original exception. Original exceptions has more relevant information about the root cause of the issue. Also original exception may trigger actions like restarting db transaction (for RetryRequest and DeadLock exceptions), so it should not be rewriten by anything else.","commit_id":"332136713fb7dfe28b6b8169d54f452e6db8a2a1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"52b003aca8ee6b5edd1d1a94833bfb0ccbbabd4d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                LOG.debug(\"An exception occurred during IP deallocation.\")"},{"line_number":67,"context_line":"                if revert_on_fail and deallocated:"},{"line_number":68,"context_line":"                    LOG.debug(\"Reverting deallocation\")"},{"line_number":69,"context_line":"                    # In case of deadlock allocate fails with db error"},{"line_number":70,"context_line":"                    # and rewrites original exception preventing db_retry"},{"line_number":71,"context_line":"                    # wrappers from restarting entire api request."},{"line_number":72,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_40c77195","line":69,"updated":"2016-04-21 10:04:23.000000000","message":"nit - the lines below are repeated 3 times - maybe we could have a utility method to do this. But it may be an overkill","commit_id":"30c48b97dabf6b19cdc0e59b36fcbd4a8a42266b"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"28dedeca1fd30abdc76db051f94c48d8176c9a17","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                LOG.debug(\"An exception occurred during IP deallocation.\")"},{"line_number":67,"context_line":"                if revert_on_fail and deallocated:"},{"line_number":68,"context_line":"                    LOG.debug(\"Reverting deallocation\")"},{"line_number":69,"context_line":"                    # In case of deadlock allocate fails with db error"},{"line_number":70,"context_line":"                    # and rewrites original exception preventing db_retry"},{"line_number":71,"context_line":"                    # wrappers from restarting entire api request."},{"line_number":72,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_60baf2e2","line":69,"in_reply_to":"1a122d0e_40c77195","updated":"2016-04-25 14:17:26.000000000","message":"+1.  Three times is about my threshold for asking for a utility but I don\u0027t think it is mandatory either.","commit_id":"30c48b97dabf6b19cdc0e59b36fcbd4a8a42266b"},{"author":{"_account_id":13768,"name":"Pavel Bondar","email":"pbondar@infoblox.com","username":"pavel_bondar"},"change_message_id":"1f808ce56e6b5e3544082247706445dcbc157e51","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                LOG.debug(\"An exception occurred during IP deallocation.\")"},{"line_number":67,"context_line":"                if revert_on_fail and deallocated:"},{"line_number":68,"context_line":"                    LOG.debug(\"Reverting deallocation\")"},{"line_number":69,"context_line":"                    # In case of deadlock allocate fails with db error"},{"line_number":70,"context_line":"                    # and rewrites original exception preventing db_retry"},{"line_number":71,"context_line":"                    # wrappers from restarting entire api request."},{"line_number":72,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_d9d8e520","line":69,"in_reply_to":"1a122d0e_60baf2e2","updated":"2016-04-27 15:05:40.000000000","message":"fixed in PS7","commit_id":"30c48b97dabf6b19cdc0e59b36fcbd4a8a42266b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"00175f0d05b91bbf23a499f67b6c526b0378079c","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                              \"Reverting IP allocation\")"},{"line_number":193,"context_line":"                    ipam_driver \u003d driver.Pool.get_instance(None, context)"},{"line_number":194,"context_line":"                    self._safe_rollback(self._ipam_deallocate_ips, context,"},{"line_number":195,"context_line":"                                        ipam_driver, port, ips,"},{"line_number":196,"context_line":"                                        revert_on_fail\u003dFalse)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _allocate_ips_for_port(self, context, port):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_58db267c","line":195,"updated":"2016-04-27 20:47:52.000000000","message":"This was port_copy[\u0027port\u0027] in the original","commit_id":"9cc8fe9e3a593bee6e13dbf0f6eb2c46b9c3ec13"},{"author":{"_account_id":13768,"name":"Pavel Bondar","email":"pbondar@infoblox.com","username":"pavel_bondar"},"change_message_id":"bc9907729365ec732c5dcad6cf7bc7e64c442e5f","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                              \"Reverting IP allocation\")"},{"line_number":193,"context_line":"                    ipam_driver \u003d driver.Pool.get_instance(None, context)"},{"line_number":194,"context_line":"                    self._safe_rollback(self._ipam_deallocate_ips, context,"},{"line_number":195,"context_line":"                                        ipam_driver, port, ips,"},{"line_number":196,"context_line":"                                        revert_on_fail\u003dFalse)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def _allocate_ips_for_port(self, context, port):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_a4c66c97","line":195,"in_reply_to":"1a122d0e_58db267c","updated":"2016-04-29 08:32:37.000000000","message":"Thanks for the catch!","commit_id":"9cc8fe9e3a593bee6e13dbf0f6eb2c46b9c3ec13"}]}
