)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a4d38aae9a883bcae16176b3fe97f1b277c12425","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Thinking about the scenario that administrator may want to make one"},{"line_number":14,"context_line":"special network node trend to act as master, but current code base don\u0027t"},{"line_number":15,"context_line":"have this ability."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I22c14bd2080bf91959b32be253868952cc2a6801"},{"line_number":18,"context_line":"Closes-Bug: #1571448"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_fe79b5fd","line":16,"updated":"2016-04-18 09:15:19.000000000","message":"Please add DocImpact flag and a release note","commit_id":"65e666ffda30763bd5e0190206c7a7dbc593fb83"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e49291f16202c25ea459866eede02da15a263e68","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Thinking about the scenario that administrator may want to make one"},{"line_number":14,"context_line":"special network node trend to act as master, but current code base don\u0027t"},{"line_number":15,"context_line":"have this ability."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I22c14bd2080bf91959b32be253868952cc2a6801"},{"line_number":18,"context_line":"Closes-Bug: #1571448"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_8a695bc1","line":16,"in_reply_to":"1a122d0e_01325610","updated":"2016-04-18 10:10:14.000000000","message":"I see no release note added.","commit_id":"65e666ffda30763bd5e0190206c7a7dbc593fb83"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"b50c52c24a2aaab0ccda9c7a74dd617817d12730","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Thinking about the scenario that administrator may want to make one"},{"line_number":14,"context_line":"special network node trend to act as master, but current code base don\u0027t"},{"line_number":15,"context_line":"have this ability."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I22c14bd2080bf91959b32be253868952cc2a6801"},{"line_number":18,"context_line":"Closes-Bug: #1571448"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_b55e3810","line":16,"in_reply_to":"1a122d0e_8a695bc1","updated":"2016-04-18 10:25:12.000000000","message":"release note added for review now","commit_id":"65e666ffda30763bd5e0190206c7a7dbc593fb83"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"c9e07bd3c41d40253d7ae16276f812734eb07952","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Thinking about the scenario that administrator may want to make one"},{"line_number":14,"context_line":"special network node trend to act as master, but current code base don\u0027t"},{"line_number":15,"context_line":"have this ability."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I22c14bd2080bf91959b32be253868952cc2a6801"},{"line_number":18,"context_line":"Closes-Bug: #1571448"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a122d0e_01325610","line":16,"in_reply_to":"1a122d0e_fe79b5fd","updated":"2016-04-18 09:33:27.000000000","message":"Done","commit_id":"65e666ffda30763bd5e0190206c7a7dbc593fb83"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"90616637dfa9ba32b4813f69260c9ab97601bf61","unresolved":false,"context_lines":[{"line_number":14,"context_line":"special network node trend to act as master, but current code base don\u0027t"},{"line_number":15,"context_line":"have this ability."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact: a previously unused configuration value"},{"line_number":18,"context_line":"           ha_default_priority is now used to configure default"},{"line_number":19,"context_line":"           priority of vrrp(managed by keepalived)."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a122d0e_5c7d3fb0","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":50},"updated":"2016-04-18 14:46:25.000000000","message":"don\u0027t you actually add a new option?","commit_id":"66b14cd3bfaa34c2d0dcd29357217f53d27c0505"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"207c3f812474895a42b59fc692befa8fd2360e71","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HA_DEFAULT_PRIORITY currently is set to 50 as hardcode, and it\u0027s not"},{"line_number":10,"context_line":"configurable. As below:"},{"line_number":11,"context_line":"https://github.com/openstack/neutron/blob/master/neutron/agent/linux/keepalived.py#L31"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Thinking about the scenario that administrator may want to make one"},{"line_number":14,"context_line":"special network node trend to act as master, but current code base don\u0027t"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a122d0e_2fead9ac","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":86},"updated":"2016-04-22 16:27:25.000000000","message":"this will point to a different line even after this patch and will be misleading","commit_id":"ba56e8d1d7d9d98fca93d1c9821ac79ed7ca4596"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"1e24b1cf619cad4c9d0382d9c0c5be04a9efb764","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HA_DEFAULT_PRIORITY currently is set to 50 as hardcode, and it\u0027s not"},{"line_number":10,"context_line":"configurable. As below:"},{"line_number":11,"context_line":"https://github.com/openstack/neutron/blob/master/neutron/agent/linux/keepalived.py#L31"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Thinking about the scenario that administrator may want to make one"},{"line_number":14,"context_line":"special network node trend to act as master, but current code base don\u0027t"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"dab17558_bce3a832","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":86},"in_reply_to":"1a122d0e_2fead9ac","updated":"2016-05-09 02:12:19.000000000","message":"Done","commit_id":"ba56e8d1d7d9d98fca93d1c9821ac79ed7ca4596"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"d9bd8ccbcd5427e833e3d0255b1b2df1b72c9835","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HA_DEFAULT_PRIORITY currently is set to 50 as hardcode, and it\u0027s not"},{"line_number":10,"context_line":"configurable. As below:"},{"line_number":11,"context_line":"https://github.com/openstack/neutron/blob/master/neutron/agent/linux/keepalived.py#L31"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Thinking about the scenario that administrator may want to make one"},{"line_number":14,"context_line":"special network node trend to act as master, but current code base don\u0027t"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a122d0e_dca78f09","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":86},"in_reply_to":"1a122d0e_2fead9ac","updated":"2016-04-23 03:19:57.000000000","message":"ohh, I will remove this link, which means the link is not necessary","commit_id":"ba56e8d1d7d9d98fca93d1c9821ac79ed7ca4596"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"207c3f812474895a42b59fc692befa8fd2360e71","unresolved":false,"context_lines":[{"line_number":14,"context_line":"special network node trend to act as master, but current code base don\u0027t"},{"line_number":15,"context_line":"have this ability."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact: a previously unused configuration value"},{"line_number":18,"context_line":"           ha_default_priority is now used to configure default"},{"line_number":19,"context_line":"           priority of vrrp(managed by keepalived)."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a122d0e_4fb0f5dd","line":17,"range":{"start_line":17,"start_character":13,"end_line":17,"end_character":44},"updated":"2016-04-22 16:27:25.000000000","message":"I had a comment on PS4 which was unaddressed: why \u0027previously unused configuration\u0027? This is a new config option which you\u0027re adding, isn\u0027t it?","commit_id":"ba56e8d1d7d9d98fca93d1c9821ac79ed7ca4596"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"d9bd8ccbcd5427e833e3d0255b1b2df1b72c9835","unresolved":false,"context_lines":[{"line_number":14,"context_line":"special network node trend to act as master, but current code base don\u0027t"},{"line_number":15,"context_line":"have this ability."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact: a previously unused configuration value"},{"line_number":18,"context_line":"           ha_default_priority is now used to configure default"},{"line_number":19,"context_line":"           priority of vrrp(managed by keepalived)."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a122d0e_dc702fa7","line":17,"range":{"start_line":17,"start_character":13,"end_line":17,"end_character":44},"in_reply_to":"1a122d0e_4fb0f5dd","updated":"2016-04-23 03:19:57.000000000","message":"yes, a new config","commit_id":"ba56e8d1d7d9d98fca93d1c9821ac79ed7ca4596"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5ec6d0d105684b65691ffa23a2c1a32734932343","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yaowei \u003cyaowei@unitedstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-22 00:01:44 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make HA_DEFAULT_PRIORITY configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HA_DEFAULT_PRIORITY currently is set to 50 as hardcode, and it\u0027s not"},{"line_number":10,"context_line":"configurable. As below:"},{"line_number":11,"context_line":"https://github.com/openstack/neutron/blob/master/neutron/agent/linux/keepalived.py#L31"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Thinking about the scenario that administrator may want to make one"},{"line_number":14,"context_line":"special network node trend to act as master, but current code base don\u0027t"},{"line_number":15,"context_line":"have this ability."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact: a previously unused configuration value"},{"line_number":18,"context_line":"           ha_default_priority is now used to configure default"},{"line_number":19,"context_line":"           priority of vrrp(managed by keepalived)."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I22c14bd2080bf91959b32be253868952cc2a6801"},{"line_number":22,"context_line":"Closes-Bug: #1571448"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a122d0e_9e46c14d","line":19,"range":{"start_line":7,"start_character":0,"end_line":19,"end_character":51},"updated":"2016-04-22 15:19:25.000000000","message":"The change has morphed since this commit message was written. Please update the commit message so it describes the change better.","commit_id":"ba56e8d1d7d9d98fca93d1c9821ac79ed7ca4596"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0151d8c88cc51b984dc9a2862a1cf2c853ec1320","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yaowei \u003cyaowei@unitedstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-22 00:01:44 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make HA_DEFAULT_PRIORITY configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HA_DEFAULT_PRIORITY currently is set to 50 as hardcode, and it\u0027s not"},{"line_number":10,"context_line":"configurable. As below:"},{"line_number":11,"context_line":"https://github.com/openstack/neutron/blob/master/neutron/agent/linux/keepalived.py#L31"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Thinking about the scenario that administrator may want to make one"},{"line_number":14,"context_line":"special network node trend to act as master, but current code base don\u0027t"},{"line_number":15,"context_line":"have this ability."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact: a previously unused configuration value"},{"line_number":18,"context_line":"           ha_default_priority is now used to configure default"},{"line_number":19,"context_line":"           priority of vrrp(managed by keepalived)."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I22c14bd2080bf91959b32be253868952cc2a6801"},{"line_number":22,"context_line":"Closes-Bug: #1571448"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a122d0e_64fd183b","line":19,"range":{"start_line":7,"start_character":0,"end_line":19,"end_character":51},"in_reply_to":"1a122d0e_210f9289","updated":"2016-04-22 16:07:14.000000000","message":"Mostly I wanted to see the new config parameter \u0027ha_vrrp_default_priority\u0027 mentioned here. It\u0027s mentioned in the release note, so I guess I should be happy with that.","commit_id":"ba56e8d1d7d9d98fca93d1c9821ac79ed7ca4596"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"3c14d0f65ea3f6d4a1a9b310e131c2ea129ddf31","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yaowei \u003cyaowei@unitedstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-22 00:01:44 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make HA_DEFAULT_PRIORITY configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"HA_DEFAULT_PRIORITY currently is set to 50 as hardcode, and it\u0027s not"},{"line_number":10,"context_line":"configurable. As below:"},{"line_number":11,"context_line":"https://github.com/openstack/neutron/blob/master/neutron/agent/linux/keepalived.py#L31"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Thinking about the scenario that administrator may want to make one"},{"line_number":14,"context_line":"special network node trend to act as master, but current code base don\u0027t"},{"line_number":15,"context_line":"have this ability."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact: a previously unused configuration value"},{"line_number":18,"context_line":"           ha_default_priority is now used to configure default"},{"line_number":19,"context_line":"           priority of vrrp(managed by keepalived)."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I22c14bd2080bf91959b32be253868952cc2a6801"},{"line_number":22,"context_line":"Closes-Bug: #1571448"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1a122d0e_210f9289","line":19,"range":{"start_line":7,"start_character":0,"end_line":19,"end_character":51},"in_reply_to":"1a122d0e_9e46c14d","updated":"2016-04-22 15:44:18.000000000","message":"@Henry Gessau, thx. But in my opinion, this commit msg have  a clear statement and describe why a change is being made, and it has summarized the code change.","commit_id":"ba56e8d1d7d9d98fca93d1c9821ac79ed7ca4596"}],"neutron/agent/l3/ha.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7882bbe59105eb22c45364e0527e6c62c91d4986","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.IntOpt(\u0027ha_vrrp_advert_int\u0027,"},{"line_number":46,"context_line":"               default\u003d2,"},{"line_number":47,"context_line":"               help\u003d_(\u0027The advertisement interval in seconds\u0027)),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027ha_default_priority\u0027,"},{"line_number":49,"context_line":"               default\u003d50,"},{"line_number":50,"context_line":"               help\u003d_(\u0027HA default priority of vrrp for keepalived.\u0027)),"},{"line_number":51,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_c5fe7837","line":48,"updated":"2016-04-19 07:21:00.000000000","message":"lets rename to \u0027ha_vrrp_default_priority\u0027 to make it consistent with the other existing config options.","commit_id":"e2b9b5b1547bced101f366aa0572ca5236c3ee69"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"a91152d0029aee8b15c8bc7a0c264265d52cb038","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.IntOpt(\u0027ha_vrrp_advert_int\u0027,"},{"line_number":46,"context_line":"               default\u003d2,"},{"line_number":47,"context_line":"               help\u003d_(\u0027The advertisement interval in seconds\u0027)),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027ha_default_priority\u0027,"},{"line_number":49,"context_line":"               default\u003d50,"},{"line_number":50,"context_line":"               help\u003d_(\u0027HA default priority of vrrp for keepalived.\u0027)),"},{"line_number":51,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_ebb0a345","line":48,"in_reply_to":"1a122d0e_c5fe7837","updated":"2016-04-19 08:05:53.000000000","message":"Done","commit_id":"e2b9b5b1547bced101f366aa0572ca5236c3ee69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7882bbe59105eb22c45364e0527e6c62c91d4986","unresolved":false,"context_lines":[{"line_number":46,"context_line":"               default\u003d2,"},{"line_number":47,"context_line":"               help\u003d_(\u0027The advertisement interval in seconds\u0027)),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027ha_default_priority\u0027,"},{"line_number":49,"context_line":"               default\u003d50,"},{"line_number":50,"context_line":"               help\u003d_(\u0027HA default priority of vrrp for keepalived.\u0027)),"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_057eb0ad","line":49,"updated":"2016-04-19 07:21:00.000000000","message":"IMO, let\u0027s use a constant for this value and use the same in the tests as well.","commit_id":"e2b9b5b1547bced101f366aa0572ca5236c3ee69"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"a91152d0029aee8b15c8bc7a0c264265d52cb038","unresolved":false,"context_lines":[{"line_number":46,"context_line":"               default\u003d2,"},{"line_number":47,"context_line":"               help\u003d_(\u0027The advertisement interval in seconds\u0027)),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027ha_default_priority\u0027,"},{"line_number":49,"context_line":"               default\u003d50,"},{"line_number":50,"context_line":"               help\u003d_(\u0027HA default priority of vrrp for keepalived.\u0027)),"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_2bdd7b0e","line":49,"in_reply_to":"1a122d0e_057eb0ad","updated":"2016-04-19 08:05:53.000000000","message":"no need to use a constant. As we can see, many options\u0027 default are numbers or string instead of constants in neutron.  On the other side, this option only used in small scope (l3 ha agent).","commit_id":"e2b9b5b1547bced101f366aa0572ca5236c3ee69"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7882bbe59105eb22c45364e0527e6c62c91d4986","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d_(\u0027The advertisement interval in seconds\u0027)),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027ha_default_priority\u0027,"},{"line_number":49,"context_line":"               default\u003d50,"},{"line_number":50,"context_line":"               help\u003d_(\u0027HA default priority of vrrp for keepalived.\u0027)),"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_c585d8ad","line":50,"updated":"2016-04-19 07:21:00.000000000","message":"How abt \"help\u003d_(\u0027VRRP HA default priority\u0027)),\"?","commit_id":"e2b9b5b1547bced101f366aa0572ca5236c3ee69"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"a91152d0029aee8b15c8bc7a0c264265d52cb038","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d_(\u0027The advertisement interval in seconds\u0027)),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027ha_default_priority\u0027,"},{"line_number":49,"context_line":"               default\u003d50,"},{"line_number":50,"context_line":"               help\u003d_(\u0027HA default priority of vrrp for keepalived.\u0027)),"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_2bbbbb28","line":50,"in_reply_to":"1a122d0e_c585d8ad","updated":"2016-04-19 08:05:53.000000000","message":"Done","commit_id":"e2b9b5b1547bced101f366aa0572ca5236c3ee69"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"6ef82050baf4c91c1797c93cee23898f4f0c2c78","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d_(\u0027The advertisement interval in seconds\u0027)),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027ha_vrrp_default_priority\u0027,"},{"line_number":49,"context_line":"               default\u003d50,"},{"line_number":50,"context_line":"               help\u003d_(\u0027VRRP HA default priority.\u0027)),"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_d3559950","line":50,"range":{"start_line":50,"start_character":47,"end_line":50,"end_character":48},"updated":"2016-04-19 09:50:46.000000000","message":"nit: help message of other configuration don\u0027t have period at the end.","commit_id":"c06bb373ab1c97b74fd8b5f90aad972f1494c6ae"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"360344aa6a20bc15284309187a7be0eea94e38cc","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d_(\u0027The advertisement interval in seconds\u0027)),"},{"line_number":48,"context_line":"    cfg.IntOpt(\u0027ha_vrrp_default_priority\u0027,"},{"line_number":49,"context_line":"               default\u003d50,"},{"line_number":50,"context_line":"               help\u003d_(\u0027VRRP HA default priority.\u0027)),"},{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_e0154b40","line":50,"range":{"start_line":50,"start_character":47,"end_line":50,"end_character":48},"in_reply_to":"1a122d0e_d3559950","updated":"2016-04-19 14:36:17.000000000","message":"Done","commit_id":"c06bb373ab1c97b74fd8b5f90aad972f1494c6ae"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8d93c020ded38d94324dc53e5b389c74d98b4f79","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    cfg.IntOpt(\u0027ha_vrrp_advert_int\u0027,"},{"line_number":47,"context_line":"               default\u003d2,"},{"line_number":48,"context_line":"               help\u003d_(\u0027The advertisement interval in seconds\u0027)),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027ha_vrrp_default_priority\u0027,"},{"line_number":50,"context_line":"               default\u003dconstants.HA_VRRP_DEFAULT_PRIORITY,"},{"line_number":51,"context_line":"               help\u003d_(\u0027VRRP HA default priority\u0027)),"},{"line_number":52,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_7a077f1c","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":40},"updated":"2016-05-09 06:06:54.000000000","message":"I would recommend consider renaming this as ha_vrrp_priority\nbecause default is 50 but now its configurable.","commit_id":"0a862bc586af866e798d934776e41445220323b9"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"425f0561ba8aa12f8e5c7830cc1b3e1a898cfc32","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    cfg.IntOpt(\u0027ha_vrrp_advert_int\u0027,"},{"line_number":47,"context_line":"               default\u003d2,"},{"line_number":48,"context_line":"               help\u003d_(\u0027The advertisement interval in seconds\u0027)),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027ha_vrrp_default_priority\u0027,"},{"line_number":50,"context_line":"               default\u003dconstants.HA_VRRP_DEFAULT_PRIORITY,"},{"line_number":51,"context_line":"               help\u003d_(\u0027VRRP HA default priority\u0027)),"},{"line_number":52,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_359cc1bf","line":49,"range":{"start_line":49,"start_character":16,"end_line":49,"end_character":40},"in_reply_to":"dab17558_7a077f1c","updated":"2016-05-10 01:36:26.000000000","message":"Done","commit_id":"0a862bc586af866e798d934776e41445220323b9"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8d93c020ded38d94324dc53e5b389c74d98b4f79","unresolved":false,"context_lines":[{"line_number":48,"context_line":"               help\u003d_(\u0027The advertisement interval in seconds\u0027)),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027ha_vrrp_default_priority\u0027,"},{"line_number":50,"context_line":"               default\u003dconstants.HA_VRRP_DEFAULT_PRIORITY,"},{"line_number":51,"context_line":"               help\u003d_(\u0027VRRP HA default priority\u0027)),"},{"line_number":52,"context_line":"]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_dd0ca53d","line":51,"range":{"start_line":51,"start_character":23,"end_line":51,"end_character":47},"updated":"2016-05-09 06:06:54.000000000","message":"same here VRRP HA priority","commit_id":"0a862bc586af866e798d934776e41445220323b9"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"425f0561ba8aa12f8e5c7830cc1b3e1a898cfc32","unresolved":false,"context_lines":[{"line_number":48,"context_line":"               help\u003d_(\u0027The advertisement interval in seconds\u0027)),"},{"line_number":49,"context_line":"    cfg.IntOpt(\u0027ha_vrrp_default_priority\u0027,"},{"line_number":50,"context_line":"               default\u003dconstants.HA_VRRP_DEFAULT_PRIORITY,"},{"line_number":51,"context_line":"               help\u003d_(\u0027VRRP HA default priority\u0027)),"},{"line_number":52,"context_line":"]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_159ffdb4","line":51,"range":{"start_line":51,"start_character":23,"end_line":51,"end_character":47},"in_reply_to":"dab17558_dd0ca53d","updated":"2016-05-10 01:36:26.000000000","message":"Done","commit_id":"0a862bc586af866e798d934776e41445220323b9"}],"neutron/agent/linux/keepalived.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"90616637dfa9ba32b4813f69260c9ab97601bf61","unresolved":false,"context_lines":[{"line_number":37,"context_line":"OPTS \u003d ["},{"line_number":38,"context_line":"    cfg.IntOpt(\u0027ha_default_priority\u0027,"},{"line_number":39,"context_line":"               default\u003d50,"},{"line_number":40,"context_line":"               help\u003d_(\u0027HA default priority for keepalived.\u0027)),"},{"line_number":41,"context_line":"]"},{"line_number":42,"context_line":"cfg.CONF.register_opts(OPTS)"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_7cabdb1d","line":40,"range":{"start_line":40,"start_character":23,"end_line":40,"end_character":58},"updated":"2016-04-18 14:46:25.000000000","message":"Priority in what? I think this might be confusing. Please add more details","commit_id":"66b14cd3bfaa34c2d0dcd29357217f53d27c0505"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4feb0e8cd46d5df2d79807ab436bd4b031e7f7ab","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    \"\"\"Instance section of a keepalived configuration.\"\"\""},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def __init__(self, state, interface, vrouter_id, ha_cidrs,"},{"line_number":164,"context_line":"                 priority\u003dcfg.CONF.ha_default_priority, advert_int\u003dNone,"},{"line_number":165,"context_line":"                 mcast_src_ip\u003dNone, nopreempt\u003dFalse,"},{"line_number":166,"context_line":"                 garp_master_delay\u003dGARP_MASTER_DELAY):"},{"line_number":167,"context_line":"        self.name \u003d \u0027VR_%s\u0027 % vrouter_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_394de33e","line":164,"range":{"start_line":164,"start_character":26,"end_line":164,"end_character":54},"updated":"2016-04-18 21:08:57.000000000","message":"Best to not ref config values in constructors; it can lead to early conf loading in certain cases that can be difficult to debug.","commit_id":"66b14cd3bfaa34c2d0dcd29357217f53d27c0505"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"6ef82050baf4c91c1797c93cee23898f4f0c2c78","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    \"\"\"Instance section of a keepalived configuration.\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, state, interface, vrouter_id, ha_cidrs,"},{"line_number":157,"context_line":"                 priority, advert_int\u003dNone,"},{"line_number":158,"context_line":"                 mcast_src_ip\u003dNone, nopreempt\u003dFalse,"},{"line_number":159,"context_line":"                 garp_master_delay\u003dGARP_MASTER_DELAY):"},{"line_number":160,"context_line":"        self.name \u003d \u0027VR_%s\u0027 % vrouter_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_eeba6c09","line":157,"range":{"start_line":157,"start_character":17,"end_line":157,"end_character":25},"updated":"2016-04-19 09:50:46.000000000","message":"Can we still add a default value to this parameter? So that the existing code can survive without change.\n\nI just did a search, and found this[1], which might be broken.\n\n[1] https://github.com/openstack/neutron/blob/1a991f77864a71b2184cb7d3d8b999afb37e31df/neutron/cmd/sanity/checks.py#L214-L216","commit_id":"c06bb373ab1c97b74fd8b5f90aad972f1494c6ae"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"360344aa6a20bc15284309187a7be0eea94e38cc","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    \"\"\"Instance section of a keepalived configuration.\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, state, interface, vrouter_id, ha_cidrs,"},{"line_number":157,"context_line":"                 priority, advert_int\u003dNone,"},{"line_number":158,"context_line":"                 mcast_src_ip\u003dNone, nopreempt\u003dFalse,"},{"line_number":159,"context_line":"                 garp_master_delay\u003dGARP_MASTER_DELAY):"},{"line_number":160,"context_line":"        self.name \u003d \u0027VR_%s\u0027 % vrouter_id"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_008cc77d","line":157,"range":{"start_line":157,"start_character":17,"end_line":157,"end_character":25},"in_reply_to":"1a122d0e_eeba6c09","updated":"2016-04-19 14:36:17.000000000","message":"priority is required parameter of vrrp, and it should be force passed. check script has been updated.","commit_id":"c06bb373ab1c97b74fd8b5f90aad972f1494c6ae"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"d5dd90d631002ab08c4a2d60037881482502e160","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    \"\"\"Instance section of a keepalived configuration.\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, state, interface, vrouter_id, ha_cidrs,"},{"line_number":157,"context_line":"                 priority, advert_int\u003dNone,"},{"line_number":158,"context_line":"                 mcast_src_ip\u003dNone, nopreempt\u003dFalse,"},{"line_number":159,"context_line":"                 garp_master_delay\u003dGARP_MASTER_DELAY):"},{"line_number":160,"context_line":"        self.name \u003d \u0027VR_%s\u0027 % vrouter_id"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_5ebdf200","line":157,"range":{"start_line":157,"start_character":17,"end_line":157,"end_character":25},"updated":"2016-04-19 18:17:17.000000000","message":"Doesn\u0027t this effectively change the interface? priority is now a require arg (not kwarg). For example I\u0027d expect this to break now: https://github.com/openstack/neutron/blob/master/neutron/agent/l3/ha_router.py#L111\n\nMaybe its fine if we change all invocations, but if out-of-tree consumers are using this class its effectively changed their interface which IMHO should be done in a deprecated manner.\n\nYou can probably do something like this to remain backwards compatible:\n\ndef __init__(self, state, interface, vrouter_id, ha_cidrs,\n                 priority\u003dNone, advert_int\u003dNone,\n                 mcast_src_ip\u003dNone, nopreempt\u003dFalse,\n                 garp_master_delay\u003dGARP_MASTER_DELAY):\n\n        #...\n        self.priority \u003d cfg.CONF.ha_default_priority if priority is None else priority\n        #...","commit_id":"22bb938346859306a4f7a6f6d704f6ce104de8c6"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"8e92632300b082c14f42c5521b3a210b9a0da739","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    \"\"\"Instance section of a keepalived configuration.\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, state, interface, vrouter_id, ha_cidrs,"},{"line_number":157,"context_line":"                 priority, advert_int\u003dNone,"},{"line_number":158,"context_line":"                 mcast_src_ip\u003dNone, nopreempt\u003dFalse,"},{"line_number":159,"context_line":"                 garp_master_delay\u003dGARP_MASTER_DELAY):"},{"line_number":160,"context_line":"        self.name \u003d \u0027VR_%s\u0027 % vrouter_id"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_7a60a4cf","line":157,"range":{"start_line":157,"start_character":17,"end_line":157,"end_character":25},"in_reply_to":"1a122d0e_2941d0a9","updated":"2016-04-20 05:51:09.000000000","message":"priority is one of key parameters should be passed from caller, same as vrouter_id and ha_cidr","commit_id":"22bb938346859306a4f7a6f6d704f6ce104de8c6"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"41283e4ca5e76fe563871d5bf8947104a6354ee0","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    \"\"\"Instance section of a keepalived configuration.\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, state, interface, vrouter_id, ha_cidrs,"},{"line_number":157,"context_line":"                 priority, advert_int\u003dNone,"},{"line_number":158,"context_line":"                 mcast_src_ip\u003dNone, nopreempt\u003dFalse,"},{"line_number":159,"context_line":"                 garp_master_delay\u003dGARP_MASTER_DELAY):"},{"line_number":160,"context_line":"        self.name \u003d \u0027VR_%s\u0027 % vrouter_id"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_e1641623","line":157,"range":{"start_line":157,"start_character":17,"end_line":157,"end_character":25},"in_reply_to":"1a122d0e_5ebdf200","updated":"2016-04-20 01:24:52.000000000","message":"The test you mentioned would not beak, because priority came from below:\nhttps://github.com/openstack/neutron/blob/master/neutron/agent/l3/ha_router.py#L44\n\nI have modified it:\n\n@property\n    def ha_priority(self):\n        return self.router.get(\u0027priority\u0027,\n                               self.agent_conf.ha_vrrp_default_priority)\n\nWe prefer to change all  invocations instead of adding more complex and useless check such as:\n\nself.priority \u003d cfg.CONF.ha_default_priority if priority is None else priority","commit_id":"22bb938346859306a4f7a6f6d704f6ce104de8c6"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"5e1384cdcfe42eb9c6036eec20975e2ceba4c591","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    \"\"\"Instance section of a keepalived configuration.\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, state, interface, vrouter_id, ha_cidrs,"},{"line_number":157,"context_line":"                 priority, advert_int\u003dNone,"},{"line_number":158,"context_line":"                 mcast_src_ip\u003dNone, nopreempt\u003dFalse,"},{"line_number":159,"context_line":"                 garp_master_delay\u003dGARP_MASTER_DELAY):"},{"line_number":160,"context_line":"        self.name \u003d \u0027VR_%s\u0027 % vrouter_id"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_e39eb505","line":157,"range":{"start_line":157,"start_character":17,"end_line":157,"end_character":25},"in_reply_to":"1a122d0e_7a60a4cf","updated":"2016-04-20 15:00:31.000000000","message":"@yaowei -- not sure I follow your response W/R/T ha_router. As I indicated at least 1 consumer creates a KeepalivedInstance passing \u0027priority\u0027 as a kwarg. That caller would be broken with this change as far as I can see. Although the following statement maybe useless:\n\nself.priority \u003d cfg.CONF.ha_default_priority if priority is None else priority\n\nIt allows you to keep priority as a kwarg and still default the conf value. Its not clear to me if out-of-tree consumers would be using this class, but if they are, they will be broken as well.\n\n\n@Akihiro Motoki -- I respectfully disagree that we should leave HA_DEFAULT_PRIORITY and use it as the default. IMHO the default should be defined in 1 place only and in this case thats the conf opt. Again, just my $0.02.","commit_id":"22bb938346859306a4f7a6f6d704f6ce104de8c6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0edac9845d8730650c9f51b355daca3998315b70","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    \"\"\"Instance section of a keepalived configuration.\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, state, interface, vrouter_id, ha_cidrs,"},{"line_number":157,"context_line":"                 priority, advert_int\u003dNone,"},{"line_number":158,"context_line":"                 mcast_src_ip\u003dNone, nopreempt\u003dFalse,"},{"line_number":159,"context_line":"                 garp_master_delay\u003dGARP_MASTER_DELAY):"},{"line_number":160,"context_line":"        self.name \u003d \u0027VR_%s\u0027 % vrouter_id"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_2941d0a9","line":157,"range":{"start_line":157,"start_character":17,"end_line":157,"end_character":25},"in_reply_to":"1a122d0e_e1641623","updated":"2016-04-20 04:12:20.000000000","message":"I don\u0027t think you need to change priority\u003dHA_DEFAULT_PRIORITY to priority. HA_DEFAULT_PRIORITY is defined in this module and having some default value in keepalived module makes sense.\n\n\"ha_priority\" is a part of a caller. It is not a good idea that the behavior of this module (keepalived module) depends on how a caller behaves.","commit_id":"22bb938346859306a4f7a6f6d704f6ce104de8c6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9eaa38024566a23263c8f41bcdea7fc4156e4a70","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    \"\"\"Instance section of a keepalived configuration.\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, state, interface, vrouter_id, ha_cidrs,"},{"line_number":157,"context_line":"                 priority, advert_int\u003dNone,"},{"line_number":158,"context_line":"                 mcast_src_ip\u003dNone, nopreempt\u003dFalse,"},{"line_number":159,"context_line":"                 garp_master_delay\u003dGARP_MASTER_DELAY):"},{"line_number":160,"context_line":"        self.name \u003d \u0027VR_%s\u0027 % vrouter_id"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_9cec492b","line":157,"range":{"start_line":157,"start_character":17,"end_line":157,"end_character":25},"in_reply_to":"1a122d0e_e39eb505","updated":"2016-04-21 12:52:31.000000000","message":"Hmm.. In the recent code, you use HA_DEFAULT_PRIORITY as the default value. It is different from your above statement... just a question.","commit_id":"22bb938346859306a4f7a6f6d704f6ce104de8c6"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"28d9907b47b810777589cadb8b96e54e0a06264b","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        self.state \u003d state"},{"line_number":166,"context_line":"        self.interface \u003d interface"},{"line_number":167,"context_line":"        self.vrouter_id \u003d vrouter_id"},{"line_number":168,"context_line":"        if priority:"},{"line_number":169,"context_line":"            self.priority \u003d priority"},{"line_number":170,"context_line":"        else:"},{"line_number":171,"context_line":"            self.priority \u003d constants.HA_VRRP_DEFAULT_PRIORITY"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_eaf02169","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":20},"updated":"2016-04-21 07:53:52.000000000","message":"I think it should be \"if priority is not None:\". The priority could be 0 in keepalived, however, it is not used in a normal case. We should avoid the confusion here.","commit_id":"69ec2a7fd5cb9ea966b8ed340c4e65c0552e00e6"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"a3db5c07176023c0fc5fd6aca395e1b9e2ad6968","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        self.state \u003d state"},{"line_number":166,"context_line":"        self.interface \u003d interface"},{"line_number":167,"context_line":"        self.vrouter_id \u003d vrouter_id"},{"line_number":168,"context_line":"        if priority:"},{"line_number":169,"context_line":"            self.priority \u003d priority"},{"line_number":170,"context_line":"        else:"},{"line_number":171,"context_line":"            self.priority \u003d constants.HA_VRRP_DEFAULT_PRIORITY"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_9048bccd","line":168,"range":{"start_line":168,"start_character":0,"end_line":168,"end_character":20},"in_reply_to":"1a122d0e_eaf02169","updated":"2016-04-21 08:34:32.000000000","message":"Done","commit_id":"69ec2a7fd5cb9ea966b8ed340c4e65c0552e00e6"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"a1dca64260ca1fe7f67ee5b11e7060041dcbb972","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    \"\"\"Instance section of a keepalived configuration.\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, state, interface, vrouter_id, ha_cidrs,"},{"line_number":157,"context_line":"                 priority\u003dNone, advert_int\u003dNone,"},{"line_number":158,"context_line":"                 mcast_src_ip\u003dNone, nopreempt\u003dFalse,"},{"line_number":159,"context_line":"                 garp_master_delay\u003dGARP_MASTER_DELAY):"},{"line_number":160,"context_line":"        self.name \u003d \u0027VR_%s\u0027 % vrouter_id"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_4b08202e","line":157,"range":{"start_line":157,"start_character":26,"end_line":157,"end_character":30},"updated":"2016-04-21 15:33:05.000000000","message":"So now that the conf opt sets it default via constants.HA_VRRP_DEFAULT_PRIORITY it seems this could also:\n\npriority\u003dconstants.HA_VRRP_DEFAULT_PRIORITY\n\nIf you do that then the if/else added below is not needed. I don\u0027t think there\u0027s an issue using a constant as a default value, but there is an issue using a config opt itself (my initial comment a few patch sets ago).","commit_id":"256ef880cd41eaacbe3017111c67a498588cfc43"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"49f2dcad919a81d06c055de67f358ef9525ae1ff","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    \"\"\"Instance section of a keepalived configuration.\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, state, interface, vrouter_id, ha_cidrs,"},{"line_number":157,"context_line":"                 priority\u003dNone, advert_int\u003dNone,"},{"line_number":158,"context_line":"                 mcast_src_ip\u003dNone, nopreempt\u003dFalse,"},{"line_number":159,"context_line":"                 garp_master_delay\u003dGARP_MASTER_DELAY):"},{"line_number":160,"context_line":"        self.name \u003d \u0027VR_%s\u0027 % vrouter_id"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_a6e64b42","line":157,"range":{"start_line":157,"start_character":26,"end_line":157,"end_character":30},"in_reply_to":"1a122d0e_4b08202e","updated":"2016-04-21 15:34:51.000000000","message":"Nice suggestion","commit_id":"256ef880cd41eaacbe3017111c67a498588cfc43"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"5a10392532ca1686586f30a53b70b2f4846c7cf7","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    \"\"\"Instance section of a keepalived configuration.\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, state, interface, vrouter_id, ha_cidrs,"},{"line_number":157,"context_line":"                 priority\u003dNone, advert_int\u003dNone,"},{"line_number":158,"context_line":"                 mcast_src_ip\u003dNone, nopreempt\u003dFalse,"},{"line_number":159,"context_line":"                 garp_master_delay\u003dGARP_MASTER_DELAY):"},{"line_number":160,"context_line":"        self.name \u003d \u0027VR_%s\u0027 % vrouter_id"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_05dc5417","line":157,"range":{"start_line":157,"start_character":26,"end_line":157,"end_character":30},"in_reply_to":"1a122d0e_4b08202e","updated":"2016-04-21 16:11:46.000000000","message":"thx","commit_id":"256ef880cd41eaacbe3017111c67a498588cfc43"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"5a10392532ca1686586f30a53b70b2f4846c7cf7","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    \"\"\"Instance section of a keepalived configuration.\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def __init__(self, state, interface, vrouter_id, ha_cidrs,"},{"line_number":157,"context_line":"                 priority\u003dNone, advert_int\u003dNone,"},{"line_number":158,"context_line":"                 mcast_src_ip\u003dNone, nopreempt\u003dFalse,"},{"line_number":159,"context_line":"                 garp_master_delay\u003dGARP_MASTER_DELAY):"},{"line_number":160,"context_line":"        self.name \u003d \u0027VR_%s\u0027 % vrouter_id"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_45e64ce9","line":157,"range":{"start_line":157,"start_character":26,"end_line":157,"end_character":30},"in_reply_to":"1a122d0e_a6e64b42","updated":"2016-04-21 16:11:46.000000000","message":"Done","commit_id":"256ef880cd41eaacbe3017111c67a498588cfc43"}],"neutron/tests/unit/agent/linux/test_keepalived.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4feb0e8cd46d5df2d79807ab436bd4b031e7f7ab","unresolved":false,"context_lines":[{"line_number":308,"context_line":"            \u0027MASTER\u0027, \u0027eth0\u0027, 1, [\u0027169.254.192.0/18\u0027])"},{"line_number":309,"context_line":"        self.assertEqual(expected, \u0027\\n\u0027.join(instance.build_config()))"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def test_build_priority_from_cfg(self):"},{"line_number":312,"context_line":"        instance \u003d keepalived.KeepalivedInstance(\u0027MASTER\u0027, \u0027ha0\u0027, 42,"},{"line_number":313,"context_line":"                                                 [\u0027169.254.192.0/18\u0027])"},{"line_number":314,"context_line":"        self.assertEqual(instance.priority, cfg.CONF.ha_default_priority)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_39e963e7","line":311,"updated":"2016-04-18 21:08:57.000000000","message":"Seems like we should also verify the non-default conf value can be used by setting it in a test to a non-default value and ensuring its used in the KeepalivedInstance","commit_id":"66b14cd3bfaa34c2d0dcd29357217f53d27c0505"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"6ef82050baf4c91c1797c93cee23898f4f0c2c78","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        instance \u003d keepalived.KeepalivedInstance("},{"line_number":307,"context_line":"            \u0027MASTER\u0027, \u0027eth0\u0027, 1, [\u0027169.254.192.0/18\u0027], 50)"},{"line_number":308,"context_line":"        self.assertEqual(expected, \u0027\\n\u0027.join(instance.build_config()))"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"class KeepalivedVipAddressTestCase(base.BaseTestCase):"},{"line_number":312,"context_line":"    def test_vip_with_scope(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_8eb138e4","line":309,"updated":"2016-04-19 09:50:46.000000000","message":"It would be better to add a test case to make sure the priority that in the output config, is the same value as the one that is passed to KeepalivedInstance","commit_id":"c06bb373ab1c97b74fd8b5f90aad972f1494c6ae"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"360344aa6a20bc15284309187a7be0eea94e38cc","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        instance \u003d keepalived.KeepalivedInstance("},{"line_number":307,"context_line":"            \u0027MASTER\u0027, \u0027eth0\u0027, 1, [\u0027169.254.192.0/18\u0027], 50)"},{"line_number":308,"context_line":"        self.assertEqual(expected, \u0027\\n\u0027.join(instance.build_config()))"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"class KeepalivedVipAddressTestCase(base.BaseTestCase):"},{"line_number":312,"context_line":"    def test_vip_with_scope(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_e04d4b3f","line":309,"in_reply_to":"1a122d0e_8eb138e4","updated":"2016-04-19 14:36:17.000000000","message":"Done","commit_id":"c06bb373ab1c97b74fd8b5f90aad972f1494c6ae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0edac9845d8730650c9f51b355daca3998315b70","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        instance1 \u003d keepalived.KeepalivedInstance(\u0027MASTER\u0027, \u0027eth0\u0027, 1,"},{"line_number":65,"context_line":"                                                  [\u0027169.254.192.0/18\u0027],"},{"line_number":66,"context_line":"                                                  50, advert_int\u003d5)"},{"line_number":67,"context_line":"        instance1.set_authentication(\u0027AH\u0027, \u0027pass123\u0027)"},{"line_number":68,"context_line":"        instance1.track_interfaces.append(\"eth0\")"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_a961603b","line":66,"updated":"2016-04-20 04:12:20.000000000","message":"If you drop the change of priority argument, these changes will be unnecessary.","commit_id":"22bb938346859306a4f7a6f6d704f6ce104de8c6"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"28d9907b47b810777589cadb8b96e54e0a06264b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                                 KeepalivedConfBaseMixin):"},{"line_number":238,"context_line":"    def test_get_primary_vip(self):"},{"line_number":239,"context_line":"        instance \u003d keepalived.KeepalivedInstance(\u0027MASTER\u0027, \u0027ha0\u0027, 42,"},{"line_number":240,"context_line":"                                                 [\u0027169.254.192.0/18\u0027], 50)"},{"line_number":241,"context_line":"        self.assertEqual(\u0027169.254.0.42/24\u0027, instance.get_primary_vip())"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def test_remove_addresses_by_interface(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_3511da52","line":240,"range":{"start_line":240,"start_character":69,"end_line":240,"end_character":73},"updated":"2016-04-21 07:53:52.000000000","message":"You could avoid change this line","commit_id":"69ec2a7fd5cb9ea966b8ed340c4e65c0552e00e6"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"a3db5c07176023c0fc5fd6aca395e1b9e2ad6968","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                                 KeepalivedConfBaseMixin):"},{"line_number":238,"context_line":"    def test_get_primary_vip(self):"},{"line_number":239,"context_line":"        instance \u003d keepalived.KeepalivedInstance(\u0027MASTER\u0027, \u0027ha0\u0027, 42,"},{"line_number":240,"context_line":"                                                 [\u0027169.254.192.0/18\u0027], 50)"},{"line_number":241,"context_line":"        self.assertEqual(\u0027169.254.0.42/24\u0027, instance.get_primary_vip())"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def test_remove_addresses_by_interface(self):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_f036504f","line":240,"range":{"start_line":240,"start_character":69,"end_line":240,"end_character":73},"in_reply_to":"1a122d0e_3511da52","updated":"2016-04-21 08:34:32.000000000","message":"Done","commit_id":"69ec2a7fd5cb9ea966b8ed340c4e65c0552e00e6"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"28d9907b47b810777589cadb8b96e54e0a06264b","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def test_add_vip_idempotent(self):"},{"line_number":325,"context_line":"        instance \u003d keepalived.KeepalivedInstance(\u0027MASTER\u0027, \u0027eth0\u0027, 1,"},{"line_number":326,"context_line":"                                                 [\u0027169.254.192.0/18\u0027], 50)"},{"line_number":327,"context_line":"        instance.add_vip(\u0027192.168.222.1/32\u0027, \u0027eth11\u0027, None)"},{"line_number":328,"context_line":"        instance.add_vip(\u0027192.168.222.1/32\u0027, \u0027eth12\u0027, \u0027link\u0027)"},{"line_number":329,"context_line":"        self.assertEqual(1, len(instance.vips))"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_7517d244","line":326,"range":{"start_line":326,"start_character":69,"end_line":326,"end_character":73},"updated":"2016-04-21 07:53:52.000000000","message":"ditto","commit_id":"69ec2a7fd5cb9ea966b8ed340c4e65c0552e00e6"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"a3db5c07176023c0fc5fd6aca395e1b9e2ad6968","unresolved":false,"context_lines":[{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    def test_add_vip_idempotent(self):"},{"line_number":325,"context_line":"        instance \u003d keepalived.KeepalivedInstance(\u0027MASTER\u0027, \u0027eth0\u0027, 1,"},{"line_number":326,"context_line":"                                                 [\u0027169.254.192.0/18\u0027], 50)"},{"line_number":327,"context_line":"        instance.add_vip(\u0027192.168.222.1/32\u0027, \u0027eth11\u0027, None)"},{"line_number":328,"context_line":"        instance.add_vip(\u0027192.168.222.1/32\u0027, \u0027eth12\u0027, \u0027link\u0027)"},{"line_number":329,"context_line":"        self.assertEqual(1, len(instance.vips))"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_5042a4ae","line":326,"range":{"start_line":326,"start_character":69,"end_line":326,"end_character":73},"in_reply_to":"1a122d0e_7517d244","updated":"2016-04-21 08:34:32.000000000","message":"Done","commit_id":"69ec2a7fd5cb9ea966b8ed340c4e65c0552e00e6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"207c3f812474895a42b59fc692befa8fd2360e71","unresolved":false,"context_lines":[{"line_number":307,"context_line":"            \u0027MASTER\u0027, \u0027eth0\u0027, 1, [\u0027169.254.192.0/18\u0027])"},{"line_number":308,"context_line":"        self.assertEqual(expected, \u0027\\n\u0027.join(instance.build_config()))"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def test_priority_with_given_value(self):"},{"line_number":311,"context_line":"        instance \u003d keepalived.KeepalivedInstance("},{"line_number":312,"context_line":"            \u0027MASTER\u0027, \u0027eth0\u0027, 1, [\u0027169.254.192.0/18\u0027], 70)"},{"line_number":313,"context_line":"        self.assertEqual(70, instance.priority)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"class KeepalivedVipAddressTestCase(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_4fe8f57c","line":313,"range":{"start_line":310,"start_character":4,"end_line":313,"end_character":47},"updated":"2016-04-22 16:27:25.000000000","message":"is this testing var assignment? seems unrelated and useless imo","commit_id":"ba56e8d1d7d9d98fca93d1c9821ac79ed7ca4596"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"d9bd8ccbcd5427e833e3d0255b1b2df1b72c9835","unresolved":false,"context_lines":[{"line_number":307,"context_line":"            \u0027MASTER\u0027, \u0027eth0\u0027, 1, [\u0027169.254.192.0/18\u0027])"},{"line_number":308,"context_line":"        self.assertEqual(expected, \u0027\\n\u0027.join(instance.build_config()))"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def test_priority_with_given_value(self):"},{"line_number":311,"context_line":"        instance \u003d keepalived.KeepalivedInstance("},{"line_number":312,"context_line":"            \u0027MASTER\u0027, \u0027eth0\u0027, 1, [\u0027169.254.192.0/18\u0027], 70)"},{"line_number":313,"context_line":"        self.assertEqual(70, instance.priority)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"class KeepalivedVipAddressTestCase(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a122d0e_3c968394","line":313,"range":{"start_line":310,"start_character":4,"end_line":313,"end_character":47},"in_reply_to":"1a122d0e_4fe8f57c","updated":"2016-04-23 03:19:57.000000000","message":"it\u0027s  a test case to make sure the priority that in the output config is the same one passed to KeepAlivedInstance","commit_id":"ba56e8d1d7d9d98fca93d1c9821ac79ed7ca4596"}],"releasenotes/notes/ha-default-priority-f70a0c6268b64857.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"829cc286fe9f16bb39179024496a85541feba04e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - A previously unused configuration value"},{"line_number":4,"context_line":"    ha_default_priority is now used to configure default"},{"line_number":5,"context_line":"    priority of vrrp(managed by keepalived)."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a122d0e_30afd695","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2016-04-18 10:40:05.000000000","message":"features","commit_id":"99c28e7a3ca4e094220f26469ab5e8d6d81fc84f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"829cc286fe9f16bb39179024496a85541feba04e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - A previously unused configuration value"},{"line_number":4,"context_line":"    ha_default_priority is now used to configure default"},{"line_number":5,"context_line":"    priority of vrrp(managed by keepalived)."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a122d0e_10a29aae","line":5,"updated":"2016-04-18 10:40:05.000000000","message":"Consider:\n\n  A new configuration parameter ``ha_default_priority``\n  to allow operators to configure the default priority of VRRP\n  (managed by keepalived).\n\nIn addition, it would be great if there is some example\nwhere this option is useful.","commit_id":"99c28e7a3ca4e094220f26469ab5e8d6d81fc84f"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"4feb0e8cd46d5df2d79807ab436bd4b031e7f7ab","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":" - A new configuration parameter ``ha_default_priority``"},{"line_number":4,"context_line":"   to allow operators to configure the default priority of"},{"line_number":5,"context_line":"   VRRP(managed by keepalived). Operators can now make a"},{"line_number":6,"context_line":"   special network node of multiple network nodes trend to act"},{"line_number":7,"context_line":"   as master by configuring higher ``ha_default_priority`` of"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_99a517b7","line":4,"range":{"start_line":4,"start_character":3,"end_line":4,"end_character":11},"updated":"2016-04-18 21:08:57.000000000","message":"...that allows operators...","commit_id":"66b14cd3bfaa34c2d0dcd29357217f53d27c0505"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4e5ef9eb6c0c0d5acd1fc698e959c21727de5a61","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":" - A new configuration parameter ``ha_default_priority``"},{"line_number":4,"context_line":"   to allow operators to configure the default priority of"},{"line_number":5,"context_line":"   VRRP(managed by keepalived). Operators can now make a"},{"line_number":6,"context_line":"   special network node of multiple network nodes trend to act"},{"line_number":7,"context_line":"   as master by configuring higher ``ha_default_priority`` of"},{"line_number":8,"context_line":"   l3 agent running on that network node."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_01b1a4e1","line":5,"updated":"2016-04-18 14:26:06.000000000","message":"nit: a space is needed between VRRP and (.","commit_id":"66b14cd3bfaa34c2d0dcd29357217f53d27c0505"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"90616637dfa9ba32b4813f69260c9ab97601bf61","unresolved":false,"context_lines":[{"line_number":3,"context_line":" - A new configuration parameter ``ha_default_priority``"},{"line_number":4,"context_line":"   to allow operators to configure the default priority of"},{"line_number":5,"context_line":"   VRRP(managed by keepalived). Operators can now make a"},{"line_number":6,"context_line":"   special network node of multiple network nodes trend to act"},{"line_number":7,"context_line":"   as master by configuring higher ``ha_default_priority`` of"},{"line_number":8,"context_line":"   l3 agent running on that network node."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_dc478f75","line":6,"range":{"start_line":6,"start_character":11,"end_line":6,"end_character":49},"updated":"2016-04-18 14:46:25.000000000","message":"of -\u003e or ?","commit_id":"66b14cd3bfaa34c2d0dcd29357217f53d27c0505"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4e5ef9eb6c0c0d5acd1fc698e959c21727de5a61","unresolved":false,"context_lines":[{"line_number":5,"context_line":"   VRRP(managed by keepalived). Operators can now make a"},{"line_number":6,"context_line":"   special network node of multiple network nodes trend to act"},{"line_number":7,"context_line":"   as master by configuring higher ``ha_default_priority`` of"},{"line_number":8,"context_line":"   l3 agent running on that network node."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a122d0e_41f9dc7f","line":8,"updated":"2016-04-18 14:26:06.000000000","message":"I am not sure an actual use case but it is okay.","commit_id":"66b14cd3bfaa34c2d0dcd29357217f53d27c0505"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"cac3c42ba0b6c362926e7e4c6b5960727224ec72","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":" - A new configuration parameter ``ha_vrrp_default_priority``"},{"line_number":4,"context_line":"   that allows operators to configure the default priority of"},{"line_number":5,"context_line":"   VRRP (managed by keepalived). Operators can now make a"},{"line_number":6,"context_line":"   special network node of multiple network nodes trend to act"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_4b3557f5","line":3,"updated":"2016-04-19 08:10:29.000000000","message":"How about renaming this file as \"ha-vrrp-default-priority-f70a0c6268b64857.yaml\"","commit_id":"c59fff1d05407606799ba15a13827c3f28caaf80"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"86ebea261ba049d717a01ae71e579f5a45a533f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":" - A new configuration parameter ``ha_vrrp_default_priority``"},{"line_number":4,"context_line":"   that allows operators to configure the default priority of"},{"line_number":5,"context_line":"   VRRP (managed by keepalived). Operators can now make a"},{"line_number":6,"context_line":"   special network node of multiple network nodes trend to act"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a122d0e_66ea0a11","line":3,"in_reply_to":"1a122d0e_4b3557f5","updated":"2016-04-19 08:16:49.000000000","message":"Done","commit_id":"c59fff1d05407606799ba15a13827c3f28caaf80"}],"releasenotes/notes/ha-vrrp-priority-f70a0c6268b64857.yaml":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c3c83f1e592c5ad484f0bcbd8fedea6a5de5210c","unresolved":false,"context_lines":[{"line_number":3,"context_line":" - A new configuration parameter ``ha_vrrp_priority``"},{"line_number":4,"context_line":"   that allows operators to configure the default priority of"},{"line_number":5,"context_line":"   VRRP (managed by keepalived). Operators can now make a"},{"line_number":6,"context_line":"   special network node of multiple network nodes trend to act"},{"line_number":7,"context_line":"   as master by configuring higher ``ha_vrrp_priority``"},{"line_number":8,"context_line":"   of l3 agent running on that network node."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"dab17558_d573b513","line":6,"range":{"start_line":6,"start_character":50,"end_line":6,"end_character":55},"updated":"2016-05-10 02:01:28.000000000","message":"this sentence does not make sense to me","commit_id":"9d4d47ec9f97a35726bb826981e683797661b704"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0a4008ee2d6f330179ef60318b73b3ab6efa9af4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":" - A new configuration parameter ``ha_vrrp_priority``"},{"line_number":4,"context_line":"   that allows operators to configure the default priority of"},{"line_number":5,"context_line":"   VRRP (managed by keepalived). Operators can now make a"},{"line_number":6,"context_line":"   special network node of multiple network nodes act"},{"line_number":7,"context_line":"   as master by configuring higher ``ha_vrrp_priority``"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"dab17558_41cee3b4","line":4,"range":{"start_line":4,"start_character":42,"end_line":4,"end_character":49},"updated":"2016-05-10 04:43:46.000000000","message":"it allows to manage the priority of VRRP which is by default 50 so in that case default make less sense here.","commit_id":"4104df3ca8e60c3c8e4f4ec1e22ecb56c94aa4cf"},{"author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"change_message_id":"3f5538375226c1e4899f342da747c09ec600cee2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":" - A new configuration parameter ``ha_vrrp_priority``"},{"line_number":4,"context_line":"   that allows operators to configure the default priority of"},{"line_number":5,"context_line":"   VRRP (managed by keepalived). Operators can now make a"},{"line_number":6,"context_line":"   special network node of multiple network nodes act"},{"line_number":7,"context_line":"   as master by configuring higher ``ha_vrrp_priority``"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"dab17558_c145b3b3","line":4,"range":{"start_line":4,"start_character":42,"end_line":4,"end_character":49},"in_reply_to":"dab17558_41cee3b4","updated":"2016-05-10 05:03:15.000000000","message":"Done","commit_id":"4104df3ca8e60c3c8e4f4ec1e22ecb56c94aa4cf"}]}