)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"b30f987ddfa738dc4924af37b25036b5fc04f879","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add check that external gw port exist when metering-agent adds a rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is no gateway port in router where metering-agent want to add"},{"line_number":10,"context_line":"a metering-label-rule method _process_metering_label_rules() will be failed"},{"line_number":11,"context_line":"with error \u0027cannot concatenate \u0027str\u0027 and \u0027NoneType\u0027 objects\u0027"},{"line_number":12,"context_line":"because there is no checking that router have an external gateway port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_5d36e652","line":9,"range":{"start_line":9,"start_character":1,"end_line":9,"end_character":63},"updated":"2016-04-18 12:01:14.000000000","message":"nit: I\u0027d paraphrase\nIf router has no gateway port when metering-agent wants ...","commit_id":"4e5ce134cdee8edc3246f67f4ec9542370325887"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"b30f987ddfa738dc4924af37b25036b5fc04f879","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add check that external gw port exist when metering-agent adds a rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is no gateway port in router where metering-agent want to add"},{"line_number":10,"context_line":"a metering-label-rule method _process_metering_label_rules() will be failed"},{"line_number":11,"context_line":"with error \u0027cannot concatenate \u0027str\u0027 and \u0027NoneType\u0027 objects\u0027"},{"line_number":12,"context_line":"because there is no checking that router have an external gateway port."},{"line_number":13,"context_line":"This patch adds this check and adds some unit test."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_5d0d468f","line":10,"range":{"start_line":10,"start_character":60,"end_line":10,"end_character":75},"updated":"2016-04-18 12:01:14.000000000","message":"nit: fails","commit_id":"4e5ce134cdee8edc3246f67f4ec9542370325887"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"b30f987ddfa738dc4924af37b25036b5fc04f879","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is no gateway port in router where metering-agent want to add"},{"line_number":10,"context_line":"a metering-label-rule method _process_metering_label_rules() will be failed"},{"line_number":11,"context_line":"with error \u0027cannot concatenate \u0027str\u0027 and \u0027NoneType\u0027 objects\u0027"},{"line_number":12,"context_line":"because there is no checking that router have an external gateway port."},{"line_number":13,"context_line":"This patch adds this check and adds some unit test."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_7d692225","line":11,"range":{"start_line":11,"start_character":59,"end_line":11,"end_character":60},"updated":"2016-04-18 12:01:14.000000000","message":"nit: \u0027 is redundant","commit_id":"4e5ce134cdee8edc3246f67f4ec9542370325887"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"5582230c984db7e7eaa5fa2f651067324bd81d4c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is no gateway port in router where metering-agent want to add"},{"line_number":10,"context_line":"a metering-label-rule method _process_metering_label_rules() will be failed"},{"line_number":11,"context_line":"with error \u0027cannot concatenate \u0027str\u0027 and \u0027NoneType\u0027 objects\u0027"},{"line_number":12,"context_line":"because there is no checking that router have an external gateway port."},{"line_number":13,"context_line":"This patch adds this check and adds some unit test."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_d8ffa4a8","line":11,"range":{"start_line":11,"start_character":59,"end_line":11,"end_character":60},"in_reply_to":"1a122d0e_7d692225","updated":"2016-04-18 12:11:45.000000000","message":"I will change it to double quotation to avoid confusion","commit_id":"4e5ce134cdee8edc3246f67f4ec9542370325887"},{"author":{"_account_id":13717,"name":"Inessa Vasilevskaya","email":"ivasilevskaya@mirantis.com","username":"ivasilevskaya"},"change_message_id":"b30f987ddfa738dc4924af37b25036b5fc04f879","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If there is no gateway port in router where metering-agent want to add"},{"line_number":10,"context_line":"a metering-label-rule method _process_metering_label_rules() will be failed"},{"line_number":11,"context_line":"with error \u0027cannot concatenate \u0027str\u0027 and \u0027NoneType\u0027 objects\u0027"},{"line_number":12,"context_line":"because there is no checking that router have an external gateway port."},{"line_number":13,"context_line":"This patch adds this check and adds some unit test."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-bug: #1527274"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_3d5e8a76","line":12,"range":{"start_line":12,"start_character":20,"end_line":12,"end_character":45},"updated":"2016-04-18 12:01:14.000000000","message":"nit: check that router has","commit_id":"4e5ce134cdee8edc3246f67f4ec9542370325887"},{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"5582230c984db7e7eaa5fa2f651067324bd81d4c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If there is no gateway port in router where metering-agent want to add"},{"line_number":10,"context_line":"a metering-label-rule method _process_metering_label_rules() will be failed"},{"line_number":11,"context_line":"with error \u0027cannot concatenate \u0027str\u0027 and \u0027NoneType\u0027 objects\u0027"},{"line_number":12,"context_line":"because there is no checking that router have an external gateway port."},{"line_number":13,"context_line":"This patch adds this check and adds some unit test."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-bug: #1527274"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_986ecc94","line":12,"range":{"start_line":12,"start_character":20,"end_line":12,"end_character":45},"in_reply_to":"1a122d0e_3d5e8a76","updated":"2016-04-18 12:11:45.000000000","message":"Thanks for review, Inessa :) All nits are fixed in next PS","commit_id":"4e5ce134cdee8edc3246f67f4ec9542370325887"}],"neutron/tests/unit/services/metering/drivers/test_iptables.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6e254f1badd97e5b10288b74e4f3435820adbcf8","unresolved":false,"context_lines":[{"line_number":192,"context_line":"                                    wrap\u003dFalse),"},{"line_number":193,"context_line":"                 mock.call.add_rule(\u0027neutron-meter-l-eeef45da-c60\u0027,"},{"line_number":194,"context_line":"                                    \u0027\u0027,"},{"line_number":195,"context_line":"                                    wrap\u003dFalse)]"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        self.v4filter_inst.assert_has_calls(calls, any_order\u003dFalse)"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_86b8a576","line":195,"updated":"2016-04-20 18:01:03.000000000","message":"My only nit is that this is duplicating a lot of code from the above test, where maybe putting this in a common method that took an arg would be better.  But then we didn\u0027t follow that below, so I don\u0027t see a strong need to change it.","commit_id":"f73dae0a65a6b63cffae5c5e3c2f98d4f0e35ccf"}]}
