)]}'
{"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":11784,"name":"Chirag Shahani","email":"chirag.shahani@gmail.com","username":"cshahani"},"change_message_id":"7030553ccac60d4d0105ef6557b37fa140afbc88","unresolved":false,"context_lines":[{"line_number":760,"context_line":"    return cfg.CONF.l3_ha"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"def is_distributed_router(router):"},{"line_number":764,"context_line":"    \"\"\"Return True if router to be handled is distributed.\"\"\""},{"line_number":765,"context_line":"    try:"},{"line_number":766,"context_line":"        # See if router is a DB object first"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_38dc3c45","line":763,"range":{"start_line":763,"start_character":4,"end_line":763,"end_character":25},"updated":"2016-04-21 00:48:30.000000000","message":"Can this be a static method?","commit_id":"3c718b7da45922e76c99cdf55996e521a8e76bd9"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"a32abf08557fbd93fa96626a26b12797cd758d52","unresolved":false,"context_lines":[{"line_number":760,"context_line":"    return cfg.CONF.l3_ha"},{"line_number":761,"context_line":""},{"line_number":762,"context_line":""},{"line_number":763,"context_line":"def is_distributed_router(router):"},{"line_number":764,"context_line":"    \"\"\"Return True if router to be handled is distributed.\"\"\""},{"line_number":765,"context_line":"    try:"},{"line_number":766,"context_line":"        # See if router is a DB object first"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_ddaaf618","line":763,"range":{"start_line":763,"start_character":4,"end_line":763,"end_character":25},"in_reply_to":"1a122d0e_38dc3c45","updated":"2016-04-22 19:28:57.000000000","message":"This is actually outside any class. It top-level so no need to make it static. I am not sure you can actually. It could be moved somewhere else, but since the is_ha_router is already here, it might be best to keep them together.","commit_id":"3c718b7da45922e76c99cdf55996e521a8e76bd9"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"165fe596b4947fa72610329292caca2ad2f4ccbc","unresolved":false,"context_lines":[{"line_number":428,"context_line":"            ha \u003d cfg.CONF.l3_ha"},{"line_number":429,"context_line":"        return ha"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def _get_device_owner(self, context, router\u003dNone):"},{"line_number":432,"context_line":"        \"\"\"Get device_owner for the specified router.\"\"\""},{"line_number":433,"context_line":"        router_is_uuid \u003d isinstance(router, six.string_types)"},{"line_number":434,"context_line":"        if router_is_uuid:"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_dd5fe1e2","line":431,"range":{"start_line":431,"start_character":41,"end_line":431,"end_character":47},"updated":"2016-05-17 20:19:11.000000000","message":"Is this supposed to be a DB object or a REST request object?  If the answer is \"it depends\" then I think we really need to refactor this code.","commit_id":"fc3c8a5637e7f1a8d853d173d561aad767920a35"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"a6b206ac6a5729bcf214ad1d03bc511b7460f094","unresolved":false,"context_lines":[{"line_number":428,"context_line":"            ha \u003d cfg.CONF.l3_ha"},{"line_number":429,"context_line":"        return ha"},{"line_number":430,"context_line":""},{"line_number":431,"context_line":"    def _get_device_owner(self, context, router\u003dNone):"},{"line_number":432,"context_line":"        \"\"\"Get device_owner for the specified router.\"\"\""},{"line_number":433,"context_line":"        router_is_uuid \u003d isinstance(router, six.string_types)"},{"line_number":434,"context_line":"        if router_is_uuid:"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_17aeaf80","line":431,"range":{"start_line":431,"start_character":41,"end_line":431,"end_character":47},"in_reply_to":"dab17558_dd5fe1e2","updated":"2016-05-20 17:24:24.000000000","message":"excellent question. I was trying to keep this patch as simple as possible so I just used the existing code. Look at my answers to assaf\u0027s and swamis comments below.","commit_id":"fc3c8a5637e7f1a8d853d173d561aad767920a35"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"e325f7bea55fdfa7348a133010e58998f835790a","unresolved":false,"context_lines":[{"line_number":762,"context_line":"    return cfg.CONF.l3_ha"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"def is_distributed_router(router):"},{"line_number":766,"context_line":"    \"\"\"Return True if router to be handled is distributed.\"\"\""},{"line_number":767,"context_line":"    try:"},{"line_number":768,"context_line":"        # See if router is a DB object first"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_19b254e5","line":765,"updated":"2016-05-19 23:09:54.000000000","message":"This function already exists in l3_dvr_db.py, can we move it to a shared location and use it from both?","commit_id":"fc3c8a5637e7f1a8d853d173d561aad767920a35"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"a6b206ac6a5729bcf214ad1d03bc511b7460f094","unresolved":false,"context_lines":[{"line_number":762,"context_line":"    return cfg.CONF.l3_ha"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"def is_distributed_router(router):"},{"line_number":766,"context_line":"    \"\"\"Return True if router to be handled is distributed.\"\"\""},{"line_number":767,"context_line":"    try:"},{"line_number":768,"context_line":"        # See if router is a DB object first"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_97fa9f41","line":765,"in_reply_to":"bab6814e_631b05cb","updated":"2016-05-20 17:24:24.000000000","message":"I think that would be a better approach.","commit_id":"fc3c8a5637e7f1a8d853d173d561aad767920a35"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"7338eef334c594913b55a28fc00cbd60f4821fef","unresolved":false,"context_lines":[{"line_number":762,"context_line":"    return cfg.CONF.l3_ha"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"def is_distributed_router(router):"},{"line_number":766,"context_line":"    \"\"\"Return True if router to be handled is distributed.\"\"\""},{"line_number":767,"context_line":"    try:"},{"line_number":768,"context_line":"        # See if router is a DB object first"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_631b05cb","line":765,"in_reply_to":"dab17558_19b254e5","updated":"2016-05-20 15:41:07.000000000","message":"Probably we can make it part of the utils, where is_dvr_serviced function is.","commit_id":"fc3c8a5637e7f1a8d853d173d561aad767920a35"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"a6b206ac6a5729bcf214ad1d03bc511b7460f094","unresolved":false,"context_lines":[{"line_number":762,"context_line":"    return cfg.CONF.l3_ha"},{"line_number":763,"context_line":""},{"line_number":764,"context_line":""},{"line_number":765,"context_line":"def is_distributed_router(router):"},{"line_number":766,"context_line":"    \"\"\"Return True if router to be handled is distributed.\"\"\""},{"line_number":767,"context_line":"    try:"},{"line_number":768,"context_line":"        # See if router is a DB object first"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_f7d32bd3","line":765,"in_reply_to":"dab17558_19b254e5","updated":"2016-05-20 17:24:24.000000000","message":"yes. however I tried using the call directlry from there. This package already imports l3_dvr_db.py, but if you make the call directly from there, upstream tests completely fail. \nI think there is an import problem somewhere. Look at PS 5.\nI\u0027ll try\u0027 swami\u0027s suggestion below.","commit_id":"fc3c8a5637e7f1a8d853d173d561aad767920a35"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"165fe596b4947fa72610329292caca2ad2f4ccbc","unresolved":false,"context_lines":[{"line_number":768,"context_line":"        # See if router is a DB object first"},{"line_number":769,"context_line":"        requested_router_type \u003d router.extra_attributes.distributed"},{"line_number":770,"context_line":"    except AttributeError:"},{"line_number":771,"context_line":"        # if not, try to see if it is a request body"},{"line_number":772,"context_line":"        requested_router_type \u003d router.get(\u0027distributed\u0027)"},{"line_number":773,"context_line":"    if attributes.is_attr_set(requested_router_type):"},{"line_number":774,"context_line":"        return requested_router_type"}],"source_content_type":"text/x-python","patch_set":7,"id":"dab17558_12cf9829","line":771,"range":{"start_line":771,"start_character":10,"end_line":771,"end_character":52},"updated":"2016-05-17 20:19:11.000000000","message":"Why are we passing around two completely different kinds of objects to the same method as if it doesn\u0027t matter?  There is such a huge difference between DB objects and REST objects, we really shouldn\u0027t create code paths that pretend not to care which one it gets.\n\nAre you doing this because we already have these confusing code paths?  Or, are you doing this because you think we should cover both cases \"just in case?\"\n\nIf the former, I guess we can merge this and then try to follow up with a refactor to return sanity to the code base.  If the latter, then please don\u0027t.","commit_id":"fc3c8a5637e7f1a8d853d173d561aad767920a35"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"a6b206ac6a5729bcf214ad1d03bc511b7460f094","unresolved":false,"context_lines":[{"line_number":768,"context_line":"        # See if router is a DB object first"},{"line_number":769,"context_line":"        requested_router_type \u003d router.extra_attributes.distributed"},{"line_number":770,"context_line":"    except AttributeError:"},{"line_number":771,"context_line":"        # if not, try to see if it is a request body"},{"line_number":772,"context_line":"        requested_router_type \u003d router.get(\u0027distributed\u0027)"},{"line_number":773,"context_line":"    if attributes.is_attr_set(requested_router_type):"},{"line_number":774,"context_line":"        return requested_router_type"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_f2597936","line":771,"range":{"start_line":771,"start_character":10,"end_line":771,"end_character":52},"in_reply_to":"dab17558_12cf9829","updated":"2016-05-20 17:24:24.000000000","message":"the former. I wanted to keep this patch as simple as possible. If we think this should be refactored we should do it in another patch. I think if we can get the already existing \"is_router_distributed\" function from l3_dvr_db.py to work then we can refactor. This is just a straight copy and paste from there because for some reason calling l3_dvr_db.is_router_distributed fails upstream (see PS5), but now that we agree the functionality of this patch solves the defect, I\u0027ll try to make the changes even smaller.","commit_id":"fc3c8a5637e7f1a8d853d173d561aad767920a35"}],"neutron/tests/functional/services/l3_router/test_l3_dvr_ha_router_plugin.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"944c8232dee505e6229e7c651a85ebf73e76a525","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                self._assert_router_is_hosted_on_both_dvr_snat_agents(router)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def _get_ha_interface_list_for_router(self, router):"},{"line_number":299,"context_line":"        ha_bindings \u003d self.l3_plugin.get_ha_router_port_bindings(self.context,"},{"line_number":300,"context_line":"                                                                 [router[\u0027id\u0027]]"},{"line_number":301,"context_line":"                                                                 )"},{"line_number":302,"context_line":"        return ha_bindings"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_4f782df9","line":299,"range":{"start_line":299,"start_character":8,"end_line":299,"end_character":21},"updated":"2016-05-24 11:17:00.000000000","message":"No need to define \u0027ha_bindings\u0027 - can simply use \u0027return self....()\u0027","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"6875e46a64547b1e810c326e2f1101ea7bc77e37","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                self._assert_router_is_hosted_on_both_dvr_snat_agents(router)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def _get_ha_interface_list_for_router(self, router):"},{"line_number":299,"context_line":"        ha_bindings \u003d self.l3_plugin.get_ha_router_port_bindings(self.context,"},{"line_number":300,"context_line":"                                                                 [router[\u0027id\u0027]]"},{"line_number":301,"context_line":"                                                                 )"},{"line_number":302,"context_line":"        return ha_bindings"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_46055678","line":299,"range":{"start_line":299,"start_character":8,"end_line":299,"end_character":21},"in_reply_to":"bab6814e_4f782df9","updated":"2016-05-25 22:03:19.000000000","message":"Done","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"944c8232dee505e6229e7c651a85ebf73e76a525","unresolved":false,"context_lines":[{"line_number":298,"context_line":"    def _get_ha_interface_list_for_router(self, router):"},{"line_number":299,"context_line":"        ha_bindings \u003d self.l3_plugin.get_ha_router_port_bindings(self.context,"},{"line_number":300,"context_line":"                                                                 [router[\u0027id\u0027]]"},{"line_number":301,"context_line":"                                                                 )"},{"line_number":302,"context_line":"        return ha_bindings"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def _delete_router(self, router):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_ef73e113","line":301,"range":{"start_line":301,"start_character":65,"end_line":301,"end_character":66},"updated":"2016-05-24 11:17:00.000000000","message":"No need to go down a line after the end of the previous one.","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"6875e46a64547b1e810c326e2f1101ea7bc77e37","unresolved":false,"context_lines":[{"line_number":298,"context_line":"    def _get_ha_interface_list_for_router(self, router):"},{"line_number":299,"context_line":"        ha_bindings \u003d self.l3_plugin.get_ha_router_port_bindings(self.context,"},{"line_number":300,"context_line":"                                                                 [router[\u0027id\u0027]]"},{"line_number":301,"context_line":"                                                                 )"},{"line_number":302,"context_line":"        return ha_bindings"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def _delete_router(self, router):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_66005a67","line":301,"range":{"start_line":301,"start_character":65,"end_line":301,"end_character":66},"in_reply_to":"bab6814e_ef73e113","updated":"2016-05-25 22:03:19.000000000","message":"Done","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"944c8232dee505e6229e7c651a85ebf73e76a525","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        self.l3_plugin.delete_router(self.context, router[\u0027id\u0027])"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def _check_dvr_ha_interfaces_are_present(self, router):"},{"line_number":308,"context_line":"        \"\"\"Returns True if at least two ha interfaces are found for the router."},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        One for each dvr_snat node"},{"line_number":311,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_0fe585a7","line":308,"range":{"start_line":308,"start_character":11,"end_line":308,"end_character":35},"updated":"2016-05-24 11:17:00.000000000","message":"This function doesn\u0027t return True and checks for exactly 2 interfaces.","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"6875e46a64547b1e810c326e2f1101ea7bc77e37","unresolved":false,"context_lines":[{"line_number":305,"context_line":"        self.l3_plugin.delete_router(self.context, router[\u0027id\u0027])"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def _check_dvr_ha_interfaces_are_present(self, router):"},{"line_number":308,"context_line":"        \"\"\"Returns True if at least two ha interfaces are found for the router."},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        One for each dvr_snat node"},{"line_number":311,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_8609fe86","line":308,"range":{"start_line":308,"start_character":11,"end_line":308,"end_character":35},"in_reply_to":"bab6814e_0fe585a7","updated":"2016-05-25 22:03:19.000000000","message":"Done","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"944c8232dee505e6229e7c651a85ebf73e76a525","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        One for each dvr_snat node"},{"line_number":311,"context_line":"        \"\"\""},{"line_number":312,"context_line":"        ha_inf_count \u003d len(self._get_ha_interface_list_for_router(router))"},{"line_number":313,"context_line":"        self.assertEqual(2, ha_inf_count)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def _check_dvr_ha_interfaces_are_not_present(self, router):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_8f9e9505","line":312,"range":{"start_line":312,"start_character":8,"end_line":312,"end_character":22},"updated":"2016-05-24 11:17:00.000000000","message":"Again, no need for this variable.","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"6875e46a64547b1e810c326e2f1101ea7bc77e37","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"        One for each dvr_snat node"},{"line_number":311,"context_line":"        \"\"\""},{"line_number":312,"context_line":"        ha_inf_count \u003d len(self._get_ha_interface_list_for_router(router))"},{"line_number":313,"context_line":"        self.assertEqual(2, ha_inf_count)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def _check_dvr_ha_interfaces_are_not_present(self, router):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_c66e662e","line":312,"range":{"start_line":312,"start_character":8,"end_line":312,"end_character":22},"in_reply_to":"bab6814e_8f9e9505","updated":"2016-05-25 22:03:19.000000000","message":"Done","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"944c8232dee505e6229e7c651a85ebf73e76a525","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        self.assertEqual(2, ha_inf_count)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def _check_dvr_ha_interfaces_are_not_present(self, router):"},{"line_number":316,"context_line":"        ha_inf_count \u003d len(self._get_ha_interface_list_for_router(router))"},{"line_number":317,"context_line":"        self.assertEqual(0, ha_inf_count)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def _set_external_gateway(self, router):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_6fa37150","line":316,"range":{"start_line":316,"start_character":8,"end_line":316,"end_character":22},"updated":"2016-05-24 11:17:00.000000000","message":"No need for this variable.","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"6875e46a64547b1e810c326e2f1101ea7bc77e37","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        self.assertEqual(2, ha_inf_count)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def _check_dvr_ha_interfaces_are_not_present(self, router):"},{"line_number":316,"context_line":"        ha_inf_count \u003d len(self._get_ha_interface_list_for_router(router))"},{"line_number":317,"context_line":"        self.assertEqual(0, ha_inf_count)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def _set_external_gateway(self, router):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_e648cab5","line":316,"range":{"start_line":316,"start_character":8,"end_line":316,"end_character":22},"in_reply_to":"bab6814e_6fa37150","updated":"2016-05-25 22:03:19.000000000","message":"Done","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"944c8232dee505e6229e7c651a85ebf73e76a525","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            {\u0027network_id\u0027: ext_net[\u0027network\u0027][\u0027id\u0027]})"},{"line_number":332,"context_line":"        return ext_net"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def _clear_external_gateway(self, router):"},{"line_number":335,"context_line":"        self.l3_plugin._update_router_gw_info("},{"line_number":336,"context_line":"            self.context, router[\u0027id\u0027], {})"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_2f67a926","line":334,"range":{"start_line":334,"start_character":8,"end_line":334,"end_character":31},"updated":"2016-05-24 11:17:00.000000000","message":"One would expect that if \u0027_set_external_gateway\u0027 creates all the resources for the subnet, then \u0027clear_external_gateway\u0027 would also delete them.\n\nI\u0027d understand if you\u0027re reluctant to clear everything here - in this case lets be more explicit - have \u0027_create_external_gateway\u0027, \u0027_set_external_gateway\u0027 and \u0027_clear_external_gateway\u0027. Then you\u0027re very explicit about not having a \u0027_delete_external_gateway\u0027.","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"6875e46a64547b1e810c326e2f1101ea7bc77e37","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            {\u0027network_id\u0027: ext_net[\u0027network\u0027][\u0027id\u0027]})"},{"line_number":332,"context_line":"        return ext_net"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def _clear_external_gateway(self, router):"},{"line_number":335,"context_line":"        self.l3_plugin._update_router_gw_info("},{"line_number":336,"context_line":"            self.context, router[\u0027id\u0027], {})"},{"line_number":337,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_896bd1b8","line":334,"range":{"start_line":334,"start_character":8,"end_line":334,"end_character":31},"in_reply_to":"bab6814e_2f67a926","updated":"2016-05-25 22:03:19.000000000","message":"You are correct. I will split this function to make more clear\nDone","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"944c8232dee505e6229e7c651a85ebf73e76a525","unresolved":false,"context_lines":[{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def test_dvr_ha_router_state_machine_path_1(self):"},{"line_number":393,"context_line":"        \"\"\"DVRHA state machine path 1"},{"line_number":394,"context_line":"        - create router"},{"line_number":395,"context_line":"        - delete router"},{"line_number":396,"context_line":"        \"\"\""},{"line_number":397,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_8f117560","line":394,"range":{"start_line":394,"start_character":8,"end_line":394,"end_character":9},"updated":"2016-05-24 11:17:00.000000000","message":"The hacking conventions [1] we use in openstack ask for a line of space between the first line of the docstring and the rest of the body.\n\n[1]: http://docs.openstack.org/developer/hacking/#docstrings","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"14d2b5a9f7b078fff07c20c31625d7890eef15bf","unresolved":false,"context_lines":[{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    def test_dvr_ha_router_state_machine_path_1(self):"},{"line_number":393,"context_line":"        \"\"\"DVRHA state machine path 1"},{"line_number":394,"context_line":"        - create router"},{"line_number":395,"context_line":"        - delete router"},{"line_number":396,"context_line":"        \"\"\""},{"line_number":397,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_5a27e5b5","line":394,"range":{"start_line":394,"start_character":8,"end_line":394,"end_character":9},"in_reply_to":"bab6814e_8f117560","updated":"2016-05-25 22:08:40.000000000","message":"Done","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"944c8232dee505e6229e7c651a85ebf73e76a525","unresolved":false,"context_lines":[{"line_number":402,"context_line":"        self._check_dvr_ha_interfaces_are_not_present(router)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def test_dvr_ha_router_state_machine_path_2(self):"},{"line_number":405,"context_line":"        \"\"\"DVRHA state machine path 2"},{"line_number":406,"context_line":"        - create router"},{"line_number":407,"context_line":"        - set router external gateway"},{"line_number":408,"context_line":"        - delete router"},{"line_number":409,"context_line":"        \"\"\""},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        # create router"},{"line_number":412,"context_line":"        router \u003d self._create_dvrha_router()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_f25e2411","line":409,"range":{"start_line":405,"start_character":8,"end_line":409,"end_character":11},"updated":"2016-05-24 11:17:00.000000000","message":"These docstrings are a comment-duplications if you also specify before each block of code what\u0027s being done (it\u0027s practically a copy-paste). Think about having to change the wording/logic in one block - this will mean that you now have to change the exact same comment twice - once before the block and once in the docstring.","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"6875e46a64547b1e810c326e2f1101ea7bc77e37","unresolved":false,"context_lines":[{"line_number":402,"context_line":"        self._check_dvr_ha_interfaces_are_not_present(router)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def test_dvr_ha_router_state_machine_path_2(self):"},{"line_number":405,"context_line":"        \"\"\"DVRHA state machine path 2"},{"line_number":406,"context_line":"        - create router"},{"line_number":407,"context_line":"        - set router external gateway"},{"line_number":408,"context_line":"        - delete router"},{"line_number":409,"context_line":"        \"\"\""},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        # create router"},{"line_number":412,"context_line":"        router \u003d self._create_dvrha_router()"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_69f5cdeb","line":409,"range":{"start_line":405,"start_character":8,"end_line":409,"end_character":11},"in_reply_to":"bab6814e_f25e2411","updated":"2016-05-25 22:03:19.000000000","message":"Taking out\nDone","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"944c8232dee505e6229e7c651a85ebf73e76a525","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        self._check_internal_subnet_interface_is_not_present(router)"},{"line_number":482,"context_line":"        self._check_snat_external_gateway_is_present(router, ext_net)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        # delete router"},{"line_number":485,"context_line":"        self._delete_router(router)"},{"line_number":486,"context_line":"        self._check_dvr_ha_interfaces_are_not_present(router)"},{"line_number":487,"context_line":"        self._check_snat_external_gateway_is_not_present(ext_net)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_b2abfcd5","line":484,"range":{"start_line":484,"start_character":10,"end_line":484,"end_character":23},"updated":"2016-05-24 11:17:00.000000000","message":"Do you not need to clear the external gateway before deleting the router?","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"6875e46a64547b1e810c326e2f1101ea7bc77e37","unresolved":false,"context_lines":[{"line_number":481,"context_line":"        self._check_internal_subnet_interface_is_not_present(router)"},{"line_number":482,"context_line":"        self._check_snat_external_gateway_is_present(router, ext_net)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        # delete router"},{"line_number":485,"context_line":"        self._delete_router(router)"},{"line_number":486,"context_line":"        self._check_dvr_ha_interfaces_are_not_present(router)"},{"line_number":487,"context_line":"        self._check_snat_external_gateway_is_not_present(ext_net)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_0901a1af","line":484,"range":{"start_line":484,"start_character":10,"end_line":484,"end_character":23},"in_reply_to":"bab6814e_b2abfcd5","updated":"2016-05-25 22:03:19.000000000","message":"Actually this is part of the test. deleting the router without first clearing the gateway is one of the possible paths of the state machine. User is allowed to delete router without first clearing gateway. Result should be the same though.","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"944c8232dee505e6229e7c651a85ebf73e76a525","unresolved":false,"context_lines":[{"line_number":562,"context_line":"    def test_router_auto_scheduling(self):"},{"line_number":563,"context_line":"        self.skipTest(\u0027Valid for DVR-only routers\u0027)"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    def _remove_interface_from_router(self, router, subnet):"},{"line_number":566,"context_line":"        self.l3_plugin.remove_router_interface("},{"line_number":567,"context_line":"            self.context, router[\u0027id\u0027],"},{"line_number":568,"context_line":"            {\u0027subnet_id\u0027: subnet[\u0027subnet\u0027][\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_5281f04c","line":565,"range":{"start_line":565,"start_character":8,"end_line":565,"end_character":37},"updated":"2016-05-24 11:17:00.000000000","message":"Please move this up so that it will be defined along with the other helpers you defined.","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"6875e46a64547b1e810c326e2f1101ea7bc77e37","unresolved":false,"context_lines":[{"line_number":562,"context_line":"    def test_router_auto_scheduling(self):"},{"line_number":563,"context_line":"        self.skipTest(\u0027Valid for DVR-only routers\u0027)"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    def _remove_interface_from_router(self, router, subnet):"},{"line_number":566,"context_line":"        self.l3_plugin.remove_router_interface("},{"line_number":567,"context_line":"            self.context, router[\u0027id\u0027],"},{"line_number":568,"context_line":"            {\u0027subnet_id\u0027: subnet[\u0027subnet\u0027][\u0027id\u0027]})"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_0918811d","line":565,"range":{"start_line":565,"start_character":8,"end_line":565,"end_character":37},"in_reply_to":"bab6814e_5281f04c","updated":"2016-05-25 22:03:19.000000000","message":"Done","commit_id":"9022ac9c445729aab38da7180d0f2e67b957f189"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"bfbfccbe5f7568f350163f6a1659c64e5df8d93a","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            self.context, router[\u0027id\u0027],"},{"line_number":335,"context_line":"            {\u0027subnet_id\u0027: subnet[\u0027subnet\u0027][\u0027id\u0027]})"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def _check_snat_external_gateway_is_present(self, router, ext_net):"},{"line_number":338,"context_line":"        ext_net_id \u003d ext_net[\u0027network\u0027][\u0027id\u0027]"},{"line_number":339,"context_line":"        gw_port \u003d (self.l3_plugin._core_plugin."},{"line_number":340,"context_line":"                   _get_router_gw_ports_by_network(self.context, ext_net_id))"}],"source_content_type":"text/x-python","patch_set":10,"id":"9abb7d3a_f7772f00","line":337,"updated":"2016-05-27 21:44:22.000000000","message":"This method and the one below can be squashed, especially if you remove line 342. For example:\n\n  def _assert_snat_gateway_presence(self, should_be_present):\n    ext_net_id \u003d ext_net[\u0027network\u0027][\u0027id\u0027]\n    gw_port \u003d (self.l3_plugin._core_plugin._get_router_gw_ports_by_network(self.context, ext_net_id))\n    self.assertEqual(should_be_present, len(gw_port))\n\nThe same comment can be applied to the other similar helpers.","commit_id":"fb57b306cb414d5fc4c911a0385f15ca5ef371de"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"9b851b494d5bf5e17c1181a2c31e5ecc34987169","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            self.context, router[\u0027id\u0027],"},{"line_number":335,"context_line":"            {\u0027subnet_id\u0027: subnet[\u0027subnet\u0027][\u0027id\u0027]})"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def _check_snat_external_gateway_is_present(self, router, ext_net):"},{"line_number":338,"context_line":"        ext_net_id \u003d ext_net[\u0027network\u0027][\u0027id\u0027]"},{"line_number":339,"context_line":"        gw_port \u003d (self.l3_plugin._core_plugin."},{"line_number":340,"context_line":"                   _get_router_gw_ports_by_network(self.context, ext_net_id))"}],"source_content_type":"text/x-python","patch_set":10,"id":"9abb7d3a_3344b948","line":337,"in_reply_to":"9abb7d3a_f7772f00","updated":"2016-05-31 15:48:46.000000000","message":"I am not sure squashing this has any value except save four lines in a test file. I\u0027ll try to see what it looks like but I don\u0027t know if doing so will make it better or worst.","commit_id":"fb57b306cb414d5fc4c911a0385f15ca5ef371de"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"bfbfccbe5f7568f350163f6a1659c64e5df8d93a","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        self.assertTrue(router[\u0027ha\u0027])"},{"line_number":389,"context_line":"        return router"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def test_dvr_ha_router_state_machine_path_1(self):"},{"line_number":392,"context_line":"        \"\"\"DVRHA state machine path 1\"\"\""},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        # create router"}],"source_content_type":"text/x-python","patch_set":10,"id":"9abb7d3a_97234305","line":391,"updated":"2016-05-27 21:44:22.000000000","message":"The test names as is are entirely non-descriptive. You might as well call these tests test_{1..6}.\n\nHere\u0027s some examples:\nThe first test can be named \"test_ha_interfaces\"\nThe second \"test_snat_interfaces\"\nThe third \"test_delete_snat_interfaces\"\n\nAnd so on.","commit_id":"fb57b306cb414d5fc4c911a0385f15ca5ef371de"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"9b851b494d5bf5e17c1181a2c31e5ecc34987169","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        self.assertTrue(router[\u0027ha\u0027])"},{"line_number":389,"context_line":"        return router"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"    def test_dvr_ha_router_state_machine_path_1(self):"},{"line_number":392,"context_line":"        \"\"\"DVRHA state machine path 1\"\"\""},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"        # create router"}],"source_content_type":"text/x-python","patch_set":10,"id":"9abb7d3a_33d4b9ea","line":391,"in_reply_to":"9abb7d3a_97234305","updated":"2016-05-31 15:48:46.000000000","message":"Yes. The test are undescriptive. unfortunately this is due to what the tests are doing. This test are not meant to test a particular functionality but a state machine patch. \nFor example:  create router, add interface, delete router is one path \nthen the next path: create router, add interface, remove interface, delete router is a different path.\nsuccess of the first DOES NOT mean success of the second. The test have to be executed with those particular steps in that exact order. The state_machine_path, is described by the comments. The \"paths\" were not randomly picked they are very specific. For example, without this fix, every test but test_path_6 will pass. I\u0027ll try to rename tests but really won\u0027t make much difference since the names will still not be descriptive enough, because what matters is the order in which the steps are taken.","commit_id":"fb57b306cb414d5fc4c911a0385f15ca5ef371de"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"bfbfccbe5f7568f350163f6a1659c64e5df8d93a","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        self._delete_router(router)"},{"line_number":400,"context_line":"        self._check_dvr_ha_interfaces_are_not_present(router)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def test_dvr_ha_router_state_machine_path_2(self):"},{"line_number":403,"context_line":"        \"\"\"DVRHA state machine path 2\"\"\""},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        # create router"}],"source_content_type":"text/x-python","patch_set":10,"id":"9abb7d3a_f7c44f41","line":402,"updated":"2016-05-27 21:44:22.000000000","message":"I think that when writing a test it\u0027s safe to assume that other tests are passing, given the same preconditions, setup and input. For example you already assert that HA interfaces are created properly in line 396 of the previous test. Therefor, you don\u0027t have to make the same assertion here.\n\nIf you buy in to that line of thinking, you can remove a large chunk of the contents of these tests.","commit_id":"fb57b306cb414d5fc4c911a0385f15ca5ef371de"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"9b851b494d5bf5e17c1181a2c31e5ecc34987169","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        self._delete_router(router)"},{"line_number":400,"context_line":"        self._check_dvr_ha_interfaces_are_not_present(router)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def test_dvr_ha_router_state_machine_path_2(self):"},{"line_number":403,"context_line":"        \"\"\"DVRHA state machine path 2\"\"\""},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"        # create router"}],"source_content_type":"text/x-python","patch_set":10,"id":"9abb7d3a_135ed543","line":402,"in_reply_to":"9abb7d3a_f7c44f41","updated":"2016-05-31 15:48:46.000000000","message":"Like I said in my previous comments. This tests are meant to execute a very particular set of steps. All steps must always be executed. Leaving a step out makes the test invalid. The tests do not check the functionality, they check that the functionality works in very exact path of the state machine.","commit_id":"fb57b306cb414d5fc4c911a0385f15ca5ef371de"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b4e81cc49c69040d49a525e7cade8114c1f5a1d2","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        return router"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def test_dvr_ha_router_create_attach_detach_delete(self):"},{"line_number":378,"context_line":"        \"\"\"DVRHA state machine path 6\"\"\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        # create router"},{"line_number":381,"context_line":"        router \u003d self._create_dvrha_router()"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_076b25f2","line":378,"updated":"2016-05-31 20:11:49.000000000","message":"This comment has no meaning any more.","commit_id":"e57f397dd08ec02c8b8800cb2574ab8a54f7df20"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"a6a7150f0b24f37ee0a575dd430cabe7a1a2a288","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        return router"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def test_dvr_ha_router_create_attach_detach_delete(self):"},{"line_number":378,"context_line":"        \"\"\"DVRHA state machine path 6\"\"\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        # create router"},{"line_number":381,"context_line":"        router \u003d self._create_dvrha_router()"}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_29d0b8f5","line":378,"in_reply_to":"9abb7d3a_076b25f2","updated":"2016-05-31 22:39:07.000000000","message":"Done","commit_id":"e57f397dd08ec02c8b8800cb2574ab8a54f7df20"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"ab964ee10c1e44218d275d80de4b9a77d719f3c1","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        router \u003d self._create_dvrha_router()"},{"line_number":382,"context_line":"        self._check_dvr_ha_interfaces_presence(router, 2)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        # add subnet interface to router"},{"line_number":385,"context_line":"        int_subnet \u003d self._add_internal_subnet_to_router(router)"},{"line_number":386,"context_line":"        self._check_internal_subnet_interface_presence(router, int_subnet, 1)"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_246c6734","line":384,"updated":"2016-05-31 19:38:35.000000000","message":"The other order is now missing (First attaching to external net, then to internal). If I haven\u0027t completely worn you down and you feel like pushing a follow up I can review it ASAP.","commit_id":"e57f397dd08ec02c8b8800cb2574ab8a54f7df20"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"a6a7150f0b24f37ee0a575dd430cabe7a1a2a288","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        router \u003d self._create_dvrha_router()"},{"line_number":382,"context_line":"        self._check_dvr_ha_interfaces_presence(router, 2)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        # add subnet interface to router"},{"line_number":385,"context_line":"        int_subnet \u003d self._add_internal_subnet_to_router(router)"},{"line_number":386,"context_line":"        self._check_internal_subnet_interface_presence(router, int_subnet, 1)"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_69d640f2","line":384,"in_reply_to":"9abb7d3a_1aaed8e5","updated":"2016-05-31 22:39:07.000000000","message":"Done","commit_id":"e57f397dd08ec02c8b8800cb2574ab8a54f7df20"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"a6a7150f0b24f37ee0a575dd430cabe7a1a2a288","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        router \u003d self._create_dvrha_router()"},{"line_number":382,"context_line":"        self._check_dvr_ha_interfaces_presence(router, 2)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        # add subnet interface to router"},{"line_number":385,"context_line":"        int_subnet \u003d self._add_internal_subnet_to_router(router)"},{"line_number":386,"context_line":"        self._check_internal_subnet_interface_presence(router, int_subnet, 1)"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_89d9e424","line":384,"in_reply_to":"9abb7d3a_246c6734","updated":"2016-05-31 22:39:07.000000000","message":"Done","commit_id":"e57f397dd08ec02c8b8800cb2574ab8a54f7df20"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b4e81cc49c69040d49a525e7cade8114c1f5a1d2","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        router \u003d self._create_dvrha_router()"},{"line_number":382,"context_line":"        self._check_dvr_ha_interfaces_presence(router, 2)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        # add subnet interface to router"},{"line_number":385,"context_line":"        int_subnet \u003d self._add_internal_subnet_to_router(router)"},{"line_number":386,"context_line":"        self._check_internal_subnet_interface_presence(router, int_subnet, 1)"},{"line_number":387,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9abb7d3a_1aaed8e5","line":384,"in_reply_to":"9abb7d3a_246c6734","updated":"2016-05-31 20:11:49.000000000","message":"I guess I kind-of agree with this comment.  Luckily Adolfo is not close enough to hit me with rotten fruit :)","commit_id":"e57f397dd08ec02c8b8800cb2574ab8a54f7df20"}]}
