)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"5caf6684537ce8fe9aac76fd7b3b7a1648ff3f15","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Object tests: Add generating nullable parameters for test coverage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Returning the None value in Neutron object base.py modify_fields_from_db(),"},{"line_number":10,"context_line":"as current implementation does not allow method to pass None from database"},{"line_number":11,"context_line":"to object."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dab17558_50665751","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":18},"updated":"2016-05-11 14:05:48.000000000","message":"Could you elaborate on why do we need this? I don\u0027t see how having None fields is better than not having those fields at all. One could always use getattr(o, \u0027f\u0027, None) explicitly where it is expected.","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"3512a94b0d7128bbee249b152beaf48aef2a5d91","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Object tests: Add generating nullable parameters for test coverage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Returning the None value in Neutron object base.py modify_fields_from_db(),"},{"line_number":10,"context_line":"as current implementation does not allow method to pass None from database"},{"line_number":11,"context_line":"to object."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dab17558_550801da","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":18},"in_reply_to":"dab17558_44505532","updated":"2016-05-11 15:09:23.000000000","message":"\u003e when user of object is accessing the unset field- the exception is raised\n\nI think it is actually good as it forces the \u0027user\u0027 to be explicit about handling nullables.","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"fb321d25d6e3b3c6f35668dc4b900b32d70a320a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Object tests: Add generating nullable parameters for test coverage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Returning the None value in Neutron object base.py modify_fields_from_db(),"},{"line_number":10,"context_line":"as current implementation does not allow method to pass None from database"},{"line_number":11,"context_line":"to object."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dab17558_44505532","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":18},"in_reply_to":"dab17558_50665751","updated":"2016-05-11 14:33:44.000000000","message":"In object implementation, if you do not pass None, the field is not set and when user of object is accessing the unset field- the exception is raised by OVO library. In current implementation, we cannot set None to fields that are None in DB... This is why we should return and set the None for object field.","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"132ed718f7e0ab19c6fe3b8f1b213c78a19ee6c4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Object tests: Add generating nullable parameters for test coverage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Returning the None value in Neutron object base.py modify_fields_from_db(),"},{"line_number":10,"context_line":"as current implementation does not allow method to pass None from database"},{"line_number":11,"context_line":"to object."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bab6814e_394dac3e","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":18},"in_reply_to":"dab17558_550801da","updated":"2016-05-20 16:14:03.000000000","message":"Agreed with Ilya. Unless we see a real need to do the switch, I prefer we leave fields unset.","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"132ed718f7e0ab19c6fe3b8f1b213c78a19ee6c4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"to object."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also modifying the QoS rule unit tests as they were creating the policy"},{"line_number":14,"context_line":"object without the required fields: tenatn_id, name, description."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I7a5457c328243330c923bd6ecb777c8d544f21d0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bab6814e_b9d19c59","line":14,"range":{"start_line":14,"start_character":36,"end_line":14,"end_character":45},"updated":"2016-05-20 16:14:03.000000000","message":"tenant_id","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"}],"neutron/common/utils.py":[{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"5caf6684537ce8fe9aac76fd7b3b7a1648ff3f15","unresolved":false,"context_lines":[{"line_number":207,"context_line":"def compare_with_null(a, b):"},{"line_number":208,"context_line":"    \"\"\" Compare elements with null consideration"},{"line_number":209,"context_line":"    \"\"\""},{"line_number":210,"context_line":"    if a is None and b is None:"},{"line_number":211,"context_line":"        return 0"},{"line_number":212,"context_line":"    if a is None:"},{"line_number":213,"context_line":"        return -1"},{"line_number":214,"context_line":"    if b is None:"},{"line_number":215,"context_line":"        return 1"},{"line_number":216,"context_line":"    return cmp(a, b)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_10db341c","line":215,"range":{"start_line":210,"start_character":0,"end_line":215,"end_character":16},"updated":"2016-05-11 14:05:48.000000000","message":"Why don\u0027t just use \u0027cmp\u0027?","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"fb321d25d6e3b3c6f35668dc4b900b32d70a320a","unresolved":false,"context_lines":[{"line_number":207,"context_line":"def compare_with_null(a, b):"},{"line_number":208,"context_line":"    \"\"\" Compare elements with null consideration"},{"line_number":209,"context_line":"    \"\"\""},{"line_number":210,"context_line":"    if a is None and b is None:"},{"line_number":211,"context_line":"        return 0"},{"line_number":212,"context_line":"    if a is None:"},{"line_number":213,"context_line":"        return -1"},{"line_number":214,"context_line":"    if b is None:"},{"line_number":215,"context_line":"        return 1"},{"line_number":216,"context_line":"    return cmp(a, b)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_a4e781aa","line":215,"range":{"start_line":210,"start_character":0,"end_line":215,"end_character":16},"in_reply_to":"dab17558_10db341c","updated":"2016-05-11 14:33:44.000000000","message":"I have added this to workaround the problem of comparing the datetime and None objects by default sorting in python. cmp is not handling that case.","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"}],"neutron/tests/tools.py":[{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"5caf6684537ce8fe9aac76fd7b3b7a1648ff3f15","unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def get_min_datetime():"},{"line_number":307,"context_line":"    return datetime.datetime(datetime.MINYEAR, 1, 1, 1, 1, 1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_3093d3fb","line":307,"range":{"start_line":307,"start_character":53,"end_line":307,"end_character":60},"updated":"2016-05-11 14:05:48.000000000","message":"nit: why not 0,0,0?","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"fb321d25d6e3b3c6f35668dc4b900b32d70a320a","unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"def get_min_datetime():"},{"line_number":307,"context_line":"    return datetime.datetime(datetime.MINYEAR, 1, 1, 1, 1, 1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_84d35dd4","line":307,"range":{"start_line":307,"start_character":53,"end_line":307,"end_character":60},"in_reply_to":"dab17558_3093d3fb","updated":"2016-05-11 14:33:44.000000000","message":"This method is no longer used, so I need to remove it.","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"}],"neutron/tests/unit/common/test_utils.py":[{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"5caf6684537ce8fe9aac76fd7b3b7a1648ff3f15","unresolved":false,"context_lines":[{"line_number":391,"context_line":"class TestCompareUtils(base.BaseTestCase):"},{"line_number":392,"context_line":"    def test_compare_with_null(self):"},{"line_number":393,"context_line":"        test_values \u003d [(None, 1, -1), (1, None, 1), (None, None, 0),"},{"line_number":394,"context_line":"                       (1, 1, 0), (1, 2, -1), (2, 1, 1)]"},{"line_number":395,"context_line":"        for value in test_values:"},{"line_number":396,"context_line":"            self.assertEqual(value[2],"},{"line_number":397,"context_line":"                             utils.compare_with_null(value[0],value[1]))"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_092f8688","line":394,"range":{"start_line":394,"start_character":23,"end_line":394,"end_character":55},"updated":"2016-05-11 14:05:48.000000000","message":"nit: You are testing \u0027cmp\u0027 here. You probably want to mock \u0027cmp\u0027 instead and ensure it is called when both arguments are not None.","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"fb321d25d6e3b3c6f35668dc4b900b32d70a320a","unresolved":false,"context_lines":[{"line_number":391,"context_line":"class TestCompareUtils(base.BaseTestCase):"},{"line_number":392,"context_line":"    def test_compare_with_null(self):"},{"line_number":393,"context_line":"        test_values \u003d [(None, 1, -1), (1, None, 1), (None, None, 0),"},{"line_number":394,"context_line":"                       (1, 1, 0), (1, 2, -1), (2, 1, 1)]"},{"line_number":395,"context_line":"        for value in test_values:"},{"line_number":396,"context_line":"            self.assertEqual(value[2],"},{"line_number":397,"context_line":"                             utils.compare_with_null(value[0],value[1]))"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_6463d942","line":394,"range":{"start_line":394,"start_character":23,"end_line":394,"end_character":55},"in_reply_to":"dab17558_092f8688","updated":"2016-05-11 14:33:44.000000000","message":"The whole problem here is that we cannot compare the datetime and None in python when sorting.","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"3512a94b0d7128bbee249b152beaf48aef2a5d91","unresolved":false,"context_lines":[{"line_number":391,"context_line":"class TestCompareUtils(base.BaseTestCase):"},{"line_number":392,"context_line":"    def test_compare_with_null(self):"},{"line_number":393,"context_line":"        test_values \u003d [(None, 1, -1), (1, None, 1), (None, None, 0),"},{"line_number":394,"context_line":"                       (1, 1, 0), (1, 2, -1), (2, 1, 1)]"},{"line_number":395,"context_line":"        for value in test_values:"},{"line_number":396,"context_line":"            self.assertEqual(value[2],"},{"line_number":397,"context_line":"                             utils.compare_with_null(value[0],value[1]))"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_bf878cb3","line":394,"range":{"start_line":394,"start_character":23,"end_line":394,"end_character":55},"in_reply_to":"dab17558_6463d942","updated":"2016-05-11 15:09:23.000000000","message":"What I meant to say is that the 3 highlighted cases are guaranteed to call \u0027cmp\u0027 given your \u0027compare_with_null\u0027 implementation. So all 3 of them essentially test the same case.","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"5caf6684537ce8fe9aac76fd7b3b7a1648ff3f15","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    return FIELD_TYPE_VALUE_GENERATOR_MAP[type(field_obj)]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"def get_value(generator, ip_version):"},{"line_number":260,"context_line":"    if \u0027version\u0027 in generator.__code__.co_varnames:"},{"line_number":261,"context_line":"        return generator(version\u003dip_version)"},{"line_number":262,"context_line":"    return generator()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_96871cb4","line":259,"range":{"start_line":259,"start_character":25,"end_line":259,"end_character":28},"updated":"2016-05-11 14:05:48.000000000","message":"What\u0027s the reason for that change?","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"fb321d25d6e3b3c6f35668dc4b900b32d70a320a","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    return FIELD_TYPE_VALUE_GENERATOR_MAP[type(field_obj)]"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"def get_value(generator, ip_version):"},{"line_number":260,"context_line":"    if \u0027version\u0027 in generator.__code__.co_varnames:"},{"line_number":261,"context_line":"        return generator(version\u003dip_version)"},{"line_number":262,"context_line":"    return generator()"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_0944a6b4","line":259,"range":{"start_line":259,"start_character":25,"end_line":259,"end_character":28},"in_reply_to":"dab17558_96871cb4","updated":"2016-05-11 14:33:44.000000000","message":"I just wanted to explicitly say what version we are passing here, meaning the IP version. Just nit.","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"5caf6684537ce8fe9aac76fd7b3b7a1648ff3f15","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        super(_BaseObjectTestCase, self).setUp()"},{"line_number":276,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":277,"context_line":"        self.db_objs \u003d list(self.get_random_fields() for _ in range(3))"},{"line_number":278,"context_line":"        self.db_objs.append(self.get_random_fields(nullable\u003dTrue))"},{"line_number":279,"context_line":"        self.db_obj \u003d self.db_objs[0]"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        self.obj_fields \u003d [self._test_class.modify_fields_from_db(db_obj)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_e69991c5","line":278,"range":{"start_line":278,"start_character":28,"end_line":278,"end_character":65},"updated":"2016-05-11 14:05:48.000000000","message":"All-None objects do not seem all that random. So instead of modifying get_random_fields and generator, maybe you could add your own get_nullable_fields?\n\nAnd correct me if I\u0027m wrong, but would it not set primary_key fields to None as well as other DB fields with sa.Column(nullable\u003dFalse)? If so, I\u0027m not sure if it would make much sense.","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"},{"author":{"_account_id":21273,"name":"Ilya Chukhnakov","email":"Ilya.chukhnakov@gmail.com","username":"ichukhnakov"},"change_message_id":"5caf6684537ce8fe9aac76fd7b3b7a1648ff3f15","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        super(_BaseObjectTestCase, self).setUp()"},{"line_number":276,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":277,"context_line":"        self.db_objs \u003d list(self.get_random_fields() for _ in range(3))"},{"line_number":278,"context_line":"        self.db_objs.append(self.get_random_fields(nullable\u003dTrue))"},{"line_number":279,"context_line":"        self.db_obj \u003d self.db_objs[0]"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        self.obj_fields \u003d [self._test_class.modify_fields_from_db(db_obj)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_6137504d","line":278,"range":{"start_line":278,"start_character":8,"end_line":278,"end_character":66},"updated":"2016-05-11 14:05:48.000000000","message":"Does that mean you want an object with all field set to None here? Including primary key?","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"fb321d25d6e3b3c6f35668dc4b900b32d70a320a","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        super(_BaseObjectTestCase, self).setUp()"},{"line_number":276,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":277,"context_line":"        self.db_objs \u003d list(self.get_random_fields() for _ in range(3))"},{"line_number":278,"context_line":"        self.db_objs.append(self.get_random_fields(nullable\u003dTrue))"},{"line_number":279,"context_line":"        self.db_obj \u003d self.db_objs[0]"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        self.obj_fields \u003d [self._test_class.modify_fields_from_db(db_obj)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_64ec792a","line":278,"range":{"start_line":278,"start_character":28,"end_line":278,"end_character":65},"in_reply_to":"dab17558_e69991c5","updated":"2016-05-11 14:33:44.000000000","message":"I wanted to create field set that include Nulls for all fields that can be nullable in OVO implementation. It should enable us to automatically test the misinterpretation between the OVO declaration and DB defaults. It is useful for BaseDbObjectTestCase implementation. The primary keys cannot be null so there should be no problem there.\n\nThis get_random_fields(nullable\u003dTrue) will return Null where in OVO declaration is declared such, for example [1]\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/objects/qos/rule.py#L94","commit_id":"86cb7ef7c4e012d1a7177498eda6e74b7180447e"}]}
