)]}'
{"neutron/api/v2/attributes.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"6de3c7cdf724d0f8d2da1a5116971a1844584d3f","unresolved":false,"context_lines":[{"line_number":976,"context_line":"                \"tenant in request requires admin privileges\")"},{"line_number":977,"context_line":"        raise webob.exc.HTTPBadRequest(msg)"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"    if is_create and \u0027tenant_id\u0027 not in res_dict and \u0027tenant_id\u0027 in attr_info:"},{"line_number":980,"context_line":"        if context.tenant_id:"},{"line_number":981,"context_line":"            res_dict[\u0027tenant_id\u0027] \u003d context.tenant_id"},{"line_number":982,"context_line":"        elif \u0027tenant_id\u0027 in attr_info:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_edf3ab08","line":979,"updated":"2016-08-16 09:27:28.000000000","message":"@Carl, haven\u0027t you ever heard of condos? :)\n\nMore seriously, I\u0027m not a fan of this change because it leaves us unprepared to quickly handle multi-tenancy use-cases in the future.\n\nIt also leads to inconsistencies in the API for top-level resources. Right now it\u0027s very clear who owns top-level objects that you fetch because you just look at the tenant_id. Now with the segment API you have to do a separate API call to fetch the network and lookup the tenant_id.\n\nA see little advantage for this other than making our lives a little bit easier.","commit_id":"9fe45a6556f5d14f9fae4f7c0558b0b8e57da48c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"52081e8b34fe9f83d481c6a438d5cb4492d0c9c0","unresolved":false,"context_lines":[{"line_number":976,"context_line":"                \"tenant in request requires admin privileges\")"},{"line_number":977,"context_line":"        raise webob.exc.HTTPBadRequest(msg)"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"    if is_create and \u0027tenant_id\u0027 not in res_dict and \u0027tenant_id\u0027 in attr_info:"},{"line_number":980,"context_line":"        if context.tenant_id:"},{"line_number":981,"context_line":"            res_dict[\u0027tenant_id\u0027] \u003d context.tenant_id"},{"line_number":982,"context_line":"        elif \u0027tenant_id\u0027 in attr_info:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_0a152ce4","line":979,"updated":"2016-06-16 21:24:11.000000000","message":"I\u0027m personally warming up to this.  There are two places I can think of where I think a tenant_id doesn\u0027t make sense.\n\nFirst is segments on networks (the one that sparked this discussion).  I don\u0027t think a segment should ever have a different tenant_id than the network.  Its like I own my house but you own one of the bedrooms.  Just seems silly.\n\nThe other one is subnets on a network.  Again, networks are composed of subnets.  It doesn\u0027t make any sense to me for a subnet to have a tenant_id different than the network.\n\nSo, if they should all be the same tenant_id, why store them in the DB or require them in the API?","commit_id":"9fe45a6556f5d14f9fae4f7c0558b0b8e57da48c"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"894069e0a8ab5d31d2d5b81b4e15bb4d5708c19e","unresolved":false,"context_lines":[{"line_number":976,"context_line":"                \"tenant in request requires admin privileges\")"},{"line_number":977,"context_line":"        raise webob.exc.HTTPBadRequest(msg)"},{"line_number":978,"context_line":""},{"line_number":979,"context_line":"    if is_create and \u0027tenant_id\u0027 not in res_dict and \u0027tenant_id\u0027 in attr_info:"},{"line_number":980,"context_line":"        if context.tenant_id:"},{"line_number":981,"context_line":"            res_dict[\u0027tenant_id\u0027] \u003d context.tenant_id"},{"line_number":982,"context_line":"        elif \u0027tenant_id\u0027 in attr_info:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a9d85d2_083f2db5","line":979,"in_reply_to":"7aa08908_0a152ce4","updated":"2016-06-20 18:37:04.000000000","message":"yeah i agree with you on this.  as you mentioned it\u0027d solve for this bug:\n\nhttps://bugs.launchpad.net/neutron/+bug/1588228","commit_id":"9fe45a6556f5d14f9fae4f7c0558b0b8e57da48c"}]}