)]}'
{"quantum/db/migration/alembic_migrations/versions/3cbf70257c28_nvp_mac_learning.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":44,"context_line":"    if not migration.should_run(active_plugin, migration_for_plugins):"},{"line_number":45,"context_line":"        return"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    op.create_table(\u0027maclearningstates\u0027,"},{"line_number":48,"context_line":"                    sa.Column(\u0027port_id\u0027, sa.String(length\u003d36),"},{"line_number":49,"context_line":"                    nullable\u003dFalse),"},{"line_number":50,"context_line":"                    sa.Column(\u0027mac_learning_enabled\u0027, sa.Boolean(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FeOo%3D","line":47,"updated":"2013-06-03 01:50:58.000000000","message":"Consider reformatting this to a version that is easier to read and less right justified.\n\n    op.create_table(\n        \u0027maclearningstates\u0027,\n        sa.Column(\u0027port_id\u0027, sa.String(length\u003d36), nullable\u003dFalse),\n        ...\n    )","commit_id":"e19ec29e40e9a60c7de887bd5400afa301a33e8d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":44,"context_line":"    if not migration.should_run(active_plugin, migration_for_plugins):"},{"line_number":45,"context_line":"        return"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    op.create_table(\u0027maclearningstates\u0027,"},{"line_number":48,"context_line":"                    sa.Column(\u0027port_id\u0027, sa.String(length\u003d36),"},{"line_number":49,"context_line":"                    nullable\u003dFalse),"},{"line_number":50,"context_line":"                    sa.Column(\u0027mac_learning_enabled\u0027, sa.Boolean(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Fcbk%3D","line":47,"in_reply_to":"AAAAPH%2F%2FeOo%3D","updated":"2013-06-03 19:44:05.000000000","message":"will do","commit_id":"e19ec29e40e9a60c7de887bd5400afa301a33e8d"}],"quantum/plugins/nicira/QuantumPlugin.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"88345da32228c55a12decc2c32799186692cc7ff","unresolved":false,"context_lines":[{"line_number":1056,"context_line":"                context, filters)"},{"line_number":1057,"context_line":"            for quantum_lport in quantum_lports:"},{"line_number":1058,"context_line":"                self._extend_port_port_security_dict(context, quantum_lport)"},{"line_number":1059,"context_line":"                self._extend_port_mac_learning_state(context, quantum_lport)"},{"line_number":1060,"context_line":"        if (filters.get(\u0027network_id\u0027) and len(filters.get(\u0027network_id\u0027)) and"},{"line_number":1061,"context_line":"            self._network_is_external(context, filters[\u0027network_id\u0027][0])):"},{"line_number":1062,"context_line":"            # Do not perform check on NVP platform"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FcaQ%3D","line":1059,"updated":"2013-06-03 19:54:30.000000000","message":"That should be possible to load mac_learning_state using joined load. See some bugfixes that address that (ex: https://review.openstack.org/#/c/28479/)","commit_id":"e19ec29e40e9a60c7de887bd5400afa301a33e8d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":1056,"context_line":"                context, filters)"},{"line_number":1057,"context_line":"            for quantum_lport in quantum_lports:"},{"line_number":1058,"context_line":"                self._extend_port_port_security_dict(context, quantum_lport)"},{"line_number":1059,"context_line":"                self._extend_port_mac_learning_state(context, quantum_lport)"},{"line_number":1060,"context_line":"        if (filters.get(\u0027network_id\u0027) and len(filters.get(\u0027network_id\u0027)) and"},{"line_number":1061,"context_line":"            self._network_is_external(context, filters[\u0027network_id\u0027][0])):"},{"line_number":1062,"context_line":"            # Do not perform check on NVP platform"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2F%2BKQ%3D","line":1059,"in_reply_to":"AAAAPH%2F%2FcaQ%3D","updated":"2013-06-04 21:10:46.000000000","message":"This is very true. Currently there\u0027s something very wrong with this pattern, in fact _extend_port_port_security_dict has the same issue and the complexity of this for loop is terrible. That said, I believe that it\u0027s better to be consistent within this patch and address the issue on a larger scale and in a different patch. I spoke with Salvatore and he seemed to be fine with this course of action.","commit_id":"e19ec29e40e9a60c7de887bd5400afa301a33e8d"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":1193,"context_line":"            port_data[ext_qos.QUEUE] \u003d self._check_for_queue_and_create("},{"line_number":1194,"context_line":"                context, port_data)"},{"line_number":1195,"context_line":"            self._process_port_queue_mapping(context, port_data)"},{"line_number":1196,"context_line":"            if (isinstance(port_data.get(mac_ext.MAC_LEARNING), bool)):"},{"line_number":1197,"context_line":"                self._create_mac_learning_state(context, port_data)"},{"line_number":1198,"context_line":"            elif mac_ext.MAC_LEARNING in port_data:"},{"line_number":1199,"context_line":"                port_data.pop(mac_ext.MAC_LEARNING)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FeOg%3D","line":1196,"updated":"2013-06-03 01:50:58.000000000","message":"This just tell you whether or not you have a bool.  When the value is False the conditional will still be invoked.","commit_id":"e19ec29e40e9a60c7de887bd5400afa301a33e8d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":1193,"context_line":"            port_data[ext_qos.QUEUE] \u003d self._check_for_queue_and_create("},{"line_number":1194,"context_line":"                context, port_data)"},{"line_number":1195,"context_line":"            self._process_port_queue_mapping(context, port_data)"},{"line_number":1196,"context_line":"            if (isinstance(port_data.get(mac_ext.MAC_LEARNING), bool)):"},{"line_number":1197,"context_line":"                self._create_mac_learning_state(context, port_data)"},{"line_number":1198,"context_line":"            elif mac_ext.MAC_LEARNING in port_data:"},{"line_number":1199,"context_line":"                port_data.pop(mac_ext.MAC_LEARNING)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FcbY%3D","line":1196,"in_reply_to":"AAAAPH%2F%2FeOg%3D","updated":"2013-06-03 19:44:05.000000000","message":"Yes, that\u0027s inline with my expectations.","commit_id":"e19ec29e40e9a60c7de887bd5400afa301a33e8d"}],"quantum/plugins/nicira/dbexts/maclearning.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"88345da32228c55a12decc2c32799186692cc7ff","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":31,"context_line":"                        sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":32,"context_line":"                        primary_key\u003dTrue)"},{"line_number":33,"context_line":"    mac_learning_enabled \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class MacLearningDbMixin(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FlA4%3D","line":33,"updated":"2013-05-30 04:00:16.000000000","message":"Opinion: I think it might be better to rename it just to \u0027enabled\u0027, because it\u0027s within MacLearningState model and there\u0027s no need to duplicate \u0027mac_learning\u0027","commit_id":"45b2fb2acc1272ce0cb8329866214afed93cbfc5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":30,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":31,"context_line":"                        sa.ForeignKey(\u0027ports.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":32,"context_line":"                        primary_key\u003dTrue)"},{"line_number":33,"context_line":"    mac_learning_enabled \u003d sa.Column(sa.Boolean(), nullable\u003dFalse)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class MacLearningDbMixin(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FgZI%3D","line":33,"in_reply_to":"AAAAPH%2F%2FlA4%3D","updated":"2013-05-31 16:52:23.000000000","message":"I thought so too, but then looking at how other extension attributes have been handled (e.g. port security binding), I preferred to be consistent with them.","commit_id":"45b2fb2acc1272ce0cb8329866214afed93cbfc5"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"88345da32228c55a12decc2c32799186692cc7ff","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        except exc.NoResultFound:"},{"line_number":63,"context_line":"            raise mac.MACLearningStateNotFound(port_id\u003dport_id)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _create_mac_learning_state(self, context, port):"},{"line_number":66,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":67,"context_line":"            enabled \u003d port[mac.MAC_LEARNING]"},{"line_number":68,"context_line":"            state \u003d MacLearningState(port_id\u003dport[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FlAw%3D","line":65,"updated":"2013-05-30 04:00:16.000000000","message":"Is there ever a need to delete mac learning state?","commit_id":"45b2fb2acc1272ce0cb8329866214afed93cbfc5"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":62,"context_line":"        except exc.NoResultFound:"},{"line_number":63,"context_line":"            raise mac.MACLearningStateNotFound(port_id\u003dport_id)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _create_mac_learning_state(self, context, port):"},{"line_number":66,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":67,"context_line":"            enabled \u003d port[mac.MAC_LEARNING]"},{"line_number":68,"context_line":"            state \u003d MacLearningState(port_id\u003dport[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2FgYk%3D","line":65,"in_reply_to":"AAAAPH%2F%2FlAw%3D","updated":"2013-05-31 16:52:23.000000000","message":"Um, maybe not. You can toggle the value (true \u003c-\u003e false) and a false value is functionally equivalent to an unset value.","commit_id":"45b2fb2acc1272ce0cb8329866214afed93cbfc5"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 VMware, Inc.  All rights reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FeOA%3D","line":1,"updated":"2013-06-03 01:50:58.000000000","message":"What was the reasoning for not including this in the nicira_models.py file?","commit_id":"e19ec29e40e9a60c7de887bd5400afa301a33e8d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 VMware, Inc.  All rights reserved."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FcbU%3D","line":1,"in_reply_to":"AAAAPH%2F%2FeOA%3D","updated":"2013-06-03 19:44:05.000000000","message":"I wanted to move all of the db models under dbexts, like nicira_models.py, nicira_networkgw_db.py, and nicira_qos_db.py. This is the first step in that direction.","commit_id":"e19ec29e40e9a60c7de887bd5400afa301a33e8d"}]}
