)]}'
{"neutron/agent/l3/dvr_fip_ns.py":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"7a54520324dfe821b5c13d075592dd9db692694f","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            ri.rtr_fip_subnet \u003d self.local_subnets.allocate(ri.router_id)"},{"line_number":248,"context_line":"        rtr_2_fip, fip_2_rtr \u003d ri.rtr_fip_subnet.get_pair()"},{"line_number":249,"context_line":"        rtr_2_fip_dev \u003d ip_lib.IPDevice(rtr_2_fip_name, namespace\u003dri.ns_name)"},{"line_number":250,"context_line":"        fip_2_rtr_dev \u003d ip_lib.IPDevice(rtr_2_fip_name, namespace\u003dfip_ns_name)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        if not rtr_2_fip_dev.exists():"},{"line_number":253,"context_line":"            ip_wrapper \u003d ip_lib.IPWrapper(namespace\u003dri.ns_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_c25deaed","line":250,"updated":"2016-04-23 07:12:15.000000000","message":"Maybe this is negligence, rtr_2_fip_name -\u003e fip_2_rtr_name?\nOn the other hand, does fip_2_rtr_dev use in other place, can we remove it?","commit_id":"2b6b8a0021c7fd921699d59a15874b40e3ce0014"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e291f794fd6b393473e2b25a496944d625b66906","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            ri.rtr_fip_subnet \u003d self.local_subnets.allocate(ri.router_id)"},{"line_number":248,"context_line":"        rtr_2_fip, fip_2_rtr \u003d ri.rtr_fip_subnet.get_pair()"},{"line_number":249,"context_line":"        rtr_2_fip_dev \u003d ip_lib.IPDevice(rtr_2_fip_name, namespace\u003dri.ns_name)"},{"line_number":250,"context_line":"        fip_2_rtr_dev \u003d ip_lib.IPDevice(rtr_2_fip_name, namespace\u003dfip_ns_name)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        if not rtr_2_fip_dev.exists():"},{"line_number":253,"context_line":"            ip_wrapper \u003d ip_lib.IPWrapper(namespace\u003dri.ns_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_7b1598e3","line":250,"in_reply_to":"1a122d0e_c25deaed","updated":"2016-04-24 01:38:06.000000000","message":"Yes, that was a copy/paste typo, thanks for finding it.  From that it\u0027s clear it\u0027s always over-ridden on L254.\n\nBut as you say, it can actually be removed until a later patch in this \"series\" that actually needs it.","commit_id":"2b6b8a0021c7fd921699d59a15874b40e3ce0014"}]}
