)]}'
{"neutron/db/securitygroups_db.py":[{"author":{"_account_id":11255,"name":"Dustin Lundquist","username":"dustin.lundquist","inactive":true},"change_message_id":"076b796bb2f603e553686558c97b422f38a8733a","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            else:"},{"line_number":454,"context_line":"                raise ext_sg.SecurityGroupInvalidPortRange()"},{"line_number":455,"context_line":"        elif ip_proto in (constants.PROTO_NUM_ICMP,"},{"line_number":456,"context_line":"                          constants.PROTO_NUM_IPV6_ICMP):"},{"line_number":457,"context_line":"            for attr, field in [(\u0027port_range_min\u0027, \u0027type\u0027),"},{"line_number":458,"context_line":"                                (\u0027port_range_max\u0027, \u0027code\u0027)]:"},{"line_number":459,"context_line":"                if rule[attr] is not None and not (0 \u003c\u003d rule[attr] \u003c\u003d 255):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_130431be","line":456,"updated":"2016-04-25 17:12:42.000000000","message":"Why are you using a tuple here, when a list is used for TCP and UDP above?","commit_id":"168870d8a13c144da7b16eada230fcc5ae2e2799"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"b876ebfc08b9f46bb90b686e0ce8510c54a6371d","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            else:"},{"line_number":454,"context_line":"                raise ext_sg.SecurityGroupInvalidPortRange()"},{"line_number":455,"context_line":"        elif ip_proto in (constants.PROTO_NUM_ICMP,"},{"line_number":456,"context_line":"                          constants.PROTO_NUM_IPV6_ICMP):"},{"line_number":457,"context_line":"            for attr, field in [(\u0027port_range_min\u0027, \u0027type\u0027),"},{"line_number":458,"context_line":"                                (\u0027port_range_max\u0027, \u0027code\u0027)]:"},{"line_number":459,"context_line":"                if rule[attr] is not None and not (0 \u003c\u003d rule[attr] \u003c\u003d 255):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_891e4d0a","line":456,"in_reply_to":"1a122d0e_130431be","updated":"2016-04-26 01:45:10.000000000","message":"Well, I think they\u0027re both OK to me, for expressing a sequence. I can change it to list if you can show me some kind of hard rule.","commit_id":"168870d8a13c144da7b16eada230fcc5ae2e2799"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"851740823e9300463e1f1b5d24c2725ccd7cbe35","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            else:"},{"line_number":454,"context_line":"                raise ext_sg.SecurityGroupInvalidPortRange()"},{"line_number":455,"context_line":"        elif ip_proto in (constants.PROTO_NUM_ICMP,"},{"line_number":456,"context_line":"                          constants.PROTO_NUM_IPV6_ICMP):"},{"line_number":457,"context_line":"            for attr, field in [(\u0027port_range_min\u0027, \u0027type\u0027),"},{"line_number":458,"context_line":"                                (\u0027port_range_max\u0027, \u0027code\u0027)]:"},{"line_number":459,"context_line":"                if rule[attr] is not None and not (0 \u003c\u003d rule[attr] \u003c\u003d 255):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_87173aed","line":456,"in_reply_to":"1a122d0e_64894626","updated":"2016-04-27 02:06:34.000000000","message":"So you mean to keep the style/behavior in file consistent? OK, let me do it.","commit_id":"168870d8a13c144da7b16eada230fcc5ae2e2799"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ff47e2673511455e232afeb03067117adba01338","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            else:"},{"line_number":454,"context_line":"                raise ext_sg.SecurityGroupInvalidPortRange()"},{"line_number":455,"context_line":"        elif ip_proto in (constants.PROTO_NUM_ICMP,"},{"line_number":456,"context_line":"                          constants.PROTO_NUM_IPV6_ICMP):"},{"line_number":457,"context_line":"            for attr, field in [(\u0027port_range_min\u0027, \u0027type\u0027),"},{"line_number":458,"context_line":"                                (\u0027port_range_max\u0027, \u0027code\u0027)]:"},{"line_number":459,"context_line":"                if rule[attr] is not None and not (0 \u003c\u003d rule[attr] \u003c\u003d 255):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_64894626","line":456,"in_reply_to":"1a122d0e_891e4d0a","updated":"2016-04-26 16:34:51.000000000","message":"I\u0027m not sure there\u0027s some hard rule, but typically you follow what\u0027s been done in the file already.","commit_id":"168870d8a13c144da7b16eada230fcc5ae2e2799"}]}
