)]}'
{"id":"openstack%2Fneutron~31002","triplet_id":"openstack%2Fneutron~master~Ibe3399aaa145d19fc758f08adb51c7ffefa5bb3a","project":"openstack/neutron","branch":"master","topic":"bug/1185687","hashtags":[],"change_id":"Ibe3399aaa145d19fc758f08adb51c7ffefa5bb3a","subject":"Fix pool update error in lbaas","status":"MERGED","created":"2013-05-31 08:03:49.000000000","updated":"2013-05-31 08:03:49.000000000","submitted":"2013-05-31 08:03:49.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"dddbaaa910c7386b5fb73384bcf819b03d69faeb","_number":31002,"virtual_id_number":31002,"owner":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"value":2,"date":"2013-05-31 08:03:49.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},{"value":0,"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},{"value":0,"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"all":[{"value":2,"date":"2013-05-31 08:03:49.000000000","_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-05-31 08:03:49.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":1,"date":"2013-05-31 08:03:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},{"value":0,"date":"2013-05-31 08:03:49.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},{"value":1,"date":"2013-05-31 08:03:49.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"all":[{"value":1,"date":"2013-05-31 08:03:49.000000000","_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-05-31 08:03:49.000000000","_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"date":"2013-05-31 08:03:49.000000000","_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},{"value":0,"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},{"value":0,"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},{"value":0,"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},{"value":0,"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-31 08:03:49.000000000","updated_by":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"reviewer":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"state":"REVIEWER"},{"updated":"2013-05-31 08:03:49.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2013-05-31 08:03:49.000000000","updated_by":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"reviewer":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"state":"REVIEWER"},{"updated":"2013-05-31 08:03:49.000000000","updated_by":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"reviewer":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"state":"REVIEWER"},{"updated":"2013-05-31 08:03:49.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"221e5490ccfa6d7f0fbbae5a2f3ff53ed113302e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/31002/1/check/gate-quantum-pep8/7422 : SUCCESS in 1m 42s\n- http://docs-draft.openstack.org/31002/1/check/gate-quantum-docs/6661/doc/build/html/ : SUCCESS in 1m 24s\n- http://logs.openstack.org/31002/1/check/gate-quantum-python26/7036 : SUCCESS in 17m 26s\n- http://logs.openstack.org/31002/1/check/gate-quantum-python27/7042 : SUCCESS in 13m 46s\n- http://logs.openstack.org/31002/1/check/gate-tempest-devstack-vm-quantum/26220 : SUCCESS in 19m 54s\n","accounts_in_message":[],"_revision_number":1},{"id":"b41f66c57bc3104ed0d8dd4004f75782c669c39f","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nIs there a test case for this?","accounts_in_message":[],"_revision_number":1},{"id":"d1df6d2d3ace888aa81f6fc8a8c343b232337e36","author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"563b9d828f72d3a14fb7c019adc0d4f0bb3f5a5b","author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 1: (1 inline comment)\n\nGary, after the second thought it appeared that there\u0027s no tests for lbaas plugin at all for a couple of reasons.\n\nI\u0027m planning to add such tests when https://review.openstack.org/#/c/29155/ got merged.\n\nConsidering the test for the case I\u0027m fixing, it should be a kind of integration test (which I\u0027m currently performing manually) because it involves quantum-server and namespace_agent interacting via mq.\n\nSo, I\u0027ll push another patchset just to fix the commit message.","accounts_in_message":[],"_revision_number":1},{"id":"0924e2b890612bc10bad4159d8784c719e3f26e9","author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 1:\n\nyou\u0027re right. And also i need to fix a typo in commit message :)","accounts_in_message":[],"_revision_number":1},{"id":"81a1dd1155e4c3a4b4fe29cf56958c1a4fe650bf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 2: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/31002/2/check/gate-quantum-pep8/7423 : SUCCESS in 1m 46s\n- http://docs-draft.openstack.org/31002/2/check/gate-quantum-docs/6662/doc/build/html/ : SUCCESS in 1m 31s\n- http://logs.openstack.org/31002/2/check/gate-quantum-python26/7037 : SUCCESS in 17m 07s\n- http://logs.openstack.org/31002/2/check/gate-quantum-python27/7043 : SUCCESS in 13m 50s\n- http://logs.openstack.org/31002/2/check/gate-tempest-devstack-vm-quantum/26226 : FAILURE in 9m 35s\n","accounts_in_message":[],"_revision_number":2},{"id":"96da4a9494b5067cdce70daa5a1a89680eea56be","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/31002/2/check/gate-quantum-pep8/7424 : SUCCESS in 1m 40s\n- http://docs-draft.openstack.org/31002/2/check/gate-quantum-docs/6663/doc/build/html/ : SUCCESS in 1m 23s\n- http://logs.openstack.org/31002/2/check/gate-quantum-python26/7038 : SUCCESS in 17m 16s\n- http://logs.openstack.org/31002/2/check/gate-quantum-python27/7044 : SUCCESS in 13m 43s\n- http://logs.openstack.org/31002/2/check/gate-tempest-devstack-vm-quantum/26228 : SUCCESS in 19m 14s\n","accounts_in_message":[],"_revision_number":2},{"id":"1bc96d7db11ba042f2c8ccc483d5556320202892","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"0d3b5bd2e8d555159ddcaa1d7bae50d23870e76f","author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"888a2c824000405bbd0f66447b4beaaa23a7717a","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"b4341803b4e68e177896c1a6ad6b401a07c18ff7","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"d45d16bfc4bde1affb4dde9d10f8a6ec587d3a2f","author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"a55fe370e58c6f7357194793ab465e8b848dcb5e","author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 2:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":2},{"id":"837c60e2cf5a22a7d456d114110c33ed94cc9ee8","author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"date":"2013-05-31 08:03:49.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ce31cd2b5d8b2db1a8bac89805dd219f2fd1649f","author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 2:\n\nberlin, could you explain?","accounts_in_message":[],"_revision_number":2},{"id":"31b5bd383a4d43cdac9965cc057150a4da483bf6","author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nOh, sorry, I was wrong","accounts_in_message":[],"_revision_number":2},{"id":"cf45fdac6f59f8cf9e53d740920c5fad60742b4e","author":{"_account_id":7317,"name":"Bo Lin","email":"linb@vmware.com","username":"berlin"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nI think whether we should also add the restriction when we delete a pool if the pool does not have a vip","accounts_in_message":[],"_revision_number":2},{"id":"d0284e2516e4800bc8930bdb8a02e93812bd9e07","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-31 08:03:49.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"943ba31e75ba62b6109f4b056591e5083d3c7ee7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-31 08:03:49.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/31002/2/gate/gate-quantum-docs/6705/doc/build/html/ : SUCCESS in 2m 23s\n- http://logs.openstack.org/31002/2/gate/gate-quantum-pep8/7466 : SUCCESS in 2m 29s\n- http://logs.openstack.org/31002/2/gate/gate-quantum-python26/7080 : SUCCESS in 17m 13s\n- http://logs.openstack.org/31002/2/gate/gate-quantum-python27/7086 : SUCCESS in 12m 48s\n- http://logs.openstack.org/31002/2/gate/gate-tempest-devstack-vm-quantum/26605 : SUCCESS in 19m 33s\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"3786f3ab2028b18e427569ee0824cdbb85e91c55","revisions":{"75c43c6a2200f88e7c4d74d34149ad71d957c865":{"kind":"REWORK","_number":1,"created":"2013-05-31 08:03:49.000000000","uploader":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"ref":"refs/changes/02/31002/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/02/31002/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/02/31002/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/02/31002/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/02/31002/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/02/31002/1"}}},"commit":{"parents":[{"commit":"726aca58d70016a12f44eb7c07742fb6a54bb366","subject":"Merge \"Fix ml2 stack trace when logging.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/726aca58d70016a12f44eb7c07742fb6a54bb366"}]}],"author":{"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","date":"2013-05-30 08:25:16.000000000","tz":240},"committer":{"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","date":"2013-05-30 08:26:43.000000000","tz":240},"subject":"Fix update poll error in lbaas","message":"Fix update poll error in lbaas\n\nfixes bug 1185687\n\nDo not notify namespace agent of modified pool\nif pool doesn\u0027t have vip\n\nChange-Id: Ibe3399aaa145d19fc758f08adb51c7ffefa5bb3a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/75c43c6a2200f88e7c4d74d34149ad71d957c865"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/75c43c6a2200f88e7c4d74d34149ad71d957c865"}]},"branch":"refs/heads/master"},"3786f3ab2028b18e427569ee0824cdbb85e91c55":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-05-31 08:03:49.000000000","uploader":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"ref":"refs/changes/02/31002/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/neutron","ref":"refs/changes/02/31002/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/neutron refs/changes/02/31002/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/neutron refs/changes/02/31002/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/neutron refs/changes/02/31002/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/neutron refs/changes/02/31002/2"}}},"commit":{"parents":[{"commit":"726aca58d70016a12f44eb7c07742fb6a54bb366","subject":"Merge \"Fix ml2 stack trace when logging.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/726aca58d70016a12f44eb7c07742fb6a54bb366"}]}],"author":{"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","date":"2013-05-30 08:25:16.000000000","tz":240},"committer":{"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","date":"2013-05-30 08:32:47.000000000","tz":240},"subject":"Fix pool update error in lbaas","message":"Fix pool update error in lbaas\n\nfixes bug 1185687\n\nDo not notify namespace agent of modified pool\nif pool doesn\u0027t have vip\n\nChange-Id: Ibe3399aaa145d19fc758f08adb51c7ffefa5bb3a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/3786f3ab2028b18e427569ee0824cdbb85e91c55"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/neutron/commit/3786f3ab2028b18e427569ee0824cdbb85e91c55"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}