)]}'
{"neutron/db/l3_agentschedulers_db.py":[{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"882d08085f4358e89e557ee324353ee9654bc15d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"          unsuitable agent (disabled, type !\u003d L3, incompatible configuration)"},{"line_number":162,"context_line":"        :raises: DVRL3CannotAssignToDvrAgent if attempting to assign a"},{"line_number":163,"context_line":"          router to an agent in \u0027dvr\u0027 mode."},{"line_number":164,"context_line":"        :raises: L3AgenWithoutExternalNetwork if attempting to assign router"},{"line_number":165,"context_line":"          without an external network."},{"line_number":166,"context_line":"        \"\"\""},{"line_number":167,"context_line":"        if agent[\u0027agent_type\u0027] !\u003d constants.AGENT_TYPE_L3:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_fc49c233","line":164,"range":{"start_line":164,"start_character":17,"end_line":164,"end_character":45},"updated":"2016-05-03 14:16:07.000000000","message":"Small typo s/L3AgenWithoutExternalNetwork/L3AgentWithoutExternalNetwork","commit_id":"09aac632bf5ddf1825aa33f632002e0b1e3b86a3"},{"author":{"_account_id":16011,"name":"James Denton","email":"james.denton@outlook.com","username":"busterswt"},"change_message_id":"814e9ac5cb4e756709fa3bc4078ca9ed8b39f56a","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                                         [agent],"},{"line_number":184,"context_line":"                                         ignore_admin_state\u003dTrue))"},{"line_number":185,"context_line":"        if not is_suitable_agent:"},{"line_number":186,"context_line":"            if \u0027network_id\u0027 not in router[\u0027external_gateway_info\u0027]:"},{"line_number":187,"context_line":"                raise l3agentscheduler.L3AgentWithoutExternalNetwork("},{"line_number":188,"context_line":"                    router_id\u003drouter[\u0027id\u0027], agent_id\u003dagent[\u0027id\u0027])"},{"line_number":189,"context_line":"            raise l3agentscheduler.InvalidL3Agent(id\u003dagent[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_5814344c","line":186,"range":{"start_line":186,"start_character":12,"end_line":186,"end_character":67},"updated":"2016-05-03 19:53:17.000000000","message":"This test results in a traceback when no external network is set. Consider checking for \u0027None\u0027.\n\n- - if \u0027network_id\u0027 not in router[\u0027external_gateway_info\u0027]:\n+ if router[\u0027external_gateway_info\u0027] is None:","commit_id":"56e5c724467d98ddfc60d262d1f890b74d5dff94"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e844f37b6532b5abdffce2aef17d5f9a4fdb37d8","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                                         [agent],"},{"line_number":184,"context_line":"                                         ignore_admin_state\u003dTrue))"},{"line_number":185,"context_line":"        if not is_suitable_agent:"},{"line_number":186,"context_line":"            if router[\u0027external_gateway_info\u0027] is None:"},{"line_number":187,"context_line":"                raise l3agentscheduler.L3AgentWithoutExternalNetwork("},{"line_number":188,"context_line":"                    router_id\u003drouter[\u0027id\u0027], agent_id\u003dagent[\u0027id\u0027])"},{"line_number":189,"context_line":"            raise l3agentscheduler.InvalidL3Agent(id\u003dagent[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_8d34b7fb","line":186,"updated":"2016-08-16 09:37:37.000000000","message":"to be honest it is not clear why the get_l3_agent_candidates would return a router that is not correctly configured.\n\nif the router is used for E/W traffic would it require the external_gateway_info?\n\nTo be honest I do not really see what value this gives.","commit_id":"a07388d98f402fe7d729e14d1a91ec53bb01b28b"}]}
